)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"728c1dc99f64b47257074f2c79123d5ef8e8284e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the fold_headers function, if the headers behaves like a dict,"},{"line_number":10,"context_line":"return it. So the headers don\u0027t get to change to lowercase that can"},{"line_number":11,"context_line":"not be parsed correctly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Convert these headers to lowercases also provide a test cse to validate"},{"line_number":14,"context_line":"the header is being parsed correctly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_8bf2316e","line":11,"updated":"2016-07-27 14:23:38.000000000","message":"I think you probably want something like:\n\nIn the fold_headers function if the headers behaved like a dict they were being returned unchanged. This would cause issues in the later processing to extract the microversion header, which matches on lower case strings.","commit_id":"949e45d3897eab6be8f3b3c3f240a9ce933cae57"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"728c1dc99f64b47257074f2c79123d5ef8e8284e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"return it. So the headers don\u0027t get to change to lowercase that can"},{"line_number":11,"context_line":"not be parsed correctly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Convert these headers to lowercases also provide a test cse to validate"},{"line_number":14,"context_line":"the header is being parsed correctly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Close-Bug:# 1606351"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_0bc76146","line":13,"updated":"2016-07-27 14:23:38.000000000","message":"s/lowercases/lowercase/\ns/cse/case/","commit_id":"949e45d3897eab6be8f3b3c3f240a9ce933cae57"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"728c1dc99f64b47257074f2c79123d5ef8e8284e","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Install Gerrit its-storyboard plugin[1] to support integration between"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Changing to lowercase if the headers behave like dict is needed."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I9bfed908df5697ead02ed1f1e8d4c55bfc6e2855"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_6bf25d9c","line":20,"updated":"2016-07-27 14:23:38.000000000","message":"These two lines look like they shouldn\u0027t be here.","commit_id":"949e45d3897eab6be8f3b3c3f240a9ce933cae57"}],"microversion_parse/__init__.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"728c1dc99f64b47257074f2c79123d5ef8e8284e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    # If it behaves like a dict, return it. Webob uses objects which"},{"line_number":91,"context_line":"    # are not dicts, but behave like them."},{"line_number":92,"context_line":"    if hasattr(headers, \u0027keys\u0027):"},{"line_number":93,"context_line":"        return dict((k.lower(), v.lower()) for k, v in headers.iteritems())"},{"line_number":94,"context_line":"    header_dict \u003d collections.defaultdict(list)"},{"line_number":95,"context_line":"    for header, value in headers:"},{"line_number":96,"context_line":"        header_dict[header.lower()].append(value.strip())"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_cb48a98a","line":93,"updated":"2016-07-27 14:23:38.000000000","message":"You should use \u0027items\u0027 here instead \u0027iteritems\u0027. iteritems is not available in python3","commit_id":"949e45d3897eab6be8f3b3c3f240a9ce933cae57"}],"microversion_parse/tests/test_get_version.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"728c1dc99f64b47257074f2c79123d5ef8e8284e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# limitations under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"import testtools"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import microversion_parse"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_4b1799ed","side":"PARENT","line":15,"updated":"2016-07-27 14:23:38.000000000","message":"You don\u0027t want to remove the whitespace here or the next line down. The openstack standard is to have three different sections of imports:\n\n* imports from stdlib\n* imports from third parties\n* imports from the current package\n\neach is separate by a blankline and then the entire block of imports is separated from whatever follows by two blank lines","commit_id":"c031779d58ebc35112b01afe60357c09a669bda3"}],"microversion_parse/tests/test_webob.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"728c1dc99f64b47257074f2c79123d5ef8e8284e","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"import testtools"},{"line_number":15,"context_line":"import microversion_parse"},{"line_number":16,"context_line":"from webob import headers as wb_headers"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class TestWebobHeaders(testtools.TestCase):"},{"line_number":19,"context_line":"    \"\"\"Webob uses a dict-like header which is not actually a dict.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_0b92c157","line":16,"updated":"2016-07-27 14:23:38.000000000","message":"See my comment on the other test file for the reasons for the ordering here.","commit_id":"949e45d3897eab6be8f3b3c3f240a9ce933cae57"}]}