)]}'
{"id":"openstack%2Fmicroversion-parse~347993","triplet_id":"openstack%2Fmicroversion-parse~master~I8501c813d668c0a32905906e4ef3f8c6c6b12de2","project":"openstack/microversion-parse","branch":"master","topic":"bug/1606351","hashtags":[],"change_id":"I8501c813d668c0a32905906e4ef3f8c6c6b12de2","subject":"Convert dict headers and Webob headers into lowercase.","status":"MERGED","created":"2016-07-27 18:33:08.000000000","updated":"2016-08-05 17:37:50.000000000","submitted":"2016-08-05 17:37:50.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d5c698063ab9c6129339a071fe088aa93f873f6f","_number":347993,"virtual_id_number":347993,"owner":{"_account_id":22012,"name":"Polly Zhou","email":"pengpeng.zhou@hotmail.com","username":"PollyZhou"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-08-05 17:37:50.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-07-31 13:55:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},{"value":2,"date":"2016-08-05 17:32:43.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},{"value":1,"date":"2016-08-05 17:32:43.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-07-28 09:04:25.000000000","updated_by":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"reviewer":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"state":"REVIEWER"},{"updated":"2016-07-31 13:55:39.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2016-08-05 17:32:43.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2016-08-05 17:37:50.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"15aac387ea5d888b0b207268dda73434de718c3c","author":{"_account_id":22012,"name":"Polly Zhou","email":"pengpeng.zhou@hotmail.com","username":"PollyZhou"},"date":"2016-07-27 18:33:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8de1e1172486644fce41bc91c6c409d96eb667cb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-27 20:13:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-microversion-parse-docs-ubuntu-xenial http://docs-draft.openstack.org/93/347993/1/check/gate-microversion-parse-docs-ubuntu-xenial/e2fb4b1//doc/build/html/ : SUCCESS in 3m 12s\n- gate-microversion-parse-pep8-ubuntu-xenial http://logs.openstack.org/93/347993/1/check/gate-microversion-parse-pep8-ubuntu-xenial/f704fbb/ : SUCCESS in 3m 27s\n- gate-microversion-parse-python27-ubuntu-xenial http://logs.openstack.org/93/347993/1/check/gate-microversion-parse-python27-ubuntu-xenial/ea2b680/ : SUCCESS in 2m 59s\n- gate-microversion-parse-python34 http://logs.openstack.org/93/347993/1/check/gate-microversion-parse-python34/530a98c/ : SUCCESS in 4m 37s\n- gate-microversion-parse-python35-nv http://logs.openstack.org/93/347993/1/check/gate-microversion-parse-python35-nv/c2af220/ : SUCCESS in 2m 29s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"930d009c234fccb80956700d23bf2bf6edebf7df","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2016-07-28 09:04:10.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nGetting close. There\u0027s a typo in the commit message, and I think perhaps we don\u0027t want to lower case the value of the headers, to match the behavior in the existing code.\n\nI\u0027ll invite some of the other microversion-parse cores in to comment as well.","accounts_in_message":[],"_revision_number":1},{"id":"d17c20f810074972eb9fd0c87f9d9dc04e6a0ae9","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2016-07-28 11:29:08.000000000","message":"Patch Set 1:\n\nYou\u0027ve submitted two changes for review where you should have just one. If you\u0027re not already using \u0027git-review\u0027[1] you might want to look into using that. Makes submitting multiple changes on the same review a bit easier. For now you should abandon the other Change-Id: I9bfed908df5697ead02ed1f1e8d4c55bfc6e2855 so that it is clear this is the one you want to be working on.\n\n[1] https://pypi.python.org/pypi/git-review","accounts_in_message":[],"_revision_number":1},{"id":"ea1796691331632c4e092b894fd66f1eaa212792","author":{"_account_id":22012,"name":"Polly Zhou","email":"pengpeng.zhou@hotmail.com","username":"PollyZhou"},"date":"2016-07-29 18:23:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1d913417299d36276c3c6a5064113ad65a822cf8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-29 22:37:38.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-microversion-parse-docs-ubuntu-xenial http://docs-draft.openstack.org/93/347993/2/check/gate-microversion-parse-docs-ubuntu-xenial/3d05534//doc/build/html/ : SUCCESS in 2m 52s\n- gate-microversion-parse-pep8-ubuntu-xenial http://logs.openstack.org/93/347993/2/check/gate-microversion-parse-pep8-ubuntu-xenial/bc5544e/ : SUCCESS in 6m 00s\n- gate-microversion-parse-python27-ubuntu-xenial http://logs.openstack.org/93/347993/2/check/gate-microversion-parse-python27-ubuntu-xenial/9f01ab8/ : SUCCESS in 6m 33s\n- gate-microversion-parse-python34 http://logs.openstack.org/93/347993/2/check/gate-microversion-parse-python34/4c74239/ : SUCCESS in 3m 16s\n- gate-microversion-parse-python35-nv http://logs.openstack.org/93/347993/2/check/gate-microversion-parse-python35-nv/cd90894/ : SUCCESS in 6m 53s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"17c2c8addc793e0ac9e0913d3d1881ef17a2072b","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2016-07-31 13:55:39.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"cc4e7edc9189e3d140eec519a2f2fdb60b061fc0","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-08-05 17:32:43.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"01f166dcc2a91ecf6df9b4b5734d953738aa7154","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-05 17:32:53.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"588c0974a03e3d6cc2dfe352dabcf176a15f1280","date":"2016-08-05 17:37:50.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"cb9bd4024d4d6e7f67331849ca363577543f1c6b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-05 17:37:50.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-microversion-parse-docs-ubuntu-xenial http://docs-draft.openstack.org/93/347993/2/gate/gate-microversion-parse-docs-ubuntu-xenial/a92a1c6//doc/build/html/ : SUCCESS in 2m 46s\n- gate-microversion-parse-pep8-ubuntu-xenial http://logs.openstack.org/93/347993/2/gate/gate-microversion-parse-pep8-ubuntu-xenial/aa996eb/ : SUCCESS in 4m 11s\n- gate-microversion-parse-python27-ubuntu-xenial http://logs.openstack.org/93/347993/2/gate/gate-microversion-parse-python27-ubuntu-xenial/d736483/ : SUCCESS in 3m 47s\n- gate-microversion-parse-python34 http://logs.openstack.org/93/347993/2/gate/gate-microversion-parse-python34/a2e1772/ : SUCCESS in 4m 15s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1f6eac7c3df048679663919f75c2bcecd3e183a2","revisions":{"728d3e1fab7efeb25bf0870f8d0a7ff5fab3a30c":{"kind":"REWORK","_number":1,"created":"2016-07-27 18:33:08.000000000","uploader":{"_account_id":22012,"name":"Polly Zhou","email":"pengpeng.zhou@hotmail.com","username":"PollyZhou"},"ref":"refs/changes/93/347993/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/microversion-parse","ref":"refs/changes/93/347993/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/93/347993/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/93/347993/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/93/347993/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/microversion-parse refs/changes/93/347993/1"}}},"commit":{"parents":[{"commit":"c031779d58ebc35112b01afe60357c09a669bda3","subject":"Fix summary information used in pypi display","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/c031779d58ebc35112b01afe60357c09a669bda3"}]}],"author":{"name":"PollyZ","email":"Polly.Zhou@rackspace.com","date":"2016-07-26 20:28:18.000000000","tz":-300},"committer":{"name":"PollyZ","email":"Polly.Zhou@rackspace.com","date":"2016-07-27 18:31:45.000000000","tz":-300},"subject":"Convert dict headers and Webob headers into lowercase.","message":"Convert dict headers and Webob headers into lowercase.\n\nIn the fold_headers function, if the headers behaves like a dict,\nthey were being retured unchanged. This would cuase issues in the\nlater processing to extract the microversion header, which matches\non lower case strings.\n\nConvert these headers to lowercase also provide a test case to\nvalidate the header is being parsed correctly.\n\nChange-Id: I8501c813d668c0a32905906e4ef3f8c6c6b12de2\nClose-Bug:# 1606351\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/728d3e1fab7efeb25bf0870f8d0a7ff5fab3a30c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/728d3e1fab7efeb25bf0870f8d0a7ff5fab3a30c"}]},"branch":"refs/heads/master"},"1f6eac7c3df048679663919f75c2bcecd3e183a2":{"kind":"REWORK","_number":2,"created":"2016-07-29 18:23:34.000000000","uploader":{"_account_id":22012,"name":"Polly Zhou","email":"pengpeng.zhou@hotmail.com","username":"PollyZhou"},"ref":"refs/changes/93/347993/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/microversion-parse","ref":"refs/changes/93/347993/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/93/347993/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/93/347993/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/93/347993/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/microversion-parse refs/changes/93/347993/2"}}},"commit":{"parents":[{"commit":"c031779d58ebc35112b01afe60357c09a669bda3","subject":"Fix summary information used in pypi display","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/c031779d58ebc35112b01afe60357c09a669bda3"}]}],"author":{"name":"PollyZ","email":"Polly.Zhou@rackspace.com","date":"2016-07-26 20:28:18.000000000","tz":-300},"committer":{"name":"PollyZ","email":"Polly.Zhou@rackspace.com","date":"2016-07-29 18:22:36.000000000","tz":-300},"subject":"Convert dict headers and Webob headers into lowercase.","message":"Convert dict headers and Webob headers into lowercase.\n\nIn the fold_headers function, if the headers behaves like a dict,\nthey were being retured unchanged. This would cause issues in the\nlater processing to extract the microversion header, which matches\non lower case strings.\n\nConvert these headers to lowercase also provide a test case to\nvalidate the header is being parsed correctly.\n\nChange-Id: I8501c813d668c0a32905906e4ef3f8c6c6b12de2\nClose-Bug:# 1606351\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/1f6eac7c3df048679663919f75c2bcecd3e183a2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/1f6eac7c3df048679663919f75c2bcecd3e183a2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}