)]}'
{"id":"openstack%2Fmicroversion-parse~495356","triplet_id":"openstack%2Fmicroversion-parse~master~I5262031d9cde0378eabe342c1913091658c3bf9b","project":"openstack/microversion-parse","branch":"master","topic":"cd/placement-functions","hashtags":[],"change_id":"I5262031d9cde0378eabe342c1913091658c3bf9b","subject":"Provide a helper method to get headers from environ","status":"MERGED","created":"2017-08-18 15:43:12.000000000","updated":"2018-03-20 13:59:43.000000000","submitted":"2018-03-20 13:59:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":18,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"495356-1521554383248-3597e5b1","meta_rev_id":"d8a4c29405990526b5ef4c818256b69fc8a8c04e","_number":495356,"virtual_id_number":495356,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":0,"date":"2018-03-20 13:30:05.000000000","_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2018-03-20 13:59:43.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"recommended":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2018-03-19 19:17:42.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":2,"date":"2018-03-20 13:08:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2018-03-20 13:51:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2018-03-20 13:51:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-08-21 08:14:13.000000000","updated_by":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"reviewer":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"state":"REVIEWER"},{"updated":"2017-08-22 21:03:44.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2018-03-07 00:50:27.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2018-03-19 19:17:42.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2018-03-20 13:08:11.000000000","updated_by":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"reviewer":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"state":"REVIEWER"},{"updated":"2018-03-20 13:51:08.000000000","updated_by":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"reviewer":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"state":"REVIEWER"},{"updated":"2018-03-20 13:59:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"98e6715261ffd2adbe52cc6a0d9e1f01e1f58581","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2017-08-18 15:43:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bcf221309a9832e9581a3cd10b97442fb6df0700","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2017-08-18 18:02:48.000000000","message":"Patch Set 1: Code-Review+2\n\nthis seems reasonable to me, my only nit is not using the `format` method for the string substitution.","accounts_in_message":[],"_revision_number":1},{"id":"2b39d41b6ca12b361f495f46aa54e916d21f551c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-18 18:20:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-microversion-parse-docs-ubuntu-xenial http://docs-draft.openstack.org/56/495356/1/check/gate-microversion-parse-docs-ubuntu-xenial/3a9ee47//doc/build/html/ : SUCCESS in 2m 34s\n- gate-microversion-parse-pep8-ubuntu-xenial http://logs.openstack.org/56/495356/1/check/gate-microversion-parse-pep8-ubuntu-xenial/e78255f/ : SUCCESS in 2m 58s\n- gate-microversion-parse-python27-ubuntu-xenial http://logs.openstack.org/56/495356/1/check/gate-microversion-parse-python27-ubuntu-xenial/2484193/ : SUCCESS in 3m 31s\n- gate-microversion-parse-python35 http://logs.openstack.org/56/495356/1/check/gate-microversion-parse-python35/f6dc1d1/ : SUCCESS in 2m 48s","accounts_in_message":[],"_revision_number":1},{"id":"67ba881da353fb52abadb947f6e0183db4934596","author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"date":"2017-08-21 08:14:13.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"7ea2cd21ca9525831630d850c4de04c5c63b092f","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2017-08-22 08:59:18.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2ad753c889ecafe81db4fcc44f2036a2ce4f4c33","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2017-08-22 09:00:06.000000000","message":"Patch Set 2:\n\nupdated to use format because I want elmiko to not be disappointed","accounts_in_message":[],"_revision_number":2},{"id":"af87757f886d6e374322bb1f3b45e4e5d71a70be","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-22 09:08:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-microversion-parse-docs-ubuntu-xenial http://docs-draft.openstack.org/56/495356/2/check/gate-microversion-parse-docs-ubuntu-xenial/789c9c0//doc/build/html/ : SUCCESS in 2m 59s\n- gate-microversion-parse-pep8-ubuntu-xenial http://logs.openstack.org/56/495356/2/check/gate-microversion-parse-pep8-ubuntu-xenial/94d483f/ : SUCCESS in 3m 49s\n- gate-microversion-parse-python27-ubuntu-xenial http://logs.openstack.org/56/495356/2/check/gate-microversion-parse-python27-ubuntu-xenial/ef59586/ : SUCCESS in 2m 40s\n- gate-microversion-parse-python35 http://logs.openstack.org/56/495356/2/check/gate-microversion-parse-python35/3005ccd/ : SUCCESS in 4m 40s","accounts_in_message":[],"_revision_number":2},{"id":"59bd420a0340f677b0a8b08e6fe1cfec5bb76405","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2017-08-22 13:41:03.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4ff59c6d9bc91f2182a49ef07003cbd1344da4e0","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2017-08-22 20:42:18.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"598bb7c3d77b33bbc50f5f76747a9de727cff559","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2017-08-22 20:54:17.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"e860bba4e59507c5cfbf7ae24eb133a92bc577fa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-22 21:03:44.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-microversion-parse-docs-ubuntu-xenial http://docs-draft.openstack.org/56/495356/3/check/gate-microversion-parse-docs-ubuntu-xenial/07fb63e//doc/build/html/ : SUCCESS in 3m 15s\n- gate-microversion-parse-pep8-ubuntu-xenial http://logs.openstack.org/56/495356/3/check/gate-microversion-parse-pep8-ubuntu-xenial/5f937aa/ : SUCCESS in 2m 57s\n- gate-microversion-parse-python27-ubuntu-xenial http://logs.openstack.org/56/495356/3/check/gate-microversion-parse-python27-ubuntu-xenial/4359f57/ : SUCCESS in 2m 44s\n- gate-microversion-parse-python35 http://logs.openstack.org/56/495356/3/check/gate-microversion-parse-python35/69fa3bc/ : SUCCESS in 4m 49s","accounts_in_message":[],"_revision_number":3},{"id":"cb24baa85908fa8d9bae9659dff828ed58bfddfe","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2017-10-23 12:21:50.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)\n\nSeems reasonable.","accounts_in_message":[],"_revision_number":3},{"id":"98e5cb479be2652fcf4c9c53343422c7ecb0418d","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-06 16:59:47.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"0dc34efc252fad70d884b218ee3d1eb5765f6e47","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-06 17:05:44.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/56/495356/4/check/openstack-tox-pep8/8126f82/ : SUCCESS in 4m 11s\n- openstack-tox-py27 http://logs.openstack.org/56/495356/4/check/openstack-tox-py27/a78be11/ : SUCCESS in 3m 15s\n- openstack-tox-py35 http://logs.openstack.org/56/495356/4/check/openstack-tox-py35/318141f/ : SUCCESS in 3m 28s","accounts_in_message":[],"_revision_number":4},{"id":"9b2d3167d79ef32098f6b3a469fd58f3e78ad6bd","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2018-03-07 00:20:32.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"057c755068f162e8a607bd33da330d772fd6ee37","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-07 00:33:13.000000000","message":"Patch Set 4:\n\n(2 comments)\n\nSome clarifying questions on the Tim\u0027s comments, within.","accounts_in_message":[],"_revision_number":4},{"id":"d2411f5339b2a5d388eae752faaed46122c862ff","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2018-03-07 00:50:27.000000000","message":"Patch Set 4:\n\n(1 comment)\n\n*shrug* For sure, within this narrow context, it\u0027s perfectly sufficient.","accounts_in_message":[],"_revision_number":4},{"id":"4afd2e460424775cf58948eaa7f4e4b5ddf355da","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-07 10:23:55.000000000","message":"Patch Set 4:\n\n(1 comment)\n\nThanks for the continued comments Tim, more within.","accounts_in_message":[],"_revision_number":4},{"id":"41b95edf6efde63b414ab7060b77c46652aeae4b","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2018-03-12 20:09:07.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"1526ce74565229c358e93e6a40e29a75ff55cf53","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-15 12:09:31.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"9889f89ab83d709907fd5c6493ab6e498ecab813","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-15 12:19:08.000000000","message":"Patch Set 5:\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/56/495356/5/check/openstack-tox-pep8/81e2ad5/ : SUCCESS in 3m 32s\n- openstack-tox-py27 http://logs.openstack.org/56/495356/5/check/openstack-tox-py27/a7d95b8/ : SUCCESS in 4m 44s\n- openstack-tox-py35 http://logs.openstack.org/56/495356/5/check/openstack-tox-py35/2ebf2d3/ : SUCCESS in 3m 01s","accounts_in_message":[],"_revision_number":5},{"id":"30bfdfd4fcec9d2a2b1261f4f4e689d4ddbe92f2","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2018-03-15 12:47:25.000000000","message":"Patch Set 5: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"d1ae30c7f0da37ca497907175900e0789bf5a948","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-15 12:56:42.000000000","message":"Patch Set 5:\n\n(2 comments)\n\nthanks, responses within","accounts_in_message":[],"_revision_number":5},{"id":"23fcbe98f21e1e559fb7729248271e1adfed01e7","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2018-03-15 13:45:36.000000000","message":"Patch Set 5: Code-Review+1\n\n(1 comment)\n\nlgtm","accounts_in_message":[],"_revision_number":5},{"id":"72bb96d9041ef776610920ead646660e04052141","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-15 18:14:33.000000000","message":"Patch Set 5:\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"3a3fd17fec03be879020a5648e213e9bb79bea81","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-15 18:24:58.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"8bf6b2264faf629aefaea805dad28de107c96fdd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-15 19:38:11.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/56/495356/6/check/openstack-tox-pep8/d03f433/ : SUCCESS in 2m 55s\n- openstack-tox-py27 http://logs.openstack.org/56/495356/6/check/openstack-tox-py27/3fe8a15/ : SUCCESS in 3m 17s\n- openstack-tox-py35 http://logs.openstack.org/56/495356/6/check/openstack-tox-py35/c04b6b1/ : SUCCESS in 3m 35s","accounts_in_message":[],"_revision_number":6},{"id":"59ba64541767a4afc89b23376b62f4562b07780a","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2018-03-15 21:31:33.000000000","message":"Patch Set 6: Code-Review+1\n\nnice doc change and the bug is good too, ++","accounts_in_message":[],"_revision_number":6},{"id":"aee4816886dc8ede7133a57818f3a82add52ab47","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2018-03-19 19:17:42.000000000","message":"Patch Set 6: Code-Review+1","accounts_in_message":[],"_revision_number":6},{"id":"4aff39335f56dc69a211e8a0594773157f543c9a","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2018-03-20 13:08:11.000000000","message":"Patch Set 6: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"cc8aaa005356747441dd1091d1a9e236b6fe67cd","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-20 13:30:05.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"340a2d3cff312df03cd9b47823e0004fb2e07328","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2018-03-20 13:51:08.000000000","message":"Patch Set 6: Workflow+1 Code-Review+2\n\nsounds good to me on fixing the bug in a followup","accounts_in_message":[],"_revision_number":6},{"id":"6a779a15d0d46a566e10000828eb84ead3444212","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-20 13:51:20.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":6},{"id":"708b3148f8607d79b290418e10b2d0d8aa103c78","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-20 13:59:43.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":6},{"id":"1822adbc3ea2d55293664c70b8325f1ea57327b4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-20 13:59:43.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/56/495356/6/gate/openstack-tox-pep8/00c340d/ : SUCCESS in 3m 05s\n- openstack-tox-py27 http://logs.openstack.org/56/495356/6/gate/openstack-tox-py27/1bc2521/ : SUCCESS in 3m 16s\n- openstack-tox-py35 http://logs.openstack.org/56/495356/6/gate/openstack-tox-py35/9d9ce51/ : SUCCESS in 3m 48s","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"bd003b52a5076905ceadf514c4d360fee545bfc5","revisions":{"1891a091d08f031429e1ed366a3ea203fe8e4289":{"kind":"REWORK","_number":1,"created":"2017-08-18 15:43:12.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/56/495356/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/microversion-parse","ref":"refs/changes/56/495356/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/1"}}},"commit":{"parents":[{"commit":"1f6eac7c3df048679663919f75c2bcecd3e183a2","subject":"Convert dict headers and Webob headers into lowercase.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/1f6eac7c3df048679663919f75c2bcecd3e183a2"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2017-08-18 15:42:20.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2017-08-18 15:43:10.000000000","tz":60},"subject":"Provide a helper method to get headers from environ","message":"Provide a helper method to get headers from environ\n\nThe get_version method accepts a dict or list of tuples that\nrepresent HTTP request headers that will be processed to find a\nmicroversion header. Sometimes, for example in some middlwares,\ndirect access to a headers dict will not be available and only the\nWSGI environ will be present.\n\nThis change provides a utility method which creates a new dict of\nheaders: headers_from_wsgi_environ. This mode was chosen to make it\nclear that a copy of the environ is being made, not the environ\nitself as we really don\u0027t want to be passing that as some values in\nit will not be simple objects (strings and numbers) and we do not\nknow what other middleware might have done or want to do with it.\n\nInternal to get_version any attempt to get a header named \u0027FOO\u0027 will\nfall back to looking for the WSGI equivalent of \u0027HTTP_FOO\u0027.\n\nREADME.rst has been updated to indicate the new style.\n\nThis change is backwards compatible, existing clients will not\nnotice.\n\nChange-Id: I5262031d9cde0378eabe342c1913091658c3bf9b\nCloses-Bug: #1579772\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/1891a091d08f031429e1ed366a3ea203fe8e4289"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/1891a091d08f031429e1ed366a3ea203fe8e4289"}]},"branch":"refs/heads/master"},"307205b8cc16999343ffe6c8185f0842c78956e4":{"kind":"REWORK","_number":2,"created":"2017-08-22 08:59:18.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/56/495356/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/microversion-parse","ref":"refs/changes/56/495356/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/2"}}},"commit":{"parents":[{"commit":"1f6eac7c3df048679663919f75c2bcecd3e183a2","subject":"Convert dict headers and Webob headers into lowercase.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/1f6eac7c3df048679663919f75c2bcecd3e183a2"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2017-08-18 15:42:20.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2017-08-22 08:59:02.000000000","tz":60},"subject":"Provide a helper method to get headers from environ","message":"Provide a helper method to get headers from environ\n\nThe get_version method accepts a dict or list of tuples that\nrepresent HTTP request headers that will be processed to find a\nmicroversion header. Sometimes, for example in some middlwares,\ndirect access to a headers dict will not be available and only the\nWSGI environ will be present.\n\nThis change provides a utility method which creates a new dict of\nheaders: headers_from_wsgi_environ. This mode was chosen to make it\nclear that a copy of the environ is being made, not the environ\nitself as we really don\u0027t want to be passing that as some values in\nit will not be simple objects (strings and numbers) and we do not\nknow what other middleware might have done or want to do with it.\n\nInternal to get_version any attempt to get a header named \u0027FOO\u0027 will\nfall back to looking for the WSGI equivalent of \u0027HTTP_FOO\u0027.\n\nREADME.rst has been updated to indicate the new style.\n\nThis change is backwards compatible, existing clients will not\nnotice.\n\nChange-Id: I5262031d9cde0378eabe342c1913091658c3bf9b\nCloses-Bug: #1579772\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/307205b8cc16999343ffe6c8185f0842c78956e4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/307205b8cc16999343ffe6c8185f0842c78956e4"}]},"branch":"refs/heads/master"},"1e7074d62882f2309ca7f3bea45d201aad6d3485":{"kind":"REWORK","_number":3,"created":"2017-08-22 20:54:17.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/56/495356/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/microversion-parse","ref":"refs/changes/56/495356/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/3"}}},"commit":{"parents":[{"commit":"1f6eac7c3df048679663919f75c2bcecd3e183a2","subject":"Convert dict headers and Webob headers into lowercase.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/1f6eac7c3df048679663919f75c2bcecd3e183a2"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2017-08-18 15:42:20.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2017-08-22 20:41:10.000000000","tz":60},"subject":"Provide a helper method to get headers from environ","message":"Provide a helper method to get headers from environ\n\nThe get_version method accepts a dict or list of tuples that\nrepresent HTTP request headers that will be processed to find a\nmicroversion header. Sometimes, for example in some middlwares,\ndirect access to a headers dict will not be available and only the\nWSGI environ will be present.\n\nThis change provides a utility method which creates a new dict of\nheaders: headers_from_wsgi_environ. This mode was chosen to make it\nclear that a copy of the environ is being made, not the environ\nitself as we really don\u0027t want to be passing that as some values in\nit will not be simple objects (strings and numbers) and we do not\nknow what other middleware might have done or want to do with it.\n\nInternal to get_version any attempt to get a header named \u0027FOO\u0027 will\nfall back to looking for the WSGI equivalent of \u0027HTTP_FOO\u0027.\n\nREADME.rst has been updated to indicate the new style.\n\nThis change is backwards compatible, existing clients will not\nnotice.\n\nChange-Id: I5262031d9cde0378eabe342c1913091658c3bf9b\nCloses-Bug: #1579772\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/1e7074d62882f2309ca7f3bea45d201aad6d3485"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/1e7074d62882f2309ca7f3bea45d201aad6d3485"}]},"branch":"refs/heads/master"},"383daf79e652e796dfe73474e7e79502ecf86897":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2018-03-06 16:59:47.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/56/495356/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/microversion-parse","ref":"refs/changes/56/495356/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/4"}}},"commit":{"parents":[{"commit":"1f6eac7c3df048679663919f75c2bcecd3e183a2","subject":"Convert dict headers and Webob headers into lowercase.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/1f6eac7c3df048679663919f75c2bcecd3e183a2"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2017-08-18 15:42:20.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-03-06 16:42:18.000000000","tz":0},"subject":"Provide a helper method to get headers from environ","message":"Provide a helper method to get headers from environ\n\nThe get_version method accepts a dict or list of tuples that\nrepresent HTTP request headers that will be processed to find a\nmicroversion header. Sometimes, for example in some middlewares,\ndirect access to a headers dict will not be available and only the\nWSGI environ will be present.\n\nThis change provides a utility method which creates a new dict of\nheaders: headers_from_wsgi_environ. This mode was chosen to make it\nclear that a copy of the environ is being made, not the environ\nitself as we really don\u0027t want to be passing that as some values in\nit will not be simple objects (strings and numbers) and we do not\nknow what other middleware might have done or want to do with it.\n\nInternal to get_version any attempt to get a header named \u0027FOO\u0027 will\nfall back to looking for the WSGI equivalent of \u0027HTTP_FOO\u0027.\n\nREADME.rst has been updated to indicate the new style.\n\nThis change is backwards compatible, existing clients will not\nnotice.\n\nChange-Id: I5262031d9cde0378eabe342c1913091658c3bf9b\nCloses-Bug: #1579772\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/383daf79e652e796dfe73474e7e79502ecf86897"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/383daf79e652e796dfe73474e7e79502ecf86897"}]},"branch":"refs/heads/master"},"c0df7fa0349a6e406a73cf400d770e0b94633a13":{"kind":"NO_CHANGE","_number":5,"created":"2018-03-15 12:09:31.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/56/495356/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/microversion-parse","ref":"refs/changes/56/495356/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/5"}}},"commit":{"parents":[{"commit":"1f6eac7c3df048679663919f75c2bcecd3e183a2","subject":"Convert dict headers and Webob headers into lowercase.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/1f6eac7c3df048679663919f75c2bcecd3e183a2"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2017-08-18 15:42:20.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-03-15 12:05:16.000000000","tz":0},"subject":"Provide a helper method to get headers from environ","message":"Provide a helper method to get headers from environ\n\nThe get_version method accepts a dict or list of tuples that\nrepresent HTTP request headers that will be processed to find a\nmicroversion header. Sometimes, for example in some middlewares,\ndirect access to a headers dict will not be available and only the\nWSGI environ will be present.\n\nThis change provides a utility method which creates a new dict of\nheaders: headers_from_wsgi_environ. This mode was chosen to make it\nclear that a copy of the environ is being made, not the environ\nitself as we really don\u0027t want to be passing that as some values in\nit will not be simple objects (strings and numbers) and we do not\nknow what other middleware might have done or want to do with it.\n\nInternal to get_version any attempt to get a header named \u0027FOO\u0027 will\nfall back to looking for the WSGI equivalent of \u0027HTTP_FOO\u0027.\n\nREADME.rst has been updated to indicate the new style.\n\nThis change is backwards compatible, existing clients will not\nnotice.\n\nChange-Id: I5262031d9cde0378eabe342c1913091658c3bf9b\nCloses-Bug: #1579772\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/c0df7fa0349a6e406a73cf400d770e0b94633a13"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/c0df7fa0349a6e406a73cf400d770e0b94633a13"}]},"branch":"refs/heads/master"},"bd003b52a5076905ceadf514c4d360fee545bfc5":{"kind":"REWORK","_number":6,"created":"2018-03-15 18:24:58.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/56/495356/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/microversion-parse","ref":"refs/changes/56/495356/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/microversion-parse refs/changes/56/495356/6"}}},"commit":{"parents":[{"commit":"1f6eac7c3df048679663919f75c2bcecd3e183a2","subject":"Convert dict headers and Webob headers into lowercase.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/1f6eac7c3df048679663919f75c2bcecd3e183a2"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2017-08-18 15:42:20.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-03-15 18:15:20.000000000","tz":0},"subject":"Provide a helper method to get headers from environ","message":"Provide a helper method to get headers from environ\n\nThe get_version method accepts a dict or list of tuples that\nrepresent HTTP request headers that will be processed to find a\nmicroversion header. Sometimes, for example in some middlewares,\ndirect access to a headers dict will not be available and only the\nWSGI environ will be present.\n\nThis change provides a utility method which creates a new dict of\nheaders: headers_from_wsgi_environ. This mode was chosen to make it\nclear that a copy of the environ is being made, not the environ\nitself as we really don\u0027t want to be passing that as some values in\nit will not be simple objects (strings and numbers) and we do not\nknow what other middleware might have done or want to do with it.\n\nInternal to get_version any attempt to get a header named \u0027FOO\u0027 will\nfall back to looking for the WSGI equivalent of \u0027HTTP_FOO\u0027.\n\nREADME.rst has been updated to indicate the new style.\n\nThis change is backwards compatible, existing clients will not\nnotice.\n\nChange-Id: I5262031d9cde0378eabe342c1913091658c3bf9b\nCloses-Bug: #1579772\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/bd003b52a5076905ceadf514c4d360fee545bfc5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/bd003b52a5076905ceadf514c4d360fee545bfc5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}