)]}'
{"id":"openstack%2Fmicroversion-parse~550251","triplet_id":"openstack%2Fmicroversion-parse~master~I71d091d037abcd068601b32722a09094ae74e658","project":"openstack/microversion-parse","branch":"master","topic":"cd/placement-functions","hashtags":[],"change_id":"I71d091d037abcd068601b32722a09094ae74e658","subject":"Improve Version.matches() method","status":"MERGED","created":"2018-03-06 20:49:08.000000000","updated":"2018-03-21 15:31:55.000000000","submitted":"2018-03-21 15:31:55.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":12,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"550251-1521646315678-3f8055e2","meta_rev_id":"ee6bc36fa0809607de7bbd6d87d276e17455b108","_number":550251,"virtual_id_number":550251,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":2,"date":"2018-03-21 15:31:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"all":[{"value":2,"date":"2018-03-21 14:11:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":1,"date":"2018-03-21 14:27:06.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"all":[{"value":1,"date":"2018-03-21 15:21:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-03-21 14:27:06.000000000","updated_by":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"reviewer":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"state":"REVIEWER"},{"updated":"2018-03-21 15:21:12.000000000","updated_by":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"reviewer":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"state":"REVIEWER"},{"updated":"2018-03-21 15:31:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b400f53a02427ccfd219031afbf744732a11c840","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-06 20:49:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4153103ebcdba5c335b00e65f40e4c57eb991664","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-06 21:00:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/51/550251/1/check/openstack-tox-pep8/bfe9199/ : SUCCESS in 2m 58s\n- openstack-tox-py27 http://logs.openstack.org/51/550251/1/check/openstack-tox-py27/b226fcc/ : SUCCESS in 3m 54s\n- openstack-tox-py35 http://logs.openstack.org/51/550251/1/check/openstack-tox-py35/d578ad9/ : SUCCESS in 3m 22s","accounts_in_message":[],"_revision_number":1},{"id":"276c710a6d53eddef219f1e1395ce776553272d6","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-15 12:09:31.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"b00d624daacb58a1568d7ae41e02e10f23717fdf","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-15 12:21:27.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/51/550251/2/check/openstack-tox-pep8/4a2dbf3/ : SUCCESS in 3m 10s\n- openstack-tox-py27 http://logs.openstack.org/51/550251/2/check/openstack-tox-py27/05bb297/ : SUCCESS in 3m 13s\n- openstack-tox-py35 http://logs.openstack.org/51/550251/2/check/openstack-tox-py35/578b0ad/ : SUCCESS in 3m 59s","accounts_in_message":[],"_revision_number":2},{"id":"7de5c2b76304696926c6d6b30458874176a34632","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2018-03-15 13:42:12.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"e8e16c07fffa45dde9089eb590b2c38bbba5a060","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-15 13:49:59.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nIt\u0027s behaving as designed, but probably mot in a transparent way","accounts_in_message":[],"_revision_number":2},{"id":"d4c4f25f9952f8451a0d70b770a88c87ec7dbf34","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2018-03-15 14:10:19.000000000","message":"Patch Set 2:\n\nthe AttributeError issue seems ok to me, but i couldn\u0027t tell is there a test for that condition?","accounts_in_message":[],"_revision_number":2},{"id":"b2898e6ff643dd3591f31481e88be4ac4aca259d","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2018-03-15 14:24:29.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"397498292073c3339034388f21fee26ca9a8a115","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-15 18:24:58.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"02d8b4ebb896568b2867732f837fd8db31b1fae5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-15 19:38:38.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/51/550251/3/check/openstack-tox-pep8/e45ab28/ : SUCCESS in 2m 51s\n- openstack-tox-py27 http://logs.openstack.org/51/550251/3/check/openstack-tox-py27/566f50d/ : SUCCESS in 3m 46s\n- openstack-tox-py35 http://logs.openstack.org/51/550251/3/check/openstack-tox-py35/2fe512d/ : SUCCESS in 4m 20s","accounts_in_message":[],"_revision_number":3},{"id":"7709782864a26c645efdf4ec7e6a34747afd1faf","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2018-03-15 21:28:39.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"9382253b2b459c0fea4e8dbf7e044cabba80be96","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2018-03-20 13:52:24.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"863c56b2093088502fab96535b013b6a7d159900","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2018-03-20 14:11:48.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"a6d0fbae4c56d8d0ea6d09cec1e3dacf9423517a","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-20 14:17:01.000000000","message":"Patch Set 3:\n\n(1 comment)\n\nI hear your pain Ed, but there\u0027s other pain that led to it being this way (plus a significant dollop of just getting on with it).","accounts_in_message":[],"_revision_number":3},{"id":"9980ddfaed5c93fa69c695ff357c65f2f40c7c0d","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2018-03-20 14:49:38.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"bff67ec0aa5d26ac7e52e7df1faf6a96f7e4c9bd","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-20 14:54:05.000000000","message":"Patch Set 3: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"5fe165671c1c976d0604cb9f69963bfef1b98b9b","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-20 15:04:37.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"adbc8b8308cf8637ba27e789a094a7349d0823f7","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2018-03-20 15:12:28.000000000","message":"Patch Set 4: Code-Review+2\n\nschweet","accounts_in_message":[],"_revision_number":4},{"id":"e47085136bdae337dfb06778e91b037d1def4f30","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-20 15:13:54.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/51/550251/4/check/openstack-tox-pep8/9512f4d/ : SUCCESS in 3m 16s\n- openstack-tox-py27 http://logs.openstack.org/51/550251/4/check/openstack-tox-py27/3011046/ : SUCCESS in 4m 28s\n- openstack-tox-py35 http://logs.openstack.org/51/550251/4/check/openstack-tox-py35/8ef6435/ : FAILURE in 3m 30s","accounts_in_message":[],"_revision_number":4},{"id":"e83654b45427e76546c3c7c77087ce125dfe3331","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2018-03-20 16:16:19.000000000","message":"Patch Set 4: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"932386f3c0ce2bf764541c0132ffa347482c318f","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-20 16:30:59.000000000","message":"Patch Set 4: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"1181a9b9d2f5329aa640d261fa9c87fedf79ed81","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-20 17:28:16.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"6b109fad340f1cfd08ce2c25a979d6c5a213bcd8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-20 17:57:52.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/51/550251/5/check/openstack-tox-pep8/e904484/ : SUCCESS in 3m 19s\n- openstack-tox-py27 http://logs.openstack.org/51/550251/5/check/openstack-tox-py27/e26beb7/ : SUCCESS in 3m 10s\n- openstack-tox-py35 http://logs.openstack.org/51/550251/5/check/openstack-tox-py35/1f3c5c2/ : SUCCESS in 3m 35s","accounts_in_message":[],"_revision_number":5},{"id":"0343a5ca2b532b0b949981747d5bbf2e2ee86652","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2018-03-21 14:11:51.000000000","message":"Patch Set 5: Code-Review+2\n\n(1 comment)\n\nI like the convention that Version(0,0) always matches. We should probably document that somewhere.","accounts_in_message":[],"_revision_number":5},{"id":"5c9ed8d3845e594106e17e92ca9e3962ea8b1ec9","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2018-03-21 14:27:06.000000000","message":"Patch Set 5: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"4f35ef5c405e5f2f04e4a807e7d93b057a00365b","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2018-03-21 14:51:09.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"b38c85356a9ca83c86591c0f0e8424908c5d060d","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2018-03-21 15:21:12.000000000","message":"Patch Set 5: Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"dd71ec3f38441edead3533eaa0c5ad64dc087b66","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-21 15:21:23.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"707a3e602556f35febd7e38f9281e38f125790b5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-21 15:31:55.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/51/550251/5/gate/openstack-tox-pep8/16ba39b/ : SUCCESS in 3m 03s\n- openstack-tox-py27 http://logs.openstack.org/51/550251/5/gate/openstack-tox-py27/a1db4ef/ : SUCCESS in 5m 37s\n- openstack-tox-py35 http://logs.openstack.org/51/550251/5/gate/openstack-tox-py35/6b44348/ : SUCCESS in 3m 45s","accounts_in_message":[],"_revision_number":5},{"id":"051ace87cc151e61641a1bd3a05d150eb2abe1a0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-21 15:31:55.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"e346558d5f67ae2a3a848f6d8ad6166c761b39d1","revisions":{"807a471ccf522978a8aecc40f16ef994d58fd2ab":{"kind":"REWORK","_number":1,"created":"2018-03-06 20:49:08.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/51/550251/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/microversion-parse","ref":"refs/changes/51/550251/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/1"}}},"commit":{"parents":[{"commit":"ed426421200de823c3486c26852de9e4e206fe5c","subject":"Import functions from placement","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/ed426421200de823c3486c26852de9e4e206fe5c"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-03-06 18:47:31.000000000","tz":0},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-03-06 18:47:31.000000000","tz":0},"subject":"Improve Version.matches() method","message":"Improve Version.matches() method\n\nUse within the placement service has made it clear that the\nVersion object knowing the min and max versions is useful when\nmaking Version.matches comparisons.\n\nTherefore the matches method has been updated to refer to\nmin_version and max_version attributes if they are not set\nin the matches() request. The extract_version function will\nnow set those attributes based on the version_list that is\npassed to it.\n\nChange-Id: I71d091d037abcd068601b32722a09094ae74e658\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/807a471ccf522978a8aecc40f16ef994d58fd2ab"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/807a471ccf522978a8aecc40f16ef994d58fd2ab"}]},"branch":"refs/heads/master"},"023756d6ae19dfe6f04d2f0094885a8b6e091070":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2018-03-15 12:09:31.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/51/550251/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/microversion-parse","ref":"refs/changes/51/550251/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/2"}}},"commit":{"parents":[{"commit":"e0155972f2964d7ee8a631388f1d9be00c637b5c","subject":"Import functions from placement","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/e0155972f2964d7ee8a631388f1d9be00c637b5c"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-03-06 18:47:31.000000000","tz":0},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-03-15 12:06:56.000000000","tz":0},"subject":"Improve Version.matches() method","message":"Improve Version.matches() method\n\nUse of Version within the placement service has made it clear\nthat the Version object knowing the min and max versions is\nuseful when making Version.matches comparisons.\n\nTherefore the matches method has been updated to refer to\nmin_version and max_version attributes if they are not set\nin the matches() request. The extract_version function now\nsets those attributes based on the version_list that is\npassed to it.\n\nChange-Id: I71d091d037abcd068601b32722a09094ae74e658\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/023756d6ae19dfe6f04d2f0094885a8b6e091070"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/023756d6ae19dfe6f04d2f0094885a8b6e091070"}]},"branch":"refs/heads/master"},"15ea09649c594af5f0f8ce61e9d93e1448d0949a":{"kind":"REWORK","_number":3,"created":"2018-03-15 18:24:58.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/51/550251/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/microversion-parse","ref":"refs/changes/51/550251/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/3"}}},"commit":{"parents":[{"commit":"da0b4d66c964242ffea1f6dfe4a91556048f1243","subject":"Import functions from placement","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/da0b4d66c964242ffea1f6dfe4a91556048f1243"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-03-06 18:47:31.000000000","tz":0},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-03-15 18:19:54.000000000","tz":0},"subject":"Improve Version.matches() method","message":"Improve Version.matches() method\n\nUse of Version within the placement service has made it clear\nthat the Version object knowing the min and max versions is\nuseful when making Version.matches comparisons.\n\nTherefore the matches method has been updated to refer to\nmin_version and max_version attributes if they are not set\nin the matches() request. The extract_version function now\nsets those attributes based on the version_list that is\npassed to it.\n\nChange-Id: I71d091d037abcd068601b32722a09094ae74e658\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/15ea09649c594af5f0f8ce61e9d93e1448d0949a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/15ea09649c594af5f0f8ce61e9d93e1448d0949a"}]},"branch":"refs/heads/master"},"6b9c88b539cf3d5cf12ff98b045481f889b48c19":{"kind":"REWORK","_number":4,"created":"2018-03-20 15:04:37.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/51/550251/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/microversion-parse","ref":"refs/changes/51/550251/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/4"}}},"commit":{"parents":[{"commit":"da0b4d66c964242ffea1f6dfe4a91556048f1243","subject":"Import functions from placement","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/da0b4d66c964242ffea1f6dfe4a91556048f1243"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-03-06 18:47:31.000000000","tz":0},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-03-20 15:04:04.000000000","tz":0},"subject":"Improve Version.matches() method","message":"Improve Version.matches() method\n\nUse of Version within the placement service has made it clear\nthat the Version object knowing the min and max versions is\nuseful when making Version.matches comparisons.\n\nTherefore the matches method has been updated to refer to\nmin_version and max_version attributes if they are not set\nin the matches() request. The extract_version function now\nsets those attributes based on the version_list that is\npassed to it.\n\nChange-Id: I71d091d037abcd068601b32722a09094ae74e658\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/6b9c88b539cf3d5cf12ff98b045481f889b48c19"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/6b9c88b539cf3d5cf12ff98b045481f889b48c19"}]},"branch":"refs/heads/master"},"e346558d5f67ae2a3a848f6d8ad6166c761b39d1":{"kind":"REWORK","_number":5,"created":"2018-03-20 17:28:16.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/51/550251/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/microversion-parse","ref":"refs/changes/51/550251/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/microversion-parse refs/changes/51/550251/5"}}},"commit":{"parents":[{"commit":"da0b4d66c964242ffea1f6dfe4a91556048f1243","subject":"Import functions from placement","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/da0b4d66c964242ffea1f6dfe4a91556048f1243"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-03-06 18:47:31.000000000","tz":0},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-03-20 17:23:26.000000000","tz":0},"subject":"Improve Version.matches() method","message":"Improve Version.matches() method\n\nUse of Version within the placement service has made it clear\nthat the Version object knowing the min and max versions is\nuseful when making Version.matches comparisons.\n\nTherefore the matches method has been updated to refer to\nmin_version and max_version attributes if they are not set\nin the matches() request. The extract_version function now\nsets those attributes based on the version_list that is\npassed to it.\n\nIf min and max are not set on the Version object, they default\nto negative versions, which are not possible in microversions\nand mean matches() (without override args) will be false. The\nuse of explicit values (instead of None) is so python3 is happy\n(and it is better anyway).\n\nChange-Id: I71d091d037abcd068601b32722a09094ae74e658\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/e346558d5f67ae2a3a848f6d8ad6166c761b39d1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/e346558d5f67ae2a3a848f6d8ad6166c761b39d1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}