)]}'
{"id":"openstack%2Fmicroversion-parse~554547","triplet_id":"openstack%2Fmicroversion-parse~master~I7a09b63db390431be044ae3fc6aeece565606b40","project":"openstack/microversion-parse","branch":"master","topic":"cd/placement-functions","hashtags":[],"change_id":"I7a09b63db390431be044ae3fc6aeece565606b40","subject":"Do not use redundant attr check for keys in fold_headers","status":"MERGED","created":"2018-03-20 13:54:27.000000000","updated":"2018-03-21 16:43:22.000000000","submitted":"2018-03-21 16:43:22.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"554547-1521650602062-7632dd8b","meta_rev_id":"4d765510037301d9fdf9eb4d84e027bccf1a13fa","_number":554547,"virtual_id_number":554547,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2018-03-21 16:43:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"all":[{"value":2,"date":"2018-03-21 14:56:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2018-03-20 17:28:16.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"all":[{"value":1,"date":"2018-03-21 16:30:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-03-20 13:56:19.000000000","updated_by":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"reviewer":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"state":"REVIEWER"},{"updated":"2018-03-21 16:30:56.000000000","updated_by":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"reviewer":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"state":"REVIEWER"},{"updated":"2018-03-21 16:43:21.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a6623f12d7a3b5e20a3761f2775b13a911c97b68","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-20 13:54:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0af014ea79ddcdc310b13599469784333ed245bc","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2018-03-20 13:56:19.000000000","message":"Patch Set 1: Code-Review+1\n\nthis seems reasonable","accounts_in_message":[],"_revision_number":1},{"id":"de33203808bf982a7f502dfe52ecb0e06b9c3a81","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2018-03-20 13:56:43.000000000","message":"Patch Set 1:\n\ncan\u0027t remember, did we have a test for this explicit case?","accounts_in_message":[],"_revision_number":1},{"id":"0e242fa59e7ebed22ff6291806bfcb59f5c7f859","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-20 14:01:52.000000000","message":"Patch Set 1:\n\n\u003e can\u0027t remember, did we have a test for this explicit case?\n\nYes, you can\u0027t get to the rest of the code in that method unless the AttributeError happens and that method has 100% test coverage (the file has 99%)","accounts_in_message":[],"_revision_number":1},{"id":"ad11500d4040a25dbfa40f07cbbd18a580d01bdd","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2018-03-20 14:02:54.000000000","message":"Patch Set 1:\n\nawesome, thanks Chris!","accounts_in_message":[],"_revision_number":1},{"id":"23547da4d8d7cde1c73b93713277657b4c8d1942","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-20 14:12:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/47/554547/1/check/openstack-tox-pep8/71230ff/ : SUCCESS in 16m 21s\n- openstack-tox-py27 http://logs.openstack.org/47/554547/1/check/openstack-tox-py27/09679b0/ : SUCCESS in 3m 22s\n- openstack-tox-py35 http://logs.openstack.org/47/554547/1/check/openstack-tox-py35/aa11a02/ : SUCCESS in 3m 42s","accounts_in_message":[],"_revision_number":1},{"id":"e29d810ff4ab79af7cb8980826ca69171b5dcac1","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-20 15:04:37.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"60a3edf0622df2c602af853cf176760bcc2eb701","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-20 15:13:45.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/47/554547/2/check/openstack-tox-pep8/ad7be3b/ : SUCCESS in 2m 54s\n- openstack-tox-py27 http://logs.openstack.org/47/554547/2/check/openstack-tox-py27/c029699/ : SUCCESS in 3m 46s\n- openstack-tox-py35 http://logs.openstack.org/47/554547/2/check/openstack-tox-py35/b78c27a/ : FAILURE in 3m 44s","accounts_in_message":[],"_revision_number":2},{"id":"bb0cf7efb9f9cdb2fec3254cbadae1fd80340860","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-03-20 17:28:16.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"50aed114777dfc00cad389affaab1771d94f0b1f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-20 17:55:31.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/47/554547/3/check/openstack-tox-pep8/e440a92/ : SUCCESS in 3m 21s\n- openstack-tox-py27 http://logs.openstack.org/47/554547/3/check/openstack-tox-py27/3af937c/ : SUCCESS in 4m 28s\n- openstack-tox-py35 http://logs.openstack.org/47/554547/3/check/openstack-tox-py35/85bf848/ : SUCCESS in 4m 12s","accounts_in_message":[],"_revision_number":3},{"id":"1456db5fee8558b2f9377644aa0052ca45628122","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2018-03-21 14:56:40.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"69f0e73e0c0196c28a28cdacd1b8bc55873e6fac","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2018-03-21 16:30:56.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"fef37c79fc296a34d285d24634dd17804f06129b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-21 16:31:08.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"eb98fb5889ca46fb17ae098d5e487e045ab8748f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-21 16:43:21.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/47/554547/3/gate/openstack-tox-pep8/f32fcac/ : SUCCESS in 3m 16s\n- openstack-tox-py27 http://logs.openstack.org/47/554547/3/gate/openstack-tox-py27/913a4f5/ : SUCCESS in 3m 49s\n- openstack-tox-py35 http://logs.openstack.org/47/554547/3/gate/openstack-tox-py35/cc8f23b/ : SUCCESS in 4m 33s","accounts_in_message":[],"_revision_number":3},{"id":"9cc13c1240340459389e00cb8018b001bd324f5f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-21 16:43:22.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"e93d35f10d3c9ad20774a4be73fd80ecaf97d404","revisions":{"8f6c35fafd4ec59cc84f5052fde0c6a58165f7cc":{"kind":"REWORK","_number":1,"created":"2018-03-20 13:54:27.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/47/554547/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/microversion-parse","ref":"refs/changes/47/554547/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/47/554547/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/47/554547/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/47/554547/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/microversion-parse refs/changes/47/554547/1"}}},"commit":{"parents":[{"commit":"0fb4576addf73d99c9cf51c0502ebbc0081b9958","subject":"Clean up package version and python version support","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/0fb4576addf73d99c9cf51c0502ebbc0081b9958"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-03-20 13:48:05.000000000","tz":0},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-03-20 13:51:00.000000000","tz":0},"subject":"Do not use redundant attr check for keys in fold_headers","message":"Do not use redundant attr check for keys in fold_headers\n\nWe only care about items, so use it, and pass if we get an\nAttributeError\n\nChange-Id: I7a09b63db390431be044ae3fc6aeece565606b40\nCloses-Bug: #1756157\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/8f6c35fafd4ec59cc84f5052fde0c6a58165f7cc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/8f6c35fafd4ec59cc84f5052fde0c6a58165f7cc"}]},"branch":"refs/heads/master"},"5387589c8e3d8d96658826043ce94217ba84f887":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2018-03-20 15:04:37.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/47/554547/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/microversion-parse","ref":"refs/changes/47/554547/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/47/554547/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/47/554547/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/47/554547/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/microversion-parse refs/changes/47/554547/2"}}},"commit":{"parents":[{"commit":"b5a254d2d50eff7c11c018c00db248ac47e90a0b","subject":"Clean up package version and python version support","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/b5a254d2d50eff7c11c018c00db248ac47e90a0b"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-03-20 13:48:05.000000000","tz":0},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-03-20 15:04:22.000000000","tz":0},"subject":"Do not use redundant attr check for keys in fold_headers","message":"Do not use redundant attr check for keys in fold_headers\n\nWe only care about items, so use it, and pass if we get an\nAttributeError\n\nChange-Id: I7a09b63db390431be044ae3fc6aeece565606b40\nCloses-Bug: #1756157\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/5387589c8e3d8d96658826043ce94217ba84f887"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/5387589c8e3d8d96658826043ce94217ba84f887"}]},"branch":"refs/heads/master"},"e93d35f10d3c9ad20774a4be73fd80ecaf97d404":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2018-03-20 17:28:16.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/47/554547/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/microversion-parse","ref":"refs/changes/47/554547/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/47/554547/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/47/554547/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/47/554547/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/microversion-parse refs/changes/47/554547/3"}}},"commit":{"parents":[{"commit":"4b8719683734e613360498fb08141dd9c4152599","subject":"Clean up package version and python version support","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/4b8719683734e613360498fb08141dd9c4152599"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-03-20 13:48:05.000000000","tz":0},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-03-20 17:24:56.000000000","tz":0},"subject":"Do not use redundant attr check for keys in fold_headers","message":"Do not use redundant attr check for keys in fold_headers\n\nWe only care about items, so use it, and pass if we get an\nAttributeError\n\nChange-Id: I7a09b63db390431be044ae3fc6aeece565606b40\nCloses-Bug: #1756157\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/e93d35f10d3c9ad20774a4be73fd80ecaf97d404"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/e93d35f10d3c9ad20774a4be73fd80ecaf97d404"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}