)]}'
{"mistraldashboard/default/SmartCell.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"c0a47a88a58d7b93eb71e67e35ff5d63e4524455","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from horizon.tables.base import Cell"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import six"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def get_data(self, datum, column, row):"},{"line_number":29,"context_line":"    \"\"\"Fetches the data to be displayed in this cell.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_25b52b30","line":26,"updated":"2015-12-28 15:46:58.000000000","message":"I think the three group imports are belong to \u0027related third party imports\u0027 according to https://www.python.org/dev/peps/pep-0008/#imports, so please combine them together.","commit_id":"3a1e52ed6345548d6a447b19793ead9567ece54a"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"c0a47a88a58d7b93eb71e67e35ff5d63e4524455","unresolved":false,"context_lines":[{"line_number":28,"context_line":"def get_data(self, datum, column, row):"},{"line_number":29,"context_line":"    \"\"\"Fetches the data to be displayed in this cell.\"\"\""},{"line_number":30,"context_line":"    table \u003d row.table"},{"line_number":31,"context_line":"    if column.auto \u003d\u003d \"multi_select\":"},{"line_number":32,"context_line":"        data \u003d \"\""},{"line_number":33,"context_line":"        if row.can_be_selected(datum):"},{"line_number":34,"context_line":"            widget \u003d forms.CheckboxInput(check_test\u003dlambda value: False)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_a5f6fbf6","line":31,"updated":"2015-12-28 15:46:58.000000000","message":"It\u0027s better to add a blank line before this line.","commit_id":"3a1e52ed6345548d6a447b19793ead9567ece54a"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"c0a47a88a58d7b93eb71e67e35ff5d63e4524455","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        data \u003d \"\""},{"line_number":33,"context_line":"        if row.can_be_selected(datum):"},{"line_number":34,"context_line":"            widget \u003d forms.CheckboxInput(check_test\u003dlambda value: False)"},{"line_number":35,"context_line":"            # Convert value to string to avoid accidental type conversion"},{"line_number":36,"context_line":"            data \u003d widget.render(\u0027object_ids\u0027,"},{"line_number":37,"context_line":"                                 six.text_type(table.get_object_id(datum)),"},{"line_number":38,"context_line":"                                 {\u0027class\u0027: \u0027table-row-multi-select\u0027})"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_a544bb1a","line":35,"updated":"2015-12-28 15:46:58.000000000","message":"It\u0027s better to add a blank line before this line.","commit_id":"3a1e52ed6345548d6a447b19793ead9567ece54a"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"c0a47a88a58d7b93eb71e67e35ff5d63e4524455","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        if row.can_be_selected(datum):"},{"line_number":34,"context_line":"            widget \u003d forms.CheckboxInput(check_test\u003dlambda value: False)"},{"line_number":35,"context_line":"            # Convert value to string to avoid accidental type conversion"},{"line_number":36,"context_line":"            data \u003d widget.render(\u0027object_ids\u0027,"},{"line_number":37,"context_line":"                                 six.text_type(table.get_object_id(datum)),"},{"line_number":38,"context_line":"                                 {\u0027class\u0027: \u0027table-row-multi-select\u0027})"},{"line_number":39,"context_line":"        table._data_cache[column][table.get_object_id(datum)] \u003d data"},{"line_number":40,"context_line":"    elif column.auto \u003d\u003d \"form_field\":"},{"line_number":41,"context_line":"        widget \u003d column.form_field"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_4575d761","line":38,"range":{"start_line":36,"start_character":0,"end_line":38,"end_character":69},"updated":"2015-12-28 15:46:58.000000000","message":"we always use the following style:\n\n    data \u003d widget.render(\n        \u0027object_ids\u0027,\n        six.text_type(table.get_object_id(datum)),\n        {\u0027class\u0027: \u0027table-row-multi-select\u0027}\n    )","commit_id":"3a1e52ed6345548d6a447b19793ead9567ece54a"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"c0a47a88a58d7b93eb71e67e35ff5d63e4524455","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        if issubclass(widget.__class__, forms.Field):"},{"line_number":43,"context_line":"            widget \u003d widget.widget"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        widget_name \u003d \"%s__%s\" % \\"},{"line_number":46,"context_line":"                      (column.name,"},{"line_number":47,"context_line":"                       six.text_type(table.get_object_id(datum)))"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # Create local copy of attributes, so it don\u0027t change column"},{"line_number":50,"context_line":"        # class form_field_attributes"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_85b2df04","line":47,"range":{"start_line":45,"start_character":0,"end_line":47,"end_character":65},"updated":"2015-12-28 15:46:58.000000000","message":"we usually don\u0027t use backslash.","commit_id":"3a1e52ed6345548d6a447b19793ead9567ece54a"},{"author":{"_account_id":17089,"name":"Gal Margalit","email":"galmargalit@gmail.com","username":"Gal"},"change_message_id":"3f82c89eb5753a3b9c515fe890d0dfe41bb24d6b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright © 2015 - Alcatel-Lucent"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":6,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":7,"context_line":"# You may obtain a copy of the License at"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# Unless required by applicable law or agreed to in writing, software"},{"line_number":12,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":13,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":14,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"File Overrides OpenStack Horizon Cell method to return the whole"},{"line_number":18,"context_line":" row data using cell_attributes_getter\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from django import forms"},{"line_number":21,"context_line":"from django import template"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from horizon.tables.base import Cell"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import six"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def get_data(self, datum, column, row):"},{"line_number":29,"context_line":"    \"\"\"Fetches the data to be displayed in this cell.\"\"\""},{"line_number":30,"context_line":"    table \u003d row.table"},{"line_number":31,"context_line":"    if column.auto \u003d\u003d \"multi_select\":"},{"line_number":32,"context_line":"        data \u003d \"\""},{"line_number":33,"context_line":"        if row.can_be_selected(datum):"},{"line_number":34,"context_line":"            widget \u003d forms.CheckboxInput(check_test\u003dlambda value: False)"},{"line_number":35,"context_line":"            # Convert value to string to avoid accidental type conversion"},{"line_number":36,"context_line":"            data \u003d widget.render(\u0027object_ids\u0027,"},{"line_number":37,"context_line":"                                 six.text_type(table.get_object_id(datum)),"},{"line_number":38,"context_line":"                                 {\u0027class\u0027: \u0027table-row-multi-select\u0027})"},{"line_number":39,"context_line":"        table._data_cache[column][table.get_object_id(datum)] \u003d data"},{"line_number":40,"context_line":"    elif column.auto \u003d\u003d \"form_field\":"},{"line_number":41,"context_line":"        widget \u003d column.form_field"},{"line_number":42,"context_line":"        if issubclass(widget.__class__, forms.Field):"},{"line_number":43,"context_line":"            widget \u003d widget.widget"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        widget_name \u003d \"%s__%s\" % \\"},{"line_number":46,"context_line":"                      (column.name,"},{"line_number":47,"context_line":"                       six.text_type(table.get_object_id(datum)))"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # Create local copy of attributes, so it don\u0027t change column"},{"line_number":50,"context_line":"        # class form_field_attributes"},{"line_number":51,"context_line":"        form_field_attributes \u003d {}"},{"line_number":52,"context_line":"        form_field_attributes.update(column.form_field_attributes)"},{"line_number":53,"context_line":"        # Adding id of the input so it pairs with label correctly"},{"line_number":54,"context_line":"        form_field_attributes[\u0027id\u0027] \u003d widget_name"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        if (template.defaultfilters.urlize in column.filters or"},{"line_number":57,"context_line":"           template.defaultfilters.yesno in column.filters):"},{"line_number":58,"context_line":"                data \u003d widget.render(widget_name,"},{"line_number":59,"context_line":"                                     column.get_raw_data(datum),"},{"line_number":60,"context_line":"                                     form_field_attributes)"},{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            data \u003d widget.render(widget_name,"},{"line_number":63,"context_line":"                                 column.get_data(datum),"},{"line_number":64,"context_line":"                                 form_field_attributes)"},{"line_number":65,"context_line":"        table._data_cache[column][table.get_object_id(datum)] \u003d data"},{"line_number":66,"context_line":"    elif column.auto \u003d\u003d \"actions\":"},{"line_number":67,"context_line":"        data \u003d table.render_row_actions(datum, pull_right\u003dFalse)"},{"line_number":68,"context_line":"        table._data_cache[column][table.get_object_id(datum)] \u003d data"},{"line_number":69,"context_line":"    else:"},{"line_number":70,"context_line":"        data \u003d column.get_data(datum)"},{"line_number":71,"context_line":"        if column.cell_attributes_getter:"},{"line_number":72,"context_line":"            # Following line is the change: cell_attributes_getter called with"},{"line_number":73,"context_line":"            #  \"datum\" instead of \"data\""},{"line_number":74,"context_line":"            cell_attributes \u003d column.cell_attributes_getter(datum) or {}"},{"line_number":75,"context_line":"            self.attrs.update(cell_attributes)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    return data"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def init():"},{"line_number":81,"context_line":"    Cell.get_data \u003d get_data"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_a55d9b7a","line":81,"range":{"start_line":1,"start_character":0,"end_line":81,"end_character":28},"updated":"2015-12-28 15:59:04.000000000","message":"Most of this code is an Horizon code, (excluding one line and my init function).\nI want it to be as close as possible to the source.","commit_id":"3a1e52ed6345548d6a447b19793ead9567ece54a"}],"mistraldashboard/executions/tables.py":[{"author":{"_account_id":8592,"name":"Anastasia Kuznetsova","email":"akuznetsova@mirantis.com","username":"nastya-kuz"},"change_message_id":"ba8b5b4597ef025d7b2cfb927d84a53becf11b75","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"class ExecutionsTable(tables.DataTable):"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def getHoverHelp(data):"},{"line_number":162,"context_line":"        if hasattr(data, \u0027state_info\u0027) and data.state_info:"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"                return {\u0027title\u0027: data.state_info}"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_ba503fd5","line":161,"updated":"2015-12-29 12:37:20.000000000","message":"Soft: I would prefer to use one code style for method\u0027s naming, e.g get_hover_help instead of getHoverHelp","commit_id":"3a1e52ed6345548d6a447b19793ead9567ece54a"},{"author":{"_account_id":17089,"name":"Gal Margalit","email":"galmargalit@gmail.com","username":"Gal"},"change_message_id":"748e4ec82021b21bcad922a05c9d2c7a4dd0248a","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"class ExecutionsTable(tables.DataTable):"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def getHoverHelp(data):"},{"line_number":162,"context_line":"        if hasattr(data, \u0027state_info\u0027) and data.state_info:"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"                return {\u0027title\u0027: data.state_info}"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_a5d6e4ee","line":161,"in_reply_to":"1a7b0d38_ba503fd5","updated":"2015-12-29 13:54:22.000000000","message":"Thanks, this is the well known and received by horizon standards I\u0027m afraid - please read: http://docs.openstack.org/developer/horizon/ref/tables.html#horizon.tables.Column.cell_attributes_getter","commit_id":"3a1e52ed6345548d6a447b19793ead9567ece54a"}],"mistraldashboard/tasks/tables.py":[{"author":{"_account_id":8592,"name":"Anastasia Kuznetsova","email":"akuznetsova@mirantis.com","username":"nastya-kuz"},"change_message_id":"ba8b5b4597ef025d7b2cfb927d84a53becf11b75","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class TaskTable(tables.DataTable):"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def getHoverHelp(data):"},{"line_number":48,"context_line":"        if hasattr(data, \u0027state_info\u0027) and data.state_info:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"                return {\u0027title\u0027: data.state_info}"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_fa71e776","line":47,"updated":"2015-12-29 12:37:20.000000000","message":"Same comment as in previous file","commit_id":"3a1e52ed6345548d6a447b19793ead9567ece54a"},{"author":{"_account_id":17089,"name":"Gal Margalit","email":"galmargalit@gmail.com","username":"Gal"},"change_message_id":"748e4ec82021b21bcad922a05c9d2c7a4dd0248a","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class TaskTable(tables.DataTable):"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def getHoverHelp(data):"},{"line_number":48,"context_line":"        if hasattr(data, \u0027state_info\u0027) and data.state_info:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"                return {\u0027title\u0027: data.state_info}"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_2538b43c","line":47,"in_reply_to":"1a7b0d38_fa71e776","updated":"2015-12-29 13:54:22.000000000","message":"Thanks, this is the well known and received by horizon standards I\u0027m afraid - please read: http://docs.openstack.org/developer/horizon/ref/tables.html#horizon.tables.Column.cell_attributes_getter","commit_id":"3a1e52ed6345548d6a447b19793ead9567ece54a"}]}
