)]}'
{"id":"openstack%2Fmistral-lib~692970","triplet_id":"openstack%2Fmistral-lib~stable%2Ftrain~I544d3c172f2dea02c62c49c311c4b5954413ae15","project":"openstack/mistral-lib","branch":"stable/train","topic":"bug/1850843","hashtags":[],"change_id":"I544d3c172f2dea02c62c49c311c4b5954413ae15","subject":"Ensure we mask sensitive data from Mistral Action logs","status":"MERGED","created":"2019-11-05 10:05:24.000000000","updated":"2019-11-06 04:39:07.000000000","submitted":"2019-11-06 04:39:07.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"692970-1573015147419-752aeac9","meta_rev_id":"a878d0f8126d5ebb41264387121075a05f05576d","_number":692970,"virtual_id_number":692970,"owner":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-11-06 04:39:07.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"value":0,"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"value":2,"date":"2019-11-06 04:30:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"value":1,"date":"2019-11-06 04:30:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-05 10:05:24.000000000","updated_by":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"reviewer":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"state":"REVIEWER"},{"updated":"2019-11-05 10:09:21.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-11-06 04:30:01.000000000","updated_by":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"reviewer":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"state":"REVIEWER"},{"updated":"2019-11-06 04:39:07.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d9602055256d6a732c4301cd20579707df62bad4","author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"date":"2019-11-05 10:05:24.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"00bec7f54cc1dd3dbb9386257d8276f44a24ce30","author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"date":"2019-11-05 10:06:02.000000000","message":"Topic set to bug/1850843","accounts_in_message":[],"_revision_number":1},{"id":"02f3d28c355a205776697c36ceed10fc6cd12f74","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-11-05 10:09:21.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"b9a69db1f3911fc508ad027cb67e4e41c559a833","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-05 10:13:28.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/26e1320f7cdb44b28666561825e6f32a : SUCCESS in 4m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7c6db5c5423a490e9c924ef9d745c9b5 : FAILURE in 2m 36s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/dce57492aecc4c919caf56574e91f185 : SUCCESS in 2m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/18d610cb7d88479889c88c29b8ab5a77 : SUCCESS in 2m 49s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/31d338c96a1e4e3687fba96e96d53ce5 : SUCCESS in 3m 11s","accounts_in_message":[],"_revision_number":1},{"id":"c6e63ca22c98097642fbc31688295b097e5c2125","author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"date":"2019-11-05 10:37:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ab83030330de14c9ec8652c8217cfba72357ce59","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-05 10:47:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2f1a2d5376d94af58b1277a5b38a4b99 : SUCCESS in 4m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/287f0251a46f4f169faa1406b23a4083 : SUCCESS in 3m 36s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/528be1ee75934074b47f7032f6a76197 : SUCCESS in 3m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d0c50c24dc984361ab3ff01c53577369 : SUCCESS in 2m 38s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/616ca2758c15477c97227571dcb76804 : SUCCESS in 2m 50s","accounts_in_message":[],"_revision_number":2},{"id":"9ad0e187813cb16a2fd47aa57eddbe0f75f4fb79","author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"date":"2019-11-06 04:30:01.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"952a21ec36cf129ef941ce648617b8d32b95ba76","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-06 04:30:12.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"aec643cc504cfd4a61e38853f02459127e4aa3c7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-06 04:39:07.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"a878d0f8126d5ebb41264387121075a05f05576d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-06 04:39:07.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9d2c29776cc14eec8fe5ae88886e14e8 : SUCCESS in 4m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/67d48935506246cf8f6d3c307958a79f : SUCCESS in 2m 50s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/4f78ab97e8b941bda54e33bfd521c0be : SUCCESS in 2m 53s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6f914f0eb81841078c691c97df389916 : SUCCESS in 2m 48s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/57959cf48cab447a965852b01ef45594 : SUCCESS in 2m 59s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4bac2b282e3a01e7a9a035d8b8c921024ecb6261","revisions":{"0493f675c8f5b0c5540e035341e6dd0763e50356":{"kind":"REWORK","_number":1,"created":"2019-11-05 10:05:24.000000000","uploader":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"ref":"refs/changes/70/692970/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/mistral-lib","ref":"refs/changes/70/692970/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/mistral-lib refs/changes/70/692970/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/mistral-lib refs/changes/70/692970/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/mistral-lib refs/changes/70/692970/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/mistral-lib refs/changes/70/692970/1"}}},"commit":{"parents":[{"commit":"b9dc3603a74e274534a56397239cd0c2d12510e7","subject":"Update TOX/UPPER_CONSTRAINTS_FILE for stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral-lib/commit/b9dc3603a74e274534a56397239cd0c2d12510e7"}]}],"author":{"name":"Cédric Jeanneret","email":"cjeanner@redhat.com","date":"2019-11-01 10:47:35.000000000","tz":60},"committer":{"name":"Dougal Matthews","email":"dougal@redhat.com","date":"2019-11-05 10:05:24.000000000","tz":0},"subject":"Ensure we mask sensitive data from Mistral Action logs","message":"Ensure we mask sensitive data from Mistral Action logs\n\nMistral didn\u0027t make use of the oslo_utils \"mask_password\" methods,\nleading in sensitive data leakage in its logs.\n\nThis patch corrects this security issue.\nNote that it depends on oslo_utils patch adding new patterns, and\nensuring it\u0027s case-insensitive.\n\nChange-Id: I544d3c172f2dea02c62c49c311c4b5954413ae15\nDepends-On: https://review.opendev.org/#/c/692965/\nRelated-Bug: #1850843\nCo-Authored-By: Dougal Matthews \u003cdougal@redhat.com\u003e\nSigned-off-by: Cédric Jeanneret \u003ccjeanner@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral-lib/commit/0493f675c8f5b0c5540e035341e6dd0763e50356"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral-lib/commit/0493f675c8f5b0c5540e035341e6dd0763e50356"}]},"branch":"refs/heads/stable/train"},"4bac2b282e3a01e7a9a035d8b8c921024ecb6261":{"kind":"REWORK","_number":2,"created":"2019-11-05 10:37:43.000000000","uploader":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"ref":"refs/changes/70/692970/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/mistral-lib","ref":"refs/changes/70/692970/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/mistral-lib refs/changes/70/692970/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/mistral-lib refs/changes/70/692970/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/mistral-lib refs/changes/70/692970/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/mistral-lib refs/changes/70/692970/2"}}},"commit":{"parents":[{"commit":"b9dc3603a74e274534a56397239cd0c2d12510e7","subject":"Update TOX/UPPER_CONSTRAINTS_FILE for stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral-lib/commit/b9dc3603a74e274534a56397239cd0c2d12510e7"}]}],"author":{"name":"Cédric Jeanneret","email":"cjeanner@redhat.com","date":"2019-11-01 10:47:35.000000000","tz":60},"committer":{"name":"Dougal Matthews","email":"dougal@redhat.com","date":"2019-11-05 10:37:43.000000000","tz":0},"subject":"Ensure we mask sensitive data from Mistral Action logs","message":"Ensure we mask sensitive data from Mistral Action logs\n\nMistral didn\u0027t make use of the oslo_utils \"mask_password\" methods,\nleading in sensitive data leakage in its logs.\n\nThis patch corrects this security issue.\nNote that it depends on oslo_utils patch adding new patterns, and\nensuring it\u0027s case-insensitive.\n\nChange-Id: I544d3c172f2dea02c62c49c311c4b5954413ae15\nRelated-Bug: #1850843\nCo-Authored-By: Dougal Matthews \u003cdougal@redhat.com\u003e\nSigned-off-by: Cédric Jeanneret \u003ccjeanner@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral-lib/commit/4bac2b282e3a01e7a9a035d8b8c921024ecb6261"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral-lib/commit/4bac2b282e3a01e7a9a035d8b8c921024ecb6261"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
