)]}'
{"id":"openstack%2Fmistral-lib~692974","triplet_id":"openstack%2Fmistral-lib~stable%2Fstein~I544d3c172f2dea02c62c49c311c4b5954413ae15","project":"openstack/mistral-lib","branch":"stable/stein","topic":"bug/1850843","hashtags":[],"change_id":"I544d3c172f2dea02c62c49c311c4b5954413ae15","subject":"Ensure we mask sensitive data from Mistral Action logs","status":"MERGED","created":"2019-11-05 10:41:52.000000000","updated":"2019-11-06 04:39:08.000000000","submitted":"2019-11-06 04:39:08.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"692974-1573015148475-dd5696ed","meta_rev_id":"2a9682122f7e0f284522e109098934931c06f3df","_number":692974,"virtual_id_number":692974,"owner":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-11-06 04:39:08.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"all":[{"value":2,"date":"2019-11-06 04:30:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"all":[{"value":1,"date":"2019-11-06 04:30:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-05 10:41:52.000000000","updated_by":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"reviewer":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"state":"REVIEWER"},{"updated":"2019-11-06 04:30:25.000000000","updated_by":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"reviewer":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"state":"REVIEWER"},{"updated":"2019-11-06 04:39:08.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"099ae762b025d9cdb28bf1ac84ad782d5f84e9da","author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"date":"2019-11-05 10:41:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"047a347f2cc73312274c48f99d97734f819c643a","author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"date":"2019-11-05 10:50:21.000000000","message":"Topic set to bug/1850843","accounts_in_message":[],"_revision_number":1},{"id":"fa7694c7b738bff0712142f211ee902aee2964b1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-05 10:56:15.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d5fbfab0c36248a58e2ecce10c5dcd23 : FAILURE in 5m 39s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e86984defa9d49a5a64413944cda9b92 : FAILURE in 5m 24s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/e0ee4e3510274cb481b939281d85f06a : FAILURE in 2m 18s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/e995ca608eb642bca54ffa7eadcad07c : FAILURE in 5m 31s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/86db20cc1000483b8f495715ac69b61d : FAILURE in 4m 46s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/78cde55b56534bb3b55aaada059c39fe : FAILURE in 5m 37s","accounts_in_message":[],"_revision_number":1},{"id":"439d2ceb69974e265d104345e3fd42011bb46c1b","author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"date":"2019-11-05 11:12:46.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8a39d40621fd19100746950544975ebd23afebdf","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-05 11:18:01.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/cee9cf7af86b4688b3fe2c6bcd0120a2 : SUCCESS in 4m 11s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/079d4827ad48404c9b62e47926389e97 : FAILURE in 2m 34s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/80357cf69f3a49df84e318d35c828bf4 : SUCCESS in 2m 40s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/10f13601361f4698a5b91f5f7d42fae5 : SUCCESS in 4m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/859e3724c3b3431dbe468e1c6f954758 : SUCCESS in 2m 38s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/4ab802a504054336825c0d4a304dbfcd : SUCCESS in 3m 09s","accounts_in_message":[],"_revision_number":2},{"id":"d4b673d258ca94009728001dc28763b15b3e21e7","author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"date":"2019-11-05 12:31:24.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"3bde99744bd25b5772ab91eb7db3098cd8db7c79","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-05 12:40:40.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ac7bbf08da3649abb0d56dd76b79bbe5 : SUCCESS in 4m 31s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/05fcaa2da3bf4153a69d4a6ca4a3e097 : SUCCESS in 3m 03s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/9091f49fb42a4ec9a4cda8e175144176 : SUCCESS in 3m 51s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/9b0da840e2f34c1eb09bfa80d086a195 : SUCCESS in 3m 02s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1d8e633d3a7c474db592fa4db76a1d63 : SUCCESS in 3m 22s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/22874245b72d402cb024fd560810b89f : SUCCESS in 3m 53s","accounts_in_message":[],"_revision_number":3},{"id":"5a9b946f5a80f171b739daad4532f031f111e282","author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"date":"2019-11-06 04:30:25.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"79c6e3330469006ae1cc05f89a6c0aa60c4eb27b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-06 04:30:36.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"173181ca6cfb50c123c2f8988f8841a9d8921b5d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-06 04:39:08.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"2a9682122f7e0f284522e109098934931c06f3df","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-06 04:39:08.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/31a28da413b1428596086a65ff45857c : SUCCESS in 4m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5926e400d74d459daf6bfd0ab41baa17 : SUCCESS in 2m 43s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/99ab7d9a5d034daabaafbe522e973056 : SUCCESS in 2m 47s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/599daf1a109a44d8b724d8f18278e1ea : SUCCESS in 3m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/89c1b286936b47578ad6231c2520324b : SUCCESS in 2m 55s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/19ada83af08f4e44ab34dfe697e67119 : SUCCESS in 3m 02s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"bb41d4d6852db966f24ecf38e4750baa870a422a","revisions":{"618ea1e3e847956d0b4c922f0d1acf0628e10bb1":{"kind":"REWORK","_number":1,"created":"2019-11-05 10:41:52.000000000","uploader":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"ref":"refs/changes/74/692974/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/mistral-lib","ref":"refs/changes/74/692974/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/mistral-lib refs/changes/74/692974/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/mistral-lib refs/changes/74/692974/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/mistral-lib refs/changes/74/692974/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/mistral-lib refs/changes/74/692974/1"}}},"commit":{"parents":[{"commit":"d1bb5a197fd0f9b42f219d80ce23271b8e3c4b6d","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral-lib/commit/d1bb5a197fd0f9b42f219d80ce23271b8e3c4b6d"}]}],"author":{"name":"Cédric Jeanneret","email":"cjeanner@redhat.com","date":"2019-11-01 10:47:35.000000000","tz":60},"committer":{"name":"Dougal Matthews","email":"dougal@redhat.com","date":"2019-11-05 10:41:32.000000000","tz":0},"subject":"Ensure we mask sensitive data from Mistral Action logs","message":"Ensure we mask sensitive data from Mistral Action logs\n\nMistral didn\u0027t make use of the oslo_utils \"mask_password\" methods,\nleading in sensitive data leakage in its logs.\n\nThis patch corrects this security issue.\nNote that it depends on oslo_utils patch adding new patterns, and\nensuring it\u0027s case-insensitive.\n\nChange-Id: I544d3c172f2dea02c62c49c311c4b5954413ae15\nRelated-Bug: #1850843\nCo-Authored-By: Dougal Matthews \u003cdougal@redhat.com\u003e\nSigned-off-by: Cédric Jeanneret \u003ccjeanner@redhat.com\u003e\n(cherry picked from commit f51d2a21c0e75fe0e20990877e0615d4ace6af89)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral-lib/commit/618ea1e3e847956d0b4c922f0d1acf0628e10bb1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral-lib/commit/618ea1e3e847956d0b4c922f0d1acf0628e10bb1"}]},"branch":"refs/heads/stable/stein"},"da624d93c63428e0d98337866019d65e648fb92f":{"kind":"REWORK","_number":2,"created":"2019-11-05 11:12:46.000000000","uploader":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"ref":"refs/changes/74/692974/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/mistral-lib","ref":"refs/changes/74/692974/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/mistral-lib refs/changes/74/692974/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/mistral-lib refs/changes/74/692974/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/mistral-lib refs/changes/74/692974/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/mistral-lib refs/changes/74/692974/2"}}},"commit":{"parents":[{"commit":"d1bb5a197fd0f9b42f219d80ce23271b8e3c4b6d","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral-lib/commit/d1bb5a197fd0f9b42f219d80ce23271b8e3c4b6d"}]}],"author":{"name":"Cédric Jeanneret","email":"cjeanner@redhat.com","date":"2019-11-01 10:47:35.000000000","tz":60},"committer":{"name":"Dougal Matthews","email":"dougal@redhat.com","date":"2019-11-05 11:12:37.000000000","tz":0},"subject":"Ensure we mask sensitive data from Mistral Action logs","message":"Ensure we mask sensitive data from Mistral Action logs\n\nMistral didn\u0027t make use of the oslo_utils \"mask_password\" methods,\nleading in sensitive data leakage in its logs.\n\nThis patch corrects this security issue.\nNote that it depends on oslo_utils patch adding new patterns, and\nensuring it\u0027s case-insensitive.\n\nChange-Id: I544d3c172f2dea02c62c49c311c4b5954413ae15\nRelated-Bug: #1850843\nCo-Authored-By: Dougal Matthews \u003cdougal@redhat.com\u003e\nSigned-off-by: Cédric Jeanneret \u003ccjeanner@redhat.com\u003e\n(cherry picked from commit f51d2a21c0e75fe0e20990877e0615d4ace6af89)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral-lib/commit/da624d93c63428e0d98337866019d65e648fb92f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral-lib/commit/da624d93c63428e0d98337866019d65e648fb92f"}]},"branch":"refs/heads/stable/stein"},"bb41d4d6852db966f24ecf38e4750baa870a422a":{"kind":"REWORK","_number":3,"created":"2019-11-05 12:31:24.000000000","uploader":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"ref":"refs/changes/74/692974/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/mistral-lib","ref":"refs/changes/74/692974/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/mistral-lib refs/changes/74/692974/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/mistral-lib refs/changes/74/692974/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/mistral-lib refs/changes/74/692974/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/mistral-lib refs/changes/74/692974/3"}}},"commit":{"parents":[{"commit":"d1bb5a197fd0f9b42f219d80ce23271b8e3c4b6d","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral-lib/commit/d1bb5a197fd0f9b42f219d80ce23271b8e3c4b6d"}]}],"author":{"name":"Cédric Jeanneret","email":"cjeanner@redhat.com","date":"2019-11-01 10:47:35.000000000","tz":60},"committer":{"name":"Dougal Matthews","email":"dougal@redhat.com","date":"2019-11-05 12:31:16.000000000","tz":0},"subject":"Ensure we mask sensitive data from Mistral Action logs","message":"Ensure we mask sensitive data from Mistral Action logs\n\nMistral didn\u0027t make use of the oslo_utils \"mask_password\" methods,\nleading in sensitive data leakage in its logs.\n\nThis patch corrects this security issue.\nNote that it depends on oslo_utils patch adding new patterns, and\nensuring it\u0027s case-insensitive.\n\nChange-Id: I544d3c172f2dea02c62c49c311c4b5954413ae15\nRelated-Bug: #1850843\nCo-Authored-By: Dougal Matthews \u003cdougal@redhat.com\u003e\nSigned-off-by: Cédric Jeanneret \u003ccjeanner@redhat.com\u003e\n(cherry picked from commit f51d2a21c0e75fe0e20990877e0615d4ace6af89)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral-lib/commit/bb41d4d6852db966f24ecf38e4750baa870a422a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral-lib/commit/bb41d4d6852db966f24ecf38e4750baa870a422a"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}