)]}'
{"specs/mitaka/approved/mistral-fail-transition-message.rst":[{"author":{"_account_id":8592,"name":"Anastasia Kuznetsova","email":"akuznetsova@mirantis.com","username":"nastya-kuz"},"change_message_id":"4b5801e5a25199adf8b79af0adc56d0a3f4b0a1f","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Items filtering in Mistral"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/mistral/+spec/mistral-fail-transition-message"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a5ae5dd_e9d1b1fc","line":8,"updated":"2016-02-03 13:40:53.000000000","message":"Please, set appropriate name","commit_id":"b3382454c78f91085e425ec075b779406639a2d2"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"fa6a5b470ee3f140f330b80925b5beec684e0c5f","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Items filtering in Mistral"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/mistral/+spec/mistral-fail-transition-message"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a5ae5dd_2a5c7c4a","line":8,"in_reply_to":"5a5ae5dd_e9d1b1fc","updated":"2016-02-03 23:53:00.000000000","message":"Done","commit_id":"b3382454c78f91085e425ec075b779406639a2d2"},{"author":{"_account_id":8592,"name":"Anastasia Kuznetsova","email":"akuznetsova@mirantis.com","username":"nastya-kuz"},"change_message_id":"4b5801e5a25199adf8b79af0adc56d0a3f4b0a1f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"End user impact"},{"line_number":63,"context_line":"---------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"User can add \"when\" and \"msg\" parameters for fail/success/pause commands."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Performance Impact"},{"line_number":68,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a5ae5dd_6995c1e2","line":65,"updated":"2016-02-03 13:40:53.000000000","message":"Why do we need \"when\" statement ?","commit_id":"b3382454c78f91085e425ec075b779406639a2d2"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"fa6a5b470ee3f140f330b80925b5beec684e0c5f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"End user impact"},{"line_number":63,"context_line":"---------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"User can add \"when\" and \"msg\" parameters for fail/success/pause commands."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Performance Impact"},{"line_number":68,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a5ae5dd_859b23c9","line":65,"in_reply_to":"5a5ae5dd_6995c1e2","updated":"2016-02-03 23:53:00.000000000","message":"I think it will improve the readability.\nAlso in ansible, fail module has \"when\" and \"msg\" parameters.","commit_id":"b3382454c78f91085e425ec075b779406639a2d2"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9aed7b12d9ee71976cfd59f2ba73a3b5e5c6ae2a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"          var1: $"},{"line_number":40,"context_line":"        on-success:"},{"line_number":41,"context_line":"          - fail:"},{"line_number":42,"context_line":"              when: \u003c% $.var1 \u003d null %\u003e"},{"line_number":43,"context_line":"              msg: var1 is null."},{"line_number":44,"context_line":"          - success:"},{"line_number":45,"context_line":"              msg: var1 is not null."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a5ae5dd_827974ca","line":42,"range":{"start_line":42,"start_character":23,"end_line":42,"end_character":25},"updated":"2016-02-05 16:54:19.000000000","message":"This is not really consistent with task conditions:\n\non-success:\n   - send_success_email: \u003c% $.vm_id !\u003d null %\u003e\n\nHere we don\u0027t use \"when\" keyword. But, in fact, \"fail\", \"pause\" and \"succeed\" are used at the same flow control level, they are just special cases of tasks if you will.\n\nSo at this point I\u0027m against of \"when\" keyword. Let\u0027s think more how we can make it consistent.","commit_id":"43dc8547e1766f51b78675ffe7afae8ddadc1405"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"b8c54c64b2399fd758b8111d5f099b4c6ae9e132","unresolved":false,"context_lines":[{"line_number":39,"context_line":"          var1: $"},{"line_number":40,"context_line":"        on-success:"},{"line_number":41,"context_line":"          - fail:"},{"line_number":42,"context_line":"              when: \u003c% $.var1 \u003d null %\u003e"},{"line_number":43,"context_line":"              msg: var1 is null."},{"line_number":44,"context_line":"          - success:"},{"line_number":45,"context_line":"              msg: var1 is not null."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a5ae5dd_f3a11c47","line":42,"range":{"start_line":42,"start_character":23,"end_line":42,"end_character":25},"in_reply_to":"5a5ae5dd_827974ca","updated":"2016-02-05 18:01:56.000000000","message":"Hi Renant ,\nMy point is not breaking previous functionality.\n - send_success_email: \u003c% $.vm_id !\u003d null %\u003e will \nwork as it is.\n\nOnly if user want to use provide customize message with condition, use of \"when\" is necessary.","commit_id":"43dc8547e1766f51b78675ffe7afae8ddadc1405"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"c82f29b7c62f8420ac77cb2ad54772d718cf457d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"          var1: $"},{"line_number":40,"context_line":"        on-success:"},{"line_number":41,"context_line":"          - fail:"},{"line_number":42,"context_line":"              when: \u003c% $.var1 \u003d null %\u003e"},{"line_number":43,"context_line":"              msg: var1 is null."},{"line_number":44,"context_line":"          - success:"},{"line_number":45,"context_line":"              msg: var1 is not null."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a5ae5dd_18ca871b","line":42,"range":{"start_line":42,"start_character":23,"end_line":42,"end_character":25},"in_reply_to":"5a5ae5dd_f3a11c47","updated":"2016-02-08 18:11:06.000000000","message":"I might not have been clear enough. I didn\u0027t talk about backwards compatibility, talked about consistency. Which means that in one case we don\u0027t use \"when\" and in another similar situation we do use it. It\u0027s important that we\u0027re talking about semantically similar elements of the language.","commit_id":"43dc8547e1766f51b78675ffe7afae8ddadc1405"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9aed7b12d9ee71976cfd59f2ba73a3b5e5c6ae2a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"          - fail:"},{"line_number":42,"context_line":"              when: \u003c% $.var1 \u003d null %\u003e"},{"line_number":43,"context_line":"              msg: var1 is null."},{"line_number":44,"context_line":"          - success:"},{"line_number":45,"context_line":"              msg: var1 is not null."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a5ae5dd_0d013505","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":19},"updated":"2016-02-05 16:54:19.000000000","message":"success -\u003e succeed","commit_id":"43dc8547e1766f51b78675ffe7afae8ddadc1405"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"b8c54c64b2399fd758b8111d5f099b4c6ae9e132","unresolved":false,"context_lines":[{"line_number":41,"context_line":"          - fail:"},{"line_number":42,"context_line":"              when: \u003c% $.var1 \u003d null %\u003e"},{"line_number":43,"context_line":"              msg: var1 is null."},{"line_number":44,"context_line":"          - success:"},{"line_number":45,"context_line":"              msg: var1 is not null."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a5ae5dd_93b22893","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":19},"in_reply_to":"5a5ae5dd_0d013505","updated":"2016-02-05 18:01:56.000000000","message":"OK","commit_id":"43dc8547e1766f51b78675ffe7afae8ddadc1405"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"2ed38d1dfd4e8eda00aa130296807022f905e43e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"To solve this problem, I would like add new parameters for fail/success/pause"},{"line_number":32,"context_line":"commands. Please consider following example::"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a57f1b5_1684cb5b","line":31,"range":{"start_line":31,"start_character":35,"end_line":31,"end_character":36},"updated":"2016-02-12 17:51:56.000000000","message":"add -\u003e to add","commit_id":"ea079c466fbcd7a468c360df8ae6dafbfaeeddd7"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"2ed38d1dfd4e8eda00aa130296807022f905e43e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        publish:"},{"line_number":39,"context_line":"          var1: $"},{"line_number":40,"context_line":"        on-success:"},{"line_number":41,"context_line":"          - fail:"},{"line_number":42,"context_line":"              when: \u003c% $.var1 \u003d null %\u003e"},{"line_number":43,"context_line":"              msg: var1 is null."},{"line_number":44,"context_line":"          - succeed:"},{"line_number":45,"context_line":"              msg: var1 is not null."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a57f1b5_9f61afab","line":43,"range":{"start_line":41,"start_character":9,"end_line":43,"end_character":32},"updated":"2016-02-12 17:51:56.000000000","message":"So here\u0027s finally my proposal.\n\nI think using this form with \"when\" and \"msg\" doesn\u0027t really conflict with the short form when we just write \"fail: \u003c% ... %\u003e\". That\u0027s true. This is just to make it possible to add a message.\n\nThe only thing I\u0027m worried about is that we also have task names that we specify in  the same form \"my_task: \u003c% .. %\u003e\" which means \"run my_task next if a certain condition is met\". So we could also allow this long form for tasks like:\n\non-success:\n  - my_task:\n      when: \u003c% $.var1 \u003d null %\u003e\n      msg: have to run my_task because xyz..\n\nThe only question is: what would that message mean in this case? Task has fields like \"state_info\" and \"description\". None of them seems to be suitable to keep this msg text because state_info is related with how a task performed (e.g. an error message if it failed), not with our intentions about this task. Description is pretty much irrelevant to execution because it\u0027s mostly about task definition. So, for example, we could just write this msg to a log (which is not so useful for end users because they can read logs) or actually add it to \"description\" field.\n\nWhat do you think?","commit_id":"ea079c466fbcd7a468c360df8ae6dafbfaeeddd7"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"3102e25f833948cc49f9c5fae664e6021065a742","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        publish:"},{"line_number":39,"context_line":"          var1: $"},{"line_number":40,"context_line":"        on-success:"},{"line_number":41,"context_line":"          - fail:"},{"line_number":42,"context_line":"              when: \u003c% $.var1 \u003d null %\u003e"},{"line_number":43,"context_line":"              msg: var1 is null."},{"line_number":44,"context_line":"          - succeed:"},{"line_number":45,"context_line":"              msg: var1 is not null."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a57f1b5_e2028ab3","line":43,"range":{"start_line":41,"start_character":9,"end_line":43,"end_character":32},"in_reply_to":"3a57f1b5_9f61afab","updated":"2016-02-12 18:16:45.000000000","message":"Or, on the second thought, it could be added into \"state_info\" similar to pause/fail/succeed but, in both cases, in a format like \"cause: running this command because my network is down\". That way we would see a reason why this command or task was called. And if during the task/command execution we need to add new info to \"state_info\" we need to preserve that initial info for history.\n\nIn that regard, I am also thinking about an additional field for all execution objects to track their causes (reasons why they started). That new field should be also public (available thru API).\n\nPlease think it over and let me know your thoughts.","commit_id":"ea079c466fbcd7a468c360df8ae6dafbfaeeddd7"}]}