)]}'
{"specs/newton/approved/event-notification-trigger.rst":[{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"e58ebcbfc0eaf432fdde4b7676dc57230abb019b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/mistral/+spec/event-notification-trigger"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec adds support to run Mistral workflows in response to OpenStack"},{"line_number":14,"context_line":"notification events.  This will provide cloud operators the ability to automate"},{"line_number":15,"context_line":"their operations by running workflows in response to specific notification"},{"line_number":16,"context_line":"events emitted from within OpenStack."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_a7a4a94a","line":14,"range":{"start_line":14,"start_character":20,"end_line":14,"end_character":22},"updated":"2016-04-21 09:05:49.000000000","message":"Remove One space","commit_id":"d61dc594291be3ff93d6535e07bb09f9616c70dc"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"255c8aa52071521ad51f421a7ee4558836cd3c9f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/mistral/+spec/event-notification-trigger"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec adds support to run Mistral workflows in response to OpenStack"},{"line_number":14,"context_line":"notification events.  This will provide cloud operators the ability to automate"},{"line_number":15,"context_line":"their operations by running workflows in response to specific notification"},{"line_number":16,"context_line":"events emitted from within OpenStack."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_ebaf03e1","line":14,"range":{"start_line":14,"start_character":20,"end_line":14,"end_character":22},"in_reply_to":"1a122d0e_a7a4a94a","updated":"2016-04-25 15:08:43.000000000","message":"Done","commit_id":"d61dc594291be3ff93d6535e07bb09f9616c70dc"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"e58ebcbfc0eaf432fdde4b7676dc57230abb019b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"As things happen within OpenStack, OpenStack components can be configured to"},{"line_number":23,"context_line":"emit"},{"line_number":24,"context_line":"notification events on the messaging bus.  This includes events such as"},{"line_number":25,"context_line":"when a server instance"},{"line_number":26,"context_line":"is created or deleted or when an image is activated or deleted.  When these"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_476cb507","line":23,"updated":"2016-04-21 09:05:49.000000000","message":"new line ?","commit_id":"d61dc594291be3ff93d6535e07bb09f9616c70dc"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"255c8aa52071521ad51f421a7ee4558836cd3c9f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"As things happen within OpenStack, OpenStack components can be configured to"},{"line_number":23,"context_line":"emit"},{"line_number":24,"context_line":"notification events on the messaging bus.  This includes events such as"},{"line_number":25,"context_line":"when a server instance"},{"line_number":26,"context_line":"is created or deleted or when an image is activated or deleted.  When these"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_6be9331a","line":23,"in_reply_to":"1a122d0e_476cb507","updated":"2016-04-25 15:08:43.000000000","message":"Done","commit_id":"d61dc594291be3ff93d6535e07bb09f9616c70dc"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"e58ebcbfc0eaf432fdde4b7676dc57230abb019b","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"As things happen within OpenStack, OpenStack components can be configured to"},{"line_number":23,"context_line":"emit"},{"line_number":24,"context_line":"notification events on the messaging bus.  This includes events such as"},{"line_number":25,"context_line":"when a server instance"},{"line_number":26,"context_line":"is created or deleted or when an image is activated or deleted.  When these"},{"line_number":27,"context_line":"events occur, operators may want to perform additional functions for their"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_276ff9fc","line":24,"range":{"start_line":24,"start_character":41,"end_line":24,"end_character":43},"updated":"2016-04-21 09:05:49.000000000","message":"Remove one space","commit_id":"d61dc594291be3ff93d6535e07bb09f9616c70dc"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"255c8aa52071521ad51f421a7ee4558836cd3c9f","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"As things happen within OpenStack, OpenStack components can be configured to"},{"line_number":23,"context_line":"emit"},{"line_number":24,"context_line":"notification events on the messaging bus.  This includes events such as"},{"line_number":25,"context_line":"when a server instance"},{"line_number":26,"context_line":"is created or deleted or when an image is activated or deleted.  When these"},{"line_number":27,"context_line":"events occur, operators may want to perform additional functions for their"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_4bec3729","line":24,"range":{"start_line":24,"start_character":41,"end_line":24,"end_character":43},"in_reply_to":"1a122d0e_276ff9fc","updated":"2016-04-25 15:08:43.000000000","message":"Done","commit_id":"d61dc594291be3ff93d6535e07bb09f9616c70dc"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"e58ebcbfc0eaf432fdde4b7676dc57230abb019b","unresolved":false,"context_lines":[{"line_number":373,"context_line":"          \"scope\": \"public\","},{"line_number":374,"context_line":"          \"topic\": \"notifications\","},{"line_number":375,"context_line":"          \"use_admin_trust\": true,"},{"line_number":376,"context_line":"          \"workflow_name\": \"my-server-created-workflow\""},{"line_number":377,"context_line":"     }"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"**Response**"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_7d75fe61","line":376,"range":{"start_line":376,"start_character":10,"end_line":376,"end_character":55},"updated":"2016-04-21 09:05:49.000000000","message":"Please use workflow_id also because we can share workflows between tenants. So there is possibility that two workflow has same name.","commit_id":"d61dc594291be3ff93d6535e07bb09f9616c70dc"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"255c8aa52071521ad51f421a7ee4558836cd3c9f","unresolved":false,"context_lines":[{"line_number":373,"context_line":"          \"scope\": \"public\","},{"line_number":374,"context_line":"          \"topic\": \"notifications\","},{"line_number":375,"context_line":"          \"use_admin_trust\": true,"},{"line_number":376,"context_line":"          \"workflow_name\": \"my-server-created-workflow\""},{"line_number":377,"context_line":"     }"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"**Response**"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_cb468720","line":376,"range":{"start_line":376,"start_character":10,"end_line":376,"end_character":55},"in_reply_to":"1a122d0e_7d75fe61","updated":"2016-04-25 15:08:43.000000000","message":"Done","commit_id":"d61dc594291be3ff93d6535e07bb09f9616c70dc"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"e58ebcbfc0eaf432fdde4b7676dc57230abb019b","unresolved":false,"context_lines":[{"line_number":588,"context_line":""},{"line_number":589,"context_line":"References"},{"line_number":590,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"Please add any useful references here. You are not required to have any"},{"line_number":593,"context_line":"reference. Moreover, this specification should still make sense when your"},{"line_number":594,"context_line":"references are unavailable. Examples of what you could include are:"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"* Links to mailing list or IRC discussions"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"* Links to notes from a summit session"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"* Links to relevant research, if appropriate"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"* Anything else you feel it is worthwhile to refer to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_2714194b","line":602,"range":{"start_line":591,"start_character":0,"end_line":602,"end_character":53},"updated":"2016-04-21 09:05:49.000000000","message":"Please add references here.","commit_id":"d61dc594291be3ff93d6535e07bb09f9616c70dc"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"255c8aa52071521ad51f421a7ee4558836cd3c9f","unresolved":false,"context_lines":[{"line_number":588,"context_line":""},{"line_number":589,"context_line":"References"},{"line_number":590,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"Please add any useful references here. You are not required to have any"},{"line_number":593,"context_line":"reference. Moreover, this specification should still make sense when your"},{"line_number":594,"context_line":"references are unavailable. Examples of what you could include are:"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"* Links to mailing list or IRC discussions"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"* Links to notes from a summit session"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"* Links to relevant research, if appropriate"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"* Anything else you feel it is worthwhile to refer to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_0b451fb2","line":602,"range":{"start_line":591,"start_character":0,"end_line":602,"end_character":53},"in_reply_to":"1a122d0e_2714194b","updated":"2016-04-25 15:08:43.000000000","message":"Done","commit_id":"d61dc594291be3ff93d6535e07bb09f9616c70dc"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b5aa9aa0dab6f7b04775c9a9e808fa2fa6bb6684","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  * Either the workflow name or workflow id.  These workflows must have the"},{"line_number":83,"context_line":"    following input parameters::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"      input:"},{"line_number":86,"context_line":"          - notification_event_type"},{"line_number":87,"context_line":"          - payload"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"This information (among other things) is stored in the new event_triggers_v2"},{"line_number":90,"context_line":"table.  See the database section for more information."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_12040b48","line":87,"range":{"start_line":85,"start_character":6,"end_line":87,"end_character":19},"updated":"2016-04-27 18:49:05.000000000","message":"I wonder can we actually make it less restrictive and allow to provide any input like we do with cron triggers where we just explicitly specify workflow input and meta parameters (\"params\" which contain things like \"task_name\" for reverse workflow and \"env\" that carries environment variables)?\n\nAt the same time, I recognize that that information about event should also be available in some form.\n\nI\u0027m bringing this up because one of the use cases I may be interested in is something like this: I already have a bunch of workflows that were not designed to take parameters \"notification_event_type\" and \"payload\" but I still want to run some of them on particular events\u0027 occurrence. They may not actually require any specific information related to an event if they are designed generically (do some major clean, reporting etc.)\n\nAny ideas on how we can achieve that?","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"ae37f27680cc81e9d70b75f4f08a8a69ed5d21f4","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  * Either the workflow name or workflow id.  These workflows must have the"},{"line_number":83,"context_line":"    following input parameters::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"      input:"},{"line_number":86,"context_line":"          - notification_event_type"},{"line_number":87,"context_line":"          - payload"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"This information (among other things) is stored in the new event_triggers_v2"},{"line_number":90,"context_line":"table.  See the database section for more information."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_8bd4e1bd","line":87,"range":{"start_line":85,"start_character":6,"end_line":87,"end_character":19},"in_reply_to":"1a122d0e_12040b48","updated":"2016-05-03 14:30:53.000000000","message":"We discussed this as well, and i think that makes a lot of sense.  We\u0027ll remove the requirement for these input params and we\u0027ll add the message event type and the message payload to the workflow params.  The workflow can then retrieve that information from the params if they need it.  In addition, we\u0027ll update the event trigger table to include the workflow input and params specified by the user.  This will be same as what is done in cron triggers..  I\u0027ll update the spec with this change.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"65940baa919db35c29b8411735df224110947210","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  * Either the workflow name or workflow id.  These workflows must have the"},{"line_number":83,"context_line":"    following input parameters::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"      input:"},{"line_number":86,"context_line":"          - notification_event_type"},{"line_number":87,"context_line":"          - payload"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"This information (among other things) is stored in the new event_triggers_v2"},{"line_number":90,"context_line":"table.  See the database section for more information."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_bf46fb78","line":87,"range":{"start_line":85,"start_character":6,"end_line":87,"end_character":19},"in_reply_to":"1a122d0e_8bd4e1bd","updated":"2016-05-04 10:09:41.000000000","message":"Ok.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b5aa9aa0dab6f7b04775c9a9e808fa2fa6bb6684","unresolved":false,"context_lines":[{"line_number":93,"context_line":"openstack) to manage the event"},{"line_number":94,"context_line":"triggers, such as list, update, and delete."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"A new Mistral service will be created that will listen on the provided"},{"line_number":97,"context_line":"notification exchanges and topics, and in response to receiving the events,"},{"line_number":98,"context_line":"will run the configured Mistral workflows.  See the Detailed Changes section"},{"line_number":99,"context_line":"for details."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"The horizon plugin will be updated to manage event triggers."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_b246f778","line":98,"range":{"start_line":96,"start_character":0,"end_line":98,"end_character":41},"updated":"2016-04-27 18:49:05.000000000","message":"Yeah, here is where we need to think how to design this new service in a general enough way so that we could reuse it, for example, here: https://blueprints.launchpad.net/mistral/+spec/mistral-resource-waiting-actions\n\nParticularly, I think it shouldn\u0027t be something that can only trigger workflows.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"65940baa919db35c29b8411735df224110947210","unresolved":false,"context_lines":[{"line_number":93,"context_line":"openstack) to manage the event"},{"line_number":94,"context_line":"triggers, such as list, update, and delete."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"A new Mistral service will be created that will listen on the provided"},{"line_number":97,"context_line":"notification exchanges and topics, and in response to receiving the events,"},{"line_number":98,"context_line":"will run the configured Mistral workflows.  See the Detailed Changes section"},{"line_number":99,"context_line":"for details."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"The horizon plugin will be updated to manage event triggers."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_5f2fe7a0","line":98,"range":{"start_line":96,"start_character":0,"end_line":98,"end_character":41},"in_reply_to":"1a122d0e_665c1cf1","updated":"2016-05-04 10:09:41.000000000","message":"Ok","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"ae37f27680cc81e9d70b75f4f08a8a69ed5d21f4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"openstack) to manage the event"},{"line_number":94,"context_line":"triggers, such as list, update, and delete."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"A new Mistral service will be created that will listen on the provided"},{"line_number":97,"context_line":"notification exchanges and topics, and in response to receiving the events,"},{"line_number":98,"context_line":"will run the configured Mistral workflows.  See the Detailed Changes section"},{"line_number":99,"context_line":"for details."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"The horizon plugin will be updated to manage event triggers."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_665c1cf1","line":98,"range":{"start_line":96,"start_character":0,"end_line":98,"end_character":41},"in_reply_to":"1a122d0e_b246f778","updated":"2016-05-03 14:30:53.000000000","message":"I think our current implementation should be able to be extended quite simply to handle these other event handlers.  Right now there is a single class that handles the notification events, this could be extended to do other things when an event is received.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b5aa9aa0dab6f7b04775c9a9e808fa2fa6bb6684","unresolved":false,"context_lines":[{"line_number":118,"context_line":"  * Workflows specified as event triggers must have the following input"},{"line_number":119,"context_line":"    parameters::"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"      input:"},{"line_number":122,"context_line":"          - notification_event_type"},{"line_number":123,"context_line":"          - payload"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"   If the specified workflow does not contain these input parameters an error"},{"line_number":126,"context_line":"   is returned."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_92193b8b","line":123,"range":{"start_line":121,"start_character":6,"end_line":123,"end_character":19},"updated":"2016-04-27 18:49:05.000000000","message":"Same note as above.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"ae37f27680cc81e9d70b75f4f08a8a69ed5d21f4","unresolved":false,"context_lines":[{"line_number":118,"context_line":"  * Workflows specified as event triggers must have the following input"},{"line_number":119,"context_line":"    parameters::"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"      input:"},{"line_number":122,"context_line":"          - notification_event_type"},{"line_number":123,"context_line":"          - payload"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"   If the specified workflow does not contain these input parameters an error"},{"line_number":126,"context_line":"   is returned."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_865b38f6","line":123,"range":{"start_line":121,"start_character":6,"end_line":123,"end_character":19},"in_reply_to":"1a122d0e_92193b8b","updated":"2016-05-03 14:30:53.000000000","message":"Done","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b5aa9aa0dab6f7b04775c9a9e808fa2fa6bb6684","unresolved":false,"context_lines":[{"line_number":134,"context_line":"* Add a new service which does the following:"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  * Reads the database table to get a list of the events to listen for"},{"line_number":137,"context_line":"    and their workflow mappings."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  * Starts an event listener on a thread to handle configured notification"},{"line_number":140,"context_line":"    events from the database.  The event listener does the following:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_5204c316","line":137,"range":{"start_line":137,"start_character":14,"end_line":137,"end_character":31},"updated":"2016-04-27 18:49:05.000000000","message":"Again, I think we can make it more generic (and hence more reusable) in the first place.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"ae37f27680cc81e9d70b75f4f08a8a69ed5d21f4","unresolved":false,"context_lines":[{"line_number":134,"context_line":"* Add a new service which does the following:"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  * Reads the database table to get a list of the events to listen for"},{"line_number":137,"context_line":"    and their workflow mappings."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  * Starts an event listener on a thread to handle configured notification"},{"line_number":140,"context_line":"    events from the database.  The event listener does the following:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_66db7c22","line":137,"range":{"start_line":137,"start_character":14,"end_line":137,"end_character":31},"in_reply_to":"1a122d0e_5204c316","updated":"2016-05-03 14:30:53.000000000","message":"I\u0027m not exactly sure what you mean. Do you have specific idea in mind?  Seems like for the purpose of event triggers this would be the correct approach.  If a notification event does something otherthan starting a workflow wouldn\u0027t that be something mistral would have to code in the notification event handler? It seems like anything a customer would want to do could be done in a workflow.  Just like cron triggers. \n\n I could see for example that Mistral could have a task action that would wait for something to  complete ( for example, a workflow that creates a server instance and then wants to wait for it to complete).  Are you thinking that this wait for task action would add something to this table?  I guess i was thinking for that resource waiting blueprint that the notification event handler would look for tasks that were in notification wait state and then resume them.  Please clarify.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"65940baa919db35c29b8411735df224110947210","unresolved":false,"context_lines":[{"line_number":134,"context_line":"* Add a new service which does the following:"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  * Reads the database table to get a list of the events to listen for"},{"line_number":137,"context_line":"    and their workflow mappings."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  * Starts an event listener on a thread to handle configured notification"},{"line_number":140,"context_line":"    events from the database.  The event listener does the following:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_c2116006","line":137,"range":{"start_line":137,"start_character":14,"end_line":137,"end_character":31},"in_reply_to":"1a122d0e_66db7c22","updated":"2016-05-04 10:09:41.000000000","message":"Yeah, that\u0027s fine. I think I just got lost in all those architectural layers when I was reading it. Of course, when we\u0027re talking about triggering workflows we should be able to specify mappings in DB. I just want to make that listening underlying component reusable (not only for triggering workflows) but that\u0027s a little bit different layer.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b5aa9aa0dab6f7b04775c9a9e808fa2fa6bb6684","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    * Listens for notifications on the exchange and topic as specified in"},{"line_number":143,"context_line":"      the database."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    * Determines which workflow to start based on the message event type and"},{"line_number":146,"context_line":"      the project in the notification.  The query will be as follows:"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"      `select workflow_name, workflow_id where event\u003dmessage.event_type and"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_ff87815e","line":145,"range":{"start_line":145,"start_character":6,"end_line":145,"end_character":40},"updated":"2016-04-27 18:49:05.000000000","message":"Same note.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"65940baa919db35c29b8411735df224110947210","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    * Listens for notifications on the exchange and topic as specified in"},{"line_number":143,"context_line":"      the database."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    * Determines which workflow to start based on the message event type and"},{"line_number":146,"context_line":"      the project in the notification.  The query will be as follows:"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"      `select workflow_name, workflow_id where event\u003dmessage.event_type and"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_c2284036","line":145,"range":{"start_line":145,"start_character":6,"end_line":145,"end_character":40},"in_reply_to":"1a122d0e_e6f66c8f","updated":"2016-05-04 10:09:41.000000000","message":"Done","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"ae37f27680cc81e9d70b75f4f08a8a69ed5d21f4","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    * Listens for notifications on the exchange and topic as specified in"},{"line_number":143,"context_line":"      the database."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    * Determines which workflow to start based on the message event type and"},{"line_number":146,"context_line":"      the project in the notification.  The query will be as follows:"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"      `select workflow_name, workflow_id where event\u003dmessage.event_type and"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_e6f66c8f","line":145,"range":{"start_line":145,"start_character":6,"end_line":145,"end_character":40},"in_reply_to":"1a122d0e_ff87815e","updated":"2016-05-03 14:30:53.000000000","message":"See previous comment.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b5aa9aa0dab6f7b04775c9a9e808fa2fa6bb6684","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"The security context of the workflow is chosen as follows::"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"  If the event trigger is configured with the admin trust id:"},{"line_number":218,"context_line":"    context \u003d admin trust token"},{"line_number":219,"context_line":"  else:"},{"line_number":220,"context_line":"    if there is a security context associated with the message:"},{"line_number":221,"context_line":"       context \u003d message notification event context"},{"line_number":222,"context_line":"    else:"},{"line_number":223,"context_line":"       context \u003d mistral service context"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_ff8dc131","line":223,"range":{"start_line":217,"start_character":2,"end_line":223,"end_character":40},"updated":"2016-04-27 18:49:05.000000000","message":"Seems like it can always be a token acquired by a trust id associated with a user who created the trigger.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b3e939db555bccc95e5a9075f20a5db19c1bf8a6","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"The security context of the workflow is chosen as follows::"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"  If the event trigger is configured with the admin trust id:"},{"line_number":218,"context_line":"    context \u003d admin trust token"},{"line_number":219,"context_line":"  else:"},{"line_number":220,"context_line":"    if there is a security context associated with the message:"},{"line_number":221,"context_line":"       context \u003d message notification event context"},{"line_number":222,"context_line":"    else:"},{"line_number":223,"context_line":"       context \u003d mistral service context"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dab17558_24099f2d","line":223,"range":{"start_line":217,"start_character":2,"end_line":223,"end_character":40},"in_reply_to":"1a122d0e_36793230","updated":"2016-05-06 05:17:47.000000000","message":"Todd, that actually sounds nice to me. That would give us enough flexibility. Accepted by me.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"6c472595bd3700fe27c73c24c1cbbf8d77669b56","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"The security context of the workflow is chosen as follows::"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"  If the event trigger is configured with the admin trust id:"},{"line_number":218,"context_line":"    context \u003d admin trust token"},{"line_number":219,"context_line":"  else:"},{"line_number":220,"context_line":"    if there is a security context associated with the message:"},{"line_number":221,"context_line":"       context \u003d message notification event context"},{"line_number":222,"context_line":"    else:"},{"line_number":223,"context_line":"       context \u003d mistral service context"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_36793230","line":223,"range":{"start_line":217,"start_character":2,"end_line":223,"end_character":40},"in_reply_to":"1a122d0e_427c30b5","updated":"2016-05-05 14:12:24.000000000","message":"Yeah, we thought about that and we were afraid that might open a security vulnerability, but the more i  think about maybe it\u0027s ok since openstack security would prevent someone who didn\u0027t have access from doing things they shouldn\u0027t.  I think it would be nice to able run these workflows as another user.  We could change the --use-admin-trust flag to something like --run-as-creator.  So instead of being limited to the admin role, it would create a trust token for the user that is creating the trigger.  The workflows would then run under that trust token. If this flag is not specified then the trust field in the database would not get set and the workflows would run as the user from the message context (if present).\n\nthoughts?","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"65940baa919db35c29b8411735df224110947210","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"The security context of the workflow is chosen as follows::"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"  If the event trigger is configured with the admin trust id:"},{"line_number":218,"context_line":"    context \u003d admin trust token"},{"line_number":219,"context_line":"  else:"},{"line_number":220,"context_line":"    if there is a security context associated with the message:"},{"line_number":221,"context_line":"       context \u003d message notification event context"},{"line_number":222,"context_line":"    else:"},{"line_number":223,"context_line":"       context \u003d mistral service context"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_427c30b5","line":223,"range":{"start_line":217,"start_character":2,"end_line":223,"end_character":40},"in_reply_to":"1a122d0e_66ec1c93","updated":"2016-05-04 10:09:41.000000000","message":"Hm.. This is interesting. I actually wasn\u0027t able to see your idea in the first place. \n\nThe use case you\u0027re describing seems valid to me, I don\u0027t want to forbid this opportunity. Maybe it should just a configuration option to inherit security context from message author so that we have a choice to decline it or not. Because, for example, I as a trigger creator may want to run some workflows so that they could do things only that I can do with my permissions. I may even want to create a special user with limited permissions and run some maintenance workflows on behalf of it to prevent any heavy damage or something like that.\n\nOr, we can even have this property in even trigger itself to configure that, don\u0027t know.\n\nWhat do you think?","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"ae37f27680cc81e9d70b75f4f08a8a69ed5d21f4","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"The security context of the workflow is chosen as follows::"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"  If the event trigger is configured with the admin trust id:"},{"line_number":218,"context_line":"    context \u003d admin trust token"},{"line_number":219,"context_line":"  else:"},{"line_number":220,"context_line":"    if there is a security context associated with the message:"},{"line_number":221,"context_line":"       context \u003d message notification event context"},{"line_number":222,"context_line":"    else:"},{"line_number":223,"context_line":"       context \u003d mistral service context"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_66ec1c93","line":223,"range":{"start_line":217,"start_character":2,"end_line":223,"end_character":40},"in_reply_to":"1a122d0e_ff8dc131","updated":"2016-05-03 14:30:53.000000000","message":"Our thought was the workflow would run under the user that generated the message if the message contains a security context.  I think what you are saying is the workflow should run as the user that created the trigger.  For example we prototyped a use case where we added expirations to server instances.  In this case an admin can just create a set of public workflows and those workflows then run as the user that created the server instance.  Do you think it would be better not to allow that and always run as the user who created the event trigger?","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"b6e1e2450d1285a203639b894db7e8d56a4e4ca4","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"The security context of the workflow is chosen as follows::"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"  If the event trigger is configured with the admin trust id:"},{"line_number":218,"context_line":"    context \u003d admin trust token"},{"line_number":219,"context_line":"  else:"},{"line_number":220,"context_line":"    if there is a security context associated with the message:"},{"line_number":221,"context_line":"       context \u003d message notification event context"},{"line_number":222,"context_line":"    else:"},{"line_number":223,"context_line":"       context \u003d mistral service context"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dab17558_ec4922d2","line":223,"range":{"start_line":217,"start_character":2,"end_line":223,"end_character":40},"in_reply_to":"dab17558_24099f2d","updated":"2016-05-06 17:14:31.000000000","message":"Done","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b5aa9aa0dab6f7b04775c9a9e808fa2fa6bb6684","unresolved":false,"context_lines":[{"line_number":252,"context_line":"+----------------------+--------------+------+-----+---------+-------+"},{"line_number":253,"context_line":"| name                 | varchar(200) | YES  |     | NULL    |       |"},{"line_number":254,"context_line":"+----------------------+--------------+------+-----+---------+-------+"},{"line_number":255,"context_line":"| workflow_name        | varchar(80)  | YES  |     | NULL    |       |"},{"line_number":256,"context_line":"+----------------------+--------------+------+-----+---------+-------+"},{"line_number":257,"context_line":"| workflow_id          | varchar(36)  | YES  |     | NULL    |       |"},{"line_number":258,"context_line":"+----------------------+--------------+------+-----+---------+-------+"},{"line_number":259,"context_line":"| exchange             | varchar(80)  | YES  | MUL | NULL    |       |"},{"line_number":260,"context_line":"+----------------------+--------------+------+-----+---------+-------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_3f9bb967","line":257,"range":{"start_line":255,"start_character":1,"end_line":257,"end_character":69},"updated":"2016-04-27 18:49:05.000000000","message":"Same note as before.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"ae37f27680cc81e9d70b75f4f08a8a69ed5d21f4","unresolved":false,"context_lines":[{"line_number":252,"context_line":"+----------------------+--------------+------+-----+---------+-------+"},{"line_number":253,"context_line":"| name                 | varchar(200) | YES  |     | NULL    |       |"},{"line_number":254,"context_line":"+----------------------+--------------+------+-----+---------+-------+"},{"line_number":255,"context_line":"| workflow_name        | varchar(80)  | YES  |     | NULL    |       |"},{"line_number":256,"context_line":"+----------------------+--------------+------+-----+---------+-------+"},{"line_number":257,"context_line":"| workflow_id          | varchar(36)  | YES  |     | NULL    |       |"},{"line_number":258,"context_line":"+----------------------+--------------+------+-----+---------+-------+"},{"line_number":259,"context_line":"| exchange             | varchar(80)  | YES  | MUL | NULL    |       |"},{"line_number":260,"context_line":"+----------------------+--------------+------+-----+---------+-------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_86eb3878","line":257,"range":{"start_line":255,"start_character":1,"end_line":257,"end_character":69},"in_reply_to":"1a122d0e_3f9bb967","updated":"2016-05-03 14:30:53.000000000","message":"See previous comment.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"65940baa919db35c29b8411735df224110947210","unresolved":false,"context_lines":[{"line_number":252,"context_line":"+----------------------+--------------+------+-----+---------+-------+"},{"line_number":253,"context_line":"| name                 | varchar(200) | YES  |     | NULL    |       |"},{"line_number":254,"context_line":"+----------------------+--------------+------+-----+---------+-------+"},{"line_number":255,"context_line":"| workflow_name        | varchar(80)  | YES  |     | NULL    |       |"},{"line_number":256,"context_line":"+----------------------+--------------+------+-----+---------+-------+"},{"line_number":257,"context_line":"| workflow_id          | varchar(36)  | YES  |     | NULL    |       |"},{"line_number":258,"context_line":"+----------------------+--------------+------+-----+---------+-------+"},{"line_number":259,"context_line":"| exchange             | varchar(80)  | YES  | MUL | NULL    |       |"},{"line_number":260,"context_line":"+----------------------+--------------+------+-----+---------+-------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_c246807a","line":257,"range":{"start_line":255,"start_character":1,"end_line":257,"end_character":69},"in_reply_to":"1a122d0e_86eb3878","updated":"2016-05-04 10:09:41.000000000","message":"Done","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b5aa9aa0dab6f7b04775c9a9e808fa2fa6bb6684","unresolved":false,"context_lines":[{"line_number":378,"context_line":"          \"name\": \"my-create-server-trigger\","},{"line_number":379,"context_line":"          \"scope\": \"public\","},{"line_number":380,"context_line":"          \"topic\": \"notifications\","},{"line_number":381,"context_line":"          \"use_admin_trust\": true,"},{"line_number":382,"context_line":"          \"workflow_id\": \"123f4567-e89b-12d3-a456-426655440000\""},{"line_number":383,"context_line":"     }"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_1f135db9","line":381,"range":{"start_line":381,"start_character":11,"end_line":381,"end_character":26},"updated":"2016-04-27 18:49:05.000000000","message":"I think we shouldn\u0027t have this option as an arbitrary user can\u0027t decide whether Mistral should act on behalf of and admin or not. Only Mistral itself can decide to use admin access for certain operations if it\u0027s needed for some functionality.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"ae37f27680cc81e9d70b75f4f08a8a69ed5d21f4","unresolved":false,"context_lines":[{"line_number":378,"context_line":"          \"name\": \"my-create-server-trigger\","},{"line_number":379,"context_line":"          \"scope\": \"public\","},{"line_number":380,"context_line":"          \"topic\": \"notifications\","},{"line_number":381,"context_line":"          \"use_admin_trust\": true,"},{"line_number":382,"context_line":"          \"workflow_id\": \"123f4567-e89b-12d3-a456-426655440000\""},{"line_number":383,"context_line":"     }"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_6661bc11","line":381,"range":{"start_line":381,"start_character":11,"end_line":381,"end_character":26},"in_reply_to":"1a122d0e_1f135db9","updated":"2016-05-03 14:30:53.000000000","message":"I\u0027m not sure i completely understand.  I\u0027m not sure how Mistral knows if a customer created workflow should run as an admin or not.  This flag was intended to allow an admin to decide if they want the workflows to run on behalf of themselves or if the workflows should run as the user who triggered the notification in the first place (the security context of the notification). Perhaps this goes back to the previous comment about whether or not the event notification context should be used at all.  Please clarify.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"6c472595bd3700fe27c73c24c1cbbf8d77669b56","unresolved":false,"context_lines":[{"line_number":378,"context_line":"          \"name\": \"my-create-server-trigger\","},{"line_number":379,"context_line":"          \"scope\": \"public\","},{"line_number":380,"context_line":"          \"topic\": \"notifications\","},{"line_number":381,"context_line":"          \"use_admin_trust\": true,"},{"line_number":382,"context_line":"          \"workflow_id\": \"123f4567-e89b-12d3-a456-426655440000\""},{"line_number":383,"context_line":"     }"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_96d766ed","line":381,"range":{"start_line":381,"start_character":11,"end_line":381,"end_character":26},"in_reply_to":"1a122d0e_455d5a14","updated":"2016-05-05 14:12:24.000000000","message":"Currently if the user running the request is not in the admin role this flag is ignored.  See previous comment about changing this flag to be usable from any user.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"65940baa919db35c29b8411735df224110947210","unresolved":false,"context_lines":[{"line_number":378,"context_line":"          \"name\": \"my-create-server-trigger\","},{"line_number":379,"context_line":"          \"scope\": \"public\","},{"line_number":380,"context_line":"          \"topic\": \"notifications\","},{"line_number":381,"context_line":"          \"use_admin_trust\": true,"},{"line_number":382,"context_line":"          \"workflow_id\": \"123f4567-e89b-12d3-a456-426655440000\""},{"line_number":383,"context_line":"     }"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_455d5a14","line":381,"range":{"start_line":381,"start_character":11,"end_line":381,"end_character":26},"in_reply_to":"1a122d0e_6661bc11","updated":"2016-05-04 10:09:41.000000000","message":"Ok, most likely I didn\u0027t understand the meaning of this flag then. I now see what you\u0027re saying. I just don\u0027t understand how Mistral should behave if, for example, I\u0027m not an admin but I set this flag to true. Would Mistral try to create a trust on behalf of an admin anyway? I guess it\u0027s not what we expect. Do we need to just ignore this flag in this case?","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b3e939db555bccc95e5a9075f20a5db19c1bf8a6","unresolved":false,"context_lines":[{"line_number":378,"context_line":"          \"name\": \"my-create-server-trigger\","},{"line_number":379,"context_line":"          \"scope\": \"public\","},{"line_number":380,"context_line":"          \"topic\": \"notifications\","},{"line_number":381,"context_line":"          \"use_admin_trust\": true,"},{"line_number":382,"context_line":"          \"workflow_id\": \"123f4567-e89b-12d3-a456-426655440000\""},{"line_number":383,"context_line":"     }"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dab17558_4410234f","line":381,"range":{"start_line":381,"start_character":11,"end_line":381,"end_character":26},"in_reply_to":"1a122d0e_96d766ed","updated":"2016-05-06 05:17:47.000000000","message":"Done","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b5aa9aa0dab6f7b04775c9a9e808fa2fa6bb6684","unresolved":false,"context_lines":[{"line_number":482,"context_line":"       -h, --help            show this help message and exit"},{"line_number":483,"context_line":"       --public              With this flag the event trigger will be marked as"},{"line_number":484,"context_line":"                             \"public\"."},{"line_number":485,"context_line":"       --use-admin-trust     With this flag the event trigger will use an admin"},{"line_number":486,"context_line":"                             trust ID."},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"* mistral event-trigger-list::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_1f619d39","line":485,"range":{"start_line":485,"start_character":7,"end_line":485,"end_character":24},"updated":"2016-04-27 18:49:05.000000000","message":"Same","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"ae37f27680cc81e9d70b75f4f08a8a69ed5d21f4","unresolved":false,"context_lines":[{"line_number":482,"context_line":"       -h, --help            show this help message and exit"},{"line_number":483,"context_line":"       --public              With this flag the event trigger will be marked as"},{"line_number":484,"context_line":"                             \"public\"."},{"line_number":485,"context_line":"       --use-admin-trust     With this flag the event trigger will use an admin"},{"line_number":486,"context_line":"                             trust ID."},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"* mistral event-trigger-list::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_662ffca7","line":485,"range":{"start_line":485,"start_character":7,"end_line":485,"end_character":24},"in_reply_to":"1a122d0e_1f619d39","updated":"2016-05-03 14:30:53.000000000","message":"See previous comment.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"65940baa919db35c29b8411735df224110947210","unresolved":false,"context_lines":[{"line_number":482,"context_line":"       -h, --help            show this help message and exit"},{"line_number":483,"context_line":"       --public              With this flag the event trigger will be marked as"},{"line_number":484,"context_line":"                             \"public\"."},{"line_number":485,"context_line":"       --use-admin-trust     With this flag the event trigger will use an admin"},{"line_number":486,"context_line":"                             trust ID."},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"* mistral event-trigger-list::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_25af7ee4","line":485,"range":{"start_line":485,"start_character":7,"end_line":485,"end_character":24},"in_reply_to":"1a122d0e_662ffca7","updated":"2016-05-04 10:09:41.000000000","message":"Done","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b5aa9aa0dab6f7b04775c9a9e808fa2fa6bb6684","unresolved":false,"context_lines":[{"line_number":510,"context_line":"      -h, --help            show this help message and exit"},{"line_number":511,"context_line":"      --public              With this flag the event trigger will be marked as"},{"line_number":512,"context_line":"                           \"public\"."},{"line_number":513,"context_line":"      --use-admin-trust     With this flag the event trigger will use an admin"},{"line_number":514,"context_line":"                           trust ID."},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"Also, update the openstack client (see mistral client above for details on"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_5f579559","line":513,"range":{"start_line":513,"start_character":6,"end_line":513,"end_character":23},"updated":"2016-04-27 18:49:05.000000000","message":"same","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"65940baa919db35c29b8411735df224110947210","unresolved":false,"context_lines":[{"line_number":510,"context_line":"      -h, --help            show this help message and exit"},{"line_number":511,"context_line":"      --public              With this flag the event trigger will be marked as"},{"line_number":512,"context_line":"                           \"public\"."},{"line_number":513,"context_line":"      --use-admin-trust     With this flag the event trigger will use an admin"},{"line_number":514,"context_line":"                           trust ID."},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"Also, update the openstack client (see mistral client above for details on"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_05aa42d2","line":513,"range":{"start_line":513,"start_character":6,"end_line":513,"end_character":23},"in_reply_to":"1a122d0e_5f579559","updated":"2016-05-04 10:09:41.000000000","message":"Done","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"ae37f27680cc81e9d70b75f4f08a8a69ed5d21f4","unresolved":false,"context_lines":[{"line_number":510,"context_line":"      -h, --help            show this help message and exit"},{"line_number":511,"context_line":"      --public              With this flag the event trigger will be marked as"},{"line_number":512,"context_line":"                           \"public\"."},{"line_number":513,"context_line":"      --use-admin-trust     With this flag the event trigger will use an admin"},{"line_number":514,"context_line":"                           trust ID."},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"Also, update the openstack client (see mistral client above for details on"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_463480fa","line":513,"range":{"start_line":513,"start_character":6,"end_line":513,"end_character":23},"in_reply_to":"1a122d0e_5f579559","updated":"2016-05-03 14:30:53.000000000","message":"See previous comment.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b5aa9aa0dab6f7b04775c9a9e808fa2fa6bb6684","unresolved":false,"context_lines":[{"line_number":578,"context_line":"Dependencies"},{"line_number":579,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"This support will add a dependency on oslo.messaging."},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"Testing"},{"line_number":584,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_bfdfc9d4","line":581,"range":{"start_line":581,"start_character":0,"end_line":581,"end_character":52},"updated":"2016-04-27 18:49:05.000000000","message":"Mistral already depends on it.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"ae37f27680cc81e9d70b75f4f08a8a69ed5d21f4","unresolved":false,"context_lines":[{"line_number":578,"context_line":"Dependencies"},{"line_number":579,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"This support will add a dependency on oslo.messaging."},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"Testing"},{"line_number":584,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_c62090b3","line":581,"range":{"start_line":581,"start_character":0,"end_line":581,"end_character":52},"in_reply_to":"1a122d0e_bfdfc9d4","updated":"2016-05-03 14:30:53.000000000","message":"Cool. I\u0027ll remove this from the spec.","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"65940baa919db35c29b8411735df224110947210","unresolved":false,"context_lines":[{"line_number":578,"context_line":"Dependencies"},{"line_number":579,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"This support will add a dependency on oslo.messaging."},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"Testing"},{"line_number":584,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_65b9762e","line":581,"range":{"start_line":581,"start_character":0,"end_line":581,"end_character":52},"in_reply_to":"1a122d0e_c62090b3","updated":"2016-05-04 10:09:41.000000000","message":"Done","commit_id":"ea54cdb56a93c0c0fb5e60d6ab9bbad60c670a98"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"8c994137b060c7a82351d9dc14fb34922e748d6d","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/mistral/+spec/event-notification-trigger"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec adds support to run Mistral workflows in response to AMPQ events."},{"line_number":14,"context_line":"This will provide cloud operators the ability to automate"},{"line_number":15,"context_line":"their operations by running workflows in response to specific notification"},{"line_number":16,"context_line":"events posted on an AMPQ topic, including those emitted by OpenStack"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_08643420","line":13,"range":{"start_line":13,"start_character":63,"end_line":13,"end_character":67},"updated":"2016-05-19 09:03:29.000000000","message":"Please consider adding what are AMPQ events.\nMaybe a link to the examples/implementation you had in mind?","commit_id":"5add15f2bf6f60e119e8b0550d1fb739921fd354"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"250b0f050e52ed713aad077c8a0e159ea3e0f179","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/mistral/+spec/event-notification-trigger"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec adds support to run Mistral workflows in response to AMPQ events."},{"line_number":14,"context_line":"This will provide cloud operators the ability to automate"},{"line_number":15,"context_line":"their operations by running workflows in response to specific notification"},{"line_number":16,"context_line":"events posted on an AMPQ topic, including those emitted by OpenStack"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_fc231256","line":13,"range":{"start_line":13,"start_character":63,"end_line":13,"end_character":67},"in_reply_to":"bab6814e_08643420","updated":"2016-05-20 17:43:07.000000000","message":"I noticed that i misspelled AMQP, so corrected that and added a link to the OpenStack notifications.  Is that what you had in mind?","commit_id":"5add15f2bf6f60e119e8b0550d1fb739921fd354"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b976b3a3d14a02aaf3d71240bef40ea3259ce528","unresolved":false,"context_lines":[{"line_number":148,"context_line":"      allows the workflow to retreive the event type and message payload as"},{"line_number":149,"context_line":"      follows::"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        event_type: \u003c% execution().params.notification_event_type %\u003e"},{"line_number":152,"context_line":"        payload: \u003c% execution().params.notification_payload %\u003e"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"      See security context section below for more information on which"},{"line_number":155,"context_line":"      security context is used."}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_46d559b7","line":152,"range":{"start_line":151,"start_character":8,"end_line":152,"end_character":62},"updated":"2016-05-10 04:27:12.000000000","message":"Nice, it should do the trick.","commit_id":"5add15f2bf6f60e119e8b0550d1fb739921fd354"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"28dfcbcf4567440084575cb191354a26b7fb1465","unresolved":false,"context_lines":[{"line_number":148,"context_line":"      allows the workflow to retreive the event type and message payload as"},{"line_number":149,"context_line":"      follows::"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        event_type: \u003c% execution().params.notification_event_type %\u003e"},{"line_number":152,"context_line":"        payload: \u003c% execution().params.notification_payload %\u003e"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"      See security context section below for more information on which"},{"line_number":155,"context_line":"      security context is used."}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_eee4f13c","line":152,"range":{"start_line":151,"start_character":8,"end_line":152,"end_character":62},"in_reply_to":"dab17558_46d559b7","updated":"2016-05-16 20:07:18.000000000","message":"Done","commit_id":"5add15f2bf6f60e119e8b0550d1fb739921fd354"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"8c994137b060c7a82351d9dc14fb34922e748d6d","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"* The Mistral service context."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"The security context of the workflow is chosen as follows::"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"  If the event trigger is configured with the trust id:"},{"line_number":215,"context_line":"    context \u003d trust token"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_94e839e4","line":212,"updated":"2016-05-19 09:03:29.000000000","message":"It seems that there should be more constrictions to what is described here.\n\nWhat stops a user from spying after another user?\nI would like to read the full logic, where do you check that the event notification trigger creator is allowed to read the message?","commit_id":"5add15f2bf6f60e119e8b0550d1fb739921fd354"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"210a685f0ab7b1db94207de33621deadfcb1a448","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"* The Mistral service context."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"The security context of the workflow is chosen as follows::"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"  If the event trigger is configured with the trust id:"},{"line_number":215,"context_line":"    context \u003d trust token"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aa08908_63f7f9f5","line":212,"in_reply_to":"bab6814e_1c3ed627","updated":"2016-06-09 23:13:58.000000000","message":"I want to be extremely clear about this, so at the risk of appearing blunt:\n\nThe design as it stands is *completely unacceptable* from a security perspective *unless* the API is locked down to admins only in policy.json.\n\nIf Mistral isn\u0027t using a policy.json file already then adding that feature should be listed under \"Dependencies\" below because you absolutely cannot ship without it.","commit_id":"5add15f2bf6f60e119e8b0550d1fb739921fd354"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"250b0f050e52ed713aad077c8a0e159ea3e0f179","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"* The Mistral service context."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"The security context of the workflow is chosen as follows::"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"  If the event trigger is configured with the trust id:"},{"line_number":215,"context_line":"    context \u003d trust token"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_1c3ed627","line":212,"in_reply_to":"bab6814e_94e839e4","updated":"2016-05-20 17:43:07.000000000","message":"I\u0027m not sure there\u0027s much we can do. In a lot of cases the notification message does not contain a security context so it\u0027s not possible to know who generated the notification.  While a user spying can get some information, it would be assumed the underlying security would prevent that user from doing anything with that information.  What i think is really needed here is the ability for a policy file to prevent any user from creating event triggers in the first place. Perhaps just making it an admin function or to be able to use the policy file to allow users access to monitor only certain notifications.  Although I\u0027m not aware of mistral having a policy file to protect its APIs similar to other openstack projects.  Thoughts?","commit_id":"5add15f2bf6f60e119e8b0550d1fb739921fd354"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"9c5218537bf8a83ccb73703e2c0f504ee38ee6fc","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Alternatives"},{"line_number":224,"context_line":"------------"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"* Use JSON file to map events to workflows rather than using the database."},{"line_number":227,"context_line":"  This idea is being discarded"},{"line_number":228,"context_line":"  because it doesn\u0027t really scale very well and the file is harder to manage."}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_67a17646","line":225,"updated":"2016-05-15 22:55:38.000000000","message":"The ceilometer way should be an alternative.","commit_id":"5add15f2bf6f60e119e8b0550d1fb739921fd354"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"28dfcbcf4567440084575cb191354a26b7fb1465","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Alternatives"},{"line_number":224,"context_line":"------------"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"* Use JSON file to map events to workflows rather than using the database."},{"line_number":227,"context_line":"  This idea is being discarded"},{"line_number":228,"context_line":"  because it doesn\u0027t really scale very well and the file is harder to manage."}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_6e792182","line":225,"in_reply_to":"dab17558_67a17646","updated":"2016-05-16 20:07:18.000000000","message":"Done","commit_id":"5add15f2bf6f60e119e8b0550d1fb739921fd354"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"8c994137b060c7a82351d9dc14fb34922e748d6d","unresolved":false,"context_lines":[{"line_number":241,"context_line":"+----------------------+--------------+------+-----+---------+-------+"},{"line_number":242,"context_line":"| updated_at           | datetime     | YES  |     | NULL    |       |"},{"line_number":243,"context_line":"+----------------------+--------------+------+-----+---------+-------+"},{"line_number":244,"context_line":"| scope                | varchar(80)  | YES  | MUL | NULL    |       |"},{"line_number":245,"context_line":"+----------------------+--------------+------+-----+---------+-------+"},{"line_number":246,"context_line":"| project_id           | varchar(80)  | YES  | MUL | NULL    |       |"},{"line_number":247,"context_line":"+----------------------+--------------+------+-----+---------+-------+"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_f4bf055e","line":244,"range":{"start_line":244,"start_character":2,"end_line":244,"end_character":7},"updated":"2016-05-19 09:03:29.000000000","message":"Do you have use-case example for public and private scopes?","commit_id":"5add15f2bf6f60e119e8b0550d1fb739921fd354"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"250b0f050e52ed713aad077c8a0e159ea3e0f179","unresolved":false,"context_lines":[{"line_number":241,"context_line":"+----------------------+--------------+------+-----+---------+-------+"},{"line_number":242,"context_line":"| updated_at           | datetime     | YES  |     | NULL    |       |"},{"line_number":243,"context_line":"+----------------------+--------------+------+-----+---------+-------+"},{"line_number":244,"context_line":"| scope                | varchar(80)  | YES  | MUL | NULL    |       |"},{"line_number":245,"context_line":"+----------------------+--------------+------+-----+---------+-------+"},{"line_number":246,"context_line":"| project_id           | varchar(80)  | YES  | MUL | NULL    |       |"},{"line_number":247,"context_line":"+----------------------+--------------+------+-----+---------+-------+"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_97b73f39","line":244,"range":{"start_line":244,"start_character":2,"end_line":244,"end_character":7},"in_reply_to":"bab6814e_f4bf055e","updated":"2016-05-20 17:43:07.000000000","message":"The use case we\u0027ve been using is that of expiration policies on server instances.  An operator may decide that servers created in certain projects don\u0027t expire.  In that case instead of maintaining a list of those projects in a public workflow, the operator can create a private workflow in that project and use a private event trigger to run it when server instances are created in that project.  The next patch set of the spec will include a link to our openstack presentation that will show server expirations.","commit_id":"5add15f2bf6f60e119e8b0550d1fb739921fd354"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"9c5218537bf8a83ccb73703e2c0f504ee38ee6fc","unresolved":false,"context_lines":[{"line_number":543,"context_line":""},{"line_number":544,"context_line":"Deployer impact"},{"line_number":545,"context_line":"---------------"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"There should be no impacts to the deployer.  This new function is enabled"},{"line_number":548,"context_line":"automatically, however, nothing will run until someone adds an event trigger"},{"line_number":549,"context_line":"to the table via the REST API or the CLI.  This is similar to the cron"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_279bee19","line":546,"updated":"2016-05-15 22:55:38.000000000","message":"Isn\u0027t the new service running in a process? If so, it is exactly the new thing should be under deployer\u0027s management, and should be mentioned. If not, how can I disable it if I don\u0027t want to run such a service?","commit_id":"5add15f2bf6f60e119e8b0550d1fb739921fd354"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"71288a0d2b08cafcdac3e2d4b2bb4ded5eb191a7","unresolved":false,"context_lines":[{"line_number":543,"context_line":""},{"line_number":544,"context_line":"Deployer impact"},{"line_number":545,"context_line":"---------------"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"There should be no impacts to the deployer.  This new function is enabled"},{"line_number":548,"context_line":"automatically, however, nothing will run until someone adds an event trigger"},{"line_number":549,"context_line":"to the table via the REST API or the CLI.  This is similar to the cron"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_4d553ac0","line":546,"in_reply_to":"dab17558_0eefb51e","updated":"2016-05-16 22:45:39.000000000","message":"I was asking because I can see one use case from my own perspective. If Ceilometer is already there installed in the deployment which can be leveraged as event listener, and suppose webhook has been implemented in Mistral integrating with Ceilometer, as an operator, how can I disable the \u0027event-trigger\u0027 built in in Mistral, to use the Ceilometer way instead?\n\nI am just thinking of making the builtin event listener in mistral to be optional.","commit_id":"5add15f2bf6f60e119e8b0550d1fb739921fd354"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"28dfcbcf4567440084575cb191354a26b7fb1465","unresolved":false,"context_lines":[{"line_number":543,"context_line":""},{"line_number":544,"context_line":"Deployer impact"},{"line_number":545,"context_line":"---------------"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"There should be no impacts to the deployer.  This new function is enabled"},{"line_number":548,"context_line":"automatically, however, nothing will run until someone adds an event trigger"},{"line_number":549,"context_line":"to the table via the REST API or the CLI.  This is similar to the cron"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_0eefb51e","line":546,"in_reply_to":"dab17558_279bee19","updated":"2016-05-16 20:07:18.000000000","message":"There\u0027s no new process.  This code is just running as a mistral service.  It doesn\u0027t do anything until you create an event trigger, similar to cron triggers.","commit_id":"5add15f2bf6f60e119e8b0550d1fb739921fd354"},{"author":{"_account_id":10159,"name":"Todd Johnson","email":"toddjohn@us.ibm.com","username":"toddjohnson"},"change_message_id":"250b0f050e52ed713aad077c8a0e159ea3e0f179","unresolved":false,"context_lines":[{"line_number":543,"context_line":""},{"line_number":544,"context_line":"Deployer impact"},{"line_number":545,"context_line":"---------------"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"There should be no impacts to the deployer.  This new function is enabled"},{"line_number":548,"context_line":"automatically, however, nothing will run until someone adds an event trigger"},{"line_number":549,"context_line":"to the table via the REST API or the CLI.  This is similar to the cron"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_32e66115","line":546,"in_reply_to":"dab17558_4d553ac0","updated":"2016-05-20 17:43:07.000000000","message":"The service is always running, but it\u0027s not listening for anything until an event trigger is created.  When an event trigger is created, the service listens only for that event.  I really think if we added the web hook, we could actually share a majority of this spec and integrate both ideas.  Take a look at the updated spec i mention that in there.  It seems to me that it would be really cool to be able to trigger workflows both ways.\n\nI guess we could add some config option to disable it, but that\u0027s currently not part of our implementation.  Does Mistral have a standard way to enable/disable services?","commit_id":"5add15f2bf6f60e119e8b0550d1fb739921fd354"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"7d667b19c23d4fd0e69b5c4132bdb8b9ed25947b","unresolved":false,"context_lines":[{"line_number":244,"context_line":"  necessarily rely on AMQP. It\u0027s possible that a webhook implementation"},{"line_number":245,"context_line":"  could share a significant portion of the event trigger implementation and"},{"line_number":246,"context_line":"  should be able to easily coexist giving operators a choice depending on"},{"line_number":247,"context_line":"  their needs."},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"Data model impact"},{"line_number":250,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7aa08908_2330519e","line":247,"updated":"2016-06-09 23:13:27.000000000","message":"With the proposal in Id0639aff09a846c81bcb1e9949e5cf342cf5dfe6 this could be done without implementing anything in Mistral at all.","commit_id":"c5ba5062180643dc291bbc6965a41406ae5303e5"}]}
