)]}'
{"id":"openstack%2Fmistral~1001655","triplet_id":"openstack%2Fmistral~master~Ic9e0199878358290035b433a2e704b5b2f12e954","project":"openstack/mistral","branch":"master","hashtags":[],"change_id":"Ic9e0199878358290035b433a2e704b5b2f12e954","subject":"Mask secret-bearing fields when logging API resources","status":"MERGED","created":"2026-08-20 12:23:27.000000000","updated":"2026-08-21 12:48:53.000000000","submitted":"2026-08-21 12:47:34.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1001655","meta_rev_id":"a2b23e031183c28b733e4dcacd0d2a5b86003f51","_number":1001655,"virtual_id_number":1001655,"owner":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-08-21 12:47:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2026-08-21 11:59:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2026-08-21 11:59:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-08-20 13:24:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0337a2f18e8e37238f3f0e6bde783e00b70442bd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"date":"2026-08-20 12:23:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"63fa9a13dcc0108dd1595b77d2879e1c3a3942b4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-20 13:24:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e26d39890ceb4995a4878f9f4ffc7cb4\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c26d8942dc7f416ba749600ebe4a8e0a : SUCCESS in 4m 54s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/aad52e81cf7a486585eda5a8e654847f : SUCCESS in 13m 51s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/fbd9e37b347a472d8834942b2bcc75c7 : SUCCESS in 10m 51s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/d846433393e4480096ab4ddeb0572ac5 : SUCCESS in 15m 20s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/305d9806025048caa10eab4848655d41 : SUCCESS in 5m 44s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/7622e7bea41c4ebeab52e1909f83e39c : SUCCESS in 3m 38s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c6f7702075c04735af5458a03c750c35 : SUCCESS in 13m 18s (non-voting)\n- mistral-devstack https://zuul.opendev.org/t/openstack/build/05209ddc88434a8e85a3a1bb9c883151 : SUCCESS in 43m 50s\n- mistral-devstack-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/e7f165bcad1e482da9772967fa1a7624 : SUCCESS in 40m 53s","accounts_in_message":[],"_revision_number":1},{"id":"a819bd9b6fbd836b2bd8ac6963c99da9606389b5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"date":"2026-08-21 09:27:14.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"NEVER\")\n","accounts_in_message":[],"_revision_number":2},{"id":"c32e56d074602dd968d5cef81dc6982855014922","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-21 10:14:45.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/54d550d32dea41ae9684bcd4b3902860\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f2c0271198a84b3b8db3ed50f47ee243 : SUCCESS in 4m 09s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/ea1d0cc6bb35488a8f7e8c0cf6d8e48c : SUCCESS in 10m 26s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/254433fb2c0d404789b2a6998d6ee05b : SUCCESS in 9m 48s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/11ae4d4f2ec74b028f696e1942d56738 : SUCCESS in 14m 19s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/61fc1513e84b4839ab86cb8c5fd33e2f : SUCCESS in 9m 06s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/139f3689c73a4f88be9bb40001dc0601 : SUCCESS in 4m 53s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/0ac438f76ba648fdb4f2c174bd783ff5 : SUCCESS in 17m 08s (non-voting)\n- mistral-devstack https://zuul.opendev.org/t/openstack/build/d2351b43d8454d29a5d02d3a4b197eb7 : SUCCESS in 35m 42s\n- mistral-devstack-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/0bf7a74c547843f6ae8c151f9509f202 : SUCCESS in 41m 43s","accounts_in_message":[],"_revision_number":2},{"id":"955ce6482f87f16b58a8be9ff0e597f2c765f53e","author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"date":"2026-08-21 11:59:55.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"85e6008554c0a6c3b0a5375b3e88b5131eac3511","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-21 12:00:25.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"207f20534e73715062b91b3fbb60d717e15b4c29","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-21 12:47:34.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5c3c15b731f24526898d012450847b14\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/eb9cc78093734b499b02cf76233ca827 : SUCCESS in 4m 22s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/cc45a88cf29e47eba23b59e272b43f1c : SUCCESS in 9m 57s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/76f75c9b552c4a7fa6e7a892c174ebe9 : SUCCESS in 11m 18s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2aa98ae6c2764f86a7de8fe21d29ad5a : SUCCESS in 8m 30s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/90a2aa4614474cf5bb6fd9dc782f3514 : SUCCESS in 5m 13s\n- mistral-devstack https://zuul.opendev.org/t/openstack/build/546f80430cd1460085f04d0bf4f07735 : SUCCESS in 40m 44s\n- mistral-devstack-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/5098b9d2f85747c383acfc50f3e061c0 : SUCCESS in 42m 04s","accounts_in_message":[],"_revision_number":2},{"id":"ecc54ee6e912fd2b863bc6849f0ba04fa060363f","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-21 12:47:34.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"a2b23e031183c28b733e4dcacd0d2a5b86003f51","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-21 12:48:53.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/2b05623f57d84b31bc220e410cb291cd\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/322cf9de29c948c18a9eb9633c15036b : SUCCESS in 1m 01s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/05082c3907c2430891316c938df20f66 : SUCCESS in 45s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f54c39355085bde766a2aaf53f541ee10f55c236","revisions":{"c91412760eb0669bc85552b399e086e78b524659":{"kind":"REWORK","_number":1,"created":"2026-08-20 12:23:27.000000000","uploader":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"ref":"refs/changes/55/1001655/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/mistral","ref":"refs/changes/55/1001655/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/mistral refs/changes/55/1001655/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/mistral refs/changes/55/1001655/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/mistral refs/changes/55/1001655/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/mistral refs/changes/55/1001655/1"}}},"commit":{"parents":[{"commit":"9a74696ff54b1183eb6ddad35423c30b9d290442","subject":"Merge \"Remove PostgreSQL references from the documentation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/9a74696ff54b1183eb6ddad35423c30b9d290442"}]}],"author":{"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","date":"2026-08-19 21:03:25.000000000","tz":120},"committer":{"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","date":"2026-08-20 12:20:26.000000000","tz":120},"subject":"Mask secret-bearing fields when logging API resources","message":"Mask secret-bearing fields when logging API resources\n\nThe v2 controllers routinely log a resource with LOG.*(\"... %s\",\nresource), and Resource.__str__ rendered every WSME attribute\nverbatim. For Execution, Task and ActionExecution that includes the\nworkflow input, output, params (which carries env), result, published,\npublished_global and runtime_context fields - and for Environment the\nvariables field. These carry client-supplied secrets (action\npasswords, API keys, auth headers/tokens), so they leaked into the\nlogs on execution/task/action-execution create and update (some at\nINFO, always on).\n\nMask these attributes in Resource.__str__ so that logging any resource\n- now or in a future controller - cannot leak them. Unset attributes\nare left readable so the output still shows which fields are present.\nThis is the central fix for the shared __str__ leak pattern; the\nindividual create/update log calls are now safe through it.\n\nGenerated-By: Claude Fable 5 (Anthropic AI assistant)\nSigned-off-by: Arnaud Morin \u003carnaud.morin@gmail.com\u003e\nRelated-Bug: #1337268\nChange-Id: Ic9e0199878358290035b433a2e704b5b2f12e954\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/c91412760eb0669bc85552b399e086e78b524659"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/c91412760eb0669bc85552b399e086e78b524659"}]},"branch":"refs/heads/master"},"f54c39355085bde766a2aaf53f541ee10f55c236":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-08-21 09:27:14.000000000","uploader":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"ref":"refs/changes/55/1001655/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/mistral","ref":"refs/changes/55/1001655/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/mistral refs/changes/55/1001655/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/mistral refs/changes/55/1001655/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/mistral refs/changes/55/1001655/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/mistral refs/changes/55/1001655/2"}}},"commit":{"parents":[{"commit":"88508624e2002737353bdb4283fbc17ac3e6d7fb","subject":"Add an outbound egress policy to std.http and the webhook notifier","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/88508624e2002737353bdb4283fbc17ac3e6d7fb"}]}],"author":{"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","date":"2026-08-19 21:03:25.000000000","tz":120},"committer":{"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","date":"2026-08-21 09:20:12.000000000","tz":120},"subject":"Mask secret-bearing fields when logging API resources","message":"Mask secret-bearing fields when logging API resources\n\nThe v2 controllers routinely log a resource with LOG.*(\"... %s\",\nresource), and Resource.__str__ rendered every WSME attribute\nverbatim. For Execution, Task and ActionExecution that includes the\nworkflow input, output, params (which carries env), result, published,\npublished_global and runtime_context fields - and for Environment the\nvariables field. These carry client-supplied secrets (action\npasswords, API keys, auth headers/tokens), so they leaked into the\nlogs on execution/task/action-execution create and update (some at\nINFO, always on).\n\nMask these attributes in Resource.__str__ so that logging any resource\n- now or in a future controller - cannot leak them. Unset attributes\nare left readable so the output still shows which fields are present.\nThis is the central fix for the shared __str__ leak pattern; the\nindividual create/update log calls are now safe through it.\n\nGenerated-By: Claude Fable 5 (Anthropic AI assistant)\nSigned-off-by: Arnaud Morin \u003carnaud.morin@gmail.com\u003e\nRelated-Bug: #1337268\nChange-Id: Ic9e0199878358290035b433a2e704b5b2f12e954\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/f54c39355085bde766a2aaf53f541ee10f55c236"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/f54c39355085bde766a2aaf53f541ee10f55c236"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}