)]}'
{"mistral/messaging.py":[{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"55709171e17acd02cd7b34b0d8c7030ced19ab73","unresolved":true,"context_lines":[{"line_number":100,"context_line":"def start_listener(conf, exchange, topic, endpoints):"},{"line_number":101,"context_line":"    \"\"\"Starts up a notification listener.\"\"\""},{"line_number":102,"context_line":"    # NOTE(fivetime): this has to be the notification transport, not the RPC"},{"line_number":103,"context_line":"    # one. Notifications can be routed to a bus of their own through"},{"line_number":104,"context_line":"    # [oslo_messaging_notifications] transport_url, and nothing publishes"},{"line_number":105,"context_line":"    # the events we listen for on the RPC bus from [DEFAULT]. When no"},{"line_number":106,"context_line":"    # separate bus is configured get_notification_transport() falls back to"}],"source_content_type":"text/x-python","patch_set":2,"id":"b12753b9_13ff7261","line":103,"updated":"2026-10-15 22:02:02.000000000","message":"Can you reduce (or ask your claude) to reduce the comments here? eventually remove all of them, these are not needed and redundant with the commit message","commit_id":"f9f81e62935f92ac92f0d777c3e9ba5b7bfcb55c"}],"mistral/tests/unit/test_messaging.py":[{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"f2ddf7630911ddbdc32ff8d2507e1a5293d2883a","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    \"\"\"Tests for mistral.messaging.start_listener().\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @mock.patch(\u0027mistral.messaging.listener.get_notification_listener\u0027)"},{"line_number":29,"context_line":"    @mock.patch(\u0027oslo_messaging.get_transport\u0027)"},{"line_number":30,"context_line":"    @mock.patch(\u0027oslo_messaging.get_notification_transport\u0027)"},{"line_number":31,"context_line":"    def test_listener_is_built_on_the_notification_transport("},{"line_number":32,"context_line":"            self, get_notification_transport, get_transport, get_listener):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5e1ad4a1_70ed8a0e","line":29,"updated":"2026-10-15 22:02:33.000000000","message":"mocking oslo_messaging.get_transport is not needed anymore I believe?","commit_id":"f9f81e62935f92ac92f0d777c3e9ba5b7bfcb55c"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"e937682c303bcdf132dcfb684c335807d2560abc","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        )"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        get_notification_transport.assert_called_once_with(CONF)"},{"line_number":43,"context_line":"        get_transport.assert_not_called()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        self.assertEqual("},{"line_number":46,"context_line":"            get_notification_transport.return_value,"}],"source_content_type":"text/x-python","patch_set":2,"id":"c5cb6b50_63e8d6ba","line":43,"updated":"2026-10-15 22:02:52.000000000","message":"not needed","commit_id":"f9f81e62935f92ac92f0d777c3e9ba5b7bfcb55c"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"f95375bdfa45ce967453b226ea066dcf8c29a1a5","unresolved":true,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @mock.patch(\u0027mistral.messaging.listener.get_notification_listener\u0027)"},{"line_number":54,"context_line":"    @mock.patch(\u0027oslo_messaging.get_notification_transport\u0027)"},{"line_number":55,"context_line":"    def test_listener_target_and_pool(self, _transport, get_listener):"},{"line_number":56,"context_line":"        messaging.start_listener("},{"line_number":57,"context_line":"            CONF, \u0027cinder\u0027, \u0027versioned_notifications\u0027, []"},{"line_number":58,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"367191af_b1354b7e","line":55,"updated":"2026-10-15 22:04:17.000000000","message":"I believe one test that assert both get_notification_transport.assert_called_once_with and verify the content of the notification is enough","commit_id":"f9f81e62935f92ac92f0d777c3e9ba5b7bfcb55c"}]}
