)]}'
{"id":"openstack%2Fmistral~1009470","triplet_id":"openstack%2Fmistral~master~I1dc5c62d4795f12813d5957f92b897bf8d4a0bf2","project":"openstack/mistral","branch":"master","topic":"mistral-OSSA-2026-044","hashtags":[],"change_id":"I1dc5c62d4795f12813d5957f92b897bf8d4a0bf2","subject":"Enforce access control when updating workbooks and environments","status":"MERGED","created":"2026-10-08 14:10:40.000000000","updated":"2026-10-08 17:07:48.000000000","submitted":"2026-10-08 17:02:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1009470-mistral-OSSA-2026-044","meta_rev_id":"0e6386c9df68f798175685498111415480b3843c","_number":1009470,"virtual_id_number":1009470,"owner":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-10-08 17:02:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2026-10-08 15:46:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2026-10-08 15:46:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-08 15:23:36.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b0d1a733c33d8aed2a356ce559558eb6b266b1a3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"date":"2026-10-08 14:10:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c63ab403e28bec9d4c093639915a718fd2cc2287","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 15:23:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a77bf3fe080b48a5bcd802f4ee7aa1ab\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/115d2c1c69c044ae8cd63968becfd12b : SUCCESS in 3m 17s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/e11307e3d7174792a59f4187ead1fa13 : SUCCESS in 10m 56s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/d5e41506205c4d59b9433ba5a06b2296 : SUCCESS in 13m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/14e086a9ef6c497f8174fdb3a341cd71 : SUCCESS in 5m 20s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e60f8c80e4be4a468713acf429d524e5 : SUCCESS in 5m 55s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a80dcd9b51194f018279c30765ea0595 : SUCCESS in 14m 39s (non-voting)\n- mistral-devstack https://zuul.opendev.org/t/openstack/build/feb1c227e772425b9b8f8af1076d81bd : SUCCESS in 39m 54s\n- mistral-devstack-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/b43c46a1eaa44aec980973dc17d1fe97 : SUCCESS in 42m 29s","accounts_in_message":[],"_revision_number":1},{"id":"d9176f723dde2b2cb60710b849d3783834704dc7","author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"date":"2026-10-08 15:46:06.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"ee513013ec62fbb8b63a6e7b3c8274ec9bdb5a01","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 16:08:15.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"470465053de395277cd1661d0160dc86eb42e7fc","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 17:02:48.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e7b7f48456834e4a8d294afee3d39139\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3e24cd65989e47d6af8418784b0e532d : SUCCESS in 4m 25s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/1d470b05cd8148f9b58e1b96ca4052d7 : SUCCESS in 9m 34s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/3b7391b1ffb047e2850a16a55551978f : SUCCESS in 13m 21s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f50b8ced2e084fefa069ccaf33bcfd80 : SUCCESS in 8m 01s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b56bc0826d0b43809fd7120a5d8f96ed : SUCCESS in 5m 03s\n- mistral-devstack https://zuul.opendev.org/t/openstack/build/a8e95d70969e4656b7c6cbcc59e77be8 : SUCCESS in 22m 17s\n- mistral-devstack-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/5a9f004774dd448f8b6345ff5afbfb14 : SUCCESS in 42m 13s","accounts_in_message":[],"_revision_number":1},{"id":"54040babfc10f0f286e4f523a4e7a10c7cf52380","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 17:02:48.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"0e6386c9df68f798175685498111415480b3843c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 17:07:48.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e63c10dfb05d4ebe8588d835ab3c083c\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bb6f724415734a0faaff141a63da5b3e : SUCCESS in 1m 09s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/62502ef1ac8046b0920de67f3addc5db : SUCCESS in 1m 05s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a0b02e19583e81583c9f6a6d78bd47c2ac2ec6dc","revisions":{"a0b02e19583e81583c9f6a6d78bd47c2ac2ec6dc":{"kind":"REWORK","_number":1,"created":"2026-10-08 14:10:40.000000000","uploader":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"ref":"refs/changes/70/1009470/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/mistral","ref":"refs/changes/70/1009470/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/mistral refs/changes/70/1009470/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/mistral refs/changes/70/1009470/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/mistral refs/changes/70/1009470/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/mistral refs/changes/70/1009470/1"}}},"commit":{"parents":[{"commit":"705b1e2412734994aea71ddc6bac9d604a15013a","subject":"Enforce access control when updating action definitions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/705b1e2412734994aea71ddc6bac9d604a15013a"}]}],"author":{"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","date":"2026-07-09 20:52:43.000000000","tz":120},"committer":{"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","date":"2026-10-08 14:09:19.000000000","tz":120},"subject":"Enforce access control when updating workbooks and environments","message":"Enforce access control when updating workbooks and environments\n\nupdate_workbook() and update_environment()/create_or_update_environment()\nresolved the target with a query that returns public resources of other\nprojects, and wrote to it without an ownership check. A non-admin project\nmember could therefore modify (and, since the update sends scope, unpublish)\nanother project\u0027s public workbook or environment.\n\nResolve the object within the caller\u0027s own project first and call\ncheck_db_obj_access() before writing, consistently with workflow and action\ndefinitions. The check is skipped when there is no authentication context.\n\nupdate_workbook() was previously protected only transitively: a workbook\nupdate cascades into update_workflow_definition(), which is guarded, so the\nwhole transaction rolled back. Making the workflow/action lookup\nproject-scoped (previous change) removes that incidental protection, so the\nguard is now applied to the workbook row itself.\n\nRelated-Bug: #2160267\nAssisted-By: Claude Fable 5 \u003cnoreply@anthropic.com\u003e\nChange-Id: I1dc5c62d4795f12813d5957f92b897bf8d4a0bf2\nSigned-off-by: Arnaud Morin \u003carnaud.morin@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/a0b02e19583e81583c9f6a6d78bd47c2ac2ec6dc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/a0b02e19583e81583c9f6a6d78bd47c2ac2ec6dc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}