)]}'
{"id":"openstack%2Fmistral~1009475","triplet_id":"openstack%2Fmistral~master~I9ab8ddad7e3c63bb7bb8be5ad216512421e59aa2","project":"openstack/mistral","branch":"master","topic":"mistral-OSSA-2026-044","hashtags":[],"change_id":"I9ab8ddad7e3c63bb7bb8be5ad216512421e59aa2","subject":"Restrict the maintenance endpoint to admins","status":"MERGED","created":"2026-10-08 14:10:40.000000000","updated":"2026-10-08 17:26:27.000000000","submitted":"2026-10-08 17:23:24.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1009475-mistral-OSSA-2026-044","meta_rev_id":"5cfeaefb6a9074dffb3d1102d01ac8307b17c3e4","_number":1009475,"virtual_id_number":1009475,"owner":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-10-08 17:23:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2026-10-08 15:40:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2026-10-08 15:40:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-08 15:23:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"68a9789a1aeb8d6a6ba266e8b18c7c38b48abf03","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"date":"2026-10-08 14:10:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c73d0948ba2b1ee4c7defd395cd808668cb952de","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 15:23:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/0a64d8f3f0294742b60b26a2203343e9\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/134dc3f91bdc47fea57c881c809d3c4d : SUCCESS in 5m 15s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/733fc4c3c77c46ddb6d03ffc326ae690 : SUCCESS in 9m 55s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/90128d1b246b46f084e5b5b185013362 : SUCCESS in 12m 13s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/31663383e2514dddb4f12eb57bc754a1 : SUCCESS in 8m 54s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/178d1b1c522f4230b299419badc44284 : SUCCESS in 5m 29s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f95a63cadf96418a87fa0cb047859b7f : SUCCESS in 17m 16s (non-voting)\n- mistral-devstack https://zuul.opendev.org/t/openstack/build/2c66a06da939430d8885b1706e5f6756 : SUCCESS in 23m 34s\n- mistral-devstack-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/e99f39ed989a498289b773f880ade141 : SUCCESS in 44m 07s","accounts_in_message":[],"_revision_number":1},{"id":"f61e94417e8e69c2afb107e88ade2e032b57f682","author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"date":"2026-10-08 15:40:06.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"59e771f9579432a193fa8240a2aa23b772f37eb6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 16:08:19.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"67e3962502965d2a048c66f9ab43213a76207754","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 17:23:24.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/34c8786d51d449459646e477a6b3d63b\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e4a76d99e16d47b192b1b14e117387af : SUCCESS in 4m 10s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/df7d0577898c4e0ea57a32b218cbc562 : SUCCESS in 10m 55s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/82ef5c3185234fa9a9c13926b79b3fc2 : SUCCESS in 14m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4f0c722c06b14a9f8ddc76c2204681f8 : SUCCESS in 9m 37s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a685f314e73a455d84082583c508e4e9 : SUCCESS in 5m 08s\n- mistral-devstack https://zuul.opendev.org/t/openstack/build/6f194086f08a4fb4802e31944cfa1008 : SUCCESS in 41m 00s\n- mistral-devstack-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/93745cc614bb475f8dd9def33ccec78c : SUCCESS in 42m 07s","accounts_in_message":[],"_revision_number":1},{"id":"77f9c0090d93f349f8d944f4c5afd48bd0eda838","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 17:23:24.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"5cfeaefb6a9074dffb3d1102d01ac8307b17c3e4","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 17:26:27.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3398819cdc2c4b0f93c58c2b5c607fc2\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7ca04264ca3d4ecbb7b94cff18da13b8 : SUCCESS in 1m 03s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b84b789dd42b45ec88639f5b9388c50b : SUCCESS in 59s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"858e35f5a6a497b7f4655b34c48a26331040022b","revisions":{"858e35f5a6a497b7f4655b34c48a26331040022b":{"kind":"REWORK","_number":1,"created":"2026-10-08 14:10:40.000000000","uploader":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"ref":"refs/changes/75/1009475/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/mistral","ref":"refs/changes/75/1009475/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/mistral refs/changes/75/1009475/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/mistral refs/changes/75/1009475/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/mistral refs/changes/75/1009475/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/mistral refs/changes/75/1009475/1"}}},"commit":{"parents":[{"commit":"6f934fcc6bb483bfd4c3200ed4500764ba0219f8","subject":"Fix RCE via std.ssh_proxied proxy_command","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/6f934fcc6bb483bfd4c3200ed4500764ba0219f8"}]}],"author":{"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","date":"2026-08-24 07:59:12.000000000","tz":120},"committer":{"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","date":"2026-10-08 14:09:21.000000000","tz":120},"subject":"Restrict the maintenance endpoint to admins","message":"Restrict the maintenance endpoint to admins\n\nThe root-level /maintenance resource read and changed Mistral\u0027s cluster\nmaintenance state with no policy enforcement: the controller cleared\nthe request context and called the service/DB layer directly. Switching\nthe status to PAUSED is a cluster-wide operation that pauses running\nexecutions across every project, and reading the status exposes\ncluster-wide operational state, yet any authenticated token holder\ncould reach both methods.\n\nAdd \u0027maintenance:get\u0027 and \u0027maintenance:update\u0027 policies (both default\nrule:admin_only) and enforce them in MaintenanceController.get() and\nput() before the request context is cleared, so only administrators can\nread or change the maintenance status. Operators can relax the rules in\npolicy.yaml if needed.\n\nCloses-Bug: #2162789\nSigned-off-by: Arnaud Morin \u003carnaud.morin@gmail.com\u003e\nChange-Id: I9ab8ddad7e3c63bb7bb8be5ad216512421e59aa2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/858e35f5a6a497b7f4655b34c48a26331040022b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/858e35f5a6a497b7f4655b34c48a26331040022b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}