)]}'
{"id":"openstack%2Fmistral~1009477","triplet_id":"openstack%2Fmistral~stable%2F2026.2~I98129d2079f1e0a565af89f76e7a8152a1beba61","project":"openstack/mistral","branch":"stable/2026.2","topic":"mistral-OSSA-2026-044","hashtags":[],"change_id":"I98129d2079f1e0a565af89f76e7a8152a1beba61","subject":"Enforce access control when updating action definitions","status":"MERGED","created":"2026-10-08 14:12:08.000000000","updated":"2026-10-08 18:51:24.000000000","submitted":"2026-10-08 18:49:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1009477-mistral-OSSA-2026-044","meta_rev_id":"873533a0546898269818d516579e8edbfdc3b00f","_number":1009477,"virtual_id_number":1009477,"owner":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-10-08 18:49:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2026-10-08 17:42:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2026-10-08 17:42:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-08 16:03:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9670b3ea811cf16163f8a5657a7e55d3ca4014a3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"date":"2026-10-08 14:12:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6c99cd01aff5c40a1016d12a9f234d9ebfbd5a2e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 16:03:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/117e195b94c9453c87c973acd61ec0e2\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/88a9c0d33456497b9369bdfe8e5e8ec5 : SUCCESS in 4m 02s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/f92746bcf2a740aebe0131971ed04dfc : SUCCESS in 11m 30s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/5acf93b4416943f19d8d93e58603ffd0 : SUCCESS in 11m 38s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/358d752e6ae941fd842256262ed1666c : SUCCESS in 14m 51s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/79eaa96aea174789b3ef98d3205a669a : SUCCESS in 9m 59s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2ef34766cbc74105b7038c18a3dc333d : SUCCESS in 4m 56s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/42b6fc0af9214103845b776320677848 : SUCCESS in 17m 32s (non-voting)\n- mistral-devstack https://zuul.opendev.org/t/openstack/build/6b5017c05b11423c9a96ccfed81aee97 : SUCCESS in 17m 47s\n- mistral-devstack-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/ff33ca31dc8642849d7f324afe2a8d5e : SUCCESS in 39m 30s","accounts_in_message":[],"_revision_number":1},{"id":"6230d3c435bed05f602f4f8016dc6870cb93ef71","author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"date":"2026-10-08 17:42:54.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"4e01e4602219d2fe503fd21a304df36c33913b48","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 17:45:35.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"b34f8841aa9e5b0325491a5cf16b4348b2ff4c99","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 18:49:48.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b8ee49a0737148d8a15f2a561655754f\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/47fc1b65726f4f41aca37e958789286a : SUCCESS in 3m 04s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/c981e8a86ab5434bae6815702e62d3d1 : SUCCESS in 11m 29s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/8a6e4f7c00cd44649ff9332fee244aaf : SUCCESS in 9m 21s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2e7df8ef3e0b4311851a1e294c65d9b5 : SUCCESS in 5m 30s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/27872f7922184b94bb3933112402318e : SUCCESS in 4m 08s\n- mistral-devstack https://zuul.opendev.org/t/openstack/build/b9f1181401304bd6870855d4465585d8 : SUCCESS in 51m 24s\n- mistral-devstack-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/fd8ee85889c04cc69b43760d5f391d1c : SUCCESS in 36m 02s","accounts_in_message":[],"_revision_number":1},{"id":"8d4bf5a59bb6e279b35b8d5aae4dd60a298460ad","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 18:49:48.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"873533a0546898269818d516579e8edbfdc3b00f","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 18:51:24.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/06af1db525994474aa6f353211eb2789\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8b38279dce3643d79aa68dbfd31132a0 : SUCCESS in 44s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b8f62822b7b045dc9aea86ba25b6712c : SUCCESS in 42s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c0162991d611e4b11d2886e58b66cf1e248e3249","revisions":{"c0162991d611e4b11d2886e58b66cf1e248e3249":{"kind":"REWORK","_number":1,"created":"2026-10-08 14:12:08.000000000","uploader":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"ref":"refs/changes/77/1009477/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/mistral","ref":"refs/changes/77/1009477/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/mistral refs/changes/77/1009477/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/mistral refs/changes/77/1009477/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/mistral refs/changes/77/1009477/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/mistral refs/changes/77/1009477/1"}}},"commit":{"parents":[{"commit":"f12fbdab8c53986b67752e8aa6098ea62e2ae91e","subject":"Fix create-or-update of definitions hijacking other projects\u0027 rows","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/f12fbdab8c53986b67752e8aa6098ea62e2ae91e"}]}],"author":{"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","date":"2026-07-09 19:34:58.000000000","tz":120},"committer":{"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","date":"2026-10-08 14:11:09.000000000","tz":120},"subject":"Enforce access control when updating action definitions","message":"Enforce access control when updating action definitions\n\nupdate_action_definition() resolved the target by name with a query\nthat, for a non-admin caller, also matches public definitions of other\nprojects (the secure query includes scope\u003d\u003d\u0027public\u0027). It then rewrote\nproject_id to the caller on write, so a non-admin could modify and\neffectively steal another project\u0027s public ad-hoc action, and it had no\nguard against modifying a system action at the DB layer -- unlike\nupdate_workflow_definition(), which calls check_db_obj_access().\n\nLook the definition up in the caller\u0027s own project first so that, when\nseveral projects share a name, the caller\u0027s own object is updated, and\ncall check_db_obj_access() to reject cross-project and system-action\nmodifications by non-admins. The check is skipped when there is no\nauthentication context, since \u0027mistral-db-manage populate\u0027 re-registers\npreinstalled ad-hoc actions through this path without one.\n\nRelated-Bug: #2160267\nAssisted-By: Claude Fable 5 \u003cnoreply@anthropic.com\u003e\nChange-Id: I98129d2079f1e0a565af89f76e7a8152a1beba61\nSigned-off-by: Arnaud Morin \u003carnaud.morin@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/c0162991d611e4b11d2886e58b66cf1e248e3249"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/c0162991d611e4b11d2886e58b66cf1e248e3249"}]},"branch":"refs/heads/stable/2026.2"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}