)]}'
{"id":"openstack%2Fmistral~1009486","triplet_id":"openstack%2Fmistral~stable%2F2026.1~I1dc5c62d4795f12813d5957f92b897bf8d4a0bf2","project":"openstack/mistral","branch":"stable/2026.1","topic":"mistral-OSSA-2026-044","hashtags":[],"change_id":"I1dc5c62d4795f12813d5957f92b897bf8d4a0bf2","subject":"Enforce access control when updating workbooks and environments","status":"MERGED","created":"2026-10-08 14:14:04.000000000","updated":"2026-10-08 19:01:35.000000000","submitted":"2026-10-08 19:01:35.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1009486-mistral-OSSA-2026-044","meta_rev_id":"372f7e917c23ca46c8a39e898caa4a5b4a1f7c67","_number":1009486,"virtual_id_number":1009486,"owner":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-10-08 19:01:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2026-10-08 17:44:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2026-10-08 17:44:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-08 16:03:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"aa64028860192caa049da285f28ed8d9b10d994e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"date":"2026-10-08 14:14:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"93d813cbd6f4799b896e40e34b2eef636cfebded","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 16:03:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/bef4e8a9ebad42078b9af47dc99c3a68\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c68f656cbb4242c69344cfd273d1d3c1 : SUCCESS in 2m 47s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/8026e24a33f245e4a04944e4d9da82c1 : SUCCESS in 11m 21s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/ca00d1d4f36f488594db4c1beb1be1ee : SUCCESS in 9m 51s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/2de2b210a9a740b18fdd61706ed128b4 : SUCCESS in 12m 43s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/110ebbc2eccb4db3848ec3810057143f : SUCCESS in 6m 46s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3817952514a3415393b8eab4f0462ca2 : SUCCESS in 3m 58s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9c83c710934a4fb892fe45405611a10d : SUCCESS in 17m 34s (non-voting)\n- mistral-devstack https://zuul.opendev.org/t/openstack/build/55ea3a23d45349be87574ae07fe91550 : SUCCESS in 43m 44s\n- mistral-devstack-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/99dfa5516e1e45e7921f00565f084fe7 : SUCCESS in 41m 41s","accounts_in_message":[],"_revision_number":1},{"id":"03ba2629efdc26495aca9ce3775089c8536599cb","author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"date":"2026-10-08 17:44:05.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"c37417ba1c315f3c878bf5051904fdd602d47e71","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 17:47:10.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"009e6c93105603b8c1b5f45aef37d2f7675df7f1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 19:01:35.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/49a87e4b60154a3dbc32951b433a4b66\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8a8bc003fe9b44a896029bfd8ca494fe : SUCCESS in 4m 54s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/904c32efb2d3446a87d715b1218943cc : SUCCESS in 10m 05s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/0d022c95b67a445ea72095e51be35e92 : SUCCESS in 11m 20s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4a3c5af7ed064edfa20e6b7dcf9c2438 : SUCCESS in 5m 13s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/28c7e242414543939fa1cbaf60d1164a : SUCCESS in 6m 40s\n- mistral-devstack https://zuul.opendev.org/t/openstack/build/54fa2545271c467abb5c3e98df68e94a : SUCCESS in 31m 18s\n- mistral-devstack-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/44d6824f0dbd45cc87354513ba782ccd : SUCCESS in 40m 41s","accounts_in_message":[],"_revision_number":1},{"id":"372f7e917c23ca46c8a39e898caa4a5b4a1f7c67","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 19:01:35.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1d183080f6aac79aaab63194719130fb2a3d1ab0","revisions":{"1d183080f6aac79aaab63194719130fb2a3d1ab0":{"kind":"REWORK","_number":1,"created":"2026-10-08 14:14:04.000000000","uploader":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"ref":"refs/changes/86/1009486/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/mistral","ref":"refs/changes/86/1009486/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/mistral refs/changes/86/1009486/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/mistral refs/changes/86/1009486/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/mistral refs/changes/86/1009486/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/mistral refs/changes/86/1009486/1"}}},"commit":{"parents":[{"commit":"c8538f10a299e8b3f80a3031e246248db41420cc","subject":"Enforce access control when updating action definitions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/c8538f10a299e8b3f80a3031e246248db41420cc"}]}],"author":{"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","date":"2026-07-09 20:52:43.000000000","tz":120},"committer":{"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","date":"2026-10-08 14:13:48.000000000","tz":120},"subject":"Enforce access control when updating workbooks and environments","message":"Enforce access control when updating workbooks and environments\n\nupdate_workbook() and update_environment()/create_or_update_environment()\nresolved the target with a query that returns public resources of other\nprojects, and wrote to it without an ownership check. A non-admin project\nmember could therefore modify (and, since the update sends scope, unpublish)\nanother project\u0027s public workbook or environment.\n\nResolve the object within the caller\u0027s own project first and call\ncheck_db_obj_access() before writing, consistently with workflow and action\ndefinitions. The check is skipped when there is no authentication context.\n\nupdate_workbook() was previously protected only transitively: a workbook\nupdate cascades into update_workflow_definition(), which is guarded, so the\nwhole transaction rolled back. Making the workflow/action lookup\nproject-scoped (previous change) removes that incidental protection, so the\nguard is now applied to the workbook row itself.\n\nRelated-Bug: #2160267\nAssisted-By: Claude Fable 5 \u003cnoreply@anthropic.com\u003e\nChange-Id: I1dc5c62d4795f12813d5957f92b897bf8d4a0bf2\nSigned-off-by: Arnaud Morin \u003carnaud.morin@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/1d183080f6aac79aaab63194719130fb2a3d1ab0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/1d183080f6aac79aaab63194719130fb2a3d1ab0"}]},"branch":"refs/heads/stable/2026.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}