)]}'
{"id":"openstack%2Fmistral~1009495","triplet_id":"openstack%2Fmistral~stable%2F2025.2~I1dc5c62d4795f12813d5957f92b897bf8d4a0bf2","project":"openstack/mistral","branch":"stable/2025.2","topic":"mistral-OSSA-2026-044","hashtags":[],"change_id":"I1dc5c62d4795f12813d5957f92b897bf8d4a0bf2","subject":"Enforce access control when updating workbooks and environments","status":"MERGED","created":"2026-10-08 14:19:11.000000000","updated":"2026-10-08 20:20:04.000000000","submitted":"2026-10-08 20:20:04.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1009495-mistral-OSSA-2026-044","meta_rev_id":"0845b1ab7dfb448c3f739fd3a68b94109baf7974","_number":1009495,"virtual_id_number":1009495,"owner":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-10-08 20:20:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2026-10-08 19:28:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2026-10-08 19:28:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-08 16:43:12.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"446675d78669af45e29767bc59e2c6ab6fbf3a90","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"date":"2026-10-08 14:19:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c10cc58e28ab221535a26200cf4ebc4864963cc7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 16:43:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/25dcad3584b2428689cc6f6906aea3a2\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b62958aa999b44569a75444d3a906608 : SUCCESS in 4m 31s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/9274304655184be5a4e608163e80e12f : SUCCESS in 12m 33s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/20430713815c4c4195f3ae93d2ca898c : SUCCESS in 11m 21s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/10f1837d5af24443a9d84b50569a89c6 : SUCCESS in 14m 49s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/87af0cdd2a0d4bb19d0cb82ca304dcee : SUCCESS in 10m 16s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b757eb32cd8d4d46ac4d35b5524cbe17 : SUCCESS in 5m 11s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9e086de12c004e679cb99bd64d69ed75 : SUCCESS in 15m 14s (non-voting)\n- mistral-devstack https://zuul.opendev.org/t/openstack/build/24439ee32d1c4650a86dc4d2681f57d1 : SUCCESS in 44m 59s\n- mistral-devstack-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/9ebe57f52a134a49aaec45b70fe49d3c : SUCCESS in 46m 59s","accounts_in_message":[],"_revision_number":1},{"id":"6ad757f6b7403d0cdda4c1f203d544f019f86c1a","author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"date":"2026-10-08 19:28:56.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"0a454c29224a89ee927c370fd3ccc52b75fb7407","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 19:29:36.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"b1ae8764c7421104e6eac5d55f6f464e4df36ad3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 20:20:04.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/73b0e643f3774c6d9ad5e93d9d6209e6\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dedaca6a0ea245d583209bfc6342ef6a : SUCCESS in 3m 05s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/5a280547309249009e34a0b5219f29a7 : SUCCESS in 12m 52s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/c03e236382c842a48aac44bbf5065796 : SUCCESS in 10m 23s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/382a541f5cdc4fb497bfebd237d7c061 : SUCCESS in 9m 28s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f8275aac982848218e6bd9d7c302dea9 : SUCCESS in 5m 38s\n- mistral-devstack https://zuul.opendev.org/t/openstack/build/c2f6314297e846fd8269c92a8acb7353 : SUCCESS in 38m 28s\n- mistral-devstack-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/2c3c0e8dab3e484e92abe133d23b4627 : SUCCESS in 37m 36s","accounts_in_message":[],"_revision_number":1},{"id":"0845b1ab7dfb448c3f739fd3a68b94109baf7974","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-08 20:20:04.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3dd61530849f29e34b75969b062331c221c5bf3e","revisions":{"3dd61530849f29e34b75969b062331c221c5bf3e":{"kind":"REWORK","_number":1,"created":"2026-10-08 14:19:11.000000000","uploader":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"ref":"refs/changes/95/1009495/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/mistral","ref":"refs/changes/95/1009495/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/mistral refs/changes/95/1009495/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/mistral refs/changes/95/1009495/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/mistral refs/changes/95/1009495/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/mistral refs/changes/95/1009495/1"}}},"commit":{"parents":[{"commit":"55023694b9b05bc22f89ffbf1c4061c724ac1b0e","subject":"Enforce access control when updating action definitions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/55023694b9b05bc22f89ffbf1c4061c724ac1b0e"}]}],"author":{"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","date":"2026-07-09 20:52:43.000000000","tz":120},"committer":{"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","date":"2026-10-08 14:18:33.000000000","tz":120},"subject":"Enforce access control when updating workbooks and environments","message":"Enforce access control when updating workbooks and environments\n\nupdate_workbook() and update_environment()/create_or_update_environment()\nresolved the target with a query that returns public resources of other\nprojects, and wrote to it without an ownership check. A non-admin project\nmember could therefore modify (and, since the update sends scope, unpublish)\nanother project\u0027s public workbook or environment.\n\nResolve the object within the caller\u0027s own project first and call\ncheck_db_obj_access() before writing, consistently with workflow and action\ndefinitions. The check is skipped when there is no authentication context.\n\nupdate_workbook() was previously protected only transitively: a workbook\nupdate cascades into update_workflow_definition(), which is guarded, so the\nwhole transaction rolled back. Making the workflow/action lookup\nproject-scoped (previous change) removes that incidental protection, so the\nguard is now applied to the workbook row itself.\n\nRelated-Bug: #2160267\nAssisted-By: Claude Fable 5 \u003cnoreply@anthropic.com\u003e\nChange-Id: I1dc5c62d4795f12813d5957f92b897bf8d4a0bf2\nSigned-off-by: Arnaud Morin \u003carnaud.morin@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/3dd61530849f29e34b75969b062331c221c5bf3e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/3dd61530849f29e34b75969b062331c221c5bf3e"}]},"branch":"refs/heads/stable/2025.2"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}