)]}'
{"mistral/cmd/launch.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9680877bfa4628b6656a989314525729059fceec","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    executor_endpoint \u003d rpc.ExecutorServer(executor_v2)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    executor_server \u003d rpc.IMPL_SERVER("},{"line_number":63,"context_line":"        rpc_utils.get_rabbit_info_from_oslo(CONF.executor)"},{"line_number":64,"context_line":"    )"},{"line_number":65,"context_line":"    executor_server.register_endpoint(executor_endpoint)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_44d0b353","line":63,"updated":"2015-07-07 06:18:34.000000000","message":"Looks like we have a design problem here. At this point we don\u0027t know exactly whether it\u0027s rabbit or not but we use rabbit specific config to initialize an RPC object. It won\u0027t work for qpid, zeromq or something else.\n\nI see that it should be configurable in a different way. E.g. in conf file where we choose \u0027oslo\u0027 or \u0027kombu\u0027 we can also specify an opt group containing corresponding rpc properties like \u0027rabbit\u0027 or \u0027qpid\u0027.","commit_id":"15931561d458b1cae55236245e4d2cfc1730d820"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"51a0f097c3beb0e3f547e9e15a09ac2794ebee4a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    executor_endpoint \u003d rpc.ExecutorServer(executor_v2)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    executor_server \u003d rpc.IMPL_SERVER("},{"line_number":63,"context_line":"        rpc_utils.get_rabbit_info_from_oslo(CONF.executor)"},{"line_number":64,"context_line":"    )"},{"line_number":65,"context_line":"    executor_server.register_endpoint(executor_endpoint)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_e59bf764","line":63,"in_reply_to":"ba3cc151_44d0b353","updated":"2015-07-07 11:29:23.000000000","message":"Ok","commit_id":"15931561d458b1cae55236245e4d2cfc1730d820"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9680877bfa4628b6656a989314525729059fceec","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    scheduler.setup()"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    engine_server \u003d rpc.IMPL_SERVER("},{"line_number":80,"context_line":"        rpc_utils.get_rabbit_info_from_oslo(CONF.engine)"},{"line_number":81,"context_line":"    )"},{"line_number":82,"context_line":"    engine_server.register_endpoint(engine_endpoint)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_e446a720","line":80,"updated":"2015-07-07 06:18:34.000000000","message":"Same here and in other places where you init RPC objects.","commit_id":"15931561d458b1cae55236245e4d2cfc1730d820"}],"mistral/utils/rpc_utils.py":[{"author":{"_account_id":15881,"name":"Limor Stotland","email":"limor.bortman@nokia.com","username":"LimorStotlamd"},"change_message_id":"caf33e301d117c0afa9076c77cbc8c658a7fe527","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def get_rpc_info_from_oslo(additional_conf\u003dNone):"},{"line_number":23,"context_line":"    if CONF.rpc_backend in [\u0027rabbit\u0027, \u0027fake\u0027]:"},{"line_number":24,"context_line":"        return _get_rabbit_info_from_oslo(additional_conf)"},{"line_number":25,"context_line":"    else:"},{"line_number":26,"context_line":"        # TODO(nmakhotkin) Implement."},{"line_number":27,"context_line":"        raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a4dcd0f_2818e783","line":24,"updated":"2015-08-10 15:02:45.000000000","message":"what about qpid?","commit_id":"70a39712ebd6e2c6d6d01dca6c8448731ad86839"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"81cd3d854e5d76e47a5ad1e98c3120b2dc3c4dff","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def get_rpc_info_from_oslo(additional_conf\u003dNone):"},{"line_number":23,"context_line":"    if CONF.rpc_backend in [\u0027rabbit\u0027, \u0027fake\u0027]:"},{"line_number":24,"context_line":"        return _get_rabbit_info_from_oslo(additional_conf)"},{"line_number":25,"context_line":"    else:"},{"line_number":26,"context_line":"        # TODO(nmakhotkin) Implement."},{"line_number":27,"context_line":"        raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a4dcd0f_c537e44b","line":24,"in_reply_to":"1a4dcd0f_2818e783","updated":"2015-08-10 17:39:49.000000000","message":"This change is intended to create rabbit-specific implementation, any other we can implement in next patches. For qpid, it is still possible to use oslo.messaging though.","commit_id":"70a39712ebd6e2c6d6d01dca6c8448731ad86839"}]}