)]}'
{"mistral/tests/unit/engine/test_with_items.py":[{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"e8b73f77265d5d80001ad1bc5b55e2da5fd14a17","unresolved":false,"context_lines":[{"line_number":789,"context_line":"          tasks:"},{"line_number":790,"context_line":"            task1:"},{"line_number":791,"context_line":"              with-items: i in [1, 2, 3]"},{"line_number":792,"context_line":"              action: std.fail"},{"line_number":793,"context_line":"              retry:"},{"line_number":794,"context_line":"                count: 3"},{"line_number":795,"context_line":"                delay: 2"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_f95e7744","line":792,"updated":"2015-08-17 23:03:28.000000000","message":"Soft: Instead of std.fail, why not use std.echo and then mock with side_effects to raise Exceptions (look at the rerun unit tests)? That way we don\u0027t need to do an unnecessary on-error task2 here.","commit_id":"1dbc45e674109ffe353ad42e9e4ad72294f00fe4"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"53b2943672b2536c3dbd66c138b20548f0f554a7","unresolved":false,"context_lines":[{"line_number":789,"context_line":"          tasks:"},{"line_number":790,"context_line":"            task1:"},{"line_number":791,"context_line":"              with-items: i in [1, 2, 3]"},{"line_number":792,"context_line":"              action: std.fail"},{"line_number":793,"context_line":"              retry:"},{"line_number":794,"context_line":"                count: 3"},{"line_number":795,"context_line":"                delay: 2"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_21f9fb80","line":792,"in_reply_to":"fa1b9901_f95e7744","updated":"2015-08-18 11:22:04.000000000","message":"Transition to task2 is necessary here because that checks  correction of with-items working (completeness of the whole task). Using mocks here is overkill, the with-items task should fail again and again and then we can see the number of executions.","commit_id":"1dbc45e674109ffe353ad42e9e4ad72294f00fe4"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"e8b73f77265d5d80001ad1bc5b55e2da5fd14a17","unresolved":false,"context_lines":[{"line_number":792,"context_line":"              action: std.fail"},{"line_number":793,"context_line":"              retry:"},{"line_number":794,"context_line":"                count: 3"},{"line_number":795,"context_line":"                delay: 2"},{"line_number":796,"context_line":"              on-error: task2"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"            task2:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_d99053ef","line":795,"updated":"2015-08-17 23:03:28.000000000","message":"Soft: This increases the total test time? Why not retry with just 2 retries and 1 sec delay?","commit_id":"1dbc45e674109ffe353ad42e9e4ad72294f00fe4"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"53b2943672b2536c3dbd66c138b20548f0f554a7","unresolved":false,"context_lines":[{"line_number":792,"context_line":"              action: std.fail"},{"line_number":793,"context_line":"              retry:"},{"line_number":794,"context_line":"                count: 3"},{"line_number":795,"context_line":"                delay: 2"},{"line_number":796,"context_line":"              on-error: task2"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"            task2:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_41f66f90","line":795,"in_reply_to":"fa1b9901_d99053ef","updated":"2015-08-18 11:22:04.000000000","message":"ok","commit_id":"1dbc45e674109ffe353ad42e9e4ad72294f00fe4"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"e8b73f77265d5d80001ad1bc5b55e2da5fd14a17","unresolved":false,"context_lines":[{"line_number":830,"context_line":"          tasks:"},{"line_number":831,"context_line":"            task1:"},{"line_number":832,"context_line":"              with-items: i in [1, 2, 3, 4]"},{"line_number":833,"context_line":"              action: std.fail"},{"line_number":834,"context_line":"              retry:"},{"line_number":835,"context_line":"                count: 3"},{"line_number":836,"context_line":"                delay: 2"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_d955b31d","line":833,"updated":"2015-08-17 23:03:28.000000000","message":"Similar comments above.","commit_id":"1dbc45e674109ffe353ad42e9e4ad72294f00fe4"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"e8b73f77265d5d80001ad1bc5b55e2da5fd14a17","unresolved":false,"context_lines":[{"line_number":833,"context_line":"              action: std.fail"},{"line_number":834,"context_line":"              retry:"},{"line_number":835,"context_line":"                count: 3"},{"line_number":836,"context_line":"                delay: 2"},{"line_number":837,"context_line":"              concurrency: 1"},{"line_number":838,"context_line":"              on-error: task2"},{"line_number":839,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_393b8fed","line":836,"updated":"2015-08-17 23:03:28.000000000","message":"Similar comments above.","commit_id":"1dbc45e674109ffe353ad42e9e4ad72294f00fe4"}],"mistral/workflow/with_items.py":[{"author":{"_account_id":15881,"name":"Limor Stotland","email":"limor.bortman@nokia.com","username":"LimorStotlamd"},"change_message_id":"28d98d114fc32b59bb8984845348eaef11bfd41d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    :return: a list of numbers."},{"line_number":60,"context_line":"    \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    return sorted("},{"line_number":63,"context_line":"        set(["},{"line_number":64,"context_line":"            ex.runtime_context[\u0027with_items_index\u0027]"},{"line_number":65,"context_line":"            for ex in unaccepted_executions"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_5a269517","line":62,"updated":"2015-08-17 10:38:12.000000000","message":"I think all answer list should be sorted. good job :-)","commit_id":"f997416344b855b1b91055a64add2dc03edf2435"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"04ff40ad62d8e4449c092269f41df9945dad40f7","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            ex.runtime_context[\u0027with_items_index\u0027]"},{"line_number":74,"context_line":"            for ex in unaccepted_executions"},{"line_number":75,"context_line":"        ])"},{"line_number":76,"context_line":"    )"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"def _get_unaccepted_act_exs(task_ex):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_53739015","line":76,"updated":"2015-08-18 18:54:26.000000000","message":"Soft: I thought set already sort the list.\n\n\u003e\u003e\u003e set([3, 1, 7, 5, 4, 4])\n\nset([1, 3, 4, 5, 7])","commit_id":"1f9b548eab5e497f6814c19f6cc1379f4a371bf4"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"87872208fb136b7692f4605409fb3b32d056834a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            ex.runtime_context[\u0027with_items_index\u0027]"},{"line_number":74,"context_line":"            for ex in unaccepted_executions"},{"line_number":75,"context_line":"        ])"},{"line_number":76,"context_line":"    )"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"def _get_unaccepted_act_exs(task_ex):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_bec09ae1","line":76,"in_reply_to":"fa1b9901_53739015","updated":"2015-08-19 08:43:48.000000000","message":"No, it is not. set doesn\u0027t guaratee the right order of elements  (like in dicts): \n\n \u003e\u003e\u003e set([20, 500])\n\n set([500, 20])","commit_id":"1f9b548eab5e497f6814c19f6cc1379f4a371bf4"}]}
