)]}'
{"mistral/api/controllers/v2/execution.py":[{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"46804c4bde58069234322fe22984cad4f394a51e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        new_description \u003d wf_ex.description"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        msg \u003d (wf_ex.state_info"},{"line_number":131,"context_line":"               if not isinstance(wf_ex.state_info, wtypes.UnsetType)"},{"line_number":132,"context_line":"               else None)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # Currently we can change only state or description."}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_773d4cba","line":131,"updated":"2015-09-03 09:00:19.000000000","message":"We can do it simplier: \n\n  msg \u003d wf_ex.state_info if wf.ex.state_info else None\n\nWSME type UnsetType returns False in checking it against bool: \nhttps://github.com/stackforge/wsme/blob/master/wsme/types.py#L319-L323","commit_id":"e517a30983cedf820a956b278ed1380b1456b1f2"}],"mistral/exceptions.py":[{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"46804c4bde58069234322fe22984cad4f394a51e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \u0027%d: %s\u0027 % (self.http_code, self.message))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class DBError(MistralException):"},{"line_number":50,"context_line":"    http_code \u003d 400"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_77922ca1","line":49,"updated":"2015-09-03 09:00:19.000000000","message":"For what purpose this exception is added? I don\u0027t see any case when it is raised (except in test). For testing we could use any other exception, say, DBException. Btw, what is the difference between that?","commit_id":"e517a30983cedf820a956b278ed1380b1456b1f2"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"e4497613667df6a7925e0d65361f1e794cbd8195","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \u0027%d: %s\u0027 % (self.http_code, self.message))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class DBError(MistralException):"},{"line_number":50,"context_line":"    http_code \u003d 400"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_9d32550f","line":49,"in_reply_to":"da20952f_49197187","updated":"2015-09-04 04:54:39.000000000","message":"Ok, the only thing I don\u0027t understand is where does DBError come from in the first place?  Does it get thrown from SQLAlchemy?","commit_id":"e517a30983cedf820a956b278ed1380b1456b1f2"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"3e8d68e2e11edf3d3ba95e340a710a4a617c2293","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \u0027%d: %s\u0027 % (self.http_code, self.message))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class DBError(MistralException):"},{"line_number":50,"context_line":"    http_code \u003d 400"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_49197187","line":49,"in_reply_to":"da20952f_77922ca1","updated":"2015-09-03 18:36:30.000000000","message":"When I update an execution to state ERROR for example, the engine client to stop the workflow return an exception of type DBError (due to the state_info being converted to a dict when it\u0027s unset).  The wrap_messaging_exception throws a different error because it cannot find DBError in the exceptions module @ https://github.com/openstack/mistral/blob/master/mistral/engine/rpc.py#L246. I don\u0027t know what is the difference between this and DBException to be honest and that\u0027s why I didn\u0027t delete DBException.","commit_id":"e517a30983cedf820a956b278ed1380b1456b1f2"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"676ecf560f23c5fee8050f7450e99ea3281dd936","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \u0027%d: %s\u0027 % (self.http_code, self.message))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class DBError(MistralException):"},{"line_number":50,"context_line":"    http_code \u003d 400"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_cb48035f","line":49,"in_reply_to":"da20952f_9d19f58a","updated":"2015-09-04 05:56:05.000000000","message":"Ooh, I see. I think we need to fix our exception wrapping mechanism because it requires that exceptions from underlying modules exist in mistral/exceptions. Which is wrong, IMO. My suggestion is to let this patch in with Winson\u0027s change. But I\u0027d really ask you to leave a good TODO comment here (and maybe even file a bug).","commit_id":"e517a30983cedf820a956b278ed1380b1456b1f2"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"e4f59772a4acb199db7208e77fe4a0a8a895aafa","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \u0027%d: %s\u0027 % (self.http_code, self.message))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class DBError(MistralException):"},{"line_number":50,"context_line":"    http_code \u003d 400"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_9d19f58a","line":49,"in_reply_to":"da20952f_9d32550f","updated":"2015-09-04 04:56:37.000000000","message":"https://github.com/openstack/oslo.db/blob/d5f390f55c8e87b10f954dae3d480362c351e5ca/oslo_db/exception.py#L51","commit_id":"e517a30983cedf820a956b278ed1380b1456b1f2"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"fcb7929214baa71586376dadca187cfea329b12c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \u0027%d: %s\u0027 % (self.http_code, self.message))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class DBError(MistralException):"},{"line_number":50,"context_line":"    http_code \u003d 400"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_e06961fa","line":49,"in_reply_to":"da20952f_cb48035f","updated":"2015-09-04 09:04:42.000000000","message":"Winson, have you ever seen that bug? https://bugs.launchpad.net/mistral/+bug/1460669\n\nThat\u0027s why wrap_messaging_exception can\u0027t see that exception.","commit_id":"e517a30983cedf820a956b278ed1380b1456b1f2"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"71c0fa7ea9caf1ab8eb7ea83d871c9deac2bc533","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \u0027%d: %s\u0027 % (self.http_code, self.message))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class DBError(MistralException):"},{"line_number":50,"context_line":"    http_code \u003d 400"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_93530b16","line":49,"in_reply_to":"da20952f_e06961fa","updated":"2015-09-04 17:48:00.000000000","message":"That makes sense. But the 1460669 bug is not allowing problems to bubble up.  I can probably remove the DBError, fix the state_info problem, and let 1460669 resolve the wrap_messaging_exception problem here.","commit_id":"e517a30983cedf820a956b278ed1380b1456b1f2"}]}
