)]}'
{"mistral/tests/unit/engine/test_execution_fields_size_limitation.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"25dfbac2dce3f40b7efd4b114fb1dbc5f1ca5857","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        task_ex \u003d self._assert_single_item(wf_ex.task_executions, name\u003d\u0027task1\u0027)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        self.assertEqual("},{"line_number":179,"context_line":"            \"Size of \u0027published\u0027 is 1KB which exceeds the limit of 0KB\","},{"line_number":180,"context_line":"            task_ex.state_info"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_1590b8eb","line":179,"updated":"2015-09-21 16:44:59.000000000","message":"I\u0027m not quite sure I understand the logic of this test. When I\u0027m looking at it (especially \u00270KB\u0027) it seems like we have another bug with \u0027published\u0027 field capacity.\n\nMy suggestions:\n * If we really have this bug, let\u0027s fix it. Otherwise, we\u0027re just ignoring it (and actually hiding).\n * I\u0027d prefer to use a mock that emulates an error in a YAQL expression. Otherwise, this test becomes dependent on a behavior from a completely different architectural layer: once we change something in DB layer the test may stop passing.\n\nMakes sense?","commit_id":"bf684b6adc93ff44f94cb6b19175bd6fde3df0a8"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d21f3abdeafb1394e759b8cbb56039aed16ddcab","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        task_ex \u003d self._assert_single_item(wf_ex.task_executions, name\u003d\u0027task1\u0027)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        self.assertEqual("},{"line_number":179,"context_line":"            \"Size of \u0027published\u0027 is 1KB which exceeds the limit of 0KB\","},{"line_number":180,"context_line":"            task_ex.state_info"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_cc42fd0e","line":179,"in_reply_to":"9a1a9d01_b43367f5","updated":"2015-10-01 06:58:53.000000000","message":"The only thing I was really asking is not to hide a potential problem. In my very strong opinion, it\u0027s counter-productive to keep building the system based on false premises which, in this case, the message that I stuck to so much. At least we could file a bug like\nhttps://bugs.launchpad.net/mistral/+bug/1501612\njust not to forget the problem and keep moving forward.\n\nWhenever I review something and I see that we ignore already existing pretty obvious problems I don\u0027t even want to validate the patch itself: it\u0027s built on a fragile basement.\n\nMoving forward, please leave TODOs and file bugs if there\u0027s no possibility to fix something bad that you see in the code right away.","commit_id":"bf684b6adc93ff44f94cb6b19175bd6fde3df0a8"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"a9a17d250590591b4bd30f6ac726da6b545cde47","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        task_ex \u003d self._assert_single_item(wf_ex.task_executions, name\u003d\u0027task1\u0027)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        self.assertEqual("},{"line_number":179,"context_line":"            \"Size of \u0027published\u0027 is 1KB which exceeds the limit of 0KB\","},{"line_number":180,"context_line":"            task_ex.state_info"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_b2c840a9","line":179,"in_reply_to":"9a1a9d01_cc42fd0e","updated":"2015-10-01 08:02:52.000000000","message":"Winson, it\u0027s not the first time when I want to apologize. The reason I was arguing with you is because I didn\u0027t really look at this test carefully and misunderstood its meaning. Specifically, I missed that part that this exception message is intentionally set up for this exact test.\n\nSo, my apologies again. I\u0027ll try to be more careful next time. Your patch is totally fine to me.","commit_id":"bf684b6adc93ff44f94cb6b19175bd6fde3df0a8"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"b5523d08939c05ebe870229c06857e4c47ef09ef","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        task_ex \u003d self._assert_single_item(wf_ex.task_executions, name\u003d\u0027task1\u0027)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        self.assertEqual("},{"line_number":179,"context_line":"            \"Size of \u0027published\u0027 is 1KB which exceeds the limit of 0KB\","},{"line_number":180,"context_line":"            task_ex.state_info"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_b43367f5","line":179,"in_reply_to":"9a1a9d01_fe66b5b9","updated":"2015-09-30 16:54:31.000000000","message":"Renat, This test is already here before the patch. I\u0027m not trying to add this test or address whatever this is testing. I\u0027m just fixing this test as a result of the bug I\u0027m fixing which is if there\u0027s error during processing of published variables, the task should be in an ERROR state. I\u0027m a bit frustrated here. I\u0027m waiting for a response on this patch for a week and the blocker has little to do with what I\u0027m trying to fix.","commit_id":"bf684b6adc93ff44f94cb6b19175bd6fde3df0a8"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"460e0f5f3fc5c8ebc80fcc6e4734ca809ab274ee","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        task_ex \u003d self._assert_single_item(wf_ex.task_executions, name\u003d\u0027task1\u0027)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        self.assertEqual("},{"line_number":179,"context_line":"            \"Size of \u0027published\u0027 is 1KB which exceeds the limit of 0KB\","},{"line_number":180,"context_line":"            task_ex.state_info"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_953fe8d5","line":179,"in_reply_to":"ba15a1d1_1590b8eb","updated":"2015-09-21 16:45:50.000000000","message":"Ok, I just realized that my second suggestion is already implemented in test_task_publish.py. Ignore it.","commit_id":"bf684b6adc93ff44f94cb6b19175bd6fde3df0a8"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b831a17171f3229fd1a2d38f9a7775b7d88d9cb3","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        task_ex \u003d self._assert_single_item(wf_ex.task_executions, name\u003d\u0027task1\u0027)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        self.assertEqual("},{"line_number":179,"context_line":"            \"Size of \u0027published\u0027 is 1KB which exceeds the limit of 0KB\","},{"line_number":180,"context_line":"            task_ex.state_info"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_fe66b5b9","line":179,"in_reply_to":"ba15a1d1_707b3f7c","updated":"2015-09-30 08:41:43.000000000","message":"I understand what you\u0027re saying about bubbling exceptions etc.\n\nWhat I\u0027m asking is:\nLook at the phrase \"Size of \u0027published\u0027 is 1KB which exceeds the limit of 0KB\". Does it really look to you a legitimate exception message? To me it doesn\u0027t make any sense because it says we have a zero KB limitation for this field. I would understand it if it said \"5KB\", \"10MB\" or some other meaningful number. If so, I don\u0027t understand why you are building a test based on this buggy behavior instead of filing a bug, making TODOs etc. in order to address the problem?\n\nI\u0027d be glad to know what I am missing.","commit_id":"bf684b6adc93ff44f94cb6b19175bd6fde3df0a8"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"5640ec73c8bef7502947854d1bf8e38a9ff16663","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        task_ex \u003d self._assert_single_item(wf_ex.task_executions, name\u003d\u0027task1\u0027)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        self.assertEqual("},{"line_number":179,"context_line":"            \"Size of \u0027published\u0027 is 1KB which exceeds the limit of 0KB\","},{"line_number":180,"context_line":"            task_ex.state_info"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_707b3f7c","line":179,"in_reply_to":"ba15a1d1_953fe8d5","updated":"2015-09-21 17:39:43.000000000","message":"I have to fix this test because previously when the size limit error occur on updating the publish field, the exception is bubbled up and the WF state is updated to ERROR. The task state is still in RUNNING though.  But now with the fix, when publish vars fails, the exception is caught and the task state is set to ERROR. we cannot re-raise the exception here because the DB transaction will rollback the task state to RUNNING. but the WF execution will detect that the task failed and write a different exception message in state_info.","commit_id":"bf684b6adc93ff44f94cb6b19175bd6fde3df0a8"}]}
