)]}'
{"mistral/engine/rpc.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"32ebc849f0262cbcc23e9921f96b3f4f6c5ed1a0","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            return method(*args, **kwargs)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        except client.RemoteError as e:"},{"line_number":252,"context_line":"            if hasattr(exc, e.exc_type):"},{"line_number":253,"context_line":"                exc_cls \u003d getattr(exc, e.exc_type)"},{"line_number":254,"context_line":"                raise exc_cls(e.value)"},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_ba5f7b74","line":252,"updated":"2015-09-21 16:28:07.000000000","message":"Can we have just one \u0027except\u0027 clause instead of two?","commit_id":"d6d2757d9cb8415b2725929e7550af14f7473253"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"f6bcb38ad3bea9ba621e1f0716d471cd52a3287b","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            return method(*args, **kwargs)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        except client.RemoteError as e:"},{"line_number":252,"context_line":"            if hasattr(exc, e.exc_type):"},{"line_number":253,"context_line":"                exc_cls \u003d getattr(exc, e.exc_type)"},{"line_number":254,"context_line":"                raise exc_cls(e.value)"},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_f2873e10","line":252,"in_reply_to":"ba15a1d1_ba5f7b74","updated":"2015-09-22 06:53:16.000000000","message":"I think no. It is needed to keep at least one \u0027except\u0027 clause for client.RemoteError because it is more specific and has exc_type attribute.","commit_id":"d6d2757d9cb8415b2725929e7550af14f7473253"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"32ebc849f0262cbcc23e9921f96b3f4f6c5ed1a0","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"            _wrap_exception_and_reraise(e)"},{"line_number":257,"context_line":"        except Exception as e:"},{"line_number":258,"context_line":"            _wrap_exception_and_reraise(e)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    return decorator"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_1af9c74d","line":258,"updated":"2015-09-21 16:28:07.000000000","message":"In case of \u0027Exception\u0027 is it possible to get an exception that belongs to mistral.exceptions as well?\n\nNot sure I understand the logic here.","commit_id":"d6d2757d9cb8415b2725929e7550af14f7473253"}],"mistral/tests/unit/engine/test_default_engine.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"1b191ebe44b34769b1db942430396bda847128a4","unresolved":false,"context_lines":[{"line_number":444,"context_line":"    def test_engine_client_remote_error_arbitrary(self):"},{"line_number":445,"context_line":"        mocked \u003d mock.Mock()"},{"line_number":446,"context_line":"        mocked.call.side_effect \u003d KeyError(\u0027wrong key\u0027)"},{"line_number":447,"context_line":"        self.engine_client._client \u003d mocked"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        exception \u003d self.assertRaises("},{"line_number":450,"context_line":"            exc.MistralException,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_ef4e9795","line":447,"updated":"2015-09-21 16:15:12.000000000","message":"@mock.patch(\u0027XXX\u0027, side_effect\u003dXXX)","commit_id":"d6d2757d9cb8415b2725929e7550af14f7473253"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"32ebc849f0262cbcc23e9921f96b3f4f6c5ed1a0","unresolved":false,"context_lines":[{"line_number":444,"context_line":"    def test_engine_client_remote_error_arbitrary(self):"},{"line_number":445,"context_line":"        mocked \u003d mock.Mock()"},{"line_number":446,"context_line":"        mocked.call.side_effect \u003d KeyError(\u0027wrong key\u0027)"},{"line_number":447,"context_line":"        self.engine_client._client \u003d mocked"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        exception \u003d self.assertRaises("},{"line_number":450,"context_line":"            exc.MistralException,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_dabeefd3","line":447,"in_reply_to":"ba15a1d1_ef4e9795","updated":"2015-09-21 16:28:07.000000000","message":"I didn\u0027t check that myself but my assumption is that decorator won\u0027t work here because we\u0027re patching an object, not a function or method.","commit_id":"d6d2757d9cb8415b2725929e7550af14f7473253"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"fc2b570ea8fec816515ccbda878931b51f83ed75","unresolved":false,"context_lines":[{"line_number":444,"context_line":"    def test_engine_client_remote_error_arbitrary(self):"},{"line_number":445,"context_line":"        mocked \u003d mock.Mock()"},{"line_number":446,"context_line":"        mocked.call.side_effect \u003d KeyError(\u0027wrong key\u0027)"},{"line_number":447,"context_line":"        self.engine_client._client \u003d mocked"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        exception \u003d self.assertRaises("},{"line_number":450,"context_line":"            exc.MistralException,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_72e7ae12","line":447,"in_reply_to":"ba15a1d1_ef4e9795","updated":"2015-09-22 06:50:27.000000000","message":"We can\u0027t apply this decorator to the object in self, e.g to\n\n  self.engine_client","commit_id":"d6d2757d9cb8415b2725929e7550af14f7473253"}]}
