)]}'
{"mistral/tests/unit/services/test_workbook_service.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"bd95662614008ffb8c5635c31e08533e1217b7d6","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        self.assertEqual(\u0027concat\u0027, action_spec.get_name())"},{"line_number":195,"context_line":"        self.assertEqual(\u0027std.echo\u0027, action_spec.get_base())"},{"line_number":196,"context_line":"        self.assertEqual(ACTION_DEFINITION, action_db.definition)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        db_wfs \u003d db_api.get_workflow_definitions()"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_ab3999f4","line":196,"updated":"2015-10-12 07:30:42.000000000","message":"It\u0027s a valid test but it\u0027s not enough. Please add more scenarios including a scenario where you have both actions and workflows within a workbook and make sure we\u0027ll have correct definitions for all of them after the workbook gets loaded.","commit_id":"7792177bd2e0f928291c9274c2b2d6988e330cd7"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"a4a548801f1a7e3a13e9346dc6b9ad4d4ec381b7","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        self.assertEqual(\u0027concat\u0027, action_spec.get_name())"},{"line_number":195,"context_line":"        self.assertEqual(\u0027std.echo\u0027, action_spec.get_base())"},{"line_number":196,"context_line":"        self.assertEqual(ACTION_DEFINITION, action_db.definition)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        db_wfs \u003d db_api.get_workflow_definitions()"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_fd619812","line":196,"in_reply_to":"7a2fa921_ab3999f4","updated":"2015-10-12 08:06:19.000000000","message":"Renat, current test loads a workbook containing workflows and actions as well. The test checks workflow definitions and action ones also.","commit_id":"7792177bd2e0f928291c9274c2b2d6988e330cd7"}],"mistral/workbook/parser.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"bd95662614008ffb8c5635c31e08533e1217b7d6","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"def get_action_definition(wb_def, action_name):"},{"line_number":162,"context_line":"    action_def \u003d []"},{"line_number":163,"context_line":"    action_name \u003d action_name + \":\""},{"line_number":164,"context_line":"    io \u003d six.StringIO(wb_def[wb_def.index(\"actions:\"):])"},{"line_number":165,"context_line":"    io.readline()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_2ba90925","line":162,"updated":"2015-10-12 07:30:42.000000000","message":"It looks ok. However, I would suggest you refactor these two methods to reduce duplication. You can extract all the logic into a separate method that works for both actions and workflows and make these two existing methods use it.","commit_id":"7792177bd2e0f928291c9274c2b2d6988e330cd7"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"a4a548801f1a7e3a13e9346dc6b9ad4d4ec381b7","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"def get_action_definition(wb_def, action_name):"},{"line_number":162,"context_line":"    action_def \u003d []"},{"line_number":163,"context_line":"    action_name \u003d action_name + \":\""},{"line_number":164,"context_line":"    io \u003d six.StringIO(wb_def[wb_def.index(\"actions:\"):])"},{"line_number":165,"context_line":"    io.readline()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_1d3574f6","line":162,"in_reply_to":"7a2fa921_2ba90925","updated":"2015-10-12 08:06:19.000000000","message":"absolutely agree. Only need to add one more argument for definition marker.","commit_id":"7792177bd2e0f928291c9274c2b2d6988e330cd7"}]}
