)]}'
{"mistral/actions/std_actions.py":[{"author":{"_account_id":9432,"name":"Dmitri Zimine","email":"dz@stackstorm.com","username":"dzimine"},"change_message_id":"d56e15bf0e27ea6a0553e8ee748de5e5b772d125","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        return ssh_utils.execute_command"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def __init__(self, cmd, host, username,"},{"line_number":334,"context_line":"                 password\u003dNone, private_key_name\u003dNone):"},{"line_number":335,"context_line":"        self.cmd \u003d cmd"},{"line_number":336,"context_line":"        self.host \u003d host"},{"line_number":337,"context_line":"        self.username \u003d username"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_b458cefb","line":334,"updated":"2015-10-20 04:48:36.000000000","message":"suggest _file or _filename instead of _name to avoid confusion (e.g. my_key.pem, which is name?)","commit_id":"edf1959c75c8e863d276cacf04809c7fa31c68fe"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"55872d5c46e9c08063598d09ecaffe5f5c54b66e","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        return ssh_utils.execute_command"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def __init__(self, cmd, host, username,"},{"line_number":334,"context_line":"                 password\u003dNone, private_key_name\u003dNone):"},{"line_number":335,"context_line":"        self.cmd \u003d cmd"},{"line_number":336,"context_line":"        self.host \u003d host"},{"line_number":337,"context_line":"        self.username \u003d username"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_bfb41ef2","line":334,"in_reply_to":"3a29b11f_5dde3d6e","updated":"2015-10-20 10:27:39.000000000","message":"ok, makes sense.","commit_id":"edf1959c75c8e863d276cacf04809c7fa31c68fe"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"5b6a11ff81a97a6f015f6c6b602a0e9c0b80b68d","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        return ssh_utils.execute_command"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def __init__(self, cmd, host, username,"},{"line_number":334,"context_line":"                 password\u003dNone, private_key_name\u003dNone):"},{"line_number":335,"context_line":"        self.cmd \u003d cmd"},{"line_number":336,"context_line":"        self.host \u003d host"},{"line_number":337,"context_line":"        self.username \u003d username"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_5dde3d6e","line":334,"in_reply_to":"3a29b11f_b458cefb","updated":"2015-10-20 06:58:27.000000000","message":"agree","commit_id":"edf1959c75c8e863d276cacf04809c7fa31c68fe"}],"mistral/utils/__init__.py":[{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"ab119fd5fc41e8484f2cdcd491bf064917202287","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            )"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"def save_text_to(text, file_path, overwrite\u003dFalse):"},{"line_number":286,"context_line":"    if os.path.exists(file_path) and not overwrite:"},{"line_number":287,"context_line":"        raise exc.DataAccessException("},{"line_number":288,"context_line":"            \"Cannot save data to file. File %s already exists.\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_9e2104fe","line":285,"updated":"2015-10-20 21:35:57.000000000","message":"I only see this function used once in unit tests. Why a util function is needed?  Also, why not just return the content of the file instead of writing it to a variable passed by ref?","commit_id":"8a59a3fa98daabda0fd1c5c50b8bc92d0654083d"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"f64838c94975da7de840ae3076d349a7e4b2c30b","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            )"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"def save_text_to(text, file_path, overwrite\u003dFalse):"},{"line_number":286,"context_line":"    if os.path.exists(file_path) and not overwrite:"},{"line_number":287,"context_line":"        raise exc.DataAccessException("},{"line_number":288,"context_line":"            \"Cannot save data to file. File %s already exists.\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_f946014e","line":285,"in_reply_to":"3a29b11f_9e2104fe","updated":"2015-10-21 08:50:33.000000000","message":"IMO, this function could potentially be useful in future. Also, the content of this file is passed as an argument, so, again, it is not necessary to return it.","commit_id":"8a59a3fa98daabda0fd1c5c50b8bc92d0654083d"}],"mistral/utils/ssh_utils.py":[{"author":{"_account_id":9432,"name":"Dmitri Zimine","email":"dz@stackstorm.com","username":"dzimine"},"change_message_id":"d56e15bf0e27ea6a0553e8ee748de5e5b772d125","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import paramiko"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"KEY_PATH \u003d path.expanduser(\"~/.ssh/\")"},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_f42c064c","line":25,"updated":"2015-10-20 04:48:36.000000000","message":"so the \"home\" is the one of the user under which the service is running, right? probably needs better explanation in the .rst","commit_id":"edf1959c75c8e863d276cacf04809c7fa31c68fe"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"55872d5c46e9c08063598d09ecaffe5f5c54b66e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import paramiko"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"KEY_PATH \u003d path.expanduser(\"~/.ssh/\")"},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_ffba96e0","line":25,"in_reply_to":"3a29b11f_f42c064c","updated":"2015-10-20 10:27:39.000000000","message":"Done","commit_id":"edf1959c75c8e863d276cacf04809c7fa31c68fe"},{"author":{"_account_id":9432,"name":"Dmitri Zimine","email":"dz@stackstorm.com","username":"dzimine"},"change_message_id":"d56e15bf0e27ea6a0553e8ee748de5e5b772d125","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def _to_paramiko_private_key(private_key_name, password):"},{"line_number":40,"context_line":"    private_key_path \u003d KEY_PATH + private_key_name"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    return paramiko.RSAKey("},{"line_number":43,"context_line":"        filename\u003dprivate_key_path,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_54685a87","line":40,"updated":"2015-10-20 04:48:36.000000000","message":"may be it\u0027s prudent to check private_key_name for having no relative paths to not do things like like ../../../tmp/my_bad_key.pem.","commit_id":"edf1959c75c8e863d276cacf04809c7fa31c68fe"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"55872d5c46e9c08063598d09ecaffe5f5c54b66e","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def _to_paramiko_private_key(private_key_name, password):"},{"line_number":40,"context_line":"    private_key_path \u003d KEY_PATH + private_key_name"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    return paramiko.RSAKey("},{"line_number":43,"context_line":"        filename\u003dprivate_key_path,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_5fedcaed","line":40,"in_reply_to":"3a29b11f_54685a87","updated":"2015-10-20 10:27:39.000000000","message":"Done","commit_id":"edf1959c75c8e863d276cacf04809c7fa31c68fe"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"ab119fd5fc41e8484f2cdcd491bf064917202287","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    return result"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def _to_paramiko_private_key(private_key_filename, password):"},{"line_number":42,"context_line":"    if \u0027../\u0027 in private_key_filename or \u0027..\\\\\u0027 in private_key_filename:"},{"line_number":43,"context_line":"        raise exc.DataAccessException("},{"line_number":44,"context_line":"            \"Private key filename must not contain \u0027..\u0027. \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_be73a014","line":41,"updated":"2015-10-20 21:35:57.000000000","message":"I would like to see some unit tests that detect exceptions.","commit_id":"8a59a3fa98daabda0fd1c5c50b8bc92d0654083d"}]}
