)]}'
{"mistral/cmd/launch.py":[{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"f89bde6a3a140e469ad91c9b07c961cebc35ae15","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # Sleep forever to have wait() working."},{"line_number":83,"context_line":"    while True:"},{"line_number":84,"context_line":"        time.sleep(604800)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"def launch_engine(transport):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_542d70fc","line":84,"updated":"2015-11-11 16:47:09.000000000","message":"so, AFAIU, it makes this thread sleep for about 604800 / 3600 \u003d 168 hours. Is this mean that mistral should work just for 168 / 24 \u003d 7 days? And then it exits? I don\u0027t think it is the right solution for that.","commit_id":"1089fd26c5d634706649a45ee3fbcf023c6e7927"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"abb50d7abd19bdc36cae23dfb91ddac6ef47c030","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # Sleep forever to have wait() working."},{"line_number":83,"context_line":"    while True:"},{"line_number":84,"context_line":"        time.sleep(604800)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"def launch_engine(transport):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_65dc6973","line":84,"in_reply_to":"da85f559_542d70fc","updated":"2015-11-12 01:03:09.000000000","message":"Nikolay, the sleep is wrapped inside while, and I didn\u0027t make it sleep 1 sec, because I don\u0027t want to bring many thread context switching. I am not sure it\u0027s the right way to do.","commit_id":"1089fd26c5d634706649a45ee3fbcf023c6e7927"},{"author":{"_account_id":9432,"name":"Dmitri Zimine","email":"dz@stackstorm.com","username":"dzimine"},"change_message_id":"998e7d0d5aa5e4eb9a2e00cf29f26f9e51068eda","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # Sleep forever to have wait() working."},{"line_number":83,"context_line":"    while True:"},{"line_number":84,"context_line":"        time.sleep(604800)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"def launch_engine(transport):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_6d7f7eab","line":84,"in_reply_to":"da85f559_542d70fc","updated":"2015-11-11 19:18:37.000000000","message":"but it\u0027s inside while True, right?","commit_id":"1089fd26c5d634706649a45ee3fbcf023c6e7927"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"1b0354c36beabb3d82a50b3184a5da4cd2b90600","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # Sleep forever to have wait() working."},{"line_number":83,"context_line":"    while True:"},{"line_number":84,"context_line":"        time.sleep(604800)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"def launch_engine(transport):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_3c118f04","line":84,"in_reply_to":"da85f559_65dc6973","updated":"2015-11-12 08:20:33.000000000","message":"Absolutely agree here with Winson.","commit_id":"1089fd26c5d634706649a45ee3fbcf023c6e7927"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"a64c396a3ecc05a641ae66a3565e6ff16a9ed22e","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # Sleep forever to have wait() working."},{"line_number":83,"context_line":"    while True:"},{"line_number":84,"context_line":"        time.sleep(604800)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"def launch_engine(transport):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_83187376","line":84,"in_reply_to":"da85f559_6d7f7eab","updated":"2015-11-11 19:50:13.000000000","message":"Can we follow the example at https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/rpc/server.py#L74?  modify to something like the following?  Disclaimer: I didn\u0027t try this yet.\n\n    try:\n        server.start()\n        while True:\n            eventlet.sleep(604800)\n    except (KeyboardInterrupt, SystemExit):\n        LOG.exception()\n    finally:\n        server.stop()\n        server.wait()","commit_id":"1089fd26c5d634706649a45ee3fbcf023c6e7927"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"5f173c758a6b166145c8c19ebe8ff75566fc1db2","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # Sleep forever to have wait() working."},{"line_number":83,"context_line":"    while True:"},{"line_number":84,"context_line":"        time.sleep(604800)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"def launch_engine(transport):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_08a2604b","line":84,"in_reply_to":"da85f559_6d7f7eab","updated":"2015-11-11 19:41:37.000000000","message":"right.","commit_id":"1089fd26c5d634706649a45ee3fbcf023c6e7927"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"abb50d7abd19bdc36cae23dfb91ddac6ef47c030","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # Sleep forever to have wait() working."},{"line_number":83,"context_line":"    while True:"},{"line_number":84,"context_line":"        time.sleep(604800)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"def launch_engine(transport):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_a5cc91bb","line":84,"in_reply_to":"da85f559_83187376","updated":"2015-11-12 01:03:09.000000000","message":"Hi, Winson, I will test what you suggested, thanks!","commit_id":"1089fd26c5d634706649a45ee3fbcf023c6e7927"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9bdda4ea9ae54cdd531475828a7c5398a1f07747","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        server.start()"},{"line_number":82,"context_line":"        while True:"},{"line_number":83,"context_line":"            time.sleep(604800)"},{"line_number":84,"context_line":"    except (KeyboardInterrupt, SystemExit):"},{"line_number":85,"context_line":"        pass"},{"line_number":86,"context_line":"    finally:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_b2e58cdc","line":83,"updated":"2015-11-13 05:30:26.000000000","message":"Where does this number come from? Why 604800?","commit_id":"ec28a305d91139ef5d307fa56ad289a635e37a90"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"fcfb25b55975efa2366544bd8d75ec9c2fcd3d89","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        server.start()"},{"line_number":82,"context_line":"        while True:"},{"line_number":83,"context_line":"            time.sleep(604800)"},{"line_number":84,"context_line":"    except (KeyboardInterrupt, SystemExit):"},{"line_number":85,"context_line":"        pass"},{"line_number":86,"context_line":"    finally:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_51ae94e8","line":83,"updated":"2015-11-12 19:22:04.000000000","message":"Why not use eventlet.sleep?","commit_id":"ec28a305d91139ef5d307fa56ad289a635e37a90"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"ea1e9d2e9fff69194b5de2669bf0ee80126d7af8","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        server.start()"},{"line_number":82,"context_line":"        while True:"},{"line_number":83,"context_line":"            time.sleep(604800)"},{"line_number":84,"context_line":"    except (KeyboardInterrupt, SystemExit):"},{"line_number":85,"context_line":"        pass"},{"line_number":86,"context_line":"    finally:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_dfa91d92","line":83,"in_reply_to":"da85f559_51ae94e8","updated":"2015-11-13 02:41:50.000000000","message":"Hi, Winson, the builtin time library has been monkeypatched in the beginning. time.sleep() here has the same effect to eventlet.sleep()","commit_id":"ec28a305d91139ef5d307fa56ad289a635e37a90"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"168cc1d6b11aa845a8f9a29265f88c4aaadb9785","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        server.start()"},{"line_number":82,"context_line":"        while True:"},{"line_number":83,"context_line":"            time.sleep(604800)"},{"line_number":84,"context_line":"    except (KeyboardInterrupt, SystemExit):"},{"line_number":85,"context_line":"        pass"},{"line_number":86,"context_line":"    finally:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_b2d1b9fd","line":83,"in_reply_to":"da85f559_b2e58cdc","updated":"2015-11-14 10:43:16.000000000","message":"Renat, 604800 secs equals to 7 days. I just specify an enough long time to avoid thread context switching.","commit_id":"ec28a305d91139ef5d307fa56ad289a635e37a90"}]}