)]}'
{"mistral/db/v2/sqlalchemy/api.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"19411afcd1ba07e9210996cde30a1339a4250d94","unresolved":false,"context_lines":[{"line_number":992,"context_line":""},{"line_number":993,"context_line":"    if query_filter:"},{"line_number":994,"context_line":"        try:"},{"line_number":995,"context_line":"            # Execute the UPDATE statement with the query_filter as the WHERE"},{"line_number":996,"context_line":"            specimen \u003d models.CronTrigger(id\u003dcron_trigger.id, **query_filter)"},{"line_number":997,"context_line":"            cron_trigger \u003d b.model_query("},{"line_number":998,"context_line":"                models.CronTrigger).update_on_match(specimen\u003dspecimen,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_fb11d152","line":995,"updated":"2015-11-12 10:09:20.000000000","message":"Soft: add a period (.) at the end of the comment.","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"594bfb1b8e3e37512556258814c2f9b624aa5f5d","unresolved":false,"context_lines":[{"line_number":997,"context_line":"            cron_trigger \u003d b.model_query("},{"line_number":998,"context_line":"                models.CronTrigger).update_on_match(specimen\u003dspecimen,"},{"line_number":999,"context_line":"                                                    surrogate_key\u003d\u0027id\u0027,"},{"line_number":1000,"context_line":"                                                    values\u003dvalues)"},{"line_number":1001,"context_line":"            return cron_trigger, 1"},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"        except oslo_sqlalchemy.update_match.NoRowsMatched:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_42d27b29","line":1000,"updated":"2015-11-12 00:52:03.000000000","message":"soft: please add a new line here. style guide for mistral requires a new line before a return.","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"263c81e3b83595c9528d531af0d5eff18cec47a1","unresolved":false,"context_lines":[{"line_number":997,"context_line":"            cron_trigger \u003d b.model_query("},{"line_number":998,"context_line":"                models.CronTrigger).update_on_match(specimen\u003dspecimen,"},{"line_number":999,"context_line":"                                                    surrogate_key\u003d\u0027id\u0027,"},{"line_number":1000,"context_line":"                                                    values\u003dvalues)"},{"line_number":1001,"context_line":"            return cron_trigger, 1"},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"        except oslo_sqlalchemy.update_match.NoRowsMatched:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_fb0d43e8","line":1000,"in_reply_to":"da85f559_42d27b29","updated":"2015-11-12 12:43:53.000000000","message":"Done","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"594bfb1b8e3e37512556258814c2f9b624aa5f5d","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"    if not cron_trigger:"},{"line_number":1022,"context_line":"        return create_cron_trigger(values)"},{"line_number":1023,"context_line":"    else:"},{"line_number":1024,"context_line":"        updated, updated_count \u003d update_cron_trigger(name, values)"},{"line_number":1025,"context_line":"        return updated"},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_a2dfa738","line":1024,"updated":"2015-11-12 00:52:03.000000000","message":"what happens if there is no rows match from line #1003?  this seems to return the cron_trigger object anyway.\n\nsoft: please add a new line here. style guide for mistral requires a new line before a return.","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"263c81e3b83595c9528d531af0d5eff18cec47a1","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"    if not cron_trigger:"},{"line_number":1022,"context_line":"        return create_cron_trigger(values)"},{"line_number":1023,"context_line":"    else:"},{"line_number":1024,"context_line":"        updated, updated_count \u003d update_cron_trigger(name, values)"},{"line_number":1025,"context_line":"        return updated"},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_1b85a7cd","line":1024,"in_reply_to":"da85f559_a2dfa738","updated":"2015-11-12 12:43:53.000000000","message":"1. Thanks, Winson. We are not passing a query_filter here so this will keep the previous behaviour and will return from line #1014.\n\n\n2. Done.","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"19411afcd1ba07e9210996cde30a1339a4250d94","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"    if not cron_trigger:"},{"line_number":1022,"context_line":"        return create_cron_trigger(values)"},{"line_number":1023,"context_line":"    else:"},{"line_number":1024,"context_line":"        updated, updated_count \u003d update_cron_trigger(name, values)"},{"line_number":1025,"context_line":"        return updated"},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_db996dc5","line":1024,"in_reply_to":"da85f559_a2dfa738","updated":"2015-11-12 10:09:20.000000000","message":"Soft: we could use form \"updated, _ \u003d ..\" here because we don\u0027t use updated_count","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"263c81e3b83595c9528d531af0d5eff18cec47a1","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"    if not cron_trigger:"},{"line_number":1022,"context_line":"        return create_cron_trigger(values)"},{"line_number":1023,"context_line":"    else:"},{"line_number":1024,"context_line":"        updated, updated_count \u003d update_cron_trigger(name, values)"},{"line_number":1025,"context_line":"        return updated"},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_3ba42bb8","line":1024,"in_reply_to":"da85f559_db996dc5","updated":"2015-11-12 12:43:53.000000000","message":"Done","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"19411afcd1ba07e9210996cde30a1339a4250d94","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"    if not cron_trigger:"},{"line_number":1033,"context_line":"        raise exc.NotFoundException(\"Cron trigger not found [name\u003d%s]\" % name)"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"    # Delete the cron trigger by ID and get the affected row count"},{"line_number":1036,"context_line":"    table \u003d models.CronTrigger.__table__"},{"line_number":1037,"context_line":"    result \u003d session.execute("},{"line_number":1038,"context_line":"        table.delete().where(table.c.id \u003d\u003d cron_trigger.id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_5bec9d29","line":1035,"updated":"2015-11-12 10:09:20.000000000","message":"Soft: A period at the end is missing.","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"263c81e3b83595c9528d531af0d5eff18cec47a1","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"    if not cron_trigger:"},{"line_number":1033,"context_line":"        raise exc.NotFoundException(\"Cron trigger not found [name\u003d%s]\" % name)"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"    # Delete the cron trigger by ID and get the affected row count"},{"line_number":1036,"context_line":"    table \u003d models.CronTrigger.__table__"},{"line_number":1037,"context_line":"    result \u003d session.execute("},{"line_number":1038,"context_line":"        table.delete().where(table.c.id \u003d\u003d cron_trigger.id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_c97f5513","line":1035,"in_reply_to":"da85f559_5bec9d29","updated":"2015-11-12 12:43:53.000000000","message":"Done","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"594bfb1b8e3e37512556258814c2f9b624aa5f5d","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"    table \u003d models.CronTrigger.__table__"},{"line_number":1037,"context_line":"    result \u003d session.execute("},{"line_number":1038,"context_line":"        table.delete().where(table.c.id \u003d\u003d cron_trigger.id)"},{"line_number":1039,"context_line":"    )"},{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"    return result.rowcount"},{"line_number":1042,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_c2b98bcd","line":1039,"updated":"2015-11-12 00:52:03.000000000","message":"Please explain the difference here between using session.delete and deleting this cron trigger by ID.  I\u0027m not a DB expert here and require some more explanation.  Thanks.","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"263c81e3b83595c9528d531af0d5eff18cec47a1","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"    table \u003d models.CronTrigger.__table__"},{"line_number":1037,"context_line":"    result \u003d session.execute("},{"line_number":1038,"context_line":"        table.delete().where(table.c.id \u003d\u003d cron_trigger.id)"},{"line_number":1039,"context_line":"    )"},{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"    return result.rowcount"},{"line_number":1042,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_642c5099","line":1039,"in_reply_to":"da85f559_9b5445ca","updated":"2015-11-12 12:43:53.000000000","message":"Thanks for answering, Winson.\n\nI agree it should be consistent - at least all DB delete operations should return rowcount. I would like to do it separately from this patch as this one should be backported to Liberty. Would you like me to create a BP for it?\n\nsqlachemy does not have \"delete_on_match\" like they have \"update_on_match\" so I needed to do something a bit different.","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"263c81e3b83595c9528d531af0d5eff18cec47a1","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"    table \u003d models.CronTrigger.__table__"},{"line_number":1037,"context_line":"    result \u003d session.execute("},{"line_number":1038,"context_line":"        table.delete().where(table.c.id \u003d\u003d cron_trigger.id)"},{"line_number":1039,"context_line":"    )"},{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"    return result.rowcount"},{"line_number":1042,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_a9d531e5","line":1039,"in_reply_to":"da85f559_c2b98bcd","updated":"2015-11-12 12:43:53.000000000","message":"Please read Renat\u0027s answer","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"19411afcd1ba07e9210996cde30a1339a4250d94","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"    table \u003d models.CronTrigger.__table__"},{"line_number":1037,"context_line":"    result \u003d session.execute("},{"line_number":1038,"context_line":"        table.delete().where(table.c.id \u003d\u003d cron_trigger.id)"},{"line_number":1039,"context_line":"    )"},{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"    return result.rowcount"},{"line_number":1042,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_9b5445ca","line":1039,"in_reply_to":"da85f559_c2b98bcd","updated":"2015-11-12 10:09:20.000000000","message":"Winson, it\u0027s because session.delete() doesn\u0027t return a row count, it\u0027s just how this method of sqlalchemy is designed. Session.execute() though is a convenience handle for doing regular SQL queries and it returns a row count.\n\nMy concern about this change is that it should be probably unified. I mean not only for cron triggers. As well as deleting by specimen. What do you think Moshe? I would just prefer to keep DB layer as consistent as possible.","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"5eb4203f9b9f558bc8ca82bdf7d76e5d25a50175","unresolved":false,"context_lines":[{"line_number":1034,"context_line":"        raise exc.NotFoundException(\"Cron trigger not found [name\u003d%s]\" % name)"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"    # Delete the cron trigger by ID and get the affected row count."},{"line_number":1037,"context_line":"    table \u003d models.CronTrigger.__table__"},{"line_number":1038,"context_line":"    result \u003d session.execute("},{"line_number":1039,"context_line":"        table.delete().where(table.c.id \u003d\u003d cron_trigger.id)"},{"line_number":1040,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_2b958be3","line":1037,"updated":"2015-11-16 15:18:10.000000000","message":"Why do we need such a low-level checks? I think this method will never return count \u003e 1 due to UUID uniqueness. But if the rowcount \u003c 1 it means cron-trigger is not found and exception will be raised before this check. Could you please explain that? Or maybe it will be clearer if there is negative unit-test on that (returning number differing from 1)?","commit_id":"2cc64a58236c2757a014a155193eea0f57a99fd0"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"ea12ae6d51fbbbe61cf79a154e967e6a378c02f6","unresolved":false,"context_lines":[{"line_number":1034,"context_line":"        raise exc.NotFoundException(\"Cron trigger not found [name\u003d%s]\" % name)"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"    # Delete the cron trigger by ID and get the affected row count."},{"line_number":1037,"context_line":"    table \u003d models.CronTrigger.__table__"},{"line_number":1038,"context_line":"    result \u003d session.execute("},{"line_number":1039,"context_line":"        table.delete().where(table.c.id \u003d\u003d cron_trigger.id)"},{"line_number":1040,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_d157ccc8","line":1037,"in_reply_to":"ba8a016a_2b958be3","updated":"2015-11-16 15:40:51.000000000","message":"Nikolay, the whole point here is to see if another thread/process has already deleted this trigger. We need to know that exactly. The only way to do that is to use this session.execute() method because it returns a number of updated rows unlike session.delete().","commit_id":"2cc64a58236c2757a014a155193eea0f57a99fd0"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"5b3c07ad4f1d0616367d43ced836aebdcbeb9bf7","unresolved":false,"context_lines":[{"line_number":1034,"context_line":"        raise exc.NotFoundException(\"Cron trigger not found [name\u003d%s]\" % name)"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"    # Delete the cron trigger by ID and get the affected row count."},{"line_number":1037,"context_line":"    table \u003d models.CronTrigger.__table__"},{"line_number":1038,"context_line":"    result \u003d session.execute("},{"line_number":1039,"context_line":"        table.delete().where(table.c.id \u003d\u003d cron_trigger.id)"},{"line_number":1040,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_56067221","line":1037,"in_reply_to":"ba8a016a_2b958be3","updated":"2015-11-16 15:39:26.000000000","message":"Yes, this method will not return rowcount \u003e 1 - it will always be 1 or 0.\nI am returning a number so that in the future all delete functions will return rowcount and they might return rowcount \u003e\u003d0.\n\n\nThe rowcount can be 0 - if two processes are processing the same cron trigger at the exact same time.\nBoth will do \"_get_cron_trigger\" and succeed but only one will be able to delete. One process will return 1 and the other will return 0.","commit_id":"2cc64a58236c2757a014a155193eea0f57a99fd0"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"52e96781972e5d811259c144225e6c7e17eb3b3d","unresolved":false,"context_lines":[{"line_number":1034,"context_line":"        raise exc.NotFoundException(\"Cron trigger not found [name\u003d%s]\" % name)"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"    # Delete the cron trigger by ID and get the affected row count."},{"line_number":1037,"context_line":"    table \u003d models.CronTrigger.__table__"},{"line_number":1038,"context_line":"    result \u003d session.execute("},{"line_number":1039,"context_line":"        table.delete().where(table.c.id \u003d\u003d cron_trigger.id)"},{"line_number":1040,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_d1b34c09","line":1037,"in_reply_to":"ba8a016a_d157ccc8","updated":"2015-11-16 15:42:29.000000000","message":"Yes, agree with Moshe.","commit_id":"2cc64a58236c2757a014a155193eea0f57a99fd0"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"68e4b8901c7f73c97620a67bb7fc75ddd757bfcd","unresolved":false,"context_lines":[{"line_number":1034,"context_line":"        raise exc.NotFoundException(\"Cron trigger not found [name\u003d%s]\" % name)"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"    # Delete the cron trigger by ID and get the affected row count."},{"line_number":1037,"context_line":"    table \u003d models.CronTrigger.__table__"},{"line_number":1038,"context_line":"    result \u003d session.execute("},{"line_number":1039,"context_line":"        table.delete().where(table.c.id \u003d\u003d cron_trigger.id)"},{"line_number":1040,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_fcce67b3","line":1037,"in_reply_to":"ba8a016a_d1b34c09","updated":"2015-11-16 15:55:45.000000000","message":"Yes. I see now, thanks for explanations.","commit_id":"2cc64a58236c2757a014a155193eea0f57a99fd0"}],"mistral/services/periodic.py":[{"author":{"_account_id":15881,"name":"Limor Stotland","email":"limor.bortman@nokia.com","username":"LimorStotlamd"},"change_message_id":"4efe239fbaf789cc8695bd06db4d84725489598d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                    LOG.debug(\"Starting workflow %s triggered by cron %s\","},{"line_number":57,"context_line":"                              t.workflow.name, t.name)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"                    try:"},{"line_number":60,"context_line":"                        rpc.get_engine_client().start_workflow("},{"line_number":61,"context_line":"                            t.workflow.name,"},{"line_number":62,"context_line":"                            t.workflow_input,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_251b2b1d","line":59,"updated":"2015-11-10 08:14:20.000000000","message":"pleas remove the nested try","commit_id":"e6055c788a4b3f75bdd302611a12a27915fd9cd8"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"895868cdef4098aac9bc10a167dee78681c22a00","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                    LOG.debug(\"Starting workflow %s triggered by cron %s\","},{"line_number":57,"context_line":"                              t.workflow.name, t.name)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"                    try:"},{"line_number":60,"context_line":"                        rpc.get_engine_client().start_workflow("},{"line_number":61,"context_line":"                            t.workflow.name,"},{"line_number":62,"context_line":"                            t.workflow_input,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_c5b33fe8","line":59,"in_reply_to":"da85f559_251b2b1d","updated":"2015-11-10 11:04:15.000000000","message":"Will do. Thanks!","commit_id":"e6055c788a4b3f75bdd302611a12a27915fd9cd8"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"19411afcd1ba07e9210996cde30a1339a4250d94","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"            try:"},{"line_number":50,"context_line":"                # Try to advance the cron trigger next_execution_time and"},{"line_number":51,"context_line":"                # remaining_executions if relevant"},{"line_number":52,"context_line":"                was_modified \u003d self.advance_cron_trigger(t)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"                # If cron trigger was not already modified by another engine"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_3b119904","line":51,"updated":"2015-11-12 10:09:20.000000000","message":"Soft: A period at the end.","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"263c81e3b83595c9528d531af0d5eff18cec47a1","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"            try:"},{"line_number":50,"context_line":"                # Try to advance the cron trigger next_execution_time and"},{"line_number":51,"context_line":"                # remaining_executions if relevant"},{"line_number":52,"context_line":"                was_modified \u003d self.advance_cron_trigger(t)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"                # If cron trigger was not already modified by another engine"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_247e486a","line":51,"in_reply_to":"da85f559_3b119904","updated":"2015-11-12 12:43:53.000000000","message":"Done","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"19411afcd1ba07e9210996cde30a1339a4250d94","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            try:"},{"line_number":50,"context_line":"                # Try to advance the cron trigger next_execution_time and"},{"line_number":51,"context_line":"                # remaining_executions if relevant"},{"line_number":52,"context_line":"                was_modified \u003d self.advance_cron_trigger(t)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"                # If cron trigger was not already modified by another engine"},{"line_number":55,"context_line":"                if was_modified:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_0499cd7b","line":52,"updated":"2015-11-12 10:09:20.000000000","message":"Small suggestion: let\u0027s just call it \"modified\".","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"263c81e3b83595c9528d531af0d5eff18cec47a1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            try:"},{"line_number":50,"context_line":"                # Try to advance the cron trigger next_execution_time and"},{"line_number":51,"context_line":"                # remaining_executions if relevant"},{"line_number":52,"context_line":"                was_modified \u003d self.advance_cron_trigger(t)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"                # If cron trigger was not already modified by another engine"},{"line_number":55,"context_line":"                if was_modified:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_e494c08b","line":52,"in_reply_to":"da85f559_0499cd7b","updated":"2015-11-12 12:43:53.000000000","message":"Done","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"19411afcd1ba07e9210996cde30a1339a4250d94","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                # remaining_executions if relevant"},{"line_number":52,"context_line":"                was_modified \u003d self.advance_cron_trigger(t)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"                # If cron trigger was not already modified by another engine"},{"line_number":55,"context_line":"                if was_modified:"},{"line_number":56,"context_line":"                    LOG.debug(\"Starting workflow %s triggered by cron %s\","},{"line_number":57,"context_line":"                              t.workflow.name, t.name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_899e36b7","line":54,"updated":"2015-11-12 10:09:20.000000000","message":"Soft: A period at the end.","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"263c81e3b83595c9528d531af0d5eff18cec47a1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                # remaining_executions if relevant"},{"line_number":52,"context_line":"                was_modified \u003d self.advance_cron_trigger(t)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"                # If cron trigger was not already modified by another engine"},{"line_number":55,"context_line":"                if was_modified:"},{"line_number":56,"context_line":"                    LOG.debug(\"Starting workflow %s triggered by cron %s\","},{"line_number":57,"context_line":"                              t.workflow.name, t.name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_24cc08ba","line":54,"in_reply_to":"da85f559_899e36b7","updated":"2015-11-12 12:43:53.000000000","message":"Done","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"19411afcd1ba07e9210996cde30a1339a4250d94","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                auth_ctx.set_ctx(None)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def advance_cron_trigger(self, ct):"},{"line_number":75,"context_line":"        modified_count \u003d 0"},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            # If the cron trigger is defined with limited execution count"},{"line_number":78,"context_line":"            if (ct.remaining_executions is not None"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_446cb507","line":75,"updated":"2015-11-12 10:09:20.000000000","message":"This method contains 2 DB operations: deleting a trigger and updating it. If process fails after deletion then a trigger will just disappear from DB and a WF won\u0027t be started. Let\u0027s wrap them into a transation. Is there a reason why you don\u0027t do this?","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"263c81e3b83595c9528d531af0d5eff18cec47a1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                auth_ctx.set_ctx(None)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def advance_cron_trigger(self, ct):"},{"line_number":75,"context_line":"        modified_count \u003d 0"},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            # If the cron trigger is defined with limited execution count"},{"line_number":78,"context_line":"            if (ct.remaining_executions is not None"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_4f77e59f","line":75,"in_reply_to":"da85f559_446cb507","updated":"2015-11-12 12:43:53.000000000","message":"I have followed the previous behaviour that was implemented here.\nThe update / delete were in a finally block and would have happened anyway.\n\nIf I will use a transaction on the update as well - the next and remaining will not be updated in a case of failure.","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"85da52ee9f1e4eca6e837bfb9c7e7b6ffb9639c8","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                auth_ctx.set_ctx(None)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def advance_cron_trigger(self, ct):"},{"line_number":75,"context_line":"        modified_count \u003d 0"},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            # If the cron trigger is defined with limited execution count"},{"line_number":78,"context_line":"            if (ct.remaining_executions is not None"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_0e177155","line":75,"in_reply_to":"da85f559_4f77e59f","updated":"2015-11-13 06:23:48.000000000","message":"Moshe, I just realized it\u0027s \"if else\" :)) Sorry, I overlooked it.","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"19411afcd1ba07e9210996cde30a1339a4250d94","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def advance_cron_trigger(self, ct):"},{"line_number":75,"context_line":"        modified_count \u003d 0"},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            # If the cron trigger is defined with limited execution count"},{"line_number":78,"context_line":"            if (ct.remaining_executions is not None"},{"line_number":79,"context_line":"               and ct.remaining_executions \u003e 0):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_497b6e7b","line":76,"updated":"2015-11-12 10:09:20.000000000","message":"Soft: blank line before \"try\" (and other control structures)","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"263c81e3b83595c9528d531af0d5eff18cec47a1","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def advance_cron_trigger(self, ct):"},{"line_number":75,"context_line":"        modified_count \u003d 0"},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            # If the cron trigger is defined with limited execution count"},{"line_number":78,"context_line":"            if (ct.remaining_executions is not None"},{"line_number":79,"context_line":"               and ct.remaining_executions \u003e 0):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_846b7484","line":76,"in_reply_to":"da85f559_497b6e7b","updated":"2015-11-12 12:43:53.000000000","message":"Done","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"19411afcd1ba07e9210996cde30a1339a4250d94","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def advance_cron_trigger(self, ct):"},{"line_number":75,"context_line":"        modified_count \u003d 0"},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            # If the cron trigger is defined with limited execution count"},{"line_number":78,"context_line":"            if (ct.remaining_executions is not None"},{"line_number":79,"context_line":"               and ct.remaining_executions \u003e 0):"},{"line_number":80,"context_line":"                ct.remaining_executions -\u003d 1"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_e9b82213","line":77,"updated":"2015-11-12 10:09:20.000000000","message":"Soft: a period at the end (applied to all comments in the file).","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"263c81e3b83595c9528d531af0d5eff18cec47a1","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def advance_cron_trigger(self, ct):"},{"line_number":75,"context_line":"        modified_count \u003d 0"},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            # If the cron trigger is defined with limited execution count"},{"line_number":78,"context_line":"            if (ct.remaining_executions is not None"},{"line_number":79,"context_line":"               and ct.remaining_executions \u003e 0):"},{"line_number":80,"context_line":"                ct.remaining_executions -\u003d 1"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_a466b8b8","line":77,"in_reply_to":"da85f559_e9b82213","updated":"2015-11-12 12:43:53.000000000","message":"Done","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"594bfb1b8e3e37512556258814c2f9b624aa5f5d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            # If the cron trigger is defined with limited execution count"},{"line_number":78,"context_line":"            if (ct.remaining_executions is not None"},{"line_number":79,"context_line":"               and ct.remaining_executions \u003e 0):"},{"line_number":80,"context_line":"                ct.remaining_executions -\u003d 1"},{"line_number":81,"context_line":"            # If this is the last execution"},{"line_number":82,"context_line":"            if ct.remaining_executions \u003d\u003d 0:"},{"line_number":83,"context_line":"                modified_count \u003d db_api_v2.delete_cron_trigger(ct.name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_42435bb2","line":80,"updated":"2015-11-12 00:52:03.000000000","message":"please add new line here","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"263c81e3b83595c9528d531af0d5eff18cec47a1","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            # If the cron trigger is defined with limited execution count"},{"line_number":78,"context_line":"            if (ct.remaining_executions is not None"},{"line_number":79,"context_line":"               and ct.remaining_executions \u003e 0):"},{"line_number":80,"context_line":"                ct.remaining_executions -\u003d 1"},{"line_number":81,"context_line":"            # If this is the last execution"},{"line_number":82,"context_line":"            if ct.remaining_executions \u003d\u003d 0:"},{"line_number":83,"context_line":"                modified_count \u003d db_api_v2.delete_cron_trigger(ct.name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_a41478e8","line":80,"in_reply_to":"da85f559_42435bb2","updated":"2015-11-12 12:43:53.000000000","message":"Done","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"c2ed97c4f09845fd2cbb8ab7fd746594d36bb574","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                )"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"                # Update the cron trigger with next execution details"},{"line_number":91,"context_line":"                # only if it wasn\u0027t already updated by a different engine"},{"line_number":92,"context_line":"                updated, modified_count \u003d db_api_v2.update_cron_trigger("},{"line_number":93,"context_line":"                    ct.name,"},{"line_number":94,"context_line":"                    {"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_fbd9d1f3","line":91,"updated":"2015-11-12 07:14:35.000000000","message":"Soft: cron-trigger is processed periodically in **api service**, not engine.","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"ec5b262579da3f8f6a7acd9005158023a593d395","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                )"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"                # Update the cron trigger with next execution details"},{"line_number":91,"context_line":"                # only if it wasn\u0027t already updated by a different engine"},{"line_number":92,"context_line":"                updated, modified_count \u003d db_api_v2.update_cron_trigger("},{"line_number":93,"context_line":"                    ct.name,"},{"line_number":94,"context_line":"                    {"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_b3225200","line":91,"in_reply_to":"da85f559_e4ccc08a","updated":"2015-11-13 06:16:42.000000000","message":"It actually can be both engine and api.","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"263c81e3b83595c9528d531af0d5eff18cec47a1","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                )"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"                # Update the cron trigger with next execution details"},{"line_number":91,"context_line":"                # only if it wasn\u0027t already updated by a different engine"},{"line_number":92,"context_line":"                updated, modified_count \u003d db_api_v2.update_cron_trigger("},{"line_number":93,"context_line":"                    ct.name,"},{"line_number":94,"context_line":"                    {"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_e4ccc08a","line":91,"in_reply_to":"da85f559_fbd9d1f3","updated":"2015-11-12 12:43:53.000000000","message":"Done","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"c2ed97c4f09845fd2cbb8ab7fd746594d36bb574","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                    }"},{"line_number":101,"context_line":"                )"},{"line_number":102,"context_line":"        except exc.NotFoundException as e:"},{"line_number":103,"context_line":"            # Cron trigger was probably already deleted by a different engine"},{"line_number":104,"context_line":"            LOG.debug("},{"line_number":105,"context_line":"                \"Cron trigger named \u0027%s\u0027 does not exist anymore: %s\","},{"line_number":106,"context_line":"                ct.name, str(e)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_87506c33","line":103,"updated":"2015-11-12 07:14:35.000000000","message":"Soft: cron trigger is processed periodically in **api service**, not engine.","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"ec5b262579da3f8f6a7acd9005158023a593d395","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                    }"},{"line_number":101,"context_line":"                )"},{"line_number":102,"context_line":"        except exc.NotFoundException as e:"},{"line_number":103,"context_line":"            # Cron trigger was probably already deleted by a different engine"},{"line_number":104,"context_line":"            LOG.debug("},{"line_number":105,"context_line":"                \"Cron trigger named \u0027%s\u0027 does not exist anymore: %s\","},{"line_number":106,"context_line":"                ct.name, str(e)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_13c6be16","line":103,"in_reply_to":"da85f559_44a4acb8","updated":"2015-11-13 06:16:42.000000000","message":"It actually can be both engine and api.","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"263c81e3b83595c9528d531af0d5eff18cec47a1","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                    }"},{"line_number":101,"context_line":"                )"},{"line_number":102,"context_line":"        except exc.NotFoundException as e:"},{"line_number":103,"context_line":"            # Cron trigger was probably already deleted by a different engine"},{"line_number":104,"context_line":"            LOG.debug("},{"line_number":105,"context_line":"                \"Cron trigger named \u0027%s\u0027 does not exist anymore: %s\","},{"line_number":106,"context_line":"                ct.name, str(e)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_44a4acb8","line":103,"in_reply_to":"da85f559_87506c33","updated":"2015-11-12 12:43:53.000000000","message":"Done","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"594bfb1b8e3e37512556258814c2f9b624aa5f5d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            LOG.debug("},{"line_number":105,"context_line":"                \"Cron trigger named \u0027%s\u0027 does not exist anymore: %s\","},{"line_number":106,"context_line":"                ct.name, str(e)"},{"line_number":107,"context_line":"            )"},{"line_number":108,"context_line":"        # Return True if this engine was able to modify the cron trigger in DB"},{"line_number":109,"context_line":"        return modified_count \u003e 0"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_8282a3c6","line":107,"updated":"2015-11-12 00:52:03.000000000","message":"please add new line here","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"263c81e3b83595c9528d531af0d5eff18cec47a1","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            LOG.debug("},{"line_number":105,"context_line":"                \"Cron trigger named \u0027%s\u0027 does not exist anymore: %s\","},{"line_number":106,"context_line":"                ct.name, str(e)"},{"line_number":107,"context_line":"            )"},{"line_number":108,"context_line":"        # Return True if this engine was able to modify the cron trigger in DB"},{"line_number":109,"context_line":"        return modified_count \u003e 0"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_24ade89a","line":107,"in_reply_to":"da85f559_8282a3c6","updated":"2015-11-12 12:43:53.000000000","message":"Done","commit_id":"c21ffcc9c09274acb9bdd09f7aec4aebb705acdc"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"5eb4203f9b9f558bc8ca82bdf7d76e5d25a50175","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"                # If cron trigger was not already modified by another engine."},{"line_number":55,"context_line":"                if modified:"},{"line_number":56,"context_line":"                    LOG.debug(\"Starting workflow %s triggered by cron %s\","},{"line_number":57,"context_line":"                              t.workflow.name, t.name)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"                    rpc.get_engine_client().start_workflow("}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_eb81c3fc","line":56,"updated":"2015-11-16 15:18:10.000000000","message":"please use form: \n\n  LOG.debug(\n      \"Starting workflow %s triggered by cron %s\",\n      t.workflow.name, t.name\n  )","commit_id":"2cc64a58236c2757a014a155193eea0f57a99fd0"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"5b3c07ad4f1d0616367d43ced836aebdcbeb9bf7","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"                # If cron trigger was not already modified by another engine."},{"line_number":55,"context_line":"                if modified:"},{"line_number":56,"context_line":"                    LOG.debug(\"Starting workflow %s triggered by cron %s\","},{"line_number":57,"context_line":"                              t.workflow.name, t.name)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"                    rpc.get_engine_client().start_workflow("}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_f17210ad","line":56,"in_reply_to":"ba8a016a_eb81c3fc","updated":"2015-11-16 15:39:26.000000000","message":"Done","commit_id":"2cc64a58236c2757a014a155193eea0f57a99fd0"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"5eb4203f9b9f558bc8ca82bdf7d76e5d25a50175","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                    )"},{"line_number":66,"context_line":"            except Exception as e:"},{"line_number":67,"context_line":"                # Log and continue to next cron trigger"},{"line_number":68,"context_line":"                msg \u003d \"Failed to process cron trigger %s\\n%s\" \\"},{"line_number":69,"context_line":"                      % (str(t), traceback.format_exc(e))"},{"line_number":70,"context_line":"                LOG.error(msg)"},{"line_number":71,"context_line":"            finally:"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_4b31efa1","line":68,"updated":"2015-11-16 15:18:10.000000000","message":"Soft: use parentheses instead of backslaches: \n\n  msg \u003d (\n      \"Failed to process cron trigger %s\\n%s\"\n      % (str(t), traceback.format_exc(e))\n  )","commit_id":"2cc64a58236c2757a014a155193eea0f57a99fd0"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"5b3c07ad4f1d0616367d43ced836aebdcbeb9bf7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                    )"},{"line_number":66,"context_line":"            except Exception as e:"},{"line_number":67,"context_line":"                # Log and continue to next cron trigger"},{"line_number":68,"context_line":"                msg \u003d \"Failed to process cron trigger %s\\n%s\" \\"},{"line_number":69,"context_line":"                      % (str(t), traceback.format_exc(e))"},{"line_number":70,"context_line":"                LOG.error(msg)"},{"line_number":71,"context_line":"            finally:"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_f1453017","line":68,"in_reply_to":"ba8a016a_4b31efa1","updated":"2015-11-16 15:39:26.000000000","message":"Done","commit_id":"2cc64a58236c2757a014a155193eea0f57a99fd0"}]}
