)]}'
{"mistral/tests/unit/engine/test_action_context.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"9c7fd48590967705c22c369ce8c96ad6a2ebfcfc","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            \u0027Mistral-Workflow-Execution-Id\u0027: wf_ex.id,"},{"line_number":79,"context_line":"            \u0027Mistral-Task-Id\u0027: task_ex.id,"},{"line_number":80,"context_line":"            \u0027Mistral-Action-Execution-Id\u0027: action_ex.id,"},{"line_number":81,"context_line":"            \u0027Mistral-Callback-URL\u0027: \u0027/v2/action_executions/%s\u0027 % action_ex.id"},{"line_number":82,"context_line":"        }"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        requests.request.assert_called_with("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_4c9582e2","line":81,"updated":"2015-11-16 16:51:21.000000000","message":"Hi, Nikolay, I\u0027m not sure we really need this in http headers, we already have \u0027Mistral-Action-Execution-Id\u0027, 3rd party application can construct the callback URL easily with that. \n\nAnd, another question, how the 3rd party application know the authentication info when calling back to Mistral?","commit_id":"dde634d8b9d8134685c785c012a594080bf9b05e"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"f0bcf5640c44dac6283803ad8ac8e8982706a3ae","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            \u0027Mistral-Workflow-Execution-Id\u0027: wf_ex.id,"},{"line_number":79,"context_line":"            \u0027Mistral-Task-Id\u0027: task_ex.id,"},{"line_number":80,"context_line":"            \u0027Mistral-Action-Execution-Id\u0027: action_ex.id,"},{"line_number":81,"context_line":"            \u0027Mistral-Callback-URL\u0027: \u0027/v2/action_executions/%s\u0027 % action_ex.id"},{"line_number":82,"context_line":"        }"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        requests.request.assert_called_with("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_b9a68abf","line":81,"in_reply_to":"ba8a016a_4c9582e2","updated":"2015-11-17 08:29:44.000000000","message":"Yes. 3rd party can construct this url but I think 3rd party app should not know much about mistral and it should not care about constructing callback URL. Say, what if this URL is changed? Then 3rd party has to change the url construction. In most cases 3rd party needs only this URL to provide the result.\n\nAs for auth, you are right, it is another question. Need to think and provide a solution in future.","commit_id":"dde634d8b9d8134685c785c012a594080bf9b05e"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"e8b7915e80c48ebffe7729f385bcd5631ce99998","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            \u0027Mistral-Workflow-Execution-Id\u0027: wf_ex.id,"},{"line_number":79,"context_line":"            \u0027Mistral-Task-Id\u0027: task_ex.id,"},{"line_number":80,"context_line":"            \u0027Mistral-Action-Execution-Id\u0027: action_ex.id,"},{"line_number":81,"context_line":"            \u0027Mistral-Callback-URL\u0027: \u0027/v2/action_executions/%s\u0027 % action_ex.id"},{"line_number":82,"context_line":"        }"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        requests.request.assert_called_with("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_d9c6dc48","line":81,"in_reply_to":"ba8a016a_b9a68abf","updated":"2015-11-17 14:07:39.000000000","message":"I have a suggestion for auth, you can consider using keystone trust, and I agree that it should be another thread, and deserve a blueprint for that.","commit_id":"dde634d8b9d8134685c785c012a594080bf9b05e"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"a90a4121e1644ac10710f71bd013fac6bf0bcd0c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            \u0027Mistral-Workflow-Execution-Id\u0027: wf_ex.id,"},{"line_number":79,"context_line":"            \u0027Mistral-Task-Id\u0027: task_ex.id,"},{"line_number":80,"context_line":"            \u0027Mistral-Action-Execution-Id\u0027: action_ex.id,"},{"line_number":81,"context_line":"            \u0027Mistral-Callback-URL\u0027: \u0027/v2/action_executions/%s\u0027 % action_ex.id"},{"line_number":82,"context_line":"        }"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        requests.request.assert_called_with("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_a21611ef","line":81,"in_reply_to":"ba8a016a_d9c6dc48","updated":"2015-11-18 09:46:12.000000000","message":"Yes, agree with that. Also agree with Nikolay about clients not carrying about particular urls.","commit_id":"dde634d8b9d8134685c785c012a594080bf9b05e"}]}
