)]}'
{"mistral/db/sqlalchemy/migration/alembic_migrations/versions/008_increase_size_of_state_info_column.py":[{"author":{"_account_id":8592,"name":"Anastasia Kuznetsova","email":"akuznetsova@mirantis.com","username":"nastya-kuz"},"change_message_id":"2e31fb68d33fd7c024474c547964f5c14556dec8","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Increase size of state_info column from String to Text"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Revision ID: 008"},{"line_number":19,"context_line":"Revises: 007"},{"line_number":20,"context_line":"Create Date: 2015-11-17 21:30:50.991290"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_96ab131d","line":18,"updated":"2015-11-18 08:25:06.000000000","message":"I guess, that you should change revision ID and Revises here, because this commit was made earlier https://review.openstack.org/#/c/244030/3/mistral/db/sqlalchemy/migration/alembic_migrations/versions/008_add_resource_members_v2_table.py","commit_id":"f26dcf3e510e8d1dd4f138b978ee15d1060ed609"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"8d1c56deb504512dc241fcd9a89fde4917dc9edd","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Increase size of state_info column from String to Text"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Revision ID: 008"},{"line_number":19,"context_line":"Revises: 007"},{"line_number":20,"context_line":"Create Date: 2015-11-17 21:30:50.991290"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_63c90c26","line":18,"in_reply_to":"ba8a016a_11a08d42","updated":"2015-11-18 10:32:29.000000000","message":"Lingxian, please do rebase your changes so the sequence is repaired. We should also make sure your changes won\u0027t get into stable/liberty. As a general rule: cases when we need to backport DB model changes into stable branches should be exceptional. Otherwise it would all turn into mess.","commit_id":"f26dcf3e510e8d1dd4f138b978ee15d1060ed609"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"c9f7c4f984e896b7d7572e1fe4576eee13ccbe1a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Increase size of state_info column from String to Text"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Revision ID: 008"},{"line_number":19,"context_line":"Revises: 007"},{"line_number":20,"context_line":"Create Date: 2015-11-17 21:30:50.991290"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_11a08d42","line":18,"in_reply_to":"ba8a016a_96ab131d","updated":"2015-11-18 08:52:39.000000000","message":"Hi, Anastasia, thanks for that consideration. I\u0027m ok that we could merge this first if most people think the whole change is fine, despite of the revision id. I can rebase my change, and modify accordingly","commit_id":"f26dcf3e510e8d1dd4f138b978ee15d1060ed609"}],"mistral/db/v2/sqlalchemy/models.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"475ba895586f6577183f8014f2f9372ab9219375","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    workflow_name \u003d sa.Column(sa.String(80))"},{"line_number":108,"context_line":"    spec \u003d sa.Column(st.JsonDictType())"},{"line_number":109,"context_line":"    state \u003d sa.Column(sa.String(20))"},{"line_number":110,"context_line":"    state_info \u003d sa.Column(sa.String(1024), nullable\u003dTrue)"},{"line_number":111,"context_line":"    tags \u003d sa.Column(st.JsonListType())"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    # Runtime context like iteration_no of a repeater."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_af4072a6","side":"PARENT","line":110,"updated":"2015-11-17 12:31:22.000000000","message":"I now wonder where this number came from..","commit_id":"b762b813e864f00080b736fe6a5b64d0de060080"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"5f680e55eef14f33daab7a5b2169f2b108a1a275","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        # Catch and trim Execution.state_info to always fit allocated size."},{"line_number":170,"context_line":"        cls.state_info,"},{"line_number":171,"context_line":"        \u0027set\u0027,"},{"line_number":172,"context_line":"        lambda t, v, o, i: utils.cut(v, 1020),"},{"line_number":173,"context_line":"        retval\u003dTrue"},{"line_number":174,"context_line":"    )"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_b2cbf552","side":"PARENT","line":172,"updated":"2015-11-17 12:47:28.000000000","message":"Can someone please explain why the -4 chars?","commit_id":"b762b813e864f00080b736fe6a5b64d0de060080"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"3785538983f71b9e9069d46337c6c770eba8b04b","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        # Catch and trim Execution.state_info to always fit allocated size."},{"line_number":170,"context_line":"        cls.state_info,"},{"line_number":171,"context_line":"        \u0027set\u0027,"},{"line_number":172,"context_line":"        lambda t, v, o, i: utils.cut(v, 1020),"},{"line_number":173,"context_line":"        retval\u003dTrue"},{"line_number":174,"context_line":"    )"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_603b70d2","side":"PARENT","line":172,"in_reply_to":"ba8a016a_b2cbf552","updated":"2015-11-17 15:09:35.000000000","message":"Hi,\n\nCut function will add three dots \"...\" while truncating string\nso ideally it should be -1 but because of this reason it is -4","commit_id":"b762b813e864f00080b736fe6a5b64d0de060080"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"5f680e55eef14f33daab7a5b2169f2b108a1a275","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    workflow_name \u003d sa.Column(sa.String(80))"},{"line_number":108,"context_line":"    spec \u003d sa.Column(st.JsonDictType())"},{"line_number":109,"context_line":"    state \u003d sa.Column(sa.String(20))"},{"line_number":110,"context_line":"    state_info \u003d sa.Column(sa.Text(65536), nullable\u003dTrue)"},{"line_number":111,"context_line":"    tags \u003d sa.Column(st.JsonListType())"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    # Runtime context like iteration_no of a repeater."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_7204adbf","line":110,"updated":"2015-11-17 12:47:28.000000000","message":"I would simply write sa.Text() and use the default length","commit_id":"e144527b739ef902f21f94ab28e4ea86f1cf0838"}],"mistral/tests/unit/db/v2/test_sqlalchemy_db_api.py":[{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"5f680e55eef14f33daab7a5b2169f2b108a1a275","unresolved":false,"context_lines":[{"line_number":652,"context_line":""},{"line_number":653,"context_line":"        updated \u003d db_api.update_action_execution("},{"line_number":654,"context_line":"            created.id,"},{"line_number":655,"context_line":"            {\u0027state\u0027: \u0027FAILED\u0027, \u0027state_info\u0027: \"..\" * 66560}"},{"line_number":656,"context_line":"        )"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"        self.assertEqual(\u0027FAILED\u0027, updated.state)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_527de9e5","line":655,"updated":"2015-11-17 12:47:28.000000000","message":"Can you use the state_info.type.length here instead of hard coding the length?","commit_id":"e144527b739ef902f21f94ab28e4ea86f1cf0838"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"6f282a5e4f80b69755f6f315415184515037083b","unresolved":false,"context_lines":[{"line_number":652,"context_line":""},{"line_number":653,"context_line":"        updated \u003d db_api.update_action_execution("},{"line_number":654,"context_line":"            created.id,"},{"line_number":655,"context_line":"            {\u0027state\u0027: \u0027FAILED\u0027, \u0027state_info\u0027: \"..\" * 66560}"},{"line_number":656,"context_line":"        )"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"        self.assertEqual(\u0027FAILED\u0027, updated.state)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_d9e33c04","line":655,"in_reply_to":"ba8a016a_527de9e5","updated":"2015-11-17 14:04:48.000000000","message":"I think i have to use hard coded value instead of \ncls.state_info.type.length\nas this attribute may be discarded in other databases\nas per spec","commit_id":"e144527b739ef902f21f94ab28e4ea86f1cf0838"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"5f680e55eef14f33daab7a5b2169f2b108a1a275","unresolved":false,"context_lines":[{"line_number":658,"context_line":"        self.assertEqual(\u0027FAILED\u0027, updated.state)"},{"line_number":659,"context_line":"        state_info \u003d db_api.load_action_execution(updated.id).state_info"},{"line_number":660,"context_line":"        self.assertEqual("},{"line_number":661,"context_line":"            65535,"},{"line_number":662,"context_line":"            len(state_info)"},{"line_number":663,"context_line":"        )"},{"line_number":664,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_3261453a","line":661,"updated":"2015-11-17 12:47:28.000000000","message":"Same and same below.","commit_id":"e144527b739ef902f21f94ab28e4ea86f1cf0838"}]}
