)]}'
{"requirements.txt":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"17cac61137afacf7fdcf93659c35c826c0bac7f2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"python-novaclient!\u003d2.33.0,\u003e\u003d2.29.0"},{"line_number":31,"context_line":"python-troveclient\u003e\u003d1.2.0"},{"line_number":32,"context_line":"python-ironicclient\u003e\u003d0.8.0"},{"line_number":33,"context_line":"python-ironic-inspector-client\u003e\u003d1.0.1"},{"line_number":34,"context_line":"PyYAML\u003e\u003d3.1.0"},{"line_number":35,"context_line":"requests\u003e\u003d2.8.1"},{"line_number":36,"context_line":"retrying!\u003d1.3.0,\u003e\u003d1.2.3 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"9a8ffd7b_c3ae1fe7","line":33,"updated":"2015-11-30 20:52:30.000000000","message":"Oops. The inspector doesn\u0027t belong here yet.","commit_id":"dd83d08c6aa36122757eb26a28550b7b602fc7ff"}],"tools/get_action_list.py":[{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"c04476b728558e4446be2fe546b69a49c05db238","unresolved":false,"context_lines":[{"line_number":113,"context_line":"]"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"IRONIC_NAMESPACE_LIST \u003d ["},{"line_number":116,"context_line":"    \u0027chassis\u0027, \u0027driver\u0027, \u0027node\u0027, \u0027port\u0027"},{"line_number":117,"context_line":"]"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_3da371a0","line":116,"updated":"2015-12-01 08:26:44.000000000","message":"More convenient way to do this is to provide BASE_IRONC_MANAGER like it was done with trove, cinder etc. It allows us to not edit this namespaces list when new namespace appears.\n\nYou can see that manager at https://github.com/openstack/python-ironicclient/blob/master/ironicclient/common/base.py#L44","commit_id":"357c716171aa437e377096d0a087b51119a9fb32"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"6af3ed12481338713ae1808807384b50336344f0","unresolved":false,"context_lines":[{"line_number":113,"context_line":"]"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"IRONIC_NAMESPACE_LIST \u003d ["},{"line_number":116,"context_line":"    \u0027chassis\u0027, \u0027driver\u0027, \u0027node\u0027, \u0027port\u0027"},{"line_number":117,"context_line":"]"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_9baa7cd1","line":116,"in_reply_to":"9a8ffd7b_3da371a0","updated":"2015-12-01 19:18:08.000000000","message":"Got it in patchset 4. Thanks for pointing out it was the Manager class.","commit_id":"357c716171aa437e377096d0a087b51119a9fb32"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"7fea82707fd48190fa13433eaa9d3cd7004b3e5a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    parser.add_argument("},{"line_number":75,"context_line":"        \u0027service\u0027,"},{"line_number":76,"context_line":"        choices\u003d[\u0027nova\u0027, \u0027glance\u0027, \u0027heat\u0027, \u0027cinder\u0027, \u0027keystone\u0027, \u0027ceilometer\u0027,"},{"line_number":77,"context_line":"                 \u0027ironic\u0027],"},{"line_number":78,"context_line":"        help\u003d\u0027Service name which methods need to be found.\u0027"},{"line_number":79,"context_line":"    )"},{"line_number":80,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_a9ea5a72","line":77,"updated":"2015-12-02 18:38:18.000000000","message":"Since this list is growing longer, please change to the following style...\nchoices\u003d[\n    \u0027nova\u0027,\n    ...,\n    \u0027ironic\u0027\n]\nSuggestion: maybe more manageable to define the list of choices as a constant and then assign the constant here?","commit_id":"1cae799a428d6f244e887f9ec97973556c1510bc"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"667400ce0779dfe5ca6023a7692d583254114ae1","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    parser.add_argument("},{"line_number":75,"context_line":"        \u0027service\u0027,"},{"line_number":76,"context_line":"        choices\u003d[\u0027nova\u0027, \u0027glance\u0027, \u0027heat\u0027, \u0027cinder\u0027, \u0027keystone\u0027, \u0027ceilometer\u0027,"},{"line_number":77,"context_line":"                 \u0027ironic\u0027],"},{"line_number":78,"context_line":"        help\u003d\u0027Service name which methods need to be found.\u0027"},{"line_number":79,"context_line":"    )"},{"line_number":80,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_904be4b0","line":77,"in_reply_to":"9a8ffd7b_a9ea5a72","updated":"2015-12-03 02:15:32.000000000","message":"I agree. If it is okay I\u0027d like to fix all the pep8 issues here first though: https://review.openstack.org/#/c/252047/","commit_id":"1cae799a428d6f244e887f9ec97973556c1510bc"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"7fea82707fd48190fa13433eaa9d3cd7004b3e5a","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    return troveclient.Client()"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def get_ironic_client(**kwargs):"},{"line_number":146,"context_line":"    return ironicclient.Client(\"http://127.0.0.1:6385/\")"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"CLIENTS \u003d {"},{"line_number":149,"context_line":"    \u0027nova\u0027: get_nova_client,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_6901d237","line":146,"updated":"2015-12-02 18:38:18.000000000","message":"So this work only on localhost?","commit_id":"1cae799a428d6f244e887f9ec97973556c1510bc"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"667400ce0779dfe5ca6023a7692d583254114ae1","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    return troveclient.Client()"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def get_ironic_client(**kwargs):"},{"line_number":146,"context_line":"    return ironicclient.Client(\"http://127.0.0.1:6385/\")"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"CLIENTS \u003d {"},{"line_number":149,"context_line":"    \u0027nova\u0027: get_nova_client,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_b0df08d5","line":146,"in_reply_to":"9a8ffd7b_6901d237","updated":"2015-12-03 02:15:32.000000000","message":"No. This just provides a stubbed in value to create a dummy client so we can generate actions. A valid URL is required so localhost seemed reasonable.","commit_id":"1cae799a428d6f244e887f9ec97973556c1510bc"}]}
