)]}'
{"mistral/db/v2/sqlalchemy/api.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"b773c7e6ff34f6fe57faee86985627740dce78a3","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        cron_triggers \u003d _get_associated_cron_triggers(identifier)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        try:"},{"line_number":353,"context_line":"            [get_cron_trigger(name) for name in cron_triggers]"},{"line_number":354,"context_line":"        except exc.NotFoundException:"},{"line_number":355,"context_line":"            raise exc.NotAllowedException("},{"line_number":356,"context_line":"                \"Can not update scope of workflow that has triggers \""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_3bc4ba3e","line":353,"updated":"2016-01-08 12:25:11.000000000","message":"why not use:\n\n    if cron_triggers:\n        raise exc.NotAllowedException...\n\n?","commit_id":"e2895cdd6d1504c10ae6a9b293f55747282bc1e3"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"4249c1a3a7ceb73396e57a645d312e8898ca0c4e","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        cron_triggers \u003d _get_associated_cron_triggers(identifier)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        try:"},{"line_number":353,"context_line":"            [get_cron_trigger(name) for name in cron_triggers]"},{"line_number":354,"context_line":"        except exc.NotFoundException:"},{"line_number":355,"context_line":"            raise exc.NotAllowedException("},{"line_number":356,"context_line":"                \"Can not update scope of workflow that has triggers \""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_95d1c359","line":353,"in_reply_to":"fa69d971_3bc4ba3e","updated":"2016-01-10 02:20:47.000000000","message":"I want to allow user to change scope if all\ncron-trigger is within workflow\u0027s tenant.","commit_id":"e2895cdd6d1504c10ae6a9b293f55747282bc1e3"}],"mistral/db/v2/sqlalchemy/models.py":[{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"19a3b23aa7a9598c13573554c8bf281912408f2a","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            \u0027next_execution_time\u0027"},{"line_number":347,"context_line":"        ),"},{"line_number":348,"context_line":"        sa.Index(\u0027%s_project_id\u0027 % __tablename__, \u0027project_id\u0027),"},{"line_number":349,"context_line":"        sa.Index(\u0027%s_scope\u0027 % __tablename__, \u0027scope\u0027),"},{"line_number":350,"context_line":"        sa.Index(\u0027%s_workflow_name\u0027 % __tablename__, \u0027workflow_name\u0027),"},{"line_number":351,"context_line":"    )"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_a4a12148","line":349,"updated":"2015-12-02 18:53:21.000000000","message":"Index for the new workflow_project_id?","commit_id":"e1acb83044eb4a595b90eda7de3f703c4bcea68c"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"8529a3e10b70be44b25b69ef6b257f7b731a2f5b","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            \u0027next_execution_time\u0027"},{"line_number":347,"context_line":"        ),"},{"line_number":348,"context_line":"        sa.Index(\u0027%s_project_id\u0027 % __tablename__, \u0027project_id\u0027),"},{"line_number":349,"context_line":"        sa.Index(\u0027%s_scope\u0027 % __tablename__, \u0027scope\u0027),"},{"line_number":350,"context_line":"        sa.Index(\u0027%s_workflow_name\u0027 % __tablename__, \u0027workflow_name\u0027),"},{"line_number":351,"context_line":"    )"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_c769b0bf","line":349,"in_reply_to":"9a8ffd7b_a4a12148","updated":"2015-12-03 04:43:35.000000000","message":"Hi,\n\n\"workflow_project_id\" will not be used for searching, sorting, or inserting\npurpose as of now.\n\nThis attribute will be used by \"cron_trigger\" to create auth context \nwhile executing the workflow.\n\nSo i think we don\u0027t need to add Index for \"workflow_project_id\"","commit_id":"e1acb83044eb4a595b90eda7de3f703c4bcea68c"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"19a3b23aa7a9598c13573554c8bf281912408f2a","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    )"},{"line_number":369,"context_line":"    workflow \u003d relationship(\u0027WorkflowDefinition\u0027, lazy\u003d\u0027joined\u0027)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    workflow_project_id \u003d sa.Column(sa.String(80))"},{"line_number":372,"context_line":"    workflow_params \u003d sa.Column(st.JsonDictType())"},{"line_number":373,"context_line":"    workflow_params_hash \u003d sa.Column("},{"line_number":374,"context_line":"        sa.CHAR(64),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_4456355d","line":371,"updated":"2015-12-02 18:53:21.000000000","message":"Is the use of \"workflow_project_id\" going to be different than the \"project_id\" in MistralSecureModelBase which this model is subclass of?","commit_id":"e1acb83044eb4a595b90eda7de3f703c4bcea68c"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"3be28ef7f411362cda78741809bf631da3ccd52d","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    )"},{"line_number":369,"context_line":"    workflow \u003d relationship(\u0027WorkflowDefinition\u0027, lazy\u003d\u0027joined\u0027)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    workflow_project_id \u003d sa.Column(sa.String(80))"},{"line_number":372,"context_line":"    workflow_params \u003d sa.Column(st.JsonDictType())"},{"line_number":373,"context_line":"    workflow_params_hash \u003d sa.Column("},{"line_number":374,"context_line":"        sa.CHAR(64),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_5cc273ea","line":371,"in_reply_to":"9a8ffd7b_4456355d","updated":"2015-12-03 04:31:30.000000000","message":"Actually if Workflow is created in different tenant and cron-trigger is created in different tenant than \"work_flow_project_id\" will be different than project_id.\n\nSo auth context should be created with \"workflow_project_id\" otherwise workflow execution will be failed if user change workflow to private and there is already cron-trgigger is created in different tenant.","commit_id":"e1acb83044eb4a595b90eda7de3f703c4bcea68c"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"2c552c6e0543b10c3c91acfc4d73b36a8f1dd38a","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    )"},{"line_number":369,"context_line":"    workflow \u003d relationship(\u0027WorkflowDefinition\u0027, lazy\u003d\u0027joined\u0027)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    workflow_project_id \u003d sa.Column(sa.String(80))"},{"line_number":372,"context_line":"    workflow_params \u003d sa.Column(st.JsonDictType())"},{"line_number":373,"context_line":"    workflow_params_hash \u003d sa.Column("},{"line_number":374,"context_line":"        sa.CHAR(64),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_0273ccb2","line":371,"in_reply_to":"9a8ffd7b_5cc273ea","updated":"2015-12-03 19:35:24.000000000","message":"So can you clarify the use case why the workflow and cron trigger will be created in different tenants?  Won\u0027t there be security concern for a cron trigger against a workflow in a different tenant?","commit_id":"e1acb83044eb4a595b90eda7de3f703c4bcea68c"}],"mistral/tests/unit/db/v2/test_sqlalchemy_db_api.py":[{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"45ef4cce52899710e2a30187125490672bf4f0f6","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        self.assertIsNotNone(fetched.updated_at)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        # Update workflow using workflow uuid as identifier."},{"line_number":309,"context_line":"        updated \u003d db_api.update_workflow_definition(created[\u0027id\u0027], {"},{"line_number":310,"context_line":"            \u0027name\u0027: \u0027updated_name\u0027,"},{"line_number":311,"context_line":"            \u0027definition\u0027: \u0027my new definition\u0027,"},{"line_number":312,"context_line":"            \u0027scope\u0027: \u0027private\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_16efaf1e","line":309,"updated":"2016-01-07 06:45:48.000000000","message":"it should be \nupdated \u003d db_api.update_workflow_definition(\n    created[\u0027id\u0027],\n    {\n        \u0027name\u0027: \u0027updated_name\u0027,\n        \u0027definition\u0027: \u0027my new definition\u0027,\n        \u0027scope\u0027: \u0027private\u0027\n    }\n)","commit_id":"126390664d068adae5ee03f8df8b43ddc2ad35de"}]}
