)]}'
{"mistral/db/sqlalchemy/base.py":[{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"9bcf2f580f67727a7f9257866c89aaae30e9467d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    # sqlite (used for unit testing and not allowed for production)"},{"line_number":59,"context_line":"    # does not support READ_COMMITTED."},{"line_number":60,"context_line":"    # Checking the drivername using the args and not the get_driver_name()"},{"line_number":61,"context_line":"    # method because that method requires a session."},{"line_number":62,"context_line":"    if args[0].drivername !\u003d \u0027sqlite\u0027:"},{"line_number":63,"context_line":"        kwargs[\"isolation_level\"] \u003d \"READ_COMMITTED\""},{"line_number":64,"context_line":"    return _sqlalchemy_create_engine_orig(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_944ec56d","line":61,"updated":"2015-12-06 18:33:53.000000000","message":"sqlite supports only SERIALIZABLE and READ UNCOMMITTED isolation levels but sqlite is less important as it is used only for unit testing and not allowed for production + the locking mechanism is different anyway.","commit_id":"5fa6b5db913a88a5a4d6f578bf99d47f2e44d51c"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"9bcf2f580f67727a7f9257866c89aaae30e9467d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    # does not support READ_COMMITTED."},{"line_number":60,"context_line":"    # Checking the drivername using the args and not the get_driver_name()"},{"line_number":61,"context_line":"    # method because that method requires a session."},{"line_number":62,"context_line":"    if args[0].drivername !\u003d \u0027sqlite\u0027:"},{"line_number":63,"context_line":"        kwargs[\"isolation_level\"] \u003d \"READ_COMMITTED\""},{"line_number":64,"context_line":"    return _sqlalchemy_create_engine_orig(*args, **kwargs)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_b4518110","line":62,"updated":"2015-12-06 18:33:53.000000000","message":"Change isolation level from REPEATABLE_READ to READ_COMMITTED.\n\nREPEATABLE_READ - while in transaction, the first read operation to the DB creates a snapshot of the entire DB so you are guarantee that all the data in the DB will remain the same until the end of the transaction.\n\n\nREPEATABLE_READ example:\n\n   1. ConnectionA selects from tableA in a transaction.\n\n   2. ConnectionB deletes all rows from tableB in a transaction.\n\n   3. ConnectionB commits.\n\n   4. ConnectionA loops over the rows of tableA and fetches from tableB using the tableA_tableB_FK - ConnectionA will get rows from tableB.\n\n\n\nREAD_COMMITTED - while in a transaction, every query to the DB will get the committed data.\n\n\nREAD_COMMITTED example:\n\n   1. ConnectionA starts a transaction.\n\n   2. ConnectionB starts a transaction.\n\n   3. ConnectionA insert row to tableA and commits.\n\n   4. ConnectionB insert row to tableA.\n\n   5. ConnectionB selects tableA and gets two rows.\n\n   6. ConnectionB commits / rollback.","commit_id":"5fa6b5db913a88a5a4d6f578bf99d47f2e44d51c"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"19470640c601d755b6a61d9f8b6e3dd03af1f95f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    # If the patch was not applied yet."},{"line_number":69,"context_line":"    if sa.create_engine !\u003d _sqlalchemy_create_engine_wrapper:"},{"line_number":70,"context_line":"        # Replace the original create_engine with our wrapper."},{"line_number":71,"context_line":"        sa.create_engine \u003d _sqlalchemy_create_engine_wrapper"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    return _get_facade().get_engine()"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_445bb2f6","line":71,"updated":"2015-12-07 12:36:32.000000000","message":"Is it necessary to change isolation level for every session? I\u0027m wondering if this could  slow down whole service on a big deployments.","commit_id":"9a568cfb1dfb14a116a69bf55bca7b69d5466691"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"c813a87557492d6678247538d4e583dfd983c60a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    # If the patch was not applied yet."},{"line_number":69,"context_line":"    if sa.create_engine !\u003d _sqlalchemy_create_engine_wrapper:"},{"line_number":70,"context_line":"        # Replace the original create_engine with our wrapper."},{"line_number":71,"context_line":"        sa.create_engine \u003d _sqlalchemy_create_engine_wrapper"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    return _get_facade().get_engine()"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_7bf0c867","line":71,"in_reply_to":"7a740942_445bb2f6","updated":"2015-12-07 14:48:29.000000000","message":"Thanks, Dawid - this is a valid concern but READ_COMMITTED is usually more efficient and requires far less internal lock operations in the DB.\n\n\nYou can look at these excellent articles:\n\nhttps://www.percona.com/blog/2015/01/14/mysql-performance-implications-of-innodb-isolation-modes/\n\nhttps://www.percona.com/blog/2012/08/28/differences-between-read-committed-and-repeatable-read-transaction-isolation-levels/\n\n\nIn addition, I think that the fact that we now know exactly what is the expected behaviour of a transaction and they all behave the same will allow us to write more robust code.","commit_id":"9a568cfb1dfb14a116a69bf55bca7b69d5466691"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"381b5b5323ad84230d097c32f71d2d6832e50ef4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    return _facade"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Monkey-patching sqlalchemy to set the isolation_level"},{"line_number":56,"context_line":"# as this configuration is not exposed by oslo_db."},{"line_number":57,"context_line":"def _sqlalchemy_create_engine_wrapper(*args, **kwargs):"},{"line_number":58,"context_line":"    # sqlite (used for unit testing and not allowed for production)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a740942_8e766cd5","line":55,"updated":"2015-12-08 06:26:25.000000000","message":"Moshe, I also suggest we raise this topic in ML with tags [oslo][sqlalchemy] so that it is added into oslo_db. For me it\u0027s very strange that oslo doesn\u0027t support it (it really doesn\u0027t, I checked myself eariler).","commit_id":"459591c3ea80fe475b206cb25ff1eaafed66e4cc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"0b90cafd8d8577197aeb5cec6c173ffde806c7ea","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    return _facade"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Monkey-patching sqlalchemy to set the isolation_level"},{"line_number":56,"context_line":"# as this configuration is not exposed by oslo_db."},{"line_number":57,"context_line":"def _sqlalchemy_create_engine_wrapper(*args, **kwargs):"},{"line_number":58,"context_line":"    # sqlite (used for unit testing and not allowed for production)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a740942_a472640f","line":55,"in_reply_to":"7a740942_8e766cd5","updated":"2015-12-08 08:39:00.000000000","message":"Good idea. Done. Email subject is \"[openstack-dev] [oslo.db][sqlalchemy][mistral] Configuring default transaction isolation level\"","commit_id":"459591c3ea80fe475b206cb25ff1eaafed66e4cc"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"d4a68b7254feb8de562fe398ab4e4b310fcf9c85","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    # Checking the drivername using the args and not the get_driver_name()"},{"line_number":61,"context_line":"    # method because that method requires a session."},{"line_number":62,"context_line":"    if args[0].drivername !\u003d \u0027sqlite\u0027:"},{"line_number":63,"context_line":"        kwargs[\"isolation_level\"] \u003d \"READ_COMMITTED\""},{"line_number":64,"context_line":"    return _sqlalchemy_create_engine_orig(*args, **kwargs)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7a740942_35850b59","line":63,"updated":"2015-12-09 02:50:03.000000000","message":"Please add a blank line here. Mistral style guide requires blank line before return statement.","commit_id":"4a89fba3c6d150e3b2c4c67bec8fdc1b5d6f3272"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"20ec83f1133eb9b7b0dc37a44e3cc5c6f280624e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    # Checking the drivername using the args and not the get_driver_name()"},{"line_number":61,"context_line":"    # method because that method requires a session."},{"line_number":62,"context_line":"    if args[0].drivername !\u003d \u0027sqlite\u0027:"},{"line_number":63,"context_line":"        kwargs[\"isolation_level\"] \u003d \"READ_COMMITTED\""},{"line_number":64,"context_line":"    return _sqlalchemy_create_engine_orig(*args, **kwargs)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7a740942_42ac908b","line":63,"in_reply_to":"7a740942_35850b59","updated":"2015-12-09 07:59:23.000000000","message":"True. Sorry. I knew that. Done.\n\nIs it possible to add all these rules to mistral pep8? That will really save a lot of time for committers and reviewers.","commit_id":"4a89fba3c6d150e3b2c4c67bec8fdc1b5d6f3272"}],"mistral/db/v2/sqlalchemy/api.py":[{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"9bcf2f580f67727a7f9257866c89aaae30e9467d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # Expire all so all objects queried after lock is acquired"},{"line_number":96,"context_line":"        # will be up-to-date from the DB and not from cache."},{"line_number":97,"context_line":"        # This does not work for sqlite - it invalidates the query cursor."},{"line_number":98,"context_line":"        session.expire_all()"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        query \u003d _secure_query(model).filter(model.id \u003d\u003d id)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_94756599","line":98,"updated":"2015-12-06 18:33:53.000000000","message":"Although we are now in READ_COMMITTED - without this session.expire_all() sqlalchemy queries by ID return the object from the session/cache and not the object from the DB.\n\nIn order to get the up-to-date object from the DB - you need to expire the objects from the session.","commit_id":"5fa6b5db913a88a5a4d6f578bf99d47f2e44d51c"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"9bcf2f580f67727a7f9257866c89aaae30e9467d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        query \u003d _secure_query(model).filter(model.id \u003d\u003d id)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        entity \u003d query.one()"},{"line_number":103,"context_line":"        entity.update({\u0027updated_at\u0027: timeutils.utcnow()})"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    else:"},{"line_number":106,"context_line":"        sqlite_lock.acquire_lock(id, session)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_346591e0","line":103,"updated":"2015-12-06 18:33:53.000000000","message":"In the previous impl - there was a use of query.update with synchronize_session\u003d\u0027fetch\u0027 - this means that there is a query before the update.\n\nSo if there is a query before the update anyway - why not use that to return the object and save a query later.\nIn addition, synchronize_session\u003d\u0027fetch\u0027 is not needed any more because we just expired all objects from the session.","commit_id":"5fa6b5db913a88a5a4d6f578bf99d47f2e44d51c"},{"author":{"_account_id":15881,"name":"Limor Stotland","email":"limor.bortman@nokia.com","username":"LimorStotlamd"},"change_message_id":"4a4f072c240aa0887d186e30cd902ebb22e9df45","unresolved":false,"context_lines":[{"line_number":93,"context_line":"def acquire_lock(model, id, session\u003dNone):"},{"line_number":94,"context_line":"    # Expire all so all objects queried after lock is acquired"},{"line_number":95,"context_line":"    # will be up-to-date from the DB and not from cache."},{"line_number":96,"context_line":"    session.expire_all()"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    if b.get_driver_name() !\u003d \u0027sqlite\u0027:"},{"line_number":99,"context_line":"        query \u003d _secure_query(model).filter(model.id \u003d\u003d id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_acdccd12","line":96,"updated":"2015-12-07 07:58:35.000000000","message":"what happens to the other open session that doesn\u0027t have the like? this they will throw exception?","commit_id":"9a568cfb1dfb14a116a69bf55bca7b69d5466691"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"c813a87557492d6678247538d4e583dfd983c60a","unresolved":false,"context_lines":[{"line_number":93,"context_line":"def acquire_lock(model, id, session\u003dNone):"},{"line_number":94,"context_line":"    # Expire all so all objects queried after lock is acquired"},{"line_number":95,"context_line":"    # will be up-to-date from the DB and not from cache."},{"line_number":96,"context_line":"    session.expire_all()"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    if b.get_driver_name() !\u003d \u0027sqlite\u0027:"},{"line_number":99,"context_line":"        query \u003d _secure_query(model).filter(model.id \u003d\u003d id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_42872dd7","line":96,"in_reply_to":"7a740942_acdccd12","updated":"2015-12-07 14:48:29.000000000","message":"This does not expire objects on all sessions.\nOnly on the current session.","commit_id":"9a568cfb1dfb14a116a69bf55bca7b69d5466691"},{"author":{"_account_id":15881,"name":"Limor Stotland","email":"limor.bortman@nokia.com","username":"LimorStotlamd"},"change_message_id":"4a4f072c240aa0887d186e30cd902ebb22e9df45","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    else:"},{"line_number":105,"context_line":"        sqlite_lock.acquire_lock(id, session)"},{"line_number":106,"context_line":"        entity \u003d _secure_query(model).filter(model.id \u003d\u003d id).one()"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    return entity"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_2ce8ddb3","line":106,"updated":"2015-12-07 07:58:35.000000000","message":"This lien is similar to 99+101 maybe you can write the code as a separate method: \n\n_get_entity();\nreturn  _secure_query(model).filter(model.id \u003d\u003d id).one()","commit_id":"9a568cfb1dfb14a116a69bf55bca7b69d5466691"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"c813a87557492d6678247538d4e583dfd983c60a","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    else:"},{"line_number":105,"context_line":"        sqlite_lock.acquire_lock(id, session)"},{"line_number":106,"context_line":"        entity \u003d _secure_query(model).filter(model.id \u003d\u003d id).one()"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    return entity"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_6416f1a8","line":106,"in_reply_to":"7a740942_2ce8ddb3","updated":"2015-12-07 14:48:29.000000000","message":"Done","commit_id":"9a568cfb1dfb14a116a69bf55bca7b69d5466691"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"7e35fc768e41f9608588e59a9fef6331bf59de87","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    else:"},{"line_number":105,"context_line":"        sqlite_lock.acquire_lock(id, session)"},{"line_number":106,"context_line":"        entity \u003d _secure_query(model).filter(model.id \u003d\u003d id).one()"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    return entity"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_a72146fd","line":106,"in_reply_to":"7a740942_2ce8ddb3","updated":"2015-12-07 08:38:26.000000000","message":"oh, yes, indeed, agree.","commit_id":"9a568cfb1dfb14a116a69bf55bca7b69d5466691"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"381b5b5323ad84230d097c32f71d2d6832e50ef4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"def acquire_lock(model, id, session\u003dNone):"},{"line_number":94,"context_line":"    # Expire all so all objects queried after lock is acquired"},{"line_number":95,"context_line":"    # will be up-to-date from the DB and not from cache."},{"line_number":96,"context_line":"    session.expire_all()"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    if b.get_driver_name() !\u003d \u0027sqlite\u0027:"},{"line_number":99,"context_line":"        entity \u003d _get_one_entity(model, id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a740942_0e1fdc6c","line":96,"updated":"2015-12-08 06:26:25.000000000","message":"Let\u0027s move it after update operation? At this point lock is not actually acquired yet.","commit_id":"459591c3ea80fe475b206cb25ff1eaafed66e4cc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"0b90cafd8d8577197aeb5cec6c173ffde806c7ea","unresolved":false,"context_lines":[{"line_number":93,"context_line":"def acquire_lock(model, id, session\u003dNone):"},{"line_number":94,"context_line":"    # Expire all so all objects queried after lock is acquired"},{"line_number":95,"context_line":"    # will be up-to-date from the DB and not from cache."},{"line_number":96,"context_line":"    session.expire_all()"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    if b.get_driver_name() !\u003d \u0027sqlite\u0027:"},{"line_number":99,"context_line":"        entity \u003d _get_one_entity(model, id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a740942_c42770c8","line":96,"in_reply_to":"7a740942_0e1fdc6c","updated":"2015-12-08 08:39:00.000000000","message":"The lock is indeed not acquired yet at this point but if we won\u0027t expire first - we will not get the up-to-date entity when calling \"_get_one_entity\".\n\n\nBeing in READ_COMMITTED and expiring the session guarantees that when we do \"_get_one_entity\" we will get the up-to-date object + we also can assure that there are no DB actions between \"session.expire_all()\" and \"_get_one_entity\" because the connection is per thread.\n\nI think we should leave it where it is. If you don\u0027t agree let\u0027s talk some more.","commit_id":"459591c3ea80fe475b206cb25ff1eaafed66e4cc"}],"mistral/engine/default_engine.py":[{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"9bcf2f580f67727a7f9257866c89aaae30e9467d","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            # policy worked."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"            wf_ex_id \u003d task_ex.workflow_execution_id"},{"line_number":159,"context_line":"            wf_ex \u003d self._lock_workflow_execution(wf_ex_id)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            wf_trace.info("},{"line_number":162,"context_line":"                task_ex,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_949c85c1","line":159,"updated":"2015-12-06 18:33:53.000000000","message":"Made lock and fetch in one line and one less statement into DB. This improvement occurs multiple times in the code.","commit_id":"5fa6b5db913a88a5a4d6f578bf99d47f2e44d51c"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"9bcf2f580f67727a7f9257866c89aaae30e9467d","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                task_ex \u003d action_ex.task_execution"},{"line_number":249,"context_line":"                wf_ex \u003d self._lock_workflow_execution("},{"line_number":250,"context_line":"                    task_ex.workflow_execution_id"},{"line_number":251,"context_line":"                )"},{"line_number":252,"context_line":"                self._on_task_state_change(task_ex, wf_ex)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"                return action_ex.get_clone()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_74a9d9de","line":251,"updated":"2015-12-06 18:33:53.000000000","message":"Added a missing lock here because if not - multiple task executions would change workflow status from RUNNING to a final state and will do workflow finishes.","commit_id":"5fa6b5db913a88a5a4d6f578bf99d47f2e44d51c"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"9bcf2f580f67727a7f9257866c89aaae30e9467d","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                \"Failed to handle action execution result [id\u003d%s]: %s\\n%s\","},{"line_number":260,"context_line":"                action_ex_id, e, traceback.format_exc()"},{"line_number":261,"context_line":"            )"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"            # If an exception was thrown after we got the wf_ex_id"},{"line_number":264,"context_line":"            if wf_ex_id:"},{"line_number":265,"context_line":"                self._fail_workflow(wf_ex_id, e)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_f4b5c930","line":262,"updated":"2015-12-06 18:33:53.000000000","message":"Not related to the bug fix but I just happened to see this when I accidently tried to do action-execution-update with a non-existing action_ex_id.","commit_id":"5fa6b5db913a88a5a4d6f578bf99d47f2e44d51c"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"9bcf2f580f67727a7f9257866c89aaae30e9467d","unresolved":false,"context_lines":[{"line_number":493,"context_line":"        # Locks a workflow execution using the db_api.acquire_lock function."},{"line_number":494,"context_line":"        # The method expires all session objects and returns the up-to-date"},{"line_number":495,"context_line":"        # workflow execution from the DB."},{"line_number":496,"context_line":"        return db_api.acquire_lock(db_models.WorkflowExecution, wf_exec_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_94832556","line":496,"updated":"2015-12-06 18:33:53.000000000","message":"Return the up-to-date object from the DB.\nYou know can fetch the object before invoking this method and it will work fine because we work in READ_COMMITTED and we do session.expire_all() inside.","commit_id":"5fa6b5db913a88a5a4d6f578bf99d47f2e44d51c"}],"mistral/tests/functional/api/v2/test_mistral_basic_v2.py":[{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"9bcf2f580f67727a7f9257866c89aaae30e9467d","unresolved":false,"context_lines":[{"line_number":556,"context_line":"                          self.client.create_execution,"},{"line_number":557,"context_line":"                          self.reverse_wf[\u0027name\u0027],"},{"line_number":558,"context_line":"                          params\u003d{\"task_name\": \"nonexist\"})"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"    @test.attr(type\u003d\u0027sanity\u0027)"},{"line_number":561,"context_line":"    def test_action_ex_concurrency(self):"},{"line_number":562,"context_line":"        resp, wf \u003d self.client.create_workflow(\"wf_action_ex_concurrency.yaml\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_b4866163","line":559,"updated":"2015-12-06 18:33:53.000000000","message":"This tests concurrency on default_engine on_action_complete","commit_id":"5fa6b5db913a88a5a4d6f578bf99d47f2e44d51c"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"9bcf2f580f67727a7f9257866c89aaae30e9467d","unresolved":false,"context_lines":[{"line_number":569,"context_line":"        self.assertEqual(\u0027RUNNING\u0027, execution[\u0027state\u0027])"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        self.client.wait_execution_success(execution)"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    @test.attr(type\u003d\u0027sanity\u0027)"},{"line_number":574,"context_line":"    def test_task_ex_concurrency(self):"},{"line_number":575,"context_line":"        resp, wf \u003d self.client.create_workflow(\"wf_task_ex_concurrency.yaml\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_547dbd6c","line":572,"updated":"2015-12-06 18:33:53.000000000","message":"This tests concurrency on default_engine on_task_state_change","commit_id":"5fa6b5db913a88a5a4d6f578bf99d47f2e44d51c"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"381b5b5323ad84230d097c32f71d2d6832e50ef4","unresolved":false,"context_lines":[{"line_number":581,"context_line":"        self.assertEqual(201, resp.status)"},{"line_number":582,"context_line":"        self.assertEqual(\u0027RUNNING\u0027, execution[\u0027state\u0027])"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        self.client.wait_execution(execution, target_state\u003d\u0027ERROR\u0027)"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"class CronTriggerTestsV2(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a740942_5376eca4","line":584,"updated":"2015-12-08 06:26:25.000000000","message":"Does this test fail consistently? If yes, I don\u0027t understand why.","commit_id":"459591c3ea80fe475b206cb25ff1eaafed66e4cc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"0b90cafd8d8577197aeb5cec6c173ffde806c7ea","unresolved":false,"context_lines":[{"line_number":581,"context_line":"        self.assertEqual(201, resp.status)"},{"line_number":582,"context_line":"        self.assertEqual(\u0027RUNNING\u0027, execution[\u0027state\u0027])"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        self.client.wait_execution(execution, target_state\u003d\u0027ERROR\u0027)"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"class CronTriggerTestsV2(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a740942_9f721510","line":584,"in_reply_to":"7a740942_5376eca4","updated":"2015-12-08 08:39:00.000000000","message":"This test does not consistently fail on DevStack but on our prod like setup it failed pretty frequent without the fix.\n\nThis is the scenario without the fix:\n\nWhen the task is expired - the scheduler invokes fail_task_if_incomplete that calls \"DefaultEngine.on_task_state_change\" with state ERROR.\n\nSo the DefaultEngine.on_task_state_change can be called simultaneously for multiple task executions in the same WF execution.\n\n\nTwo processes has started a transaction in REPEATABLE READ - and one gets the WF EX lock. Process1 in _on_task_state_change, changes the task ex state and in _check_workflow_completion it checks and sees that not all tasks are completed and does not end the WF EX.\n\n\nProcess2 in _on_task_state_change, changes the task ex state and in _check_workflow_completion it checks and because we are in REPEATABLE READ it sees that not all tasks are completed and does not end the WF EX.\n\n\nThe WF EX stays in RUNNING state.","commit_id":"459591c3ea80fe475b206cb25ff1eaafed66e4cc"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"d4a68b7254feb8de562fe398ab4e4b310fcf9c85","unresolved":false,"context_lines":[{"line_number":581,"context_line":"        self.assertEqual(201, resp.status)"},{"line_number":582,"context_line":"        self.assertEqual(\u0027RUNNING\u0027, execution[\u0027state\u0027])"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        self.client.wait_execution(execution, target_state\u003d\u0027ERROR\u0027)"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"class CronTriggerTestsV2(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a740942_f5246360","line":584,"updated":"2015-12-09 02:50:03.000000000","message":"How come we are waiting for ERROR state here?","commit_id":"4a89fba3c6d150e3b2c4c67bec8fdc1b5d6f3272"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"20ec83f1133eb9b7b0dc37a44e3cc5c6f280624e","unresolved":false,"context_lines":[{"line_number":581,"context_line":"        self.assertEqual(201, resp.status)"},{"line_number":582,"context_line":"        self.assertEqual(\u0027RUNNING\u0027, execution[\u0027state\u0027])"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        self.client.wait_execution(execution, target_state\u003d\u0027ERROR\u0027)"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"class CronTriggerTestsV2(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a740942_62ec2cbb","line":584,"in_reply_to":"7a740942_f5246360","updated":"2015-12-09 07:59:23.000000000","message":"Both tasks will fail on timeout so the WF EX should be in ERROR","commit_id":"4a89fba3c6d150e3b2c4c67bec8fdc1b5d6f3272"}],"mistral/tests/functional/base.py":[{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"d4a68b7254feb8de562fe398ab4e4b310fcf9c85","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                       target_state\u003d\u0027SUCCESS\u0027):"},{"line_number":96,"context_line":"        start_time \u003d time.time()"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        expected_states \u003d [target_state, \u0027RUNNING\u0027]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        while ex_body[\u0027state\u0027] !\u003d target_state:"},{"line_number":101,"context_line":"            if time.time() - start_time \u003e timeout:"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a740942_f5b22305","line":98,"updated":"2015-12-09 02:50:03.000000000","message":"Why multiple states here? The while loop below will only wait for the target_state. The RUNNING state seems pointless and confusing here.","commit_id":"4a89fba3c6d150e3b2c4c67bec8fdc1b5d6f3272"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"20ec83f1133eb9b7b0dc37a44e3cc5c6f280624e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                       target_state\u003d\u0027SUCCESS\u0027):"},{"line_number":96,"context_line":"        start_time \u003d time.time()"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        expected_states \u003d [target_state, \u0027RUNNING\u0027]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        while ex_body[\u0027state\u0027] !\u003d target_state:"},{"line_number":101,"context_line":"            if time.time() - start_time \u003e timeout:"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a740942_62a42c4a","line":98,"in_reply_to":"7a740942_f5b22305","updated":"2015-12-09 07:59:23.000000000","message":"We expect the WF EX to go from RUNNING to target_state.\n\nThe while loop will loop as long as the state is RUNNING and will end successfully if the state is target_state.\n\nIf during the loop the state will not be in RUNNING or target_state (for example PAUSED) - an exception will be raised immediately and will spare us the need to wait for timeout","commit_id":"4a89fba3c6d150e3b2c4c67bec8fdc1b5d6f3272"}],"mistral/tests/unit/db/v2/test_locking.py":[{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"9bcf2f580f67727a7f9257866c89aaae30e9467d","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        print(\"Correct locking test gave object name: %s\" % wf_ex.name)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.assertEqual(str(number), wf_ex.name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_74f799f5","line":124,"updated":"2015-12-06 18:33:53.000000000","message":"I have deleted \"test_invalid_locking\" unit test because now calling lock method is valid even if the object was queried before.","commit_id":"5fa6b5db913a88a5a4d6f578bf99d47f2e44d51c"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"a565cf4ba110cb1d7aa82dd9cc50c43d03b39b01","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self.assertEqual(str(number), wf_ex.name)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def _run_invalid_locking(self, wf_ex):"},{"line_number":132,"context_line":"        self._random_sleep()"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        with db_api.transaction():"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a740942_3d49b460","side":"PARENT","line":131,"updated":"2015-12-08 03:27:17.000000000","message":"Any way to test failure case for locking in this new scheme?","commit_id":"7264fe6ee18ca25fd9e1f7576b676209389081a6"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"0b90cafd8d8577197aeb5cec6c173ffde806c7ea","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self.assertEqual(str(number), wf_ex.name)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def _run_invalid_locking(self, wf_ex):"},{"line_number":132,"context_line":"        self._random_sleep()"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        with db_api.transaction():"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a740942_4a6069a5","side":"PARENT","line":131,"in_reply_to":"7a740942_3d49b460","updated":"2015-12-08 08:39:00.000000000","message":"This is an sqlite test so as Renat mentioned it should behave the same because I did not change sqlite behaviour.\nI will put the test back. Thanks.","commit_id":"7264fe6ee18ca25fd9e1f7576b676209389081a6"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"381b5b5323ad84230d097c32f71d2d6832e50ef4","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"            return wf_ex.name"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_invalid_locking(self):"},{"line_number":150,"context_line":"        wf_ex \u003d db_api.create_workflow_execution(WF_EXEC)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        threads \u003d []"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a740942_504ca29d","side":"PARENT","line":149,"updated":"2015-12-08 06:26:25.000000000","message":"Moshe, what is the reason why you removed this test? Seems like it should work the same way as before because it\u0027s sqlite in unit tests. The only difference is that we return the locked object now.","commit_id":"7264fe6ee18ca25fd9e1f7576b676209389081a6"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"0b90cafd8d8577197aeb5cec6c173ffde806c7ea","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"            return wf_ex.name"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_invalid_locking(self):"},{"line_number":150,"context_line":"        wf_ex \u003d db_api.create_workflow_execution(WF_EXEC)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        threads \u003d []"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a740942_4abce9db","side":"PARENT","line":149,"in_reply_to":"7a740942_504ca29d","updated":"2015-12-08 08:39:00.000000000","message":"You are correct, Renat.\n\n\nI removed it because I saw it is failing so I assumed it is because of the fix but you are right - my fix does not change sqlite behaviour.\n\n\nI now double checked it and this test indeed fails consistently on my DevStack.\n\nIt succeeds only after I add \"eventlet.monkey_patch\" to tests/__init__.py.\n\n\nI will put this test back in. Thanks!","commit_id":"7264fe6ee18ca25fd9e1f7576b676209389081a6"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"d4a68b7254feb8de562fe398ab4e4b310fcf9c85","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"            return wf_ex.name"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_invalid_locking(self):"},{"line_number":150,"context_line":"        wf_ex \u003d db_api.create_workflow_execution(WF_EXEC)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        threads \u003d []"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a740942_558e972e","side":"PARENT","line":149,"updated":"2015-12-09 02:50:03.000000000","message":"I thought we\u0027re putting this test back from the comments of previous patch set.","commit_id":"209319e5074608adbff761d39bffaf6db5ce60ef"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"20ec83f1133eb9b7b0dc37a44e3cc5c6f280624e","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"            return wf_ex.name"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_invalid_locking(self):"},{"line_number":150,"context_line":"        wf_ex \u003d db_api.create_workflow_execution(WF_EXEC)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        threads \u003d []"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a740942_c242c067","side":"PARENT","line":149,"in_reply_to":"7a740942_558e972e","updated":"2015-12-09 07:59:23.000000000","message":"I tried to but it did not go smoothly. I talked with Renat and we agreed to remove this. Thanks.","commit_id":"209319e5074608adbff761d39bffaf6db5ce60ef"}],"mistral/tests/unit/engine/test_workflow_resume.py":[{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"9bcf2f580f67727a7f9257866c89aaae30e9467d","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        # Wait for task3."},{"line_number":307,"context_line":"        task3_ex \u003d self._assert_single_item(task_execs, name\u003d\u0027task3\u0027)"},{"line_number":308,"context_line":"        self._await(lambda: self.is_task_success(task3_ex.id))"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        # Finish task2."},{"line_number":311,"context_line":"        task2_action_ex \u003d db_api.get_action_executions("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_54cb7da5","line":308,"updated":"2015-12-06 18:33:53.000000000","message":"I have added waiting for task3 before continuing because my bugfix unveils / creates another bug.\n\nIf that other bug is caused by my changes - I will remove this await and will continue working on my fix.\nIf that other bug already exists but my changes make it more often - we can continue with this bugfix and open a different bug.\n\nI have sent an email to Renat and Nikolay with the details to decide.","commit_id":"5fa6b5db913a88a5a4d6f578bf99d47f2e44d51c"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"9bcf2f580f67727a7f9257866c89aaae30e9467d","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        with mock.patch.object("},{"line_number":341,"context_line":"                db_api,"},{"line_number":342,"context_line":"                \u0027acquire_lock\u0027,"},{"line_number":343,"context_line":"                side_effect\u003derr):"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"            self.assertRaises("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_34da7179","line":342,"updated":"2015-12-06 18:33:53.000000000","message":"I changed the patched function because \"get_workflow_execution\" is no longer called in this flow.","commit_id":"5fa6b5db913a88a5a4d6f578bf99d47f2e44d51c"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"a565cf4ba110cb1d7aa82dd9cc50c43d03b39b01","unresolved":false,"context_lines":[{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        wf_ex \u003d db_api.get_workflow_execution(wf_ex.id)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        self.assertEqual(states.SUCCESS, wf_ex.state, wf_ex.state_info)"},{"line_number":323,"context_line":"        self.assertEqual(4, len(wf_ex.task_executions))"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    @mock.patch.object(de.DefaultEngine, \u0027_fail_workflow\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a740942_1d895875","line":322,"updated":"2015-12-08 03:27:17.000000000","message":"Why the check of wf_ex.state_info here?","commit_id":"459591c3ea80fe475b206cb25ff1eaafed66e4cc"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"0b90cafd8d8577197aeb5cec6c173ffde806c7ea","unresolved":false,"context_lines":[{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        wf_ex \u003d db_api.get_workflow_execution(wf_ex.id)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        self.assertEqual(states.SUCCESS, wf_ex.state, wf_ex.state_info)"},{"line_number":323,"context_line":"        self.assertEqual(4, len(wf_ex.task_executions))"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    @mock.patch.object(de.DefaultEngine, \u0027_fail_workflow\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a740942_6a19a5d6","line":322,"in_reply_to":"7a740942_1d895875","updated":"2015-12-08 08:39:00.000000000","message":"Thanks. I do not check for state_info I just use it as the message in case the assert fails.\n\n\nWe expect that the wf_ex will be in SUCCESS but if it is in ERROR - it will be very helpful to see the state_info and to know why.\nI actually think we need to have a \"assert_wf_ex_state\" function so you could do \"assert_wf_ex_state(wf_ex, states.SUCCESS)\" and that method will always use the state_info as message.\n\n\nAs I see it when a unit test fails - you should be able (in most cases) understand the reason of the failure without rerunning and debugging - but I think this wish is out of scope :-).","commit_id":"459591c3ea80fe475b206cb25ff1eaafed66e4cc"}],"mistral/tests/unit/services/test_trigger_service.py":[{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"d4a68b7254feb8de562fe398ab4e4b310fcf9c85","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                                                           start_wf_mock):"},{"line_number":299,"context_line":"        eventlet.sleep(1)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        return trigger_count \u003d\u003d start_wf_mock.call_count"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a740942_f581c3c3","line":301,"updated":"2015-12-09 02:50:03.000000000","message":"How does this change here relate to the scope of this patch?","commit_id":"4a89fba3c6d150e3b2c4c67bec8fdc1b5d6f3272"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"20ec83f1133eb9b7b0dc37a44e3cc5c6f280624e","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                                                           start_wf_mock):"},{"line_number":299,"context_line":"        eventlet.sleep(1)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        return trigger_count \u003d\u003d start_wf_mock.call_count"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a740942_221e2470","line":301,"in_reply_to":"7a740942_f581c3c3","updated":"2015-12-09 07:59:23.000000000","message":"It does not. I have explained it in my comments in patchset 4.\nThis is a test that wasn\u0027t stable. I just fixed it on the way.","commit_id":"4a89fba3c6d150e3b2c4c67bec8fdc1b5d6f3272"}],"releasenotes/notes/support-cinder-v2-29deecbd1b35f823.yaml":[{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"54cf80ece7a711941affb2f773bd4710b866ee83","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Cinder V1 API has been deprecated since Juno dev cycle, and will be"},{"line_number":4,"context_line":"    removed in future, Mistral will support Cinder V2 API from Mitaka release."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a740942_fafc60b9","side":"PARENT","line":2,"updated":"2015-12-08 19:42:51.000000000","message":"I learned there can only be one prelude per release so I changed this to features.","commit_id":"209319e5074608adbff761d39bffaf6db5ce60ef"}],"releasenotes/notes/support-trove-534a1402e88f5e55.yaml":[{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"54cf80ece7a711941affb2f773bd4710b866ee83","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Mistral now supports Trove actions in workbook or workflow."},{"line_number":4,"context_line":"upgrade:"},{"line_number":5,"context_line":"  - During an upgrade to Mitaka, operators or administrators must use"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a740942_9a32fca5","side":"PARENT","line":2,"updated":"2015-12-08 19:42:51.000000000","message":"I learned that there can be only one prelude per release so I changed it to features.","commit_id":"209319e5074608adbff761d39bffaf6db5ce60ef"}]}
