)]}'
{"mistral/engine/default_engine.py":[{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"0bdf7dbe8fd74136095ecee83eea5ff3afba9fb8","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        # workflow complete."},{"line_number":212,"context_line":"        incomplete_tasks \u003d wf_utils.find_incomplete_task_executions(wf_ex)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        if [t for t in incomplete_tasks if not states.is_waiting(t.state)]:"},{"line_number":215,"context_line":"            return"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        if wf_ctrl.all_errors_handled():"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_9692ad56","line":214,"updated":"2015-12-14 20:02:05.000000000","message":"This condition could be more readable (I had to spend more time than I thought understanding this list comprehension): \n\n  if not any(states.is_waiting(t.state) for t in incomplete_tasks):","commit_id":"9cf5e75bf50568c3b691bfd81d73ee197ebd255a"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"eb6190d2d0797c993082645cd1402774b794625a","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        # workflow complete."},{"line_number":212,"context_line":"        incomplete_tasks \u003d wf_utils.find_incomplete_task_executions(wf_ex)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        if [t for t in incomplete_tasks if not states.is_waiting(t.state)]:"},{"line_number":215,"context_line":"            return"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        if wf_ctrl.all_errors_handled():"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_644bbe5a","line":214,"in_reply_to":"5a710552_9692ad56","updated":"2015-12-15 00:29:24.000000000","message":"Done","commit_id":"9cf5e75bf50568c3b691bfd81d73ee197ebd255a"}],"mistral/tests/unit/engine/test_join.py":[{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"0bdf7dbe8fd74136095ecee83eea5ff3afba9fb8","unresolved":false,"context_lines":[{"line_number":571,"context_line":"                - task2"},{"line_number":572,"context_line":"                - task4"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"            task2:"},{"line_number":575,"context_line":"              action: std.noop"},{"line_number":576,"context_line":"              on-success:"},{"line_number":577,"context_line":"                - task3"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_d65ef575","line":574,"updated":"2015-12-14 20:02:05.000000000","message":"Soft: Could you rename tasks according to branch which it belongs to? For example, task1 on-success will be task2.1 and task2.2. It helps to track these all tasks in mind.","commit_id":"9cf5e75bf50568c3b691bfd81d73ee197ebd255a"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"eb6190d2d0797c993082645cd1402774b794625a","unresolved":false,"context_lines":[{"line_number":571,"context_line":"                - task2"},{"line_number":572,"context_line":"                - task4"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"            task2:"},{"line_number":575,"context_line":"              action: std.noop"},{"line_number":576,"context_line":"              on-success:"},{"line_number":577,"context_line":"                - task3"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_e456ce05","line":574,"in_reply_to":"5a710552_d65ef575","updated":"2015-12-15 00:29:24.000000000","message":"Done. Not exactly what you suggested. 2.1 and 2.2 will be along the same WF branch and 3.1 and 3.2 will be along the second WF branch.","commit_id":"9cf5e75bf50568c3b691bfd81d73ee197ebd255a"}],"mistral/workflow/direct_workflow.py":[{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"0bdf7dbe8fd74136095ecee83eea5ff3afba9fb8","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        )"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        # TODO(rakhmerov): Temporary hack. See the previous comment."},{"line_number":290,"context_line":"        in_t_ex \u003d in_t_execs[-1] if in_t_execs else None"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        if not in_t_ex or not states.is_completed(in_t_ex.state):"},{"line_number":293,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_767701d5","line":290,"updated":"2015-12-14 20:02:05.000000000","message":"Just a question. Which kind of situation (or situation) may lead to inexisting task_ex for task_spec? I am a little bit confused.","commit_id":"9cf5e75bf50568c3b691bfd81d73ee197ebd255a"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"d1c939690a8513f34e0fe2def331a667e15419fe","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        )"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        # TODO(rakhmerov): Temporary hack. See the previous comment."},{"line_number":290,"context_line":"        in_t_ex \u003d in_t_execs[-1] if in_t_execs else None"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        if not in_t_ex or not states.is_completed(in_t_ex.state):"},{"line_number":293,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_ba777101","line":290,"in_reply_to":"5a710552_6f48775c","updated":"2015-12-15 08:31:42.000000000","message":"hmmm, that\u0027s strange. Ok, thanks","commit_id":"9cf5e75bf50568c3b691bfd81d73ee197ebd255a"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"eb6190d2d0797c993082645cd1402774b794625a","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        )"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        # TODO(rakhmerov): Temporary hack. See the previous comment."},{"line_number":290,"context_line":"        in_t_ex \u003d in_t_execs[-1] if in_t_execs else None"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        if not in_t_ex or not states.is_completed(in_t_ex.state):"},{"line_number":293,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_6f48775c","line":290,"in_reply_to":"5a710552_767701d5","updated":"2015-12-15 00:29:24.000000000","message":"I get the following error for the new unit test if I don\u0027t patch this line. Plus, I don\u0027t see why we can\u0027t code safe here regardless whether it\u0027s possible to have an empty list or not.\n\nTraceback (most recent call last):\n  File \"/home/vagrant/code/openstack/mistral/mistral/engine/default_executor.py\", line 62, in run_action\n    result \u003d action.run()\n  File \"/home/vagrant/code/openstack/mistral/mistral/actions/std_actions.py\", line 95, in run\n    raise exc.ActionException(\u0027Fail action expected exception.\u0027)\nmistral.exceptions.ActionException: Fail action expected exception.\n   ERROR [mistral.engine.default_engine] Failed to handle action execution result [id\u003d424072c5-4dc7-4a6d-a891-9cf8169a768b]: list index out of range\nTraceback (most recent call last):\n  File \"/home/vagrant/code/openstack/mistral/mistral/engine/default_engine.py\", line 259, in on_action_complete\n    self._on_task_state_change(task_ex, wf_ex)\n  File \"/home/vagrant/code/openstack/mistral/mistral/engine/default_engine.py\", line 185, in _on_task_state_change\n    cmds \u003d wf_ctrl.continue_workflow()\n  File \"/home/vagrant/code/openstack/mistral/mistral/workflow/base.py\", line 69, in continue_workflow\n    return self._find_next_commands()\n  File \"/home/vagrant/code/openstack/mistral/mistral/workflow/direct_workflow.py\", line 80, in _find_next_commands\n    cmds.extend(self._find_next_commands_for_task(t_ex))\n  File \"/home/vagrant/code/openstack/mistral/mistral/workflow/direct_workflow.py\", line 121, in _find_next_commands_for_task\n    if self._is_unsatisfied_join(cmd):\n  File \"/home/vagrant/code/openstack/mistral/mistral/workflow/direct_workflow.py\", line 265, in _is_unsatisfied_join\n    num \u003d len([1 for in_t_s in in_task_specs\n  File \"/home/vagrant/code/openstack/mistral/mistral/workflow/direct_workflow.py\", line 266, in \u003clistcomp\u003e\n    if self._triggers_join(task_spec, in_t_s)])\n  File \"/home/vagrant/code/openstack/mistral/mistral/workflow/direct_workflow.py\", line 290, in _triggers_join\n    in_t_ex \u003d in_t_execs[-1] \nIndexError: list index out of range","commit_id":"9cf5e75bf50568c3b691bfd81d73ee197ebd255a"}]}
