)]}'
{"mistral/api/controllers/v2/workflow.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"718fca1eec937ab7d2184223cde489225ec01a9a","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        argspec \u003d pecan.util._cfg(state.controller)[\u0027argspec\u0027]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        support_uuid \u003d \u0027support_uuid\u0027 in argspec.args"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if support_uuid and uuidutils.is_uuid_like(state.arguments.args[0]):"},{"line_number":124,"context_line":"            # Consider \u0027self\u0027 argument in argspec.args tuple."},{"line_number":125,"context_line":"            support_uuid_index \u003d argspec.args.index(\u0027support_uuid\u0027) - 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_9ae7f511","line":122,"updated":"2015-12-10 12:08:12.000000000","message":"Lingxian, I\u0027m strongly against implementing this via hook. It has nothing to do with web layer. It should work on DB api layer. We simply need to determine if the given string is a uuid and get an object by id if needed.","commit_id":"4312fc406ed18f39d401b6dbfdfb86fc89602453"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"1e15c66c5270fdb602a177a4ad6fea164ff7b769","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        support_uuid \u003d \u0027support_uuid\u0027 in argspec.args"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if support_uuid and uuidutils.is_uuid_like(state.arguments.args[0]):"},{"line_number":124,"context_line":"            # Consider \u0027self\u0027 argument in argspec.args tuple."},{"line_number":125,"context_line":"            support_uuid_index \u003d argspec.args.index(\u0027support_uuid\u0027) - 1"},{"line_number":126,"context_line":"            state.arguments.args[support_uuid_index] \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_dab33d09","line":123,"updated":"2015-12-10 12:08:29.000000000","message":"We could use this function (is_uuid_like) in db api layer to detect whether passed identifier UUID or not. Depending on this we could make a decision about what query to use: for name or id. IMO, it is not necessary to do PecanHook here.","commit_id":"4312fc406ed18f39d401b6dbfdfb86fc89602453"}],"mistral/tests/unit/api/v2/test_workflows.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"f9c4be9ff200aa8efd864c27f20f907c82b8064a","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        self.assertEqual(200, resp.status_int)"},{"line_number":159,"context_line":"        self.assertDictEqual(WF, resp.json)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @mock.patch(\"mistral.db.v2.sqlalchemy.api._get_workflow_definition_by_id\")"},{"line_number":162,"context_line":"    def test_get_with_uuid(self, db_mock):"},{"line_number":163,"context_line":"        resp \u003d self.app.get("},{"line_number":164,"context_line":"            \u0027/v2/workflows/123e4567-e89b-12d3-a456-426655440000\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_36970a92","line":161,"range":{"start_line":161,"start_character":10,"end_line":161,"end_character":15},"updated":"2015-12-17 11:31:05.000000000","message":"I\u0027m generally not against of having this test but I still don\u0027t understand why we need it. Again, the whole change is purely related to DB API functionality. It has nothing to do with API. So please add a unit test for DB layer, not for API. The same for all patches in this chain.","commit_id":"685c914524a741726b023694dc57ffaab5a8fa27"}]}
