)]}'
{"mistral/api/app.py":[{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"dd01c8ffcd03032b2c6c6efd0e6054683d2c2bfb","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"@functools.total_ordering"},{"line_number":82,"context_line":"class Version(object):"},{"line_number":83,"context_line":"    \"\"\"API Version object.\"\"\""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    string \u003d \u0027X-OpenStack-Mistral-API-Version\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_1f199379","line":82,"updated":"2015-12-10 21:58:10.000000000","message":"Other than the class properties, where is the Version object instantiated and tested?","commit_id":"052544828dc1d3291b232ce97dba6d9cc0dee713"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"dd01c8ffcd03032b2c6c6efd0e6054683d2c2bfb","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        :raises: webob.HTTPNotAcceptable"},{"line_number":101,"context_line":"        \"\"\""},{"line_number":102,"context_line":"        (self.major, self.minor) \u003d Version.parse_headers("},{"line_number":103,"context_line":"            headers, default_version, latest_version)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def __repr__(self):"},{"line_number":106,"context_line":"        return \u0027%s.%s\u0027 % (self.major, self.minor)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_a444f21a","line":103,"updated":"2015-12-10 21:58:10.000000000","message":"Please change style to\n\n(self.major, self.minor) \u003d Version.parse_headers(\n    headers,\n    default_version,\n    latest_version\n)","commit_id":"052544828dc1d3291b232ce97dba6d9cc0dee713"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"dd01c8ffcd03032b2c6c6efd0e6054683d2c2bfb","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        if len(version) !\u003d 2:"},{"line_number":131,"context_line":"            raise exceptions.NotAcceptableException(_("},{"line_number":132,"context_line":"                \"Invalid value for %s header\") % Version.string)"},{"line_number":133,"context_line":"        return version"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def __gt__(a, b):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_e492fa4a","line":132,"updated":"2015-12-10 21:58:10.000000000","message":"Please change style to \n\nraise exceptions.NotAcceptableException(\n    (\"Invalid value for %s header\") % Version.string\n)\n\nAlso, add a blank line before return","commit_id":"052544828dc1d3291b232ce97dba6d9cc0dee713"}],"mistral/tests/unit/api/test_middleware.py":[{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"dd01c8ffcd03032b2c6c6efd0e6054683d2c2bfb","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        # Load up our valid domain values before the application is created."},{"line_number":37,"context_line":"        cfg.CONF.set_override(\"allowed_origin\","},{"line_number":38,"context_line":"                              \"http://valid.example.com\","},{"line_number":39,"context_line":"                              group\u003d\u0027cors\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # Create the application."}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_65db6fee","line":38,"updated":"2015-12-10 21:58:10.000000000","message":"Please assign this URL to a constant and use the constant thru out the tests below.","commit_id":"052544828dc1d3291b232ce97dba6d9cc0dee713"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"dd01c8ffcd03032b2c6c6efd0e6054683d2c2bfb","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                     headers\u003d{"},{"line_number":56,"context_line":"                         \u0027Origin\u0027: \u0027http://valid.example.com\u0027,"},{"line_number":57,"context_line":"                         \u0027Access-Control-Request-Method\u0027: \u0027GET\u0027"},{"line_number":58,"context_line":"                     })"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        # Assert response status."},{"line_number":61,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_45a51345","line":58,"updated":"2015-12-10 21:58:10.000000000","message":"Please use this style.\n\nresponse \u003d self.app.options(\n    \u0027/\u0027,\n    headers\u003d{\n        \u0027Origin\u0027: ...,\n        \u0027Access-Control-Request-Method\u0027: ...\n    }\n)","commit_id":"052544828dc1d3291b232ce97dba6d9cc0dee713"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"dd01c8ffcd03032b2c6c6efd0e6054683d2c2bfb","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        # Assert response status."},{"line_number":61,"context_line":"        self.assertEqual("},{"line_number":62,"context_line":"            self._response_string(http_client.OK), response.status)"},{"line_number":63,"context_line":"        self.assertIn(\u0027Access-Control-Allow-Origin\u0027, response.headers)"},{"line_number":64,"context_line":"        self.assertEqual(\u0027http://valid.example.com\u0027,"},{"line_number":65,"context_line":"                         response.headers[\u0027Access-Control-Allow-Origin\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_2581e78f","line":62,"updated":"2015-12-10 21:58:10.000000000","message":"Please use this style.\n\nself.assertEqual(\n    self._response_string(http_client.OK),\n    response.status\n)","commit_id":"052544828dc1d3291b232ce97dba6d9cc0dee713"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"dd01c8ffcd03032b2c6c6efd0e6054683d2c2bfb","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                     headers\u003d{"},{"line_number":71,"context_line":"                         \u0027Origin\u0027: \u0027http://invalid.example.com\u0027,"},{"line_number":72,"context_line":"                         \u0027Access-Control-Request-Method\u0027: \u0027GET\u0027"},{"line_number":73,"context_line":"                     })"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # Assert response status."},{"line_number":76,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_457c33b5","line":73,"updated":"2015-12-10 21:58:10.000000000","message":"See comment above.","commit_id":"052544828dc1d3291b232ce97dba6d9cc0dee713"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"dd01c8ffcd03032b2c6c6efd0e6054683d2c2bfb","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # Assert response status."},{"line_number":76,"context_line":"        self.assertEqual("},{"line_number":77,"context_line":"            self._response_string(http_client.OK), response.status)"},{"line_number":78,"context_line":"        self.assertNotIn(\u0027Access-Control-Allow-Origin\u0027, response.headers)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def test_valid_cors_get_request(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_e5499f8f","line":77,"updated":"2015-12-10 21:58:10.000000000","message":"See comment above.","commit_id":"052544828dc1d3291b232ce97dba6d9cc0dee713"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"dd01c8ffcd03032b2c6c6efd0e6054683d2c2bfb","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            .get(\u0027/\u0027,"},{"line_number":83,"context_line":"                 headers\u003d{"},{"line_number":84,"context_line":"                     \u0027Origin\u0027: \u0027http://valid.example.com\u0027"},{"line_number":85,"context_line":"                 })"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # Assert response status."},{"line_number":88,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_8520dbb1","line":85,"updated":"2015-12-10 21:58:10.000000000","message":"See comment above.","commit_id":"052544828dc1d3291b232ce97dba6d9cc0dee713"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"dd01c8ffcd03032b2c6c6efd0e6054683d2c2bfb","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # Assert response status."},{"line_number":88,"context_line":"        self.assertEqual("},{"line_number":89,"context_line":"            self._response_string(http_client.OK), response.status)"},{"line_number":90,"context_line":"        self.assertIn(\u0027Access-Control-Allow-Origin\u0027, response.headers)"},{"line_number":91,"context_line":"        self.assertEqual(\u0027http://valid.example.com\u0027,"},{"line_number":92,"context_line":"                         response.headers[\u0027Access-Control-Allow-Origin\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_452af391","line":89,"updated":"2015-12-10 21:58:10.000000000","message":"See comment above.","commit_id":"052544828dc1d3291b232ce97dba6d9cc0dee713"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"dd01c8ffcd03032b2c6c6efd0e6054683d2c2bfb","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            .get(\u0027/\u0027,"},{"line_number":97,"context_line":"                 headers\u003d{"},{"line_number":98,"context_line":"                     \u0027Origin\u0027: \u0027http://invalid.example.com\u0027"},{"line_number":99,"context_line":"                 })"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # Assert response status."},{"line_number":102,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_e5175f52","line":99,"updated":"2015-12-10 21:58:10.000000000","message":"See comment above.","commit_id":"052544828dc1d3291b232ce97dba6d9cc0dee713"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"dd01c8ffcd03032b2c6c6efd0e6054683d2c2bfb","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # Assert response status."},{"line_number":102,"context_line":"        self.assertEqual("},{"line_number":103,"context_line":"            self._response_string(http_client.OK), response.status)"},{"line_number":104,"context_line":"        self.assertNotIn(\u0027Access-Control-Allow-Origin\u0027, response.headers)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_a511575f","line":103,"updated":"2015-12-10 21:58:10.000000000","message":"See comment above.","commit_id":"052544828dc1d3291b232ce97dba6d9cc0dee713"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"dd01c8ffcd03032b2c6c6efd0e6054683d2c2bfb","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # Assert response status."},{"line_number":102,"context_line":"        self.assertEqual("},{"line_number":103,"context_line":"            self._response_string(http_client.OK), response.status)"},{"line_number":104,"context_line":"        self.assertNotIn(\u0027Access-Control-Allow-Origin\u0027, response.headers)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_85077b1c","line":104,"updated":"2015-12-10 21:58:10.000000000","message":"Any need to include unit tests for POST, PUT, DELETE?","commit_id":"052544828dc1d3291b232ce97dba6d9cc0dee713"}]}