)]}'
{"mistral/db/v2/sqlalchemy/api.py":[{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"29b694a17ed04d3067ac1a47518a8d60b17d38a1","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            \"Workflow not found [workflow_identifier\u003d%s]\" % identifier"},{"line_number":363,"context_line":"        )"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    if wf_def.project_id !\u003d security.get_project_id():"},{"line_number":366,"context_line":"        raise exc.NotAllowedException("},{"line_number":367,"context_line":"            \"Can not delete workflow of other users. [workflow_identifier\u003d%s]\""},{"line_number":368,"context_line":"            % identifier"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_aca6b40c","line":365,"updated":"2015-12-14 08:09:33.000000000","message":"Just query.\nSo now on public workflow cannot be deleted or updated \nin other tenants ?","commit_id":"7cc3f45d34e7da0cd5d4b9a584fc681aacd3ae03"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"8ee441679ea012ae632cdbc8e5a95991764332e1","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            \"Workflow not found [workflow_identifier\u003d%s]\" % identifier"},{"line_number":363,"context_line":"        )"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    if wf_def.project_id !\u003d security.get_project_id():"},{"line_number":366,"context_line":"        raise exc.NotAllowedException("},{"line_number":367,"context_line":"            \"Can not delete workflow of other users. [workflow_identifier\u003d%s]\""},{"line_number":368,"context_line":"            % identifier"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_27ec1dba","line":365,"in_reply_to":"7a740942_aca6b40c","updated":"2015-12-14 08:44:47.000000000","message":"Yes.","commit_id":"7cc3f45d34e7da0cd5d4b9a584fc681aacd3ae03"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"29b694a17ed04d3067ac1a47518a8d60b17d38a1","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    cron_triggers \u003d _secure_query("},{"line_number":389,"context_line":"        models.CronTrigger,"},{"line_number":390,"context_line":"        models.CronTrigger.name"},{"line_number":391,"context_line":"    ).filter_by(workflow_name\u003dwf_name).all()"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    return [t[0] for t in cron_triggers]"},{"line_number":394,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_51280b9a","line":391,"updated":"2015-12-14 08:09:33.000000000","message":"Please modify here also. For identifier is uuid.","commit_id":"7cc3f45d34e7da0cd5d4b9a584fc681aacd3ae03"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"8ee441679ea012ae632cdbc8e5a95991764332e1","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    cron_triggers \u003d _secure_query("},{"line_number":389,"context_line":"        models.CronTrigger,"},{"line_number":390,"context_line":"        models.CronTrigger.name"},{"line_number":391,"context_line":"    ).filter_by(workflow_name\u003dwf_name).all()"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    return [t[0] for t in cron_triggers]"},{"line_number":394,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_472929e5","line":391,"in_reply_to":"7a740942_51280b9a","updated":"2015-12-14 08:44:47.000000000","message":"Nice catch, hardik, I\u0027ll update, thanks!","commit_id":"7cc3f45d34e7da0cd5d4b9a584fc681aacd3ae03"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"80cc7a4e96512e03ac0d0750d9ef4783b552ebf5","unresolved":false,"context_lines":[{"line_number":364,"context_line":"def delete_workflow_definition(identifier, session\u003dNone):"},{"line_number":365,"context_line":"    wf_def \u003d (_get_workflow_definition_by_id(identifier)"},{"line_number":366,"context_line":"              if uuidutils.is_uuid_like(identifier)"},{"line_number":367,"context_line":"              else _get_workflow_definition(identifier))"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    if not wf_def:"},{"line_number":370,"context_line":"        raise exc.NotFoundException("}],"source_content_type":"text/x-python","patch_set":6,"id":"5a710552_0add2114","line":367,"updated":"2015-12-15 01:30:37.000000000","message":"Can we push this logic to get_workflow_definition or _get_workflow_definition so we don\u0027t have to duplicate this whenever we get a workflow definition?","commit_id":"95b0e13b1e598458be9fcae905caf583ff72a75b"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"2cbe088707a292b6245373764d629f315bcc20a0","unresolved":false,"context_lines":[{"line_number":364,"context_line":"def delete_workflow_definition(identifier, session\u003dNone):"},{"line_number":365,"context_line":"    wf_def \u003d (_get_workflow_definition_by_id(identifier)"},{"line_number":366,"context_line":"              if uuidutils.is_uuid_like(identifier)"},{"line_number":367,"context_line":"              else _get_workflow_definition(identifier))"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    if not wf_def:"},{"line_number":370,"context_line":"        raise exc.NotFoundException("}],"source_content_type":"text/x-python","patch_set":6,"id":"5a710552_58a69ec2","line":367,"in_reply_to":"5a710552_0add2114","updated":"2015-12-15 05:04:56.000000000","message":"Done","commit_id":"95b0e13b1e598458be9fcae905caf583ff72a75b"}],"mistral/engine/action_handler.py":[{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"80cc7a4e96512e03ac0d0750d9ef4783b552ebf5","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    if action_def.action_class:"},{"line_number":95,"context_line":"        _inject_action_ctx_for_validating(action_def, input_dict)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # NOTE(lane): Don\u0027t validate action input if action initialization method"},{"line_number":98,"context_line":"    # contains ** argument."},{"line_number":99,"context_line":"    if \u0027**\u0027 not in action_def.input:"},{"line_number":100,"context_line":"        e_utils.validate_input(action_def, input_dict)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a710552_0a60c134","line":97,"updated":"2015-12-15 01:30:37.000000000","message":"LOL. Do we have to make this change in this patch?  Since this touches several different files, can you submit a different patch for name change?  When I look at this patchset overview, I actually thought how come this patchset requires touches to so many files.","commit_id":"95b0e13b1e598458be9fcae905caf583ff72a75b"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"2cbe088707a292b6245373764d629f315bcc20a0","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    if action_def.action_class:"},{"line_number":95,"context_line":"        _inject_action_ctx_for_validating(action_def, input_dict)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # NOTE(lane): Don\u0027t validate action input if action initialization method"},{"line_number":98,"context_line":"    # contains ** argument."},{"line_number":99,"context_line":"    if \u0027**\u0027 not in action_def.input:"},{"line_number":100,"context_line":"        e_utils.validate_input(action_def, input_dict)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a710552_f898aa6c","line":97,"in_reply_to":"5a710552_0a60c134","updated":"2015-12-15 05:04:56.000000000","message":":-) yes, it does make people confused with the name changes","commit_id":"95b0e13b1e598458be9fcae905caf583ff72a75b"}],"mistral/tests/unit/db/v2/test_sqlalchemy_db_api.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b55e450a7d275c1b589d0b90710b97ff6c4bd4a7","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            created.name"},{"line_number":357,"context_line":"        )"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def test_delete_other_project_workflow_definition(self):"},{"line_number":360,"context_line":"        created \u003d db_api.create_workflow_definition(WF_DEFINITIONS[0])"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        # Switch to another project."}],"source_content_type":"text/x-python","patch_set":8,"id":"3a7e1126_09f0b08f","line":359,"range":{"start_line":359,"start_character":8,"end_line":359,"end_character":53},"updated":"2015-12-17 12:24:22.000000000","message":"Same as in other patches. Mainly we need to test that we can use both id and name with the same effect. It must be here, in DB layer, not API.","commit_id":"0db5cc61e25903f77c0a17d08c8c954b071ee9a0"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"ef6fc88b7c0a00aac8a937d699716eb6852282bc","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            created.name"},{"line_number":357,"context_line":"        )"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def test_delete_other_project_workflow_definition(self):"},{"line_number":360,"context_line":"        created \u003d db_api.create_workflow_definition(WF_DEFINITIONS[0])"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        # Switch to another project."}],"source_content_type":"text/x-python","patch_set":8,"id":"3a7e1126_396fc493","line":359,"range":{"start_line":359,"start_character":8,"end_line":359,"end_character":53},"in_reply_to":"3a7e1126_09f0b08f","updated":"2015-12-18 05:32:40.000000000","message":"Done","commit_id":"0db5cc61e25903f77c0a17d08c8c954b071ee9a0"}]}