)]}'
{"mistral/engine/task_handler.py":[{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"c7b614203555f9593509bf5f0ba9e6f050b6c12c","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    # In some cases we can have no input, e.g. in case of \u0027with-items\u0027."},{"line_number":96,"context_line":"    if input_dicts:"},{"line_number":97,"context_line":"        for index, input_d in input_dicts:"},{"line_number":98,"context_line":"            _run_action_or_workflow(task_ex, task_spec, input_d, index,"},{"line_number":99,"context_line":"                                    wf_spec)"},{"line_number":100,"context_line":"    else:"},{"line_number":101,"context_line":"        _schedule_noop_action(task_ex, task_spec, wf_spec)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_c88e4f27","line":99,"range":{"start_line":98,"start_character":11,"end_line":99,"end_character":44},"updated":"2016-02-03 00:35:23.000000000","message":"Please use:\n _run_action_or_workflow(\n    task_ex,\n    task_spec,\n    input_d,\n    index,\n    wf_spec\n)","commit_id":"6eaa009b1a8d518f798d553af26d191269ea9982"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"8fc29fa4b0c6180c471ee5c1c5dfd2b1d42915de","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    # In some cases we can have no input, e.g. in case of \u0027with-items\u0027."},{"line_number":96,"context_line":"    if input_dicts:"},{"line_number":97,"context_line":"        for index, input_d in input_dicts:"},{"line_number":98,"context_line":"            _run_action_or_workflow(task_ex, task_spec, input_d, index,"},{"line_number":99,"context_line":"                                    wf_spec)"},{"line_number":100,"context_line":"    else:"},{"line_number":101,"context_line":"        _schedule_noop_action(task_ex, task_spec, wf_spec)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_134faf93","line":99,"range":{"start_line":98,"start_character":11,"end_line":99,"end_character":44},"in_reply_to":"5a5ae5dd_c88e4f27","updated":"2016-02-03 08:20:05.000000000","message":"Done","commit_id":"6eaa009b1a8d518f798d553af26d191269ea9982"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"c7b614203555f9593509bf5f0ba9e6f050b6c12c","unresolved":false,"context_lines":[{"line_number":382,"context_line":"            \"Task \u0027%s\u0027 is RUNNING [workflow_name \u003d %s]\" %"},{"line_number":383,"context_line":"            (t_name, task_spec.get_workflow_name()))"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        _schedule_run_workflow(task_ex, task_spec, input_dict, index)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"def _get_action_defaults(task_ex, task_spec):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_c8bbaf74","line":385,"range":{"start_line":385,"start_character":7,"end_line":385,"end_character":69},"updated":"2016-02-03 00:35:23.000000000","message":"wf_spec can be used here.","commit_id":"6eaa009b1a8d518f798d553af26d191269ea9982"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"8fc29fa4b0c6180c471ee5c1c5dfd2b1d42915de","unresolved":false,"context_lines":[{"line_number":382,"context_line":"            \"Task \u0027%s\u0027 is RUNNING [workflow_name \u003d %s]\" %"},{"line_number":383,"context_line":"            (t_name, task_spec.get_workflow_name()))"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        _schedule_run_workflow(task_ex, task_spec, input_dict, index)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"def _get_action_defaults(task_ex, task_spec):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_f330d309","line":385,"range":{"start_line":385,"start_character":7,"end_line":385,"end_character":69},"in_reply_to":"5a5ae5dd_3f8dd77b","updated":"2016-02-03 08:20:05.000000000","message":"Yeah I was a bit confused by which spec it mapped to in that function. I believe it\u0027s the parent one?","commit_id":"6eaa009b1a8d518f798d553af26d191269ea9982"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"b904421dad85b9b9e7915009b6f4e61b08d66e82","unresolved":false,"context_lines":[{"line_number":382,"context_line":"            \"Task \u0027%s\u0027 is RUNNING [workflow_name \u003d %s]\" %"},{"line_number":383,"context_line":"            (t_name, task_spec.get_workflow_name()))"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        _schedule_run_workflow(task_ex, task_spec, input_dict, index)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"def _get_action_defaults(task_ex, task_spec):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_3f8dd77b","line":385,"range":{"start_line":385,"start_character":7,"end_line":385,"end_character":69},"in_reply_to":"5a5ae5dd_c8bbaf74","updated":"2016-02-03 02:36:44.000000000","message":"i agree with hardik here. See https://github.com/openstack/mistral/blob/master/mistral/engine/task_handler.py#L455","commit_id":"6eaa009b1a8d518f798d553af26d191269ea9982"}],"mistral/workbook/v2/tasks.py":[{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"c7b614203555f9593509bf5f0ba9e6f050b6c12c","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        self._process_action_and_workflow()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def validate_schema(self):"},{"line_number":115,"context_line":"        super(TaskSpec, self).validate_schema()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        action \u003d self._data.get(\u0027action\u0027)"},{"line_number":118,"context_line":"        workflow \u003d self._data.get(\u0027workflow\u0027)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # Validate YAQL expressions."},{"line_number":121,"context_line":"        if action or workflow:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_8b0e11e4","line":118,"range":{"start_line":115,"start_character":7,"end_line":118,"end_character":45},"updated":"2016-02-03 00:35:23.000000000","message":"Why self._transform_with_items() is deleted ?","commit_id":"6eaa009b1a8d518f798d553af26d191269ea9982"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"8fc29fa4b0c6180c471ee5c1c5dfd2b1d42915de","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        self._process_action_and_workflow()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def validate_schema(self):"},{"line_number":115,"context_line":"        super(TaskSpec, self).validate_schema()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        action \u003d self._data.get(\u0027action\u0027)"},{"line_number":118,"context_line":"        workflow \u003d self._data.get(\u0027workflow\u0027)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # Validate YAQL expressions."},{"line_number":121,"context_line":"        if action or workflow:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_9322bfb8","line":118,"range":{"start_line":115,"start_character":7,"end_line":118,"end_character":45},"in_reply_to":"5a5ae5dd_8b0e11e4","updated":"2016-02-03 08:20:05.000000000","message":"It\u0027s called in __init__, so calling it twice doesn\u0027t give extra validation that I can see.","commit_id":"6eaa009b1a8d518f798d553af26d191269ea9982"}],"mistral/workflow/base.py":[{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"c7b614203555f9593509bf5f0ba9e6f050b6c12c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    \"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __init__(self, wf_ex, wf_spec\u003dNone):"},{"line_number":44,"context_line":"        \"\"\"Creates a new workflow controller."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        :param wf_ex: Workflow execution."},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        self.wf_ex \u003d wf_ex"},{"line_number":49,"context_line":"        if wf_spec is None:"},{"line_number":50,"context_line":"            wf_spec \u003d spec_parser.get_workflow_spec(wf_ex.spec)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_4bf8197d","line":47,"range":{"start_line":44,"start_character":5,"end_line":47,"end_character":11},"updated":"2016-02-03 00:35:23.000000000","message":"soft: Please add doc for wf_spec also.","commit_id":"6eaa009b1a8d518f798d553af26d191269ea9982"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"8fc29fa4b0c6180c471ee5c1c5dfd2b1d42915de","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    \"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __init__(self, wf_ex, wf_spec\u003dNone):"},{"line_number":44,"context_line":"        \"\"\"Creates a new workflow controller."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        :param wf_ex: Workflow execution."},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        self.wf_ex \u003d wf_ex"},{"line_number":49,"context_line":"        if wf_spec is None:"},{"line_number":50,"context_line":"            wf_spec \u003d spec_parser.get_workflow_spec(wf_ex.spec)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_33066b21","line":47,"range":{"start_line":44,"start_character":5,"end_line":47,"end_character":11},"in_reply_to":"5a5ae5dd_4bf8197d","updated":"2016-02-03 08:20:05.000000000","message":"Done","commit_id":"6eaa009b1a8d518f798d553af26d191269ea9982"},{"author":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"change_message_id":"b904421dad85b9b9e7915009b6f4e61b08d66e82","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.wf_ex \u003d wf_ex"},{"line_number":49,"context_line":"        if wf_spec is None:"},{"line_number":50,"context_line":"            wf_spec \u003d spec_parser.get_workflow_spec(wf_ex.spec)"},{"line_number":51,"context_line":"        self.wf_spec \u003d wf_spec"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _update_task_ex_env(self, task_ex, env):"},{"line_number":54,"context_line":"        if not env:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_ff3bbf9a","line":51,"updated":"2016-02-03 02:36:44.000000000","message":"self.wf_spec \u003d wf_spec or spec_parser.get_workflow_spec(wf_ex.spec)","commit_id":"6eaa009b1a8d518f798d553af26d191269ea9982"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"8fc29fa4b0c6180c471ee5c1c5dfd2b1d42915de","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.wf_ex \u003d wf_ex"},{"line_number":49,"context_line":"        if wf_spec is None:"},{"line_number":50,"context_line":"            wf_spec \u003d spec_parser.get_workflow_spec(wf_ex.spec)"},{"line_number":51,"context_line":"        self.wf_spec \u003d wf_spec"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _update_task_ex_env(self, task_ex, env):"},{"line_number":54,"context_line":"        if not env:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_1326ceba","line":51,"in_reply_to":"5a5ae5dd_ff3bbf9a","updated":"2016-02-03 08:20:05.000000000","message":"Can I argue with this one? It\u0027s really not the same, eg if you implement boolean logic on the spec object. I could do:\n\nself.wf_spec \u003d wf_spec if wf_spec is not None else spec_parser.get_workflow_spec(wf_ex.spec)\n\nBut it\u0027s not really more clear to me.","commit_id":"6eaa009b1a8d518f798d553af26d191269ea9982"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"c7b614203555f9593509bf5f0ba9e6f050b6c12c","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        if not wf_spec:"},{"line_number":197,"context_line":"            wf_spec \u003d spec_parser.get_workflow_spec(wf_ex[\u0027spec\u0027])"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        return WorkflowController._get_class(wf_spec.get_type())(wf_ex,"},{"line_number":200,"context_line":"                                                                 wf_spec)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_6b1dd50e","line":200,"range":{"start_line":199,"start_character":0,"end_line":200,"end_character":73},"updated":"2016-02-03 00:35:23.000000000","message":"Use,\nreturn WorkflowController._get_class(wf_spec.get_type())(\n    wf_ex,\n    wf_spec\n)","commit_id":"6eaa009b1a8d518f798d553af26d191269ea9982"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"8fc29fa4b0c6180c471ee5c1c5dfd2b1d42915de","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        if not wf_spec:"},{"line_number":197,"context_line":"            wf_spec \u003d spec_parser.get_workflow_spec(wf_ex[\u0027spec\u0027])"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        return WorkflowController._get_class(wf_spec.get_type())(wf_ex,"},{"line_number":200,"context_line":"                                                                 wf_spec)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_f32452b0","line":200,"range":{"start_line":199,"start_character":0,"end_line":200,"end_character":73},"in_reply_to":"5a5ae5dd_6b1dd50e","updated":"2016-02-03 08:20:05.000000000","message":"Done","commit_id":"6eaa009b1a8d518f798d553af26d191269ea9982"}]}