)]}'
{"mistral/config.py":[{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"45b4ab805de5e1072ba55cdf24b29a23a0db3beb","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    \"\"\"Update default configuration options for oslo.middleware.\"\"\""},{"line_number":199,"context_line":"    # CORS Defaults"},{"line_number":200,"context_line":"    # TODO(krotscheck): Update with https://review.openstack.org/#/c/285368/"},{"line_number":201,"context_line":"    cfg.set_defaults(cors.CORS_OPTS,"},{"line_number":202,"context_line":"                     allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":203,"context_line":"                                    \u0027X-Identity-Status\u0027,"},{"line_number":204,"context_line":"                                    \u0027X-Roles\u0027,"},{"line_number":205,"context_line":"                                    \u0027X-Service-Catalog\u0027,"},{"line_number":206,"context_line":"                                    \u0027X-User-Id\u0027,"},{"line_number":207,"context_line":"                                    \u0027X-Tenant-Id\u0027,"},{"line_number":208,"context_line":"                                    \u0027X-Project-Id\u0027,"},{"line_number":209,"context_line":"                                    \u0027X-User-Name\u0027,"},{"line_number":210,"context_line":"                                    \u0027X-Project-Name\u0027],"},{"line_number":211,"context_line":"                     expose_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":212,"context_line":"                                     \u0027X-Subject-Token\u0027,"},{"line_number":213,"context_line":"                                     \u0027X-Service-Token\u0027,"},{"line_number":214,"context_line":"                                     \u0027X-Project-Id\u0027,"},{"line_number":215,"context_line":"                                     \u0027X-User-Name\u0027,"},{"line_number":216,"context_line":"                                     \u0027X-Project-Name\u0027],"},{"line_number":217,"context_line":"                     allow_methods\u003d[\u0027GET\u0027,"},{"line_number":218,"context_line":"                                    \u0027PUT\u0027,"},{"line_number":219,"context_line":"                                    \u0027POST\u0027,"},{"line_number":220,"context_line":"                                    \u0027DELETE\u0027,"},{"line_number":221,"context_line":"                                    \u0027PATCH\u0027]"},{"line_number":222,"context_line":"                     )"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_4e8e5428","line":222,"range":{"start_line":201,"start_character":4,"end_line":222,"end_character":22},"updated":"2016-03-07 03:17:54.000000000","message":"Please use following formatting:\ncfg.set_defaults(\n    cors.CORS_OPTS,\n    allow_headers\u003d[\u0027X-Auth-Token\u0027, \u0027X-Identity-Status\u0027, \u0027X-Roles\u0027,\n                   \u0027X-Service-Catalog\u0027, \u0027X-User-Id\u0027, \u0027X-Tenant-Id\u0027\n                   \u0027X-Project-Id\u0027, \u0027X-User-Name\u0027, \u0027X-Project-Name\u0027],\n    allow_methods\u003d[\u0027GET\u0027, \u0027PUT\u0027, \u0027POST\u0027, \u0027DELETE\u0027, \u0027PATCH\u0027],\n    expose_headers\u003d[\u0027X-Auth-Token\u0027, \u0027X-Subject-Token\u0027,\n                    \u0027X-Service-Token\u0027, \u0027X-Project-Id\u0027, \u0027X-User-Name\u0027,\n                    \u0027X-Project-Name\u0027]\n)","commit_id":"4f3c87a2b2d401de5d88b74493aa0d8b37854559"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"de520617b5d6096af37bdd60b5540407080f460e","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    )"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"def set_config_defaults():"},{"line_number":193,"context_line":"    \"\"\"This method updates all configuration default values.\"\"\""},{"line_number":194,"context_line":"    set_cors_middleware_defaults()"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_b7c16ee6","line":192,"updated":"2016-03-10 20:14:26.000000000","message":"why we need this method?","commit_id":"095781ea7c27669cc4c6b38bf9413f70d3489fa9"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"ac3a9dfd34b88d709d85cd122721cbb20e3a8025","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    )"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"def set_config_defaults():"},{"line_number":193,"context_line":"    \"\"\"This method updates all configuration default values.\"\"\""},{"line_number":194,"context_line":"    set_cors_middleware_defaults()"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_3ad9c3f3","line":192,"in_reply_to":"5aef4532_b7c16ee6","updated":"2016-03-10 20:28:23.000000000","message":"It\u0027s not so much that we need this method, but that we need the other one. For the whole project, it makes sense to have one method that overrides all defaults. It should be generic. For the oslo-config default hooks though, we need to have a method per genconfig entry. Hence the two methods.","commit_id":"095781ea7c27669cc4c6b38bf9413f70d3489fa9"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"de520617b5d6096af37bdd60b5540407080f460e","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    \"\"\"Update default configuration options for oslo.middleware.\"\"\""},{"line_number":199,"context_line":"    # CORS Defaults"},{"line_number":200,"context_line":"    # TODO(krotscheck): Update with https://review.openstack.org/#/c/285368/"},{"line_number":201,"context_line":"    cfg.set_defaults(cors.CORS_OPTS,"},{"line_number":202,"context_line":"                     allow_headers\u003d[\u0027X-Auth-Token\u0027, \u0027X-Identity-Status\u0027,"},{"line_number":203,"context_line":"                                    \u0027X-Roles\u0027, \u0027X-Service-Catalog\u0027,"},{"line_number":204,"context_line":"                                    \u0027X-User-Id\u0027, \u0027X-Tenant-Id\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_377a7e24","line":201,"updated":"2016-03-10 20:14:26.000000000","message":"please see hardik\u0027s comment about the code formatting.","commit_id":"095781ea7c27669cc4c6b38bf9413f70d3489fa9"}]}