)]}'
{"mistral/api/controllers/v2/action_execution.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"eba980cf5b433f39e7b703589bbd2be3a9bef4f7","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            % (id, action_ex)"},{"line_number":172,"context_line":"        )"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        output \u003d action_ex.output"},{"line_number":175,"context_line":"        if action_ex.state \u003d\u003d states.SUCCESS:"},{"line_number":176,"context_line":"            result \u003d wf_utils.Result(data\u003doutput)"},{"line_number":177,"context_line":"        elif action_ex.state \u003d\u003d states.ERROR:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_d20c52ee","line":174,"range":{"start_line":174,"start_character":27,"end_line":174,"end_character":33},"updated":"2016-05-26 04:53:45.000000000","message":"Soft: Please insert a blank line before condition.","commit_id":"4050787c5df811dfb43b77692954f5d956c91a55"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"59d2d76cb4adb5dce87fcaa18a5da385347765a3","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            result \u003d wf_utils.Result(data\u003doutput)"},{"line_number":177,"context_line":"        elif action_ex.state \u003d\u003d states.ERROR:"},{"line_number":178,"context_line":"            if not output:"},{"line_number":179,"context_line":"                output \u003d \u0027Unknown error\u0027"},{"line_number":180,"context_line":"            result \u003d wf_utils.Result(error\u003doutput)"},{"line_number":181,"context_line":"        else:"},{"line_number":182,"context_line":"            raise exc.InvalidResultException("}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_a7e7e310","line":179,"range":{"start_line":179,"start_character":16,"end_line":179,"end_character":22},"updated":"2016-05-25 18:28:37.000000000","message":"\u0027output\u0027 is jsontype not string type.","commit_id":"4050787c5df811dfb43b77692954f5d956c91a55"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"0e2a9b7170d46c284ef323e3175cb6deddfd2aa7","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            result \u003d wf_utils.Result(data\u003doutput)"},{"line_number":177,"context_line":"        elif action_ex.state \u003d\u003d states.ERROR:"},{"line_number":178,"context_line":"            if not output:"},{"line_number":179,"context_line":"                output \u003d \u0027Unknown error\u0027"},{"line_number":180,"context_line":"            result \u003d wf_utils.Result(error\u003doutput)"},{"line_number":181,"context_line":"        else:"},{"line_number":182,"context_line":"            raise exc.InvalidResultException("}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_35a82877","line":179,"range":{"start_line":179,"start_character":16,"end_line":179,"end_character":22},"in_reply_to":"bab6814e_12225a52","updated":"2016-05-26 05:43:21.000000000","message":"Thanks !","commit_id":"4050787c5df811dfb43b77692954f5d956c91a55"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"eba980cf5b433f39e7b703589bbd2be3a9bef4f7","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            result \u003d wf_utils.Result(data\u003doutput)"},{"line_number":177,"context_line":"        elif action_ex.state \u003d\u003d states.ERROR:"},{"line_number":178,"context_line":"            if not output:"},{"line_number":179,"context_line":"                output \u003d \u0027Unknown error\u0027"},{"line_number":180,"context_line":"            result \u003d wf_utils.Result(error\u003doutput)"},{"line_number":181,"context_line":"        else:"},{"line_number":182,"context_line":"            raise exc.InvalidResultException("}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_12225a52","line":179,"range":{"start_line":179,"start_character":16,"end_line":179,"end_character":22},"in_reply_to":"bab6814e_124d3a3e","updated":"2016-05-26 04:53:45.000000000","message":"Actually this change is correct because string is a JSON compatible type. This JsonType() uses json.dumps(value) to convert to a base type (string) and it will work fine.","commit_id":"4050787c5df811dfb43b77692954f5d956c91a55"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"09da2726d060c20f7c9d213eeb906b579337c474","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            result \u003d wf_utils.Result(data\u003doutput)"},{"line_number":177,"context_line":"        elif action_ex.state \u003d\u003d states.ERROR:"},{"line_number":178,"context_line":"            if not output:"},{"line_number":179,"context_line":"                output \u003d \u0027Unknown error\u0027"},{"line_number":180,"context_line":"            result \u003d wf_utils.Result(error\u003doutput)"},{"line_number":181,"context_line":"        else:"},{"line_number":182,"context_line":"            raise exc.InvalidResultException("}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_81a276ac","line":179,"range":{"start_line":179,"start_character":16,"end_line":179,"end_character":22},"in_reply_to":"bab6814e_35a82877","updated":"2016-05-26 07:56:56.000000000","message":"Honestly I just took the message from the last line of the bug (see link below). If someone has a strong preference for a different message, I will happily change it.\nhttps://bugs.launchpad.net/mistral/+bug/1581514","commit_id":"4050787c5df811dfb43b77692954f5d956c91a55"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"60a259ab6511277fe6f16185068e30e5e58feb09","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            result \u003d wf_utils.Result(data\u003doutput)"},{"line_number":177,"context_line":"        elif action_ex.state \u003d\u003d states.ERROR:"},{"line_number":178,"context_line":"            if not output:"},{"line_number":179,"context_line":"                output \u003d \u0027Unknown error\u0027"},{"line_number":180,"context_line":"            result \u003d wf_utils.Result(error\u003doutput)"},{"line_number":181,"context_line":"        else:"},{"line_number":182,"context_line":"            raise exc.InvalidResultException("}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_f2c23684","line":179,"range":{"start_line":179,"start_character":16,"end_line":179,"end_character":22},"in_reply_to":"bab6814e_a7e7e310","updated":"2016-05-26 04:46:03.000000000","message":"Yes, seems like. For that reason please write a simple test that checks that in mistral.tests.unit.api.v2.test_action_executions.\n\nThanks","commit_id":"4050787c5df811dfb43b77692954f5d956c91a55"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"ef5a4856bc2f6009f31949e54574633b5bb15375","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            result \u003d wf_utils.Result(data\u003doutput)"},{"line_number":177,"context_line":"        elif action_ex.state \u003d\u003d states.ERROR:"},{"line_number":178,"context_line":"            if not output:"},{"line_number":179,"context_line":"                output \u003d \u0027Unknown error\u0027"},{"line_number":180,"context_line":"            result \u003d wf_utils.Result(error\u003doutput)"},{"line_number":181,"context_line":"        else:"},{"line_number":182,"context_line":"            raise exc.InvalidResultException("}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_124d3a3e","line":179,"range":{"start_line":179,"start_character":16,"end_line":179,"end_character":22},"in_reply_to":"bab6814e_f2c23684","updated":"2016-05-26 04:47:03.000000000","message":"Oooh, sorry! There is a test, taking my words back and continue to review..","commit_id":"4050787c5df811dfb43b77692954f5d956c91a55"}]}