)]}'
{"mistral/services/scheduler.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"23d11906685952a99a5c78eff60598e5a9b39e06","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                # Call the method."},{"line_number":172,"context_line":"                target_method(**method_args)"},{"line_number":173,"context_line":"            except Exception as e:"},{"line_number":174,"context_line":"                LOG.exception(\"Delayed call failed [exception\u003d%s]: %s\","},{"line_number":175,"context_line":"                              target_method, e)"},{"line_number":176,"context_line":"            finally:"},{"line_number":177,"context_line":"                # Remove context."}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_3a38afd2","line":174,"updated":"2016-06-02 02:45:40.000000000","message":"\u0027target_method\u0027 is not \u0027exception\u0027, how about using the following:\n\n    LOG.exception(\"Delayed call failed, method %s, exception: %s\", target_method, e)","commit_id":"2f3aa765604137ee60b1c02fb1df394fda9dadf0"},{"author":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"change_message_id":"80dceaed3f055514adbc1a0d1cdc235bd1244606","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                # Call the method."},{"line_number":172,"context_line":"                target_method(**method_args)"},{"line_number":173,"context_line":"            except Exception as e:"},{"line_number":174,"context_line":"                LOG.exception(\"Delayed call failed [exception\u003d%s]: %s\","},{"line_number":175,"context_line":"                              target_method, e)"},{"line_number":176,"context_line":"            finally:"},{"line_number":177,"context_line":"                # Remove context."}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_f52a9e2e","line":174,"in_reply_to":"9abb7d3a_3a38afd2","updated":"2016-06-02 13:29:39.000000000","message":"That\u0027s fine, I wasn\u0027t sure exactly what format would be wanted.","commit_id":"2f3aa765604137ee60b1c02fb1df394fda9dadf0"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"ead113364e95a63173da7c3546fad06e7f537672","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                # Call the method."},{"line_number":172,"context_line":"                target_method(**method_args)"},{"line_number":173,"context_line":"            except Exception as e:"},{"line_number":174,"context_line":"                LOG.exception(\"Delayed call failed [exception\u003d%s]: %s\","},{"line_number":175,"context_line":"                              target_method, e)"},{"line_number":176,"context_line":"            finally:"},{"line_number":177,"context_line":"                # Remove context."}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_11fdd16d","line":174,"in_reply_to":"9abb7d3a_3a38afd2","updated":"2016-06-02 04:16:03.000000000","message":"Yes, agree with Lingxian.","commit_id":"2f3aa765604137ee60b1c02fb1df394fda9dadf0"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"4c6e851919fafeb4f35f47f573321b56c00c61ac","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                # Call the method."},{"line_number":172,"context_line":"                target_method(**method_args)"},{"line_number":173,"context_line":"            except Exception as e:"},{"line_number":174,"context_line":"                LOG.exception(\"Delayed call failed, method: %s, exception: %s\","},{"line_number":175,"context_line":"                              target_method, e)"},{"line_number":176,"context_line":"            finally:"},{"line_number":177,"context_line":"                # Remove context."},{"line_number":178,"context_line":"                context.set_ctx(None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_2e3b2b9e","line":175,"range":{"start_line":174,"start_character":0,"end_line":175,"end_character":47},"updated":"2016-06-02 16:23:49.000000000","message":"When method call takes more then one line it should looks like this due to mistral convention:\n\nLOG.exception(\n    \"Delayed call failed, method: %s, exception: %s\",\n    target_method, e\n)","commit_id":"bd13f6e48fd0f85917b3286302d4ef50f451d31d"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"c80584dadbe9ca805aa3b22a94d243d150cd1e2b","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                # Call the method."},{"line_number":172,"context_line":"                target_method(**method_args)"},{"line_number":173,"context_line":"            except Exception as e:"},{"line_number":174,"context_line":"                LOG.exception(\"Delayed call failed, method: %s, exception: %s\","},{"line_number":175,"context_line":"                              target_method, e)"},{"line_number":176,"context_line":"            finally:"},{"line_number":177,"context_line":"                # Remove context."},{"line_number":178,"context_line":"                context.set_ctx(None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_59b8eae5","line":175,"range":{"start_line":174,"start_character":0,"end_line":175,"end_character":47},"in_reply_to":"9abb7d3a_1f1acf17","updated":"2016-06-02 20:55:58.000000000","message":"It\u0027s only a blueprint https://blueprints.launchpad.net/mistral/+spec/add-custom-code-style-checks \n\nand it is pointing to https://etherpad.openstack.org/p/mistral-additional-codestyle-checks\n\nbut since it is still not in official guide/pep-8 I\u0027m removing my -1","commit_id":"bd13f6e48fd0f85917b3286302d4ef50f451d31d"},{"author":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"change_message_id":"74d25b212b960807f7473f9dedf405734670539e","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                # Call the method."},{"line_number":172,"context_line":"                target_method(**method_args)"},{"line_number":173,"context_line":"            except Exception as e:"},{"line_number":174,"context_line":"                LOG.exception(\"Delayed call failed, method: %s, exception: %s\","},{"line_number":175,"context_line":"                              target_method, e)"},{"line_number":176,"context_line":"            finally:"},{"line_number":177,"context_line":"                # Remove context."},{"line_number":178,"context_line":"                context.set_ctx(None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_1f1acf17","line":175,"range":{"start_line":174,"start_character":0,"end_line":175,"end_character":47},"in_reply_to":"9abb7d3a_2e3b2b9e","updated":"2016-06-02 17:15:14.000000000","message":"Really? I\u0027m new to this project, but it appears to be done as I wrote it many other places. It passes pep8, so I\u0027m going to leave it as is unless there\u0027s some document that explicitly states this preference.","commit_id":"bd13f6e48fd0f85917b3286302d4ef50f451d31d"},{"author":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"change_message_id":"88afc168a65bebd23b05120bc1430e3afb938ae0","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                # Call the method."},{"line_number":172,"context_line":"                target_method(**method_args)"},{"line_number":173,"context_line":"            except Exception as e:"},{"line_number":174,"context_line":"                LOG.exception(\"Delayed call failed, method: %s, exception: %s\","},{"line_number":175,"context_line":"                              target_method, e)"},{"line_number":176,"context_line":"            finally:"},{"line_number":177,"context_line":"                # Remove context."},{"line_number":178,"context_line":"                context.set_ctx(None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_4303d80f","line":175,"range":{"start_line":174,"start_character":0,"end_line":175,"end_character":47},"in_reply_to":"9abb7d3a_39c6c616","updated":"2016-06-02 22:03:30.000000000","message":"You provided exactly what I requested, so I\u0027ll just change it. Appreciate you removing the -1 though.","commit_id":"bd13f6e48fd0f85917b3286302d4ef50f451d31d"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"8e4e37c1d48ecaa17bf7f41ab10e76a0b568907f","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                # Call the method."},{"line_number":172,"context_line":"                target_method(**method_args)"},{"line_number":173,"context_line":"            except Exception as e:"},{"line_number":174,"context_line":"                LOG.exception(\"Delayed call failed, method: %s, exception: %s\","},{"line_number":175,"context_line":"                              target_method, e)"},{"line_number":176,"context_line":"            finally:"},{"line_number":177,"context_line":"                # Remove context."},{"line_number":178,"context_line":"                context.set_ctx(None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_39c6c616","line":175,"range":{"start_line":174,"start_character":0,"end_line":175,"end_character":47},"in_reply_to":"9abb7d3a_59b8eae5","updated":"2016-06-02 21:04:26.000000000","message":"Oh, and due to mentioned convention this code should look like this:\nLOG.exception(\n    \"Delayed call failed, method: %s, exception: %s\",\n    target_method,\n    e\n)","commit_id":"bd13f6e48fd0f85917b3286302d4ef50f451d31d"}]}