)]}'
{"mistral/actions/std_actions.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"37f92fbbab608123897b02d7305ac06187d38703","unresolved":false,"context_lines":[{"line_number":441,"context_line":"    This action sleeps for given amount of seconds. It can be mostly useful"},{"line_number":442,"context_line":"    for testing and debugging purposes."},{"line_number":443,"context_line":"    \"\"\""},{"line_number":444,"context_line":"    def __init__(self, sleep_time\u003d1):"},{"line_number":445,"context_line":"        try:"},{"line_number":446,"context_line":"            self._sleep \u003d int(sleep_time)"},{"line_number":447,"context_line":"            self._sleep \u003d 0 if self._sleep \u003c 0 else self._sleep"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_014f11be","line":444,"range":{"start_line":444,"start_character":23,"end_line":444,"end_character":33},"updated":"2016-06-22 10:06:58.000000000","message":"How about renaming \"sleep_time\" to \"seconds\"? IMO it would look cool:\n\nstd.sleep seconds\u003d12","commit_id":"7caadda6cb284c545ff2865d054432a692a74525"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"0afc8aedc7611f35121c83bf9c715b4a742a7c86","unresolved":false,"context_lines":[{"line_number":441,"context_line":"    This action sleeps for given amount of seconds. It can be mostly useful"},{"line_number":442,"context_line":"    for testing and debugging purposes."},{"line_number":443,"context_line":"    \"\"\""},{"line_number":444,"context_line":"    def __init__(self, sleep_time\u003d1):"},{"line_number":445,"context_line":"        try:"},{"line_number":446,"context_line":"            self._sleep \u003d int(sleep_time)"},{"line_number":447,"context_line":"            self._sleep \u003d 0 if self._sleep \u003c 0 else self._sleep"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_7c12fa63","line":444,"range":{"start_line":444,"start_character":23,"end_line":444,"end_character":33},"in_reply_to":"3aaa91ec_014f11be","updated":"2016-06-22 10:31:28.000000000","message":"OK, will do","commit_id":"7caadda6cb284c545ff2865d054432a692a74525"}],"mistral/tests/unit/engine/test_workflow_resume.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"37f92fbbab608123897b02d7305ac06187d38703","unresolved":false,"context_lines":[{"line_number":171,"context_line":"          - pause"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"      task2:"},{"line_number":174,"context_line":"        action: std.sleep sleep_time\u003d5"},{"line_number":175,"context_line":"        # This one won\u0027t be finished when execution is already PAUSED."},{"line_number":176,"context_line":"        on-complete:"},{"line_number":177,"context_line":"          - task4"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_bc41023c","line":174,"range":{"start_line":174,"start_character":25,"end_line":174,"end_character":26},"updated":"2016-06-22 10:06:58.000000000","message":"We can also use \"std.async_noop\" here. It will never finish unless we send result to Mistral engine explicitly.\n\nBtw, why did you choose 5 seconds? Keep in mind that behavior of the workflow is not different because previously action would never end. Now it\u0027s synchronous and it will end in 5 seconds.","commit_id":"7caadda6cb284c545ff2865d054432a692a74525"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"0afc8aedc7611f35121c83bf9c715b4a742a7c86","unresolved":false,"context_lines":[{"line_number":171,"context_line":"          - pause"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"      task2:"},{"line_number":174,"context_line":"        action: std.sleep sleep_time\u003d5"},{"line_number":175,"context_line":"        # This one won\u0027t be finished when execution is already PAUSED."},{"line_number":176,"context_line":"        on-complete:"},{"line_number":177,"context_line":"          - task4"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_22216c4e","line":174,"range":{"start_line":174,"start_character":25,"end_line":174,"end_character":26},"in_reply_to":"3aaa91ec_bc41023c","updated":"2016-06-22 10:31:28.000000000","message":"Oh, OK. I was thinking that the intention of using mistral_http here is to simulate something that would last for long, but would eventually end. I didn\u0027t know that you have to explicitly tell mistral that mistral_http action completed.\n\nI choose 5 seconds randomly - based on my previous assumptions (that mistral_http is used for simulating long running action)\n\nSo I would change mistral_http to async_noop. The question is - do we want to delete std.sleep or we want to leave it because it may be useful in some cases?","commit_id":"7caadda6cb284c545ff2865d054432a692a74525"}]}