)]}'
{"mistral/api/controllers/v2/types.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"eebc966f41303065303eaa1c1ec1c8d90976ed10","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        return value"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def frombasetype(self, value):"},{"line_number":110,"context_line":"        if isinstance(value, basestring) \u003d\u003d False:"},{"line_number":111,"context_line":"            value \u003d json.dumps(value)"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_4a2211ba","line":110,"updated":"2016-07-01 09:03:13.000000000","message":"basestring is Python 2 only. To handle this in Python 2 and 3 you need to do something like this:\n\n    try:\n      basestring\n    except NameError:\n      basestring \u003d str\n\nIt would also be better to write \"if not isinstance(value, basestring):\"","commit_id":"c69594f8a2f8b8a59b56b112fcf49b077b1621bb"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"eebc966f41303065303eaa1c1ec1c8d90976ed10","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    def frombasetype(self, value):"},{"line_number":110,"context_line":"        if isinstance(value, basestring) \u003d\u003d False:"},{"line_number":111,"context_line":"            value \u003d json.dumps(value)"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            pass"},{"line_number":114,"context_line":"        return json.loads(value) if value is not None else None"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_8a287998","line":112,"updated":"2016-07-01 09:03:13.000000000","message":"I would remove the else and pass","commit_id":"c69594f8a2f8b8a59b56b112fcf49b077b1621bb"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"eebc966f41303065303eaa1c1ec1c8d90976ed10","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            value \u003d json.dumps(value)"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            pass"},{"line_number":114,"context_line":"        return json.loads(value) if value is not None else None"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def tobasetype(self, value):"},{"line_number":117,"context_line":"        # Value must be a dict."}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_4d106b4e","line":114,"updated":"2016-07-01 09:03:13.000000000","message":"I think this would read much better:\n\n    if value is not None:\n        return json.loads(value)","commit_id":"c69594f8a2f8b8a59b56b112fcf49b077b1621bb"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"6267c079fe2b32c98af6c18bd0bb935fd01f6b02","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        return value"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def frombasetype(self, value):"},{"line_number":110,"context_line":"        if isinstance(value, dict):"},{"line_number":111,"context_line":"            value \u003d json.dumps(value)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        if value is not None:"},{"line_number":114,"context_line":"            return json.loads(value)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def tobasetype(self, value):"},{"line_number":117,"context_line":"        # Value must be a dict."}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_b569298e","line":114,"range":{"start_line":110,"start_character":8,"end_line":114,"end_character":36},"updated":"2016-07-04 05:10:56.000000000","message":"What\u0027s happening here? Can you explain why you added data conversion in the opposite direction in the same method? There are two different methods for this.","commit_id":"a586a3eb7daa2382478e66762af119577544250b"}]}