)]}'
{"mistral/actions/openstack/actions.py":[{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"f7f167678b868372e83e70a0a09639218a0298c1","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        glance_endpoint \u003d keystone_utils.get_endpoint_for_project(\u0027glance\u0027)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        return GlanceAction._get_client_class()("},{"line_number":101,"context_line":"            glance_endpoint.url,"},{"line_number":102,"context_line":"            region_name\u003dglance_endpoint.region,"},{"line_number":103,"context_line":"            token\u003dctx.auth_token"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_ec9d300b","line":100,"range":{"start_line":100,"start_character":15,"end_line":100,"end_character":28},"updated":"2016-07-06 10:58:57.000000000","message":"It is better to leave self._method() here. Call using classname is old-style coding in Python. Ditto for all below calls.","commit_id":"9eee2019786704a32b40c2a22b966f51b6255a6c"}],"mistral/actions/openstack/base.py":[{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"bf95c83ad993d9884e069c6023d3b2422a03df55","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        saving into DB."},{"line_number":65,"context_line":"        \"\"\""},{"line_number":66,"context_line":"        # Default is simple _get_client_class instance"},{"line_number":67,"context_line":"        return cls._get_client_class()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @classmethod"},{"line_number":70,"context_line":"    def get_fake_client_method(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_4c68c487","line":67,"range":{"start_line":67,"start_character":15,"end_line":67,"end_character":38},"updated":"2016-07-06 10:48:58.000000000","message":"But this default will not work because _get_client_class method doesn\u0027t exist in this base class.","commit_id":"9eee2019786704a32b40c2a22b966f51b6255a6c"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"31fc925a36e6e4d0685dd26a5135f9c95914c24a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        saving into DB."},{"line_number":65,"context_line":"        \"\"\""},{"line_number":66,"context_line":"        # Default is simple _get_client_class instance"},{"line_number":67,"context_line":"        return cls._get_client_class()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @classmethod"},{"line_number":70,"context_line":"    def get_fake_client_method(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_8cbd8cb9","line":67,"range":{"start_line":67,"start_character":15,"end_line":67,"end_character":38},"in_reply_to":"1aa78d24_4c68c487","updated":"2016-07-06 10:52:30.000000000","message":"cls._get_client_class() doesn\u0027t return an instance of class, it returns the class. For returning an instance it should be cls._get_client_class()(). Looks weird.","commit_id":"9eee2019786704a32b40c2a22b966f51b6255a6c"}]}