)]}'
{"mistral/engine/actions.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"db453a7cb2b46cf43a2862d2be161e22c70dc092","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.action_ex.output \u003d {\u0027result\u0027: msg}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @abc.abstractmethod"},{"line_number":78,"context_line":"    def schedule(self, input_dict, target, index\u003d0, desc\u003d\u0027\u0027, idempotent\u003dFalse):"},{"line_number":79,"context_line":"        \"\"\"Schedule action run."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        This method is needed to schedule action run so its result can"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_3d6d2dcd","line":78,"range":{"start_line":78,"start_character":61,"end_line":78,"end_character":71},"updated":"2016-07-08 06:15:40.000000000","message":"I wonder if \"idempotent\" is a good name for parameter name. Yes, it is very precise  and comes from math world but maybe we need to come up with something more user-friendly and simple as \"rerun_allowed\" or \"safe_rerun\".\n\nEspecially, when you get to making DSL changes we need to come up with a very good consistent name because we won\u0027t be able to change it any time soon.\n\nWhat do you think?","commit_id":"a7b4ca195ddca038449c4682b045e3628c559723"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"fb8bd3c92a9a6f7be3881dc01be60040fc1b8259","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.action_ex.output \u003d {\u0027result\u0027: msg}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @abc.abstractmethod"},{"line_number":78,"context_line":"    def schedule(self, input_dict, target, index\u003d0, desc\u003d\u0027\u0027, idempotent\u003dFalse):"},{"line_number":79,"context_line":"        \"\"\"Schedule action run."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        This method is needed to schedule action run so its result can"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_2ea03ea5","line":78,"range":{"start_line":78,"start_character":61,"end_line":78,"end_character":71},"in_reply_to":"1aa78d24_3d6d2dcd","updated":"2016-07-08 15:16:56.000000000","message":"I agree that \u0027safe_rerun\u0027 is a better name for DSL. I\u0027ll change it also in engine for sake of consistency.","commit_id":"a7b4ca195ddca038449c4682b045e3628c559723"}],"mistral/engine/rpc/ack_patterns.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"46fa30223f1b429d0f8a71246c1fe04e7d21fe84","unresolved":false,"context_lines":[{"line_number":22,"context_line":"]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def get_process_type(idempotent):"},{"line_number":26,"context_line":"    if idempotent:"},{"line_number":27,"context_line":"        return PROCESS_THEN_ACK"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_a7709edd","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":20},"updated":"2016-07-11 08:37:08.000000000","message":"Let\u0027s rename to \"get_ack_type\"?","commit_id":"dda5e37b6841d849eb12ab70cad885006066de7f"}],"mistral/engine/rpc/rpc.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"db453a7cb2b46cf43a2862d2be161e22c70dc092","unresolved":false,"context_lines":[{"line_number":538,"context_line":"            \u0027action_class_str\u0027: action_class_str,"},{"line_number":539,"context_line":"            \u0027attributes\u0027: attributes,"},{"line_number":540,"context_line":"            \u0027params\u0027: action_params,"},{"line_number":541,"context_line":"            \u0027process_type\u0027: rpc_utils.get_process_type(idempotent)"},{"line_number":542,"context_line":"        }"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        rpc_client_method \u003d (self._client.async_call"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_dd29898b","line":541,"range":{"start_line":541,"start_character":28,"end_line":541,"end_character":66},"updated":"2016-07-08 06:15:40.000000000","message":"This method could be a part of ack_types module I mentioned.","commit_id":"a7b4ca195ddca038449c4682b045e3628c559723"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"fb8bd3c92a9a6f7be3881dc01be60040fc1b8259","unresolved":false,"context_lines":[{"line_number":538,"context_line":"            \u0027action_class_str\u0027: action_class_str,"},{"line_number":539,"context_line":"            \u0027attributes\u0027: attributes,"},{"line_number":540,"context_line":"            \u0027params\u0027: action_params,"},{"line_number":541,"context_line":"            \u0027process_type\u0027: rpc_utils.get_process_type(idempotent)"},{"line_number":542,"context_line":"        }"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        rpc_client_method \u003d (self._client.async_call"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_0e30e29d","line":541,"range":{"start_line":541,"start_character":28,"end_line":541,"end_character":66},"in_reply_to":"1aa78d24_dd29898b","updated":"2016-07-08 15:16:56.000000000","message":"Done","commit_id":"a7b4ca195ddca038449c4682b045e3628c559723"}],"mistral/utils/rpc_utils.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"db453a7cb2b46cf43a2862d2be161e22c70dc092","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def get_process_type(idempotent):"},{"line_number":49,"context_line":"    if idempotent:"},{"line_number":50,"context_line":"        return PROCESS_THEN_ACK"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_f9473a75","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":20},"updated":"2016-07-08 06:15:40.000000000","message":"Like in the previous patch, I would like to call it differently. Like \"ack_type\".","commit_id":"a7b4ca195ddca038449c4682b045e3628c559723"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"fb8bd3c92a9a6f7be3881dc01be60040fc1b8259","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def get_process_type(idempotent):"},{"line_number":49,"context_line":"    if idempotent:"},{"line_number":50,"context_line":"        return PROCESS_THEN_ACK"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_ee191624","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":20},"in_reply_to":"1aa78d24_f9473a75","updated":"2016-07-08 15:16:56.000000000","message":"Done","commit_id":"a7b4ca195ddca038449c4682b045e3628c559723"}]}