)]}'
{"id":"openstack%2Fmistral~342076","triplet_id":"openstack%2Fmistral~master~Ibce9a40bc63ed63173b91e5f03cf71125537cf73","project":"openstack/mistral","branch":"master","topic":"remove_redundant_param_in_task_controller","hashtags":[],"change_id":"Ibce9a40bc63ed63173b91e5f03cf71125537cf73","subject":"Fixing filtering in task controller","status":"MERGED","created":"2016-07-14 09:52:39.000000000","updated":"2016-07-14 12:04:06.000000000","submitted":"2016-07-14 12:04:05.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3c1902a04015c7d9df1e2a9baa4afb34193a0145","_number":342076,"virtual_id_number":342076,"owner":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8592,"name":"Anastasia Kuznetsova","email":"akuznetsova@mirantis.com","username":"nastya-kuz"},{"value":2,"date":"2016-07-14 12:04:05.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},{"value":0,"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},{"value":0,"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"value":0,"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"value":0,"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8592,"name":"Anastasia Kuznetsova","email":"akuznetsova@mirantis.com","username":"nastya-kuz"},"all":[{"value":2,"date":"2016-07-14 11:54:00.000000000","_account_id":8592,"name":"Anastasia Kuznetsova","email":"akuznetsova@mirantis.com","username":"nastya-kuz"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},{"value":0,"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},{"value":0,"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"value":0,"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"value":2,"date":"2016-07-14 11:25:25.000000000","_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8592,"name":"Anastasia Kuznetsova","email":"akuznetsova@mirantis.com","username":"nastya-kuz"},"all":[{"value":1,"date":"2016-07-14 11:54:00.000000000","_account_id":8592,"name":"Anastasia Kuznetsova","email":"akuznetsova@mirantis.com","username":"nastya-kuz"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},{"value":0,"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},{"value":0,"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"value":0,"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"value":0,"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},{"_account_id":8592,"name":"Anastasia Kuznetsova","email":"akuznetsova@mirantis.com","username":"nastya-kuz"},{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-07-14 09:53:44.000000000","updated_by":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"reviewer":{"_account_id":5558,"name":"Winson Chan","email":"wcchan@stackstorm.com","username":"winson-c-chan"},"state":"REVIEWER"},{"updated":"2016-07-14 09:53:44.000000000","updated_by":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"reviewer":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"state":"REVIEWER"},{"updated":"2016-07-14 09:53:44.000000000","updated_by":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"reviewer":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"state":"REVIEWER"},{"updated":"2016-07-14 11:25:25.000000000","updated_by":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"reviewer":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"state":"REVIEWER"},{"updated":"2016-07-14 11:54:00.000000000","updated_by":{"_account_id":8592,"name":"Anastasia Kuznetsova","email":"akuznetsova@mirantis.com","username":"nastya-kuz"},"reviewer":{"_account_id":8592,"name":"Anastasia Kuznetsova","email":"akuznetsova@mirantis.com","username":"nastya-kuz"},"state":"REVIEWER"},{"updated":"2016-07-14 12:04:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d4042088bc2b49578ab3ac1c9e05f70a2346eb86","author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"date":"2016-07-14 09:52:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"574fa2efedd509ce4d29f791e3d9fe97e8b04775","author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"date":"2016-07-14 10:02:43.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"243dd48d0fc72dd5745c296bfa18ae7cf6bf1208","author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"date":"2016-07-14 10:14:30.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"55f3c3a71f2784124cb58c0ea03a6fe5bbc6e838","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-14 10:26:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-mistral-docs http://docs-draft.openstack.org/76/342076/1/check/gate-mistral-docs/8406623//doc/build/html/ : SUCCESS in 3m 58s\n- gate-mistral-pep8 http://logs.openstack.org/76/342076/1/check/gate-mistral-pep8/a17dbc8/ : SUCCESS in 2m 52s\n- gate-mistral-python27 http://logs.openstack.org/76/342076/1/check/gate-mistral-python27/226445c/ : SUCCESS in 6m 54s\n- gate-mistral-python34 http://logs.openstack.org/76/342076/1/check/gate-mistral-python34/0ab682f/ : SUCCESS in 6m 49s\n- gate-mistral-python35-nv http://logs.openstack.org/76/342076/1/check/gate-mistral-python35-nv/517dbaa/ : SUCCESS in 8m 00s (non-voting)\n- gate-rally-dsvm-mistral-task http://logs.openstack.org/76/342076/1/check/gate-rally-dsvm-mistral-task/b1a313b/ : SUCCESS in 19m 08s (non-voting)\n- gate-mistral-devstack-dsvm http://logs.openstack.org/76/342076/1/check/gate-mistral-devstack-dsvm/5865d48/ : FAILURE in 32m 48s (non-voting)\n- gate-mistral-tox-db-unit-postgresql http://logs.openstack.org/76/342076/1/check/gate-mistral-tox-db-unit-postgresql/661f57b/ : SUCCESS in 19m 04s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9e8e6049510b60ea6c78fbcfb0b13fe6362d4bef","author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"date":"2016-07-14 10:55:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"24e223605eba1109af5588b7345bab52bbfe8dd6","author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"date":"2016-07-14 11:25:25.000000000","message":"Patch Set 2: Code-Review+2\n\nassuming jenkins will pass","accounts_in_message":[],"_revision_number":2},{"id":"a603b226c513dcc54869f604f84ea906f450c3ac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-14 11:33:57.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-mistral-docs http://docs-draft.openstack.org/76/342076/2/check/gate-mistral-docs/17ea436//doc/build/html/ : SUCCESS in 3m 31s\n- gate-mistral-pep8 http://logs.openstack.org/76/342076/2/check/gate-mistral-pep8/ef90146/ : SUCCESS in 5m 39s\n- gate-mistral-python27 http://logs.openstack.org/76/342076/2/check/gate-mistral-python27/71df0f1/ : SUCCESS in 9m 37s\n- gate-mistral-python34 http://logs.openstack.org/76/342076/2/check/gate-mistral-python34/95e7a2b/ : SUCCESS in 9m 37s\n- gate-mistral-python35-nv http://logs.openstack.org/76/342076/2/check/gate-mistral-python35-nv/0a13370/ : SUCCESS in 10m 07s (non-voting)\n- gate-rally-dsvm-mistral-task http://logs.openstack.org/76/342076/2/check/gate-rally-dsvm-mistral-task/45cdd9b/ : SUCCESS in 24m 40s (non-voting)\n- gate-mistral-devstack-dsvm http://logs.openstack.org/76/342076/2/check/gate-mistral-devstack-dsvm/3274fe9/ : FAILURE in 36m 27s (non-voting)\n- gate-mistral-tox-db-unit-postgresql http://logs.openstack.org/76/342076/2/check/gate-mistral-tox-db-unit-postgresql/bb32f1c/ : SUCCESS in 21m 35s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"f81fe3b5ca1957c260dfaf96bcef74b7e5ea2510","author":{"_account_id":8592,"name":"Anastasia Kuznetsova","email":"akuznetsova@mirantis.com","username":"nastya-kuz"},"date":"2016-07-14 11:54:00.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"8816d85dba0ca3d81dbbf293356258d7b27a5f43","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-14 11:54:18.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"aa6f72db54cf206483cc8e1f878c7538f6edea99","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-14 12:04:05.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-mistral-docs http://docs-draft.openstack.org/76/342076/2/gate/gate-mistral-docs/a1aaf79//doc/build/html/ : SUCCESS in 4m 58s\n- gate-mistral-pep8 http://logs.openstack.org/76/342076/2/gate/gate-mistral-pep8/a42ef88/ : SUCCESS in 3m 56s\n- gate-mistral-python27 http://logs.openstack.org/76/342076/2/gate/gate-mistral-python27/83b2625/ : SUCCESS in 9m 34s\n- gate-mistral-python34 http://logs.openstack.org/76/342076/2/gate/gate-mistral-python34/f1b7c97/ : SUCCESS in 8m 07s","accounts_in_message":[],"_revision_number":2},{"id":"48cccda85502eaebf655b9bcc097e228933beb47","date":"2016-07-14 12:04:06.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1dbb3f25251b6acd8c185d768750803e192a9a31","revisions":{"b9701dd10b3ac57a89361f52d779885de9312b83":{"kind":"REWORK","_number":1,"created":"2016-07-14 09:52:39.000000000","uploader":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"ref":"refs/changes/76/342076/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/mistral","ref":"refs/changes/76/342076/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/mistral refs/changes/76/342076/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/mistral refs/changes/76/342076/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/mistral refs/changes/76/342076/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/mistral refs/changes/76/342076/1"}}},"commit":{"parents":[{"commit":"d0009166e09a5788999dec40c017094c6baa17c5","subject":"Merge \"Release note for KeyCloak OIDC support\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/d0009166e09a5788999dec40c017094c6baa17c5"}]}],"author":{"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","date":"2016-07-14 09:51:22.000000000","tz":420},"committer":{"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","date":"2016-07-14 09:51:22.000000000","tz":420},"subject":"Remove redundant param in task controller function","message":"Remove redundant param in task controller function\n\n* _get_task_resources_with_results() was given one extra parameter\n  \"wf_ex_id\" whereas it was already passed in **filters\n\nChange-Id: Ibce9a40bc63ed63173b91e5f03cf71125537cf73\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/b9701dd10b3ac57a89361f52d779885de9312b83"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/b9701dd10b3ac57a89361f52d779885de9312b83"}]},"branch":"refs/heads/master"},"1dbb3f25251b6acd8c185d768750803e192a9a31":{"kind":"REWORK","_number":2,"created":"2016-07-14 10:55:39.000000000","uploader":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"ref":"refs/changes/76/342076/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/mistral","ref":"refs/changes/76/342076/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/mistral refs/changes/76/342076/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/mistral refs/changes/76/342076/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/mistral refs/changes/76/342076/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/mistral refs/changes/76/342076/2"}}},"commit":{"parents":[{"commit":"d0009166e09a5788999dec40c017094c6baa17c5","subject":"Merge \"Release note for KeyCloak OIDC support\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/d0009166e09a5788999dec40c017094c6baa17c5"}]}],"author":{"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","date":"2016-07-14 09:51:22.000000000","tz":420},"committer":{"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","date":"2016-07-14 10:53:15.000000000","tz":420},"subject":"Fixing filtering in task controller","message":"Fixing filtering in task controller\n\n* _get_task_resources_with_results() was given one extra parameter\n  \"wf_ex_id\" whereas it was already passed in **filters. It was all\n  wrong as we just need to pass \"workflow_execution_id\" in filters\n* There was also wrong \"id\" filter which gave empty db list every\n  time\n\nTODO:\n * Add tests to check filtering in controllers\n\nChange-Id: Ibce9a40bc63ed63173b91e5f03cf71125537cf73\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/1dbb3f25251b6acd8c185d768750803e192a9a31"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/1dbb3f25251b6acd8c185d768750803e192a9a31"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}