)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"fb16c1a1e6697287474cd165d77dce2e623d17bb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the new endpoint /v2/tasks/\u003cid\u003e/workflow_executions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* This new endpoint is needed to be able to navigate through a workflow tree"},{"line_number":10,"context_line":"  from parent workflows down to nested workflows"},{"line_number":11,"context_line":"* This endpoint is added for symmetry with /v2/tasks/\u003cid\u003e/action_executions"},{"line_number":12,"context_line":"* Added the new module resources.py under mistral.api.controllers.v2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_88e58fdd","line":9,"range":{"start_line":9,"start_character":2,"end_line":9,"end_character":76},"updated":"2016-07-20 09:03:59.000000000","message":"Soft: Some of the lines are over 80 characters long, but I\u0027m not sure if we have such convention for commit messages.","commit_id":"56b900b5b50dce8dc3c2614b374f98fd3292e8ec"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"f9c4f0558ca7a3144e2ad6044fc81ea99a0ca55d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the new endpoint /v2/tasks/\u003cid\u003e/workflow_executions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* This new endpoint is needed to be able to navigate through a workflow tree"},{"line_number":10,"context_line":"  from parent workflows down to nested workflows"},{"line_number":11,"context_line":"* This endpoint is added for symmetry with /v2/tasks/\u003cid\u003e/action_executions"},{"line_number":12,"context_line":"* Added the new module resources.py under mistral.api.controllers.v2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_38bdd0b7","line":9,"range":{"start_line":9,"start_character":2,"end_line":9,"end_character":76},"in_reply_to":"dada55a8_88e58fdd","updated":"2016-07-20 09:33:19.000000000","message":"As far as I know, we don\u0027t for not-summary lines. But I can fix it.","commit_id":"56b900b5b50dce8dc3c2614b374f98fd3292e8ec"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"fb16c1a1e6697287474cd165d77dce2e623d17bb","unresolved":false,"context_lines":[{"line_number":23,"context_line":"* Move all REST resources to resources.py module"},{"line_number":24,"context_line":"* Move all sub-controllers to same modules as main controllers"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Partially implements: blueprint bp/mistral-task-subexecutions-endpoint"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I6cbcd83cf9ac4ad5c38bda435c3b2300c42043ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_68b3fbe9","line":26,"range":{"start_line":26,"start_character":32,"end_line":26,"end_character":35},"updated":"2016-07-20 09:03:59.000000000","message":"Soft: please remove this so the http link is valid","commit_id":"56b900b5b50dce8dc3c2614b374f98fd3292e8ec"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"f9c4f0558ca7a3144e2ad6044fc81ea99a0ca55d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"* Move all REST resources to resources.py module"},{"line_number":24,"context_line":"* Move all sub-controllers to same modules as main controllers"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Partially implements: blueprint bp/mistral-task-subexecutions-endpoint"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I6cbcd83cf9ac4ad5c38bda435c3b2300c42043ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_58dfe40c","line":26,"range":{"start_line":26,"start_character":32,"end_line":26,"end_character":35},"in_reply_to":"dada55a8_68b3fbe9","updated":"2016-07-20 09:33:19.000000000","message":"Yes, good catch!","commit_id":"56b900b5b50dce8dc3c2614b374f98fd3292e8ec"}],"mistral/api/controllers/v2/task.py":[{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"fb16c1a1e6697287474cd165d77dce2e623d17bb","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class TasksController(rest.RestController):"},{"line_number":235,"context_line":"    action_executions \u003d action_execution.TasksActionExecutionController()"},{"line_number":236,"context_line":"    workflow_executions \u003d TaskExecutionsController()"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    @rest_utils.wrap_wsme_controller_exception"},{"line_number":239,"context_line":"    @wsme_pecan.wsexpose(Task, wtypes.text)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_22763f06","line":236,"range":{"start_line":236,"start_character":3,"end_line":236,"end_character":52},"updated":"2016-07-20 09:03:59.000000000","message":"This seems unused?","commit_id":"56b900b5b50dce8dc3c2614b374f98fd3292e8ec"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"f9c4f0558ca7a3144e2ad6044fc81ea99a0ca55d","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class TasksController(rest.RestController):"},{"line_number":235,"context_line":"    action_executions \u003d action_execution.TasksActionExecutionController()"},{"line_number":236,"context_line":"    workflow_executions \u003d TaskExecutionsController()"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    @rest_utils.wrap_wsme_controller_exception"},{"line_number":239,"context_line":"    @wsme_pecan.wsexpose(Task, wtypes.text)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_f8e05898","line":236,"range":{"start_line":236,"start_character":3,"end_line":236,"end_character":52},"in_reply_to":"dada55a8_22763f06","updated":"2016-07-20 09:33:19.000000000","message":"No, this is the whole meaning of this patch. Pecan framework creates endpoints based on analysis of REST controllers. In this case, based on this field it will create /workflow_executions subendpoint (look at the test).","commit_id":"56b900b5b50dce8dc3c2614b374f98fd3292e8ec"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"182ad35640e64d263d1350f845e6f19aa6a50482","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class TasksController(rest.RestController):"},{"line_number":235,"context_line":"    action_executions \u003d action_execution.TasksActionExecutionController()"},{"line_number":236,"context_line":"    workflow_executions \u003d TaskExecutionsController()"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    @rest_utils.wrap_wsme_controller_exception"},{"line_number":239,"context_line":"    @wsme_pecan.wsexpose(Task, wtypes.text)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_3b382aef","line":236,"range":{"start_line":236,"start_character":3,"end_line":236,"end_character":52},"in_reply_to":"dada55a8_f8e05898","updated":"2016-07-20 09:51:41.000000000","message":"I didn\u0027t know about this. Thanks!","commit_id":"56b900b5b50dce8dc3c2614b374f98fd3292e8ec"}],"mistral/tests/unit/api/v2/test_executions.py":[{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"fb16c1a1e6697287474cd165d77dce2e623d17bb","unresolved":false,"context_lines":[{"line_number":542,"context_line":"        self.assertDictEqual("},{"line_number":543,"context_line":"            SUB_WF_EX_JSON_WITH_DESC,"},{"line_number":544,"context_line":"            resp.json[\u0027executions\u0027][0]"},{"line_number":545,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_42c373ed","line":545,"updated":"2016-07-20 09:03:59.000000000","message":"Maybe it is worth to also add test_get_task_workflow_executions_workflow_not_found test?","commit_id":"56b900b5b50dce8dc3c2614b374f98fd3292e8ec"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"f9c4f0558ca7a3144e2ad6044fc81ea99a0ca55d","unresolved":false,"context_lines":[{"line_number":542,"context_line":"        self.assertDictEqual("},{"line_number":543,"context_line":"            SUB_WF_EX_JSON_WITH_DESC,"},{"line_number":544,"context_line":"            resp.json[\u0027executions\u0027][0]"},{"line_number":545,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_5814049f","line":545,"in_reply_to":"dada55a8_42c373ed","updated":"2016-07-20 09:33:19.000000000","message":"Yes, indeed. This series of patches is not finished yet and I\u0027m planning to add more tests for sure.","commit_id":"56b900b5b50dce8dc3c2614b374f98fd3292e8ec"}]}