)]}'
{"mistral/tests/unit/engine/test_error_handling.py":[{"author":{"_account_id":8592,"name":"Anastasia Kuznetsova","email":"akuznetsova@mirantis.com","username":"nastya-kuz"},"change_message_id":"d44fa7630d01323aac7de0e3ec58f23531d1c356","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        # must not affect action state."},{"line_number":202,"context_line":"        task_execs \u003d wf_ex.task_executions"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        # NOTE: task3 must not run because on-error handler triggers only"},{"line_number":205,"context_line":"        # on error outcome of an action (or workflow) associated with a task."},{"line_number":206,"context_line":"        self.assertEqual(1, len(task_execs))"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_3980f2f4","line":204,"updated":"2016-07-21 10:44:41.000000000","message":"Renat, according what you said \" on-error handler triggers only on error outcome of an action\", am I right that it also works for on-success trigger? So if actions is success, but whole task is on Error state, on-success transition should work?","commit_id":"ef531c1cde0561d7f951fc69a987f8e565c8da98"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"1a150910f211087b9f03d0e86981c39357b53037","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        # must not affect action state."},{"line_number":202,"context_line":"        task_execs \u003d wf_ex.task_executions"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        # NOTE: task3 must not run because on-error handler triggers only"},{"line_number":205,"context_line":"        # on error outcome of an action (or workflow) associated with a task."},{"line_number":206,"context_line":"        self.assertEqual(1, len(task_execs))"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_b234c1fb","line":204,"in_reply_to":"dada55a8_3980f2f4","updated":"2016-07-22 09:38:54.000000000","message":"I think on-success should happen after publish the result, so, the answer is no, right?","commit_id":"ef531c1cde0561d7f951fc69a987f8e565c8da98"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"50da6034f9f43f30439aaacf1ae5e141fcab0c01","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        # must not affect action state."},{"line_number":202,"context_line":"        task_execs \u003d wf_ex.task_executions"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        # NOTE: task3 must not run because on-error handler triggers only"},{"line_number":205,"context_line":"        # on error outcome of an action (or workflow) associated with a task."},{"line_number":206,"context_line":"        self.assertEqual(1, len(task_execs))"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        task_ex \u003d self._assert_single_item("}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_3047a04c","line":205,"range":{"start_line":204,"start_character":0,"end_line":205,"end_character":77},"updated":"2016-07-20 11:50:40.000000000","message":"Soft: maybe change to \"task3 must not run because error happend during publish. On-error tasks would only be run if there is an error during action execution\"","commit_id":"ef531c1cde0561d7f951fc69a987f8e565c8da98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"fd362cff78f5103920c83f5d496d561d160318fc","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        # must not affect action state."},{"line_number":202,"context_line":"        task_execs \u003d wf_ex.task_executions"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        # NOTE: task3 must not run because on-error handler triggers only"},{"line_number":205,"context_line":"        # on error outcome of an action (or workflow) associated with a task."},{"line_number":206,"context_line":"        self.assertEqual(1, len(task_execs))"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        task_ex \u003d self._assert_single_item("}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_b0b710f4","line":205,"range":{"start_line":204,"start_character":0,"end_line":205,"end_character":77},"in_reply_to":"dada55a8_3047a04c","updated":"2016-07-20 11:54:30.000000000","message":"Yes.","commit_id":"ef531c1cde0561d7f951fc69a987f8e565c8da98"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"50da6034f9f43f30439aaacf1ae5e141fcab0c01","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            name\u003d\u0027std.noop\u0027,"},{"line_number":221,"context_line":"            state\u003dstates.SUCCESS"},{"line_number":222,"context_line":"        )"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def test_workflow_error(self):"},{"line_number":225,"context_line":"        # Check that state of all workflow objects (workflow executions,"},{"line_number":226,"context_line":"        # task executions, action executions) is properly persisted in case"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_10e09c28","line":223,"updated":"2016-07-20 11:50:40.000000000","message":"I think this test should also check the workflow state.","commit_id":"ef531c1cde0561d7f951fc69a987f8e565c8da98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"fd362cff78f5103920c83f5d496d561d160318fc","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            name\u003d\u0027std.noop\u0027,"},{"line_number":221,"context_line":"            state\u003dstates.SUCCESS"},{"line_number":222,"context_line":"        )"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def test_workflow_error(self):"},{"line_number":225,"context_line":"        # Check that state of all workflow objects (workflow executions,"},{"line_number":226,"context_line":"        # task executions, action executions) is properly persisted in case"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_708f582a","line":223,"in_reply_to":"dada55a8_10e09c28","updated":"2016-07-20 11:54:30.000000000","message":"Ooh, it is checked on line 195 when we await for workflow error.","commit_id":"ef531c1cde0561d7f951fc69a987f8e565c8da98"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"f37715139b9650f3487d25ebb23b3702da001be7","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            name\u003d\u0027std.noop\u0027,"},{"line_number":221,"context_line":"            state\u003dstates.SUCCESS"},{"line_number":222,"context_line":"        )"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def test_workflow_error(self):"},{"line_number":225,"context_line":"        # Check that state of all workflow objects (workflow executions,"},{"line_number":226,"context_line":"        # task executions, action executions) is properly persisted in case"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_5057b425","line":223,"in_reply_to":"dada55a8_708f582a","updated":"2016-07-20 12:00:29.000000000","message":"Oh yes, it is, sorry about that.","commit_id":"ef531c1cde0561d7f951fc69a987f8e565c8da98"}]}