)]}'
{"mistral/actions/base.py":[{"author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"change_message_id":"0c5e37795d2e91e67c61bc966d85626659c1f52b","unresolved":false,"context_lines":[{"line_number":105,"context_line":"       Optional named arguments may be passed to override default config file."},{"line_number":106,"context_line":"    \"\"\""},{"line_number":107,"context_line":"    project \u003d project.capitalize()"},{"line_number":108,"context_line":"    assert project in SUPPORTED_MODULES, \\"},{"line_number":109,"context_line":"        \"Project %s is not supported\" % project"},{"line_number":110,"context_line":"    if not context.has_ctx() or keystone_utils.will_expire_soon("},{"line_number":111,"context_line":"            context.ctx().expires_at):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_be339a12","line":108,"updated":"2016-07-25 12:39:48.000000000","message":"This limit should not be in the base action.  If this patch is supposed to support custom action development, we will be limiting consumers to only be able to cache openstack actions.  e.g. I create an action that uses python-gnocchiclient and cannot use the cache for it.","commit_id":"3b9aeb7a4bc16381347fb9faa967c4d925f7ad52"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"5f0b53b38eee1b9f7dffb40b66c35d80c82bdaf9","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        return True"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def get_client(project\u003dNone, cls_name\u003dNone, **kwargs):"},{"line_number":95,"context_line":"    \"\"\"Returns project python client instance to non-Mistral consumers"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"       The cache is first checked and if no valid client exists there"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_46ca876e","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":54},"updated":"2016-08-16 16:02:24.000000000","message":"Soft: Not sure if this file is the best place for this method. Maybe it can be stored somewhere under mistral/utils directory? What do you think?","commit_id":"2148b831af9c32a1411039104e8e6c47c8b76630"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"5f0b53b38eee1b9f7dffb40b66c35d80c82bdaf9","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        return True"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def get_client(project\u003dNone, cls_name\u003dNone, **kwargs):"},{"line_number":95,"context_line":"    \"\"\"Returns project python client instance to non-Mistral consumers"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"       The cache is first checked and if no valid client exists there"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_06224f52","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":54},"updated":"2016-08-16 16:02:24.000000000","message":"What is the reason for adding this method? Doesn\u0027t it provide some security issues?\n\nI\u0027m felling like I\u0027m missing some blueprint related to this change.","commit_id":"2148b831af9c32a1411039104e8e6c47c8b76630"},{"author":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"change_message_id":"1ad09ab737f584416688157ee9c4c491606f3d9f","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        return True"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def get_client(project\u003dNone, cls_name\u003dNone, **kwargs):"},{"line_number":95,"context_line":"    \"\"\"Returns project python client instance to non-Mistral consumers"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"       The cache is first checked and if no valid client exists there"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_dcafade1","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":54},"in_reply_to":"1ac06dbe_a420eef8","updated":"2016-08-19 20:21:27.000000000","message":"Actually, the context is properly checked so there shouldn\u0027t be a security vulnerability. This code will eventually end up in mistral-lib anyway, so I don\u0027t think there\u0027s any reason to move it.","commit_id":"2148b831af9c32a1411039104e8e6c47c8b76630"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"c65df981c99bc3d3abaa6011edaa350fb39a5e30","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        return True"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def get_client(project\u003dNone, cls_name\u003dNone, **kwargs):"},{"line_number":95,"context_line":"    \"\"\"Returns project python client instance to non-Mistral consumers"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"       The cache is first checked and if no valid client exists there"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_de0857dc","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":54},"in_reply_to":"1ac06dbe_dcafade1","updated":"2016-08-24 16:04:44.000000000","message":"OK. Can you please describe a little bit more what would this function will be use for? As for now, it is only used in tests...","commit_id":"2148b831af9c32a1411039104e8e6c47c8b76630"},{"author":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"change_message_id":"8c05e705bbb70dd59a5bc165185e97dc15a8ead4","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        return True"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def get_client(project\u003dNone, cls_name\u003dNone, **kwargs):"},{"line_number":95,"context_line":"    \"\"\"Returns project python client instance to non-Mistral consumers"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"       The cache is first checked and if no valid client exists there"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_a420eef8","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":54},"in_reply_to":"3ac371cc_06224f52","updated":"2016-08-19 14:58:35.000000000","message":"You\u0027re right I\u0027m missing the blueprint. I\u0027ll go ahead and add it - it\u0027s for the custom actions API. And I think I\u0027ll need to rethink this call to include a keystone token of some sort instead of allowing access to any cached client available.","commit_id":"2148b831af9c32a1411039104e8e6c47c8b76630"}],"mistral/context.py":[{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"5f0b53b38eee1b9f7dffb40b66c35d80c82bdaf9","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"def context_from_config(username\u003dNone, password\u003dNone, tenant_name\u003dNone,"},{"line_number":184,"context_line":"                        auth_url\u003dNone):"},{"line_number":185,"context_line":"    # how else to detect if parsing has already occurred?"},{"line_number":186,"context_line":"    if CONF._namespace is None:"},{"line_number":187,"context_line":"        parse_args()"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_8bef6a86","line":185,"range":{"start_line":185,"start_character":6,"end_line":185,"end_character":57},"updated":"2016-08-16 16:02:24.000000000","message":"Soft: All comments should be complaint with English language (starting with capital letter)","commit_id":"2148b831af9c32a1411039104e8e6c47c8b76630"}]}