)]}'
{"mistral/utils/rpc_utils.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"1bd6da7606a06335212bcd06c5208f1dd1a112bc","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def get_rpc_info_from_oslo(additional_conf\u003dNone):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    try:"},{"line_number":27,"context_line":"        transport \u003d messaging.TransportURL.parse(CONF, CONF.transport_url)"},{"line_number":28,"context_line":"    except cfg.NoSuchOptError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_41c0aae0","line":25,"updated":"2016-07-29 10:51:16.000000000","message":"Please remove this line.","commit_id":"6a8c4ffb50ac395af419a4b9c8d36b5f95bbe6a9"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"dce41de88c7faab7228fc246ec97846194195d4b","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def get_rpc_info_from_oslo(additional_conf\u003dNone):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    try:"},{"line_number":27,"context_line":"        transport \u003d messaging.TransportURL.parse(CONF, CONF.transport_url)"},{"line_number":28,"context_line":"    except cfg.NoSuchOptError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_39bde268","line":25,"in_reply_to":"bacf61ea_41c0aae0","updated":"2016-07-29 14:30:55.000000000","message":"Done","commit_id":"6a8c4ffb50ac395af419a4b9c8d36b5f95bbe6a9"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"e3efeb52f2024cc69514b43f0b80f82e568f4800","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    try:"},{"line_number":27,"context_line":"        transport \u003d messaging.TransportURL.parse(CONF, CONF.transport_url)"},{"line_number":28,"context_line":"    except cfg.NoSuchOptError:"},{"line_number":29,"context_line":"        transport \u003d None"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    rpc_backend \u003d _get_rpc_backend(transport)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_412f0af6","line":28,"range":{"start_line":28,"start_character":15,"end_line":28,"end_character":29},"updated":"2016-07-29 10:47:11.000000000","message":"Why can it happen? I think transport_url should always be available. No?","commit_id":"6a8c4ffb50ac395af419a4b9c8d36b5f95bbe6a9"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"1bd6da7606a06335212bcd06c5208f1dd1a112bc","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    try:"},{"line_number":27,"context_line":"        transport \u003d messaging.TransportURL.parse(CONF, CONF.transport_url)"},{"line_number":28,"context_line":"    except cfg.NoSuchOptError:"},{"line_number":29,"context_line":"        transport \u003d None"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    rpc_backend \u003d _get_rpc_backend(transport)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_a1d246d0","line":28,"range":{"start_line":28,"start_character":15,"end_line":28,"end_character":29},"in_reply_to":"bacf61ea_412f0af6","updated":"2016-07-29 10:51:16.000000000","message":"My understanding is that even if we didn\u0027t configure this option explicitly we still should be able to access its value because the option is implicitly available. Is this correct?","commit_id":"6a8c4ffb50ac395af419a4b9c8d36b5f95bbe6a9"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"dce41de88c7faab7228fc246ec97846194195d4b","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    try:"},{"line_number":27,"context_line":"        transport \u003d messaging.TransportURL.parse(CONF, CONF.transport_url)"},{"line_number":28,"context_line":"    except cfg.NoSuchOptError:"},{"line_number":29,"context_line":"        transport \u003d None"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    rpc_backend \u003d _get_rpc_backend(transport)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_d92be692","line":28,"range":{"start_line":28,"start_character":15,"end_line":28,"end_character":29},"in_reply_to":"bacf61ea_a1d246d0","updated":"2016-07-29 14:30:55.000000000","message":"Renat, I\u0027ve double checked and it seems that you are right. I\u0027ve deleted the try-except block.","commit_id":"6a8c4ffb50ac395af419a4b9c8d36b5f95bbe6a9"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"1bd6da7606a06335212bcd06c5208f1dd1a112bc","unresolved":false,"context_lines":[{"line_number":40,"context_line":"def _get_rpc_backend(transport):"},{"line_number":41,"context_line":"    if transport:"},{"line_number":42,"context_line":"        return transport.transport"},{"line_number":43,"context_line":"    else:"},{"line_number":44,"context_line":"        return CONF.rpc_backend"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_a1e9a682","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":8},"updated":"2016-07-29 10:51:16.000000000","message":"Soft: I would just remove \u0027else\u0027.","commit_id":"6a8c4ffb50ac395af419a4b9c8d36b5f95bbe6a9"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"dce41de88c7faab7228fc246ec97846194195d4b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"def _get_rpc_backend(transport):"},{"line_number":41,"context_line":"    if transport:"},{"line_number":42,"context_line":"        return transport.transport"},{"line_number":43,"context_line":"    else:"},{"line_number":44,"context_line":"        return CONF.rpc_backend"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_79b75a86","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":8},"in_reply_to":"bacf61ea_a1e9a682","updated":"2016-07-29 14:30:55.000000000","message":"Done","commit_id":"6a8c4ffb50ac395af419a4b9c8d36b5f95bbe6a9"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"1bd6da7606a06335212bcd06c5208f1dd1a112bc","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    if transport and len(transport.hosts) \u003d\u003d 1:"},{"line_number":49,"context_line":"        # TODO(ddeja): Handle multiple hosts."},{"line_number":50,"context_line":"        return _get_rpc_info_from_transport_url(transport, additional_conf)"},{"line_number":51,"context_line":"    else:"},{"line_number":52,"context_line":"        return _get_rabbit_info_from_oslo(additional_conf)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_c1fe5a37","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":8},"updated":"2016-07-29 10:51:16.000000000","message":"Same.","commit_id":"6a8c4ffb50ac395af419a4b9c8d36b5f95bbe6a9"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"dce41de88c7faab7228fc246ec97846194195d4b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    if transport and len(transport.hosts) \u003d\u003d 1:"},{"line_number":49,"context_line":"        # TODO(ddeja): Handle multiple hosts."},{"line_number":50,"context_line":"        return _get_rpc_info_from_transport_url(transport, additional_conf)"},{"line_number":51,"context_line":"    else:"},{"line_number":52,"context_line":"        return _get_rabbit_info_from_oslo(additional_conf)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_b9b1d291","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":8},"in_reply_to":"bacf61ea_c1fe5a37","updated":"2016-07-29 14:30:55.000000000","message":"Done","commit_id":"6a8c4ffb50ac395af419a4b9c8d36b5f95bbe6a9"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"1bd6da7606a06335212bcd06c5208f1dd1a112bc","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def _get_rpc_info_from_transport_url(transport, additional_conf):"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    transport_host \u003d transport.hosts[0]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    return _prepare_rabbit_conf_dict("}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_61968ef1","line":68,"updated":"2016-07-29 10:51:16.000000000","message":"Soft: please remove this line.","commit_id":"6a8c4ffb50ac395af419a4b9c8d36b5f95bbe6a9"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"dce41de88c7faab7228fc246ec97846194195d4b","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def _get_rpc_info_from_transport_url(transport, additional_conf):"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    transport_host \u003d transport.hosts[0]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    return _prepare_rabbit_conf_dict("}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_f9822a93","line":68,"in_reply_to":"bacf61ea_61968ef1","updated":"2016-07-29 14:30:55.000000000","message":"Done","commit_id":"6a8c4ffb50ac395af419a4b9c8d36b5f95bbe6a9"}]}