)]}'
{"mistral/db/v2/sqlalchemy/models.py":[{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"d4896e3f74e06de6c18ca1d46078589274bf8db7","unresolved":false,"context_lines":[{"line_number":315,"context_line":"            \u0027processing\u0027,"},{"line_number":316,"context_line":"            \u0027execution_time\u0027"},{"line_number":317,"context_line":"        ),"},{"line_number":318,"context_line":"        sa.UniqueConstraint(\u0027unique_key\u0027, \u0027processing\u0027)"},{"line_number":319,"context_line":"    )"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    id \u003d mb.id_column()"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_b79f9264","line":318,"range":{"start_line":318,"start_character":0,"end_line":318,"end_character":55},"updated":"2016-08-02 13:23:03.000000000","message":"Why we create constraint from both unique_key and processing flags instead of just unique_key?","commit_id":"bb54545be74e36026fab1952a54fea0f90086989"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"685e40fceb4f635097a3b4a3107363134f1fc9ab","unresolved":false,"context_lines":[{"line_number":315,"context_line":"            \u0027processing\u0027,"},{"line_number":316,"context_line":"            \u0027execution_time\u0027"},{"line_number":317,"context_line":"        ),"},{"line_number":318,"context_line":"        sa.UniqueConstraint(\u0027unique_key\u0027, \u0027processing\u0027)"},{"line_number":319,"context_line":"    )"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    id \u003d mb.id_column()"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_3a0402c5","line":318,"range":{"start_line":318,"start_character":0,"end_line":318,"end_character":55},"in_reply_to":"bacf61ea_b79f9264","updated":"2016-08-03 06:25:50.000000000","message":"Yeah, it\u0027s a bit tricky here and related to how Scheduler main loop works. If you look at it you\u0027ll see that scheduler first queries delayed calls and marks them with processing\u003dTrue in such a way that it doesn\u0027t conflict with other scheduler instances (that\u0027s why \"UPDATE ... WHERE ... is used and updated row count is taken into account). Then it performs delayed calls and then deletes those delayed calls being confident that no one else touched these rows.\n\nSo \"processing\" is added as part of this constraint not to interfere with delayed calls that are already being processed because otherwise it would be possible to get \"lost update\" phenomena when we performed the call, in parallel something else updated this call in DB but then we immediately would delete this call by mistake so the result of the last update is lost.\n\nI hope this is clear.","commit_id":"bb54545be74e36026fab1952a54fea0f90086989"}],"mistral/services/scheduler.py":[{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"d4896e3f74e06de6c18ca1d46078589274bf8db7","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        made against."},{"line_number":49,"context_line":"    :param target_method_name: Name of a method which will be invoked."},{"line_number":50,"context_line":"    :param run_after: Value in seconds."},{"line_number":51,"context_line":"        param serializers: map of argument names and their serializer class"},{"line_number":52,"context_line":"        paths. Use when an argument is an object of specific type, and needs"},{"line_number":53,"context_line":"        to be serialized. Example:"},{"line_number":54,"context_line":"        { \"result\": \"mistral.utils.serializer.ResultSerializer\"}"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_bc165956","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":8},"updated":"2016-08-02 13:23:03.000000000","message":"Soft: There should be \u0027:\u0027 instead of \u0027tab\u0027","commit_id":"bb54545be74e36026fab1952a54fea0f90086989"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"685e40fceb4f635097a3b4a3107363134f1fc9ab","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        made against."},{"line_number":49,"context_line":"    :param target_method_name: Name of a method which will be invoked."},{"line_number":50,"context_line":"    :param run_after: Value in seconds."},{"line_number":51,"context_line":"        param serializers: map of argument names and their serializer class"},{"line_number":52,"context_line":"        paths. Use when an argument is an object of specific type, and needs"},{"line_number":53,"context_line":"        to be serialized. Example:"},{"line_number":54,"context_line":"        { \"result\": \"mistral.utils.serializer.ResultSerializer\"}"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_5a13b60d","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":8},"in_reply_to":"bacf61ea_bc165956","updated":"2016-08-03 06:25:50.000000000","message":"Sorry, will fix it.","commit_id":"bb54545be74e36026fab1952a54fea0f90086989"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"82c46f1ce91f862bb1b7dad2cb18d4f0d02c9af8","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            try:"},{"line_number":84,"context_line":"                serializer \u003d importutils.import_class(serializer_path)()"},{"line_number":85,"context_line":"            except ImportError as e:"},{"line_number":86,"context_line":"                raise ImportError("},{"line_number":87,"context_line":"                    \"Cannot import class %s: %s\" % (serializer_path, e)"},{"line_number":88,"context_line":"                )"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"            method_args[arg_name] \u003d serializer.serialize(method_args[arg_name])"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_8a8e7925","line":88,"range":{"start_line":86,"start_character":16,"end_line":88,"end_character":17},"updated":"2016-08-03 08:51:18.000000000","message":"Soft: I know it is not directly your change, but does it make sense to catch an exception and re-raise it with different message? Error messages from importutils seems fine to me:\n\n\u003e\u003e\u003e importutils.import_class(\u0027os.non_existing_class\u0027)\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n  File \"/usr/lib/python2.7/site-packages/oslo_utils/importutils.py\", line 36, in import_class\n    traceback.format_exception(*sys.exc_info())))\nImportError: Class non_existing_class cannot be found ([\u0027Traceback (most recent call last):\\n\u0027, \u0027  File \"/usr/lib/python2.7/site-packages/oslo_utils/importutils.py\", line 32, in import_class\\n    return getattr(sys.modules[mod_str], class_str)\\n\u0027, \"AttributeError: \u0027module\u0027 object has no attribute \u0027non_existing_class\u0027\\n\"])\nClass non_existing_class cannot be found ([\u0027Traceback (most recent call last):\\n\u0027, \u0027  File \"/usr/lib/python2.7/site-packages/oslo_utils/importutils.py\", line 32, in import_class\\n    return getattr(sys.modules[mod_str], class_str)\\n\u0027, \"AttributeError: \u0027module\u0027 object has no attribute \u0027non_existing_class\u0027\\n\"])\n\n\u003e\u003e\u003e importutils.import_class(\u0027non_existing_module.non_existing_class\u0027)\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n  File \"/usr/lib/python2.7/site-packages/oslo_utils/importutils.py\", line 30, in import_class\n    __import__(mod_str)\nImportError: No module named non_existing_module\nNo module named non_existing_module","commit_id":"0c8ad1aaa4850a6e991aa0b343841fe9ddb3236c"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"e4644643f7df1fde25be09f48a7e522f36a53559","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            try:"},{"line_number":84,"context_line":"                serializer \u003d importutils.import_class(serializer_path)()"},{"line_number":85,"context_line":"            except ImportError as e:"},{"line_number":86,"context_line":"                raise ImportError("},{"line_number":87,"context_line":"                    \"Cannot import class %s: %s\" % (serializer_path, e)"},{"line_number":88,"context_line":"                )"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"            method_args[arg_name] \u003d serializer.serialize(method_args[arg_name])"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_d63c65c1","line":88,"range":{"start_line":86,"start_character":16,"end_line":88,"end_character":17},"in_reply_to":"bacf61ea_8a8e7925","updated":"2016-08-04 04:03:21.000000000","message":"Yeah, I agree with you. Let me address it separately.","commit_id":"0c8ad1aaa4850a6e991aa0b343841fe9ddb3236c"}]}
