)]}'
{"mistral/engine/actions.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"93d6f2ddd25375ca9728058ccbc34bffed8b65cb","unresolved":false,"context_lines":[{"line_number":524,"context_line":"    :param result: ActionResult instance or ActionResult dict"},{"line_number":525,"context_line":"    :return: wf_utils.Result."},{"line_number":526,"context_line":"    \"\"\""},{"line_number":527,"context_line":"    if isinstance(result, dict):"},{"line_number":528,"context_line":"        result \u003d wf_utils.Result(result.get(\u0027data\u0027), result.get(\u0027error\u0027))"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"    return result"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_3afec205","line":527,"range":{"start_line":527,"start_character":26,"end_line":527,"end_character":30},"updated":"2016-08-03 06:17:17.000000000","message":"It seems to me now that this \"if\" condition is not needed at all because executor client (see rpc.ExecutorClient) always returns an instance of Result class. Please check that.\n\nAnd please be careful, the purpose of this method was to represent action output in a form that will be stored in DB. That\u0027s why it used to return a dict. This is needed because an action may return anything including integers, strings etc. but we need to be able to coerce them to JSonDict() data type.","commit_id":"c8e1e8b579bb77c20978052f1bc582f33676f885"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"654c8421ee1c55c5818dd19cd7af9186ab91c6df","unresolved":false,"context_lines":[{"line_number":524,"context_line":"    :param result: ActionResult instance or ActionResult dict"},{"line_number":525,"context_line":"    :return: wf_utils.Result."},{"line_number":526,"context_line":"    \"\"\""},{"line_number":527,"context_line":"    if isinstance(result, dict):"},{"line_number":528,"context_line":"        result \u003d wf_utils.Result(result.get(\u0027data\u0027), result.get(\u0027error\u0027))"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"    return result"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_5516e755","line":527,"range":{"start_line":527,"start_character":26,"end_line":527,"end_character":30},"in_reply_to":"bacf61ea_3afec205","updated":"2016-08-03 07:09:40.000000000","message":"You are right - actually this whole function can be deleted.\n\nI know that this method was to convert action output to dict. That is why I have added to_dict method to Result class. Also, I have add usage of it in complete method in next patch set.\n\nThis method is private, so it was easy to find all usages and make changes accordingly.","commit_id":"c8e1e8b579bb77c20978052f1bc582f33676f885"},{"author":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"change_message_id":"bc4275f007c0e5c637513ea764595bbad72c7aca","unresolved":false,"context_lines":[{"line_number":524,"context_line":"    :param result: ActionResult instance or ActionResult dict"},{"line_number":525,"context_line":"    :return: wf_utils.Result."},{"line_number":526,"context_line":"    \"\"\""},{"line_number":527,"context_line":"    if isinstance(result, dict):"},{"line_number":528,"context_line":"        result \u003d wf_utils.Result(result.get(\u0027data\u0027), result.get(\u0027error\u0027))"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"    return result"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_7f1665a8","line":527,"range":{"start_line":527,"start_character":26,"end_line":527,"end_character":30},"in_reply_to":"bacf61ea_509d5558","updated":"2016-08-03 08:31:27.000000000","message":"I have made changes in same commit - just starting from patchset no 3.","commit_id":"c8e1e8b579bb77c20978052f1bc582f33676f885"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"932ea820834e8054082cc26d39d77e2e521b218e","unresolved":false,"context_lines":[{"line_number":524,"context_line":"    :param result: ActionResult instance or ActionResult dict"},{"line_number":525,"context_line":"    :return: wf_utils.Result."},{"line_number":526,"context_line":"    \"\"\""},{"line_number":527,"context_line":"    if isinstance(result, dict):"},{"line_number":528,"context_line":"        result \u003d wf_utils.Result(result.get(\u0027data\u0027), result.get(\u0027error\u0027))"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"    return result"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_509d5558","line":527,"range":{"start_line":527,"start_character":26,"end_line":527,"end_character":30},"in_reply_to":"bacf61ea_5516e755","updated":"2016-08-03 07:18:58.000000000","message":"Yes. Ok. Just make sure to make changes atomically so everything keeps working. I somewhat think that w/o using this to_dict() method a lot of tests won\u0027t pass so maybe you should squash your commits into one.","commit_id":"c8e1e8b579bb77c20978052f1bc582f33676f885"}]}